[edk2-devel][PATCH v4 7/7] CometlakeOpenBoard: Move ReportCpuHob library path

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298 Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar ---

[edk2-devel][PATCH v4 5/7] WhiskeylakeOpenBoard: Move library path

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298 Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone --- .../WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 7 --- .../WhiskeylakeURvp/OpenBoardPkg.dsc

[edk2-devel][PATCH v4 6/7] MiniPlatformPkg: Move ReportCpuHob library path

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298 Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 2 +-

[edk2-devel][PATCH v4 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298 Add ReportCpuHobLib Signed-off-by: SofiaX Chuang Cc: Ray Ni Cc: Rangasai V Chaganty --- .../Include/Library/ReportCpuHobLib.h | 30 + .../Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 6 ++-

[edk2-devel][PATCH v4 4/7] KabylakeOpenBoard: Move ReportCpuHob library path

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298 Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Jeremy Soller --- .../KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 11 ---

[edk2-devel][PATCH v4 3/7] SimicsOpenBoard: Move ReportCpuHob library path

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298 Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg. Cc: Agyeman Prince Cc: Chasel Chiu --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 11 --- 1 file changed, 8 insertions(+), 3

[edk2-devel][PATCH v4 2/7] TigerlakeOpenBoard: Move ReportCpuHob library path

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298 Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo --- .../Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 2 +- 1 file changed, 1

[edk2-devel][PATCH v4 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg

2021-05-03 Thread sofiax . chuang
From: SofiaX Chuang Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg SofiaX Chuang (7): IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib TigerlakeOpenBoard: Move ReportCpuHob library path SimicsOpenBoard: Move ReportCpuHob library path KabylakeOpenBoard: Move ReportCpuHob 

Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU

2021-05-03 Thread Michael D Kinney
Pushed commit to edk2/master: https://github.com/tianocore/edk2/commit/f297b7f20010711e36e981fe45645302cc9d109d GitHub PR: https://github.com/tianocore/edk2/pull/1623 Mike > -Original Message- > From: Kinney, Michael D > Sent: Monday, May 3, 2021 5:38 PM > To:

Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU

2021-05-03 Thread Michael D Kinney
I found one more place that is missing EFIAPI: STATIC VOID UnitTestLogFailure (   IN FAILURE_TYPE  FailureType,   IN CONST CHAR8   *Format,   ...   ) { I will fix this one too in the PR. Mike From: Kinney, Michael D Sent: Monday, May 3, 2021 5:28 PM To: devel@edk2.groups.io;

Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU

2021-05-03 Thread Michael D Kinney
Reviewed-by: Michael D Kinney michael.d.kin...@intel.com Yes. I will submit PR. Mike From: devel@edk2.groups.io On Behalf Of Bret Barkelew via groups.io Sent: Friday, April 30, 2021 2:16 PM To: devel@edk2.groups.io; Getnat Ejigu Cc: Kinney, Michael D ;

[edk2-devel] No ShellBinPkg with newer releases on github

2021-05-03 Thread Rebecca Cran
I noticed the ShellBinPkg zip file has stopped being uploaded to https://github.com/tianocore/edk2/releases for newer tags: the most recent release that has it is edk2-stable202002. Was that deliberate? I can easily build it myself, but was wondering since I don't recall seeing any messages about

Re: [edk2-devel] [PATCH RFC v2 21/28] OvmfPkg/MemEncryptSevLib: Add support to validate system RAM

2021-05-03 Thread Brijesh Singh
On 5/3/21 9:04 AM, Erdem Aktas wrote: >> +// >> +// If the request page state change is shared then invalidate the pages >> before >> +// adding the page in the RMP table. >> +// >> +if (State == SevSnpPagePrivate) { >> + PvalidateRange (Info, 0, i, TRUE); >> +} >

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix New Target/ToolChain/Arch in DSC [BuildOptions] issues

2021-05-03 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish Thanks, Andrew Fish > On May 1, 2021, at 10:02 AM, Michael D Kinney > wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3359 > > * Save/Restore global state in GetToolChainAndFamilyFromDsc() > This resolves an issue where the multi-arch build for >

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix New Target/ToolChain/Arch in DSC [BuildOptions] issues

2021-05-03 Thread Rebecca Cran
Acked-by: Rebecca Cran -- Rebecca Cran On 5/1/21 11:02 AM, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3359 > > * Save/Restore global state in GetToolChainAndFamilyFromDsc() > This resolves an issue where the multi-arch build for > UefiPayloadPkg would

Re: [edk2-devel] [edk2-platforms][PATCH V1 00/17] Enable idle state and CPPC support for RD platform

2021-05-03 Thread Thomas Abraham
On 4/28/21 6:05 PM, Pranav Madhu via groups.io wrote: > Low Power Idle (LPI) and Collaborative Processor Performance Control > (CPPC) are two power management mechanisms described in ACPI 6.4 > specification. OSPM uses the _LPI object to select a local power state > for each level of processor

Re: [edk2-devel] [PATCH RFC v2 17/28] OvmfPkg/ResetVector: Invalidate the GHCB page

2021-05-03 Thread Brijesh Singh
On 5/3/21 8:05 AM, Erdem Aktas wrote: > Hi Brijesh, > I have few naive questions inlined: > > On Fri, Apr 30, 2021 at 4:52 AM Brijesh Singh wrote: >> +; Use PVALIDATE instruction to invalidate the page >> +mov eax, GHCB_BASE >> +mov ecx, 0 >> +mov edx, 0 >> +DB

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add PPTT table for Neoverse Reference Design platforms

2021-05-03 Thread Thomas Abraham
On 4/28/21 5:42 PM, Pranav Madhu via groups.io wrote: > Changes since V1: > - Rebase the patches on top of latest master branch > - Addressed comments from Pierre > > Processor Properties Topology Table (PPTT) describes the topological > structure of processors, and their shared resources such as

Re: [edk2-devel] [PATCH RFC v2 21/28] OvmfPkg/MemEncryptSevLib: Add support to validate system RAM

2021-05-03 Thread Erdem Aktas via groups.io
> +// > +// If the request page state change is shared then invalidate the pages > before > +// adding the page in the RMP table. > +// > +if (State == SevSnpPagePrivate) { > + PvalidateRange (Info, 0, i, TRUE); > +} Looks like some copy-paste mistake in the comment.

Re: [edk2-devel] [PATCH RFC v2 03/28] MdePkg: Define the GHCB GPA structure

2021-05-03 Thread Laszlo Ersek
On 05/03/21 15:50, Laszlo Ersek wrote: > On 05/03/21 14:55, Brijesh Singh wrote: >> >> On 5/3/21 7:19 AM, Laszlo Ersek wrote: >>> On 05/03/21 12:24, Laszlo Ersek wrote: On 04/30/21 13:51, Brijesh Singh wrote: > BZ: >

Re: [edk2-devel] [PATCH RFC v2 03/28] MdePkg: Define the GHCB GPA structure

2021-05-03 Thread Laszlo Ersek
On 05/03/21 14:55, Brijesh Singh wrote: > > On 5/3/21 7:19 AM, Laszlo Ersek wrote: >> On 05/03/21 12:24, Laszlo Ersek wrote: >>> On 04/30/21 13:51, Brijesh Singh wrote: BZ:

Re: [edk2-devel] [PATCH RFC v2 02/28] MdePkg: Define the GHCB Hypervisor features

2021-05-03 Thread Laszlo Ersek
On 05/03/21 14:20, Brijesh Singh wrote: > > On 5/3/21 5:10 AM, Laszlo Ersek wrote: >> Hi Brijesh, Tom, >> >> On 04/30/21 13:51, Brijesh Singh wrote: >>> BZ: >>>

Re: [edk2-devel] [PATCH RFC v2 17/28] OvmfPkg/ResetVector: Invalidate the GHCB page

2021-05-03 Thread Erdem Aktas via groups.io
Hi Brijesh, I have few naive questions inlined: On Fri, Apr 30, 2021 at 4:52 AM Brijesh Singh wrote: > +; Use PVALIDATE instruction to invalidate the page > +mov eax, GHCB_BASE > +mov ecx, 0 > +mov edx, 0 > +DB 0xF2, 0x0F, 0x01, 0xFF > +cmp eax, 0 > +

Re: [edk2-devel] [PATCH RFC v2 03/28] MdePkg: Define the GHCB GPA structure

2021-05-03 Thread Brijesh Singh
On 5/3/21 7:19 AM, Laszlo Ersek wrote: > On 05/03/21 12:24, Laszlo Ersek wrote: >> On 04/30/21 13:51, Brijesh Singh wrote: >>> BZ: >>>

Re: [edk2-devel] [PATCH RFC v2 02/28] MdePkg: Define the GHCB Hypervisor features

2021-05-03 Thread Brijesh Singh
On 5/3/21 5:10 AM, Laszlo Ersek wrote: > Hi Brijesh, Tom, > > On 04/30/21 13:51, Brijesh Singh wrote: >> BZ: >>

Re: [edk2-devel] [PATCH RFC v2 03/28] MdePkg: Define the GHCB GPA structure

2021-05-03 Thread Laszlo Ersek
On 05/03/21 12:24, Laszlo Ersek wrote: > On 04/30/21 13:51, Brijesh Singh wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 >> >> An SEV-SNP guest is required to perform the GHCB GPA registration. See >> the GHCB specification for further details. >> >> Cc: James Bottomley >> Cc:

Re: [edk2-devel] Question about PACKAGES_PATH

2021-05-03 Thread Laszlo Ersek
On 05/03/21 03:55, Abner Chang wrote: > Hi all, > > I encountered a weird build issue when I use PACKAGES_PATH for the > package outside WORKSPACE. > > Currently I have RedfishClientPkg in the different repo and I configure > PACKAGES_PATH as below, > > Set PACKAGES_PATH=d:\edk2;

Re: [edk2-devel] [PATCH RFC v2 01/28] MdePkg: Expand the SEV MSR to include the SNP definition

2021-05-03 Thread Brijesh Singh
On 5/3/21 3:39 AM, Laszlo Ersek wrote: > On 04/30/21 13:51, Brijesh Singh wrote: >> BZ: >>

Re: [edk2-devel] [PATCH RFC v2 03/28] MdePkg: Define the GHCB GPA structure

2021-05-03 Thread Laszlo Ersek
On 04/30/21 13:51, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > An SEV-SNP guest is required to perform the GHCB GPA registration. See > the GHCB specification for further details. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky

Re: [edk2-devel] [PATCH RFC v2 02/28] MdePkg: Define the GHCB Hypervisor features

2021-05-03 Thread Laszlo Ersek
Hi Brijesh, Tom, On 04/30/21 13:51, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of GHCB introduces advertisement of features that are supported > by the hypervisor. See the GHCB spec section 2.2 for an additional details. > > Cc: James Bottomley

Re: [edk2-devel] [PATCH RFC v2 01/28] MdePkg: Expand the SEV MSR to include the SNP definition

2021-05-03 Thread Laszlo Ersek
On 04/30/21 13:51, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Define the SEV-SNP MSR bits. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas >