回复: [edk2-devel] [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN

2021-05-21 Thread gaoliming
Reviewed-by: Liming Gao I am ok to merge this patch for stable tag 202105. Thanks Liming 发件人: devel@edk2.groups.io 代表 Bret Barkelew via groups.io 发送时间: 2021年5月22日 4:43 收件人: Laszlo Ersek ; edk2-devel-groups-io 抄送: Hao A Wu ; Jian J Wang ; Liming Gao ; Kinney, Michael D ; Philippe

Re: [edk2-devel] [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib instances

2021-05-21 Thread Nate DeSimone
Thank Michael, I was able to get the new patch series to apply. For the series... Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, May 18, 2021 8:59 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Kethi Reddy, Deepika ;

Re: [edk2-devel] [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN

2021-05-21 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew bret.barke...@microsoft.com I don’t regret making it ERROR at first because now no one can claim to have not been warned when the interface drops, but I agree that lowering to WARN now is prudent. - Bret From: Laszlo

[edk2-devel] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN

2021-05-21 Thread Laszlo Ersek
Commit a18a9bde36d2 ("MdeModulePkg/Variable/RuntimeDxe: Restore Variable Lock Protocol behavior", 2020-12-15), for bug 3111, added two such sets of debug messages that: (a) are relevant for developers, (b) yet should not necessarily poke end-users, because no functionality suffers in practice.

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-05-21 Thread Rebecca Cran
Could someone review this please? I submitted it almost 2 weeks ago. -- Rebecca Cran On 5/9/21 1:18 PM, Rebecca Cran wrote: The existing instructions no longer work on macOS Big Sur and Xcode 12.5. Update them to include for example using lldb instead of gdb, installing XQuartz, and using

Re: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

2021-05-21 Thread Daniel Schaefer
It's not required to go into that tag. We need two more patches that we haven't submitted yet to boot on Qemu. Would it be okay if we used a library from ArmVirtPkg for RISCV64? See: https://github.com/riscv/riscv-edk2/commit/8c7960ef860c65f2646912c3dccbb308a98e0cc3 Or does it have to be moved

Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3

2021-05-21 Thread Joey Gouly
>From: Joey Gouly > Sent: 09 March 2021 16:45 > Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3   Hi, A little ping on this. Can someone take a look? There was a similar patch here, that addressed the same issue https://edk2.groups.io/g/devel/topic/82327316#74401 so

回复: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

2021-05-21 Thread gaoliming
Daniel: Thanks for your information. Acked-by: Liming Gao And, do you request to merge this patch for edk2 stable tag 202105? Thanks Liming 发件人: devel@edk2.groups.io 代表 Daniel Schaefer 发送时间: 2021年5月21日 13:27 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn 抄送: Chang, Abner (HPS

回复: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

2021-05-21 Thread gaoliming
This patch is reviewed before soft feature freeze. So, I create PR https://github.com/tianocore/edk2/pull/1659 to merge it for this stable tag. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2021年5月16日 16:10 > 收件人: 'Garrett Kirkendall' ; > devel@edk2.groups.io

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

2021-05-21 Thread Sunny Wang
The change looks good to me. Added some more info for Liming and others reference. For DBG2, https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table Table 3. Debug port types and subtypes 0x0005 Nvidia 16550 For SPCR,