Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmCache.h

2021-06-18 Thread Leif Lindholm
Agh. *Actually* cc Wenyi. On Fri, Jun 18, 2021 at 16:53:38 +0100, Leif Lindholm wrote: > +Wenyi > > On Mon, Jun 14, 2021 at 12:57:49 -0600, Rebecca Cran wrote: > > Many of the cache definitions in ArmLibPrivate.h are being used outside > > of ArmLib, in Universal/Smbios. Move them into

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmCache.h

2021-06-18 Thread Leif Lindholm
+Wenyi On Mon, Jun 14, 2021 at 12:57:49 -0600, Rebecca Cran wrote: > Many of the cache definitions in ArmLibPrivate.h are being used outside > of ArmLib, in Universal/Smbios. Move them into ArmCache.h to make them > public, and remove the include of ArmLibPrivate.h from files in >

Re: [edk2-devel] [EXTERNAL] 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error

2021-06-18 Thread manickavasakam karpagavinayagam
Liming : Add Signed-off-by information and created/sent a new PATCH V3 [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors Thank you -Manic -Original Message- From: gaoliming Sent: Thursday, June 17, 2021 9:06 PM To: Manickavasakam

[edk2-devel] [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

2021-06-18 Thread manickavasakam karpagavinayagam
Build error reported for missing structures IPMI_SET_BOOT_OPTIONS_RESPONSE, EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE when using

[edk2-devel] [PATCH V2 3/4] NXP/LS1046aFrwyPkg: Enable ConfigurationManager on LS1046AFRWY

2021-06-18 Thread Vikas Singh via groups.io
This patch enables the use of ConfigurationManager (CM) and its services to leverage the Dynamic ACPI support for NXP's LS1046aFrwy platform. Signed-off-by: Vikas Singh --- Platform/NXP/LS1046aFrwyPkg/Include/Platform.h | 152 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc

[edk2-devel] [PATCH V2 4/4] Platform/NXP/LS1046aFrwyPkg: Add OEM specific DSDT generator

2021-06-18 Thread Vikas Singh via groups.io
This patch adds platform specific DSDT generator and Clk dsdt properties for LS1046AFRWY platform. Reviewed-by: Leif Lindholm Signed-off-by: Vikas Singh --- Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/Dsdt/Clk.asl | 60 +

[edk2-devel] [PATCH V2 2/4] Silicon/NXP: Add support of SVR handling for LS1046A SoC

2021-06-18 Thread Vikas Singh via groups.io
This patch adds a generic method to get Silicon Version Register (SVR) on LS1046A SoC. This method will be generic for all platfroms based on LS1046A SoC, like - LS1046AFRWY, LS1046ARDB. Signed-off-by: Vikas Singh --- Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 16 1 file

[edk2-devel] [PATCH V2 1/4] Platform/NXP: Make SoC version log in ConfigurationManager generic

2021-06-18 Thread Vikas Singh via groups.io
This patch replaces the logic in ConfigurationManager to print platform name based on platform ID with a simple #define PLAT_SOC_NAME defined in platform headers. This also removes duplication of the SVR_LX2160A, SVR_SOC_VER, SVR_MAJOR and SVR_MINOR macro definitions between SoC headers and

[edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-06-18 Thread Vikas Singh via groups.io
This patch series basically aims to extend the Dynamic ACPI framework towards NXP's LS1046AFRWY platform. In continuation to https://edk2.groups.io/g/devel/message/71709 The change set in the series is in below order - (1)Introducing a new platform specific macro "PLAT_SOC_NAME" This macro will

[edk2-devel] [edk2-platforms][PATCH v3 41/41] TigerlakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-06-18 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the library to identify flash regions by GUID and internally map the GUID entries to values specific to TigerlakeSiliconPkg. Cc: Rangasai V Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael

[edk2-devel] [edk2-platforms][PATCH v3 40/41] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-06-18 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the library to identify flash regions by GUID and internally map the GUID entries to values specific to SimicsIch10Pkg. Cc: Agyeman Prince Cc: Nate DeSimone Signed-off-by: Michael Kubacki ---

Re: [edk2-devel] [PATCH V1 4/4] Platform/NXP/LS1046aFrwyPkg: Add OEM specific DSDT generator

2021-06-18 Thread Vikas Singh via groups.io
On Tue, Jun 15, 2021 at 3:07 AM Leif Lindholm wrote: > > On Fri, Jun 11, 2021 at 21:22:00 +0530, Vikas Singh wrote: > > This patch adds platform specific DSDT generator > > and Clk dsdt properties for LS1046AFRWY platform. > > > > Signed-off-by: Vikas Singh > > --- > >

Re: [edk2-devel] [PATCH V1 3/4] Platform/NXP/LS1046aFrwyPkg: Extend Dynamic ACPI support

2021-06-18 Thread Vikas Singh via groups.io
On Tue, Jun 15, 2021 at 2:58 AM Leif Lindholm wrote: > > On Fri, Jun 11, 2021 at 21:21:59 +0530, Vikas Singh wrote: > > This patch set extends Configuration Manager (CM) and > > its services to leverage the Dynamic ACPI support for > > NXP's LS1046aFrwy platform. > > This patch does not touch

Re: [edk2-devel] [PATCH V1 2/4] Silicon/NXP: Add support of SVR handling for LS1046FRWY

2021-06-18 Thread Vikas Singh via groups.io
On Tue, Jun 15, 2021 at 2:29 AM Leif Lindholm wrote: > > On Fri, Jun 11, 2021 at 21:21:58 +0530, Vikas Singh wrote: > > This change set intend to add a generic method to get > > Does it intend to add, or does it add? > > / > Leif > Leif, this patch adds a generic method to get the SVR

Re: [edk2-devel] [PATCH V1 1/4] Platform/NXP: Add generic log in CM to print SoC version

2021-06-18 Thread Vikas Singh via groups.io
On Tue, Jun 15, 2021 at 2:28 AM Leif Lindholm wrote: > > On Fri, Jun 11, 2021 at 21:21:57 +0530, Vikas Singh wrote: > > Summary - > > 1.Configuration Manager(CM) is a common implementation > > and should not evaluate the SoC version using macro's > > However CM must directly consume SoC ver

Re: [edk2-devel] [edk2-platforms][PATCH v3 39/41] KabylakeSiliconPkg: Identify flash regions by GUID

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 39/41] KabylakeSiliconPkg:

Re: [edk2-devel] [edk2-platforms][PATCH v3 38/41] CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 38/41] >

Re: [edk2-devel] [edk2-platforms][PATCH v3 33/41] KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 33/41] KabylakeSiliconPkg:

Re: [edk2-devel] [edk2-platforms][PATCH v3 32/41] CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 32/41]

Re: [edk2-devel] [edk2-platforms][PATCH v3 27/41] KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 27/41] KabylakeSiliconPkg:

[edk2-devel] [PATCH v1 2/2] MdePkg: MmConfiguration: Added definition of MM Configuration PPI

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 MM Configuration PPI was defined in PI Specification since v1.5. This change added definition of such PPI and related GUIDs into MdePkg. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Signed-off-by: Kun Qin

[edk2-devel] [PATCH v1 1/2] MdePkg: MmConfiguration: Moved EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 The definition of EFI_MM_RESERVED_MMRAM_REGION, according to PI Spec 1.5 is also referenced in EFI_PEI_MM_CONFIGURATION_PPI. Defining this structure as is will enforce any potential usage of MM Configuration PPI interface to include . This

[edk2-devel] [PATCH v1 0/2] Add MM Configuration PPI definition to MdePkg

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 EFI_PEI_MM_CONFIGURATION_PPI is defined since PI spec v1.5. This patch series added the interface definition and related GUIDs into MdePkg. On the other hand, EFI_MM_RESERVED_MMRAM_REGION is referenced by both MM Configuration PPI and

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-06-18 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Gao Jie via groups.io Sent: Thursday, June 10, 2021 3:39 PM To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Samer El-Haj-Mahmoud ; Eric Jin ; Arvin Chen Subject: [edk2-devel]

Re: [edk2-devel] [PATCH 1/6] NetworkPkg/IScsiDxe: re-set session-level authentication state before login

2021-06-18 Thread Philippe Mathieu-Daudé
On 6/8/21 3:06 PM, Laszlo Ersek wrote: > RFC 7143 explains that a single iSCSI session may use multiple TCP > connections. The first connection established is called the leading > connection. The login performed on the leading connection is called the > leading login. Before the session is

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

2021-06-18 Thread Marvin Häuser
Hey Kun, On 16.06.21 22:58, Kun Qin wrote: Hi Marvin, Thanks for reaching out. Please see my comment inline. Regards, Kun On 06/16/2021 00:02, Marvin Häuser wrote: Good day, May I ask about two small things? 1) Was there any rationale as to e.g. code compatibility with choosing UINT64

[edk2-devel] [PATCH v2 4/6] MdeModulePkg: SmiHandlerProfileInfo: Updated MessageLength calculation

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 This change replaced the calculation of communication buffer size from explicitly adding the size of each member with the OFFSET macro function. This will make the structure field defition change transparent to consumers. Cc: Jian J Wang

[edk2-devel] [PATCH v2 3/6] MdeModulePkg: MemoryProfileInfo: Updated MessageLength calculation

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 This change replaced the calculation of communication buffer size from explicitly adding the size of each member with the OFFSET macro function. This will make the structure field defition change transparent to consumers. Cc: Jian J Wang

[edk2-devel] [PATCH v2 6/6] MdePkg: MmCommunication: Extend MessageLength field size to UINT64

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 The MessageLength field of EFI_MM_COMMUNICATE_HEADER, as a generic definition, could be used for both PEI and DXE MM communication. On a system that supports PEI MM launch, but

[edk2-devel] [PATCH v2 1/6] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This change includes specification update markdown file that describes the proposed PI Specification v1.7 Errata A in detail and potential impact to the existing codebase. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Andrew

[edk2-devel] [PATCH v2 0/6] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/76303 v2 patch changes include feedback for v1 series: a. Added "Reviewed-by" tag for applicable patch; b. Removed "BZ3398" tags for applicable

[edk2-devel] [PATCH v2 5/6] MdeModulePkg: SmmLockBoxDxeLib: Updated MessageLength calculation

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 This change replaced the calculation of communication buffer size from explicitly adding the size of each member with the OFFSET macro function. This will make the structure field defition change transparent to consumers. Cc: Jian J Wang

[edk2-devel] [PATCH v2 2/6] MdeModulePkg: PiSmmIpl: Update MessageLength calculation for MmCommunicate

2021-06-18 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 This change updated calculation routine for MM communication in PiSmmIpl. It removes ambiguity brought in by UINTN variables from this routine and paves way for updating definition of field MessageLength in EFI_MM_COMMUNICATE_HEADER to

Re: [edk2-devel] [PATCH v3 8/8] MdeModulePkg: Use SecureBootVariableLib in PlatformVarCleanupLib.

2021-06-18 Thread Grzegorz Bernacki
Hi, Thanks for the comment, I will move that function to AuthVariableLib. greg czw., 17 cze 2021 o 04:35 gaoliming napisał(a): > > Grzegorz: > MdeModulePkg is generic base package. It should not depend on SecurityPkg. > > I agree CreateTimeBasedPayload() is the generic API. It can be shared