Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-07-04 Thread Nickle Wang
Hi Liming, I add it to exception list and I pass all CI test. New patch is sent for review. Ref: https://github.com/tianocore/edk2/pull/1789 Thanks, Nickle -Original Message- From: gaoliming Sent: Monday, July 5, 2021 9:46 AM To: devel@edk2.groups.io; Wang, Nickle (HPS SW) ;

[edk2-devel] [PATCH v2 2/2] MdeModulePkg: Update YAML file to fix CI error

2021-07-04 Thread Nickle Wang
Add OnigurumaUefiPort.h and OnigurumaUefiPort.c into ECC exception in MdeModulePkg.ci.yaml in order to fix CI error. Signed-off-by: Nickle Wang --- MdeModulePkg/MdeModulePkg.ci.yaml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml

[edk2-devel] [PATCH v2 1/2] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-07-04 Thread Nickle Wang
Memory buffer that is allocated by malloc() and realloc() will be shifted by 8 bytes because Oniguruma keeps its memory signature. This 8 bytes shift is not handled while calling free() to release memory. Add free() function to check Oniguruma signature before release memory because memory buffer

回复: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-07-04 Thread gaoliming
Please also add this file into the ignored file list. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nickle Wang > 发送时间: 2021年7月5日 8:55 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; > ler...@redhat.com > 抄送: jian.j.w...@intel.com; hao.a...@intel.com; Wang, Nickle (HPS

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-04 Thread Chiu, Chasel
Thanks Ashraf. Adding my comments below inline. > -Original Message- > From: S, Ashraf Ali > Sent: Sunday, July 4, 2021 7:23 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg: PatchFv

[edk2-devel] [PATCH] MdeModulePkg PiSmmCore: Change MemoryAttributes message to DEBUG_VERBOSE level

2021-07-04 Thread Yang Gang
1. Reduce the debug message during boot. 2. Update SmmCore debug level of MemoryAttributesTable align to DxeCore. Signed-off-by: Yang Gang Cc: Eric Dong Cc: Ray Ni Cc: Liming Gao --- .../Core/PiSmmCore/MemoryAttributesTable.c| 26 +-- 1 file changed, 13 insertions(+), 13

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-07-04 Thread Nickle Wang
Thanks Liming! I create personal PR below and I also see CI error on OnigurumaUefiPort.h. It looks like "Ubuntu GCC PR" does not like the coding style on OnigurumaUefiPort.h. However, I just follow the coding style of other functions in this file. https://github.com/tianocore/edk2/pull/1788

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h

2021-07-04 Thread Wu, Hao A
Acked-by: Hao A Wu Best Regards, Hao Wu From: Liu, Zhiguang Sent: Monday, July 5, 2021 9:07 AM To: Tan, Dun ; devel@edk2.groups.io; Wu, Hao A ; Wang, Jian J Cc: Ni, Ray Subject: Re: [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h Reviewed-by: Zhiguang Liu

[edk2-devel] Update stable tag release date for future stable tag

2021-07-04 Thread gaoliming
Hi, all Based on the proposal in https://edk2.groups.io/g/rfc/message/684, Soft Feature Freeze phase (SFF) will be shorten to 5 days for the reviewed patch merge, Hard Feature Freeze phase (HFF) will be extended to 2 weeks for downstream verification.

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h

2021-07-04 Thread Zhiguang Liu
Reviewed-by: Zhiguang Liu Add MdeModulePkg's maintainers. From: Tan, Dun Sent: Friday, July 2, 2021 15:35 To: devel@edk2.groups.io Cc: Liu, Zhiguang ; Ni, Ray ; Tan, Dun Subject: [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h Change

回复: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

2021-07-04 Thread gaoliming
This patch in MdePkg has been merged at 55dee4947b20103fc48858b18307bd2b114dc145 on edk2 master. Thanks Liming 发件人: devel@edk2.groups.io 代表 gaoliming 发送时间: 2021年6月30日 9:22 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; latee...@gmail.com 抄送: 'manickavasakam karpagavinayagam' ;

[edk2-devel] [PATCH] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-04 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3476 parseInfFile currently reading the EFI_BASE_ADDRESS from INF, once the address found still it's continues to read the complete inf file which is not required. once the EFI_BASE_ADDRESS read from the INF no need to read the INF further. MSFT

[edk2-devel] [PATCH] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-04 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3476 parseInfFile currently reading the EFI_BASE_ADDRESS from INF, once the address found still it's continues to read the complete inf file which is not required. once the EFI_BASE_ADDRESS read from the INF no need to read the INF further. MSFT