[edk2-devel] 回复: [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

2021-07-19 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: Chang, Abner (HPS SW/FW Technologist) > 发送时间: 2021年7月14日 22:12 > 收件人: Schaefer, Daniel ; devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Leif > Lindholm > 主题: RE: [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

[edk2-devel] 回复: [PATCH] BaseTools GenFw: Add support for R_RISCV_PCREL_LO12_S relocation

2021-07-19 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: Sunil V L > 发送时间: 2021年7月13日 18:14 > 收件人: Daniel Schaefer > 抄送: devel@edk2.groups.io; sunil...@gmail.com; Liming Gao > ; Bob Feng ; Yuwei Chen > ; Pete Batard ; Abner Chang > > 主题: Re: [PATCH] BaseTools GenFw: Add support for > R_RISCV_PCREL_LO12_S

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Dov Murik
On 20/07/2021 1:36, Christoph Willing wrote: > On 20/7/21 3:58 am, Dov Murik wrote: >> >> >> On 19/07/2021 15:56, Christoph Willing wrote: >>> Thanks for the clarification Dov. >>> >>> I've been trying with just "normal" VMs, not SEV. I did already find and >>> try the

[edk2-devel] [staging/edk2-redfish-client PATCH v2 1/2] RedfishClientPkg: Initial commit

2021-07-19 Thread Abner Chang
Initial commit of architecture diagrams and Readme.md Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney --- RedfishClientPkg/Readme.md| 185 +++ .../Media/RedfishClientDriverStack.svg| 1068

[edk2-devel] [staging/edk2-redfish-client PATCH v2 0/2] RedfishClientPkg

2021-07-19 Thread Abner Chang
In V2: Correct EFI_PLATFORM_CONFIG_TO_REDFISH_PROTOCOL to EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL in readme and diagrams. In V1: This is the first commit of RedfishClientPkg. Readme and diagrams are created to delineate EDK2 Redfish Client implementation. Signed-off-by: Abner

[edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt

2021-07-19 Thread Abner Chang
Add maintainer and reviewer to RedfishClinetPkg. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, July 20, 2021 #cal-cancelled

2021-07-19 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/20/2021 #cal-reminder

2021-07-19 Thread gaoliming
Few new issues are supported. Let’s cancel the meeting. 3500 EDK2 Code unassig...@tianocore.org UNCO Add some debugger scripts to the edk2 repo 18:13:17 af...@apple.com

Re: [edk2-devel] [Patch V2] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-19 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: Luo, Heng > Sent: Tuesday, July 20, 2021 10:18 AM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan > Subject: [Patch V2] NetworkPkg: Add HTTP Additional Event Notifications > > REF:

Re: [edk2-devel] [staging/edk2-redfish-client PATCH 2/2] edk2: Update Maintainers.txt

2021-07-19 Thread Nickle Wang
Reviewed-by: Nickle Wang Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Saturday, July 17, 2021 10:02 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao ; Andrew Fish ; Leif Lindholm ; Michael D Kinney Subject:

Re: [edk2-devel] [PATCH] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-19 Thread Heng Luo
Thank Jiaxin, the patch V2 is sent out following Jiaxin's comment. > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, July 20, 2021 9:45 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Maciej Rabeda ; Fu, Siyuan > > Subject: RE: [PATCH] NetworkPkg: Add HTTP Additional Event

[edk2-devel] [Patch V2] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-19 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3496 Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg, Send HTTP Events via EDKII_HTTP_CALLBACK_PROTOCOL when Dns/ConnectTcp/TlsConnectSession/InitSession occurs. Signed-off-by: Heng Luo Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu ---

回复: [edk2-devel] [PATCH v4 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-07-19 Thread gaoliming
Hi, all This patch set has passed code review. How about merge it for this stable tag edk2 202108? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sami > Mujawar > 发送时间: 2021年5月19日 17:58 > 收件人: Etienne Carriere ; > devel@edk2.groups.io > 抄送: Achin Gupta ; Ard Biesheuvel > ;

Re: [edk2-devel] [PATCH] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-19 Thread Wu, Jiaxin
For the below EDKII_HTTP_CALLBACK_EVENT definition: All event is to retrieve the event Status, so the comments should be made clearly and align with code returned status, for example, > + /// Retrieve the host address, EventStatus: There might be the misunderstanding you want the host

回复: [edk2-devel] [PATCH v6 00/11] Secure Boot default keys

2021-07-19 Thread gaoliming
Sami: For EmulatorPkg, Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Samer El-Haj-Mahmoud > 发送时间: 2021年7月16日 20:00 > 收件人: devel@edk2.groups.io; g...@semihalf.com > 抄送: l...@nuviainc.com; ardb+tianoc...@kernel.org; Sunny Wang > ; m...@semihalf.com; upstr...@semihalf.com; >

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/20/2021 #cal-reminder

2021-07-19 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Christoph Willing
On 20/7/21 3:58 am, Dov Murik wrote: > > > On 19/07/2021 15:56, Christoph Willing wrote: >> Thanks for the clarification Dov. >> >> I've been trying with just "normal" VMs, not SEV. I did already find and try >> the confidential-containers-demo sev-hashes-v2 branch but it didn't help - >> not

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platform/RaspberryPi/RPi4: Fix non-standard ACPI HIDs

2021-07-19 Thread Samer El-Haj-Mahmoud
Remove non-standard RPI ACPI _CIDs that are not needed. This also fixes the FWTS failure reported in https://github.com/pftf/RPi4/issues/67 The windows drivers at https://github.com/raspberrypi/windows-drivers are still able to match the ACPI objects using the HIDs which are supported in

Re: [edk2-devel] [PATCH v5 3/4] OvmfPkg/PlatformPei: Mark SEC GHCB page as unencrypted via hypercall

2021-07-19 Thread Ashish Kalra via groups.io
Hello Tom, On Fri, Jul 16, 2021 at 09:22:20AM -0500, Tom Lendacky wrote: > On 7/8/21 9:08 AM, Ashish Kalra wrote: > > From: Ashish Kalra > > > > Mark the SEC GHCB page (that is mapped as unencrypted in > > ResetVector code) in the hypervisor page status tracking. > > > > Cc: Jordan Justen > >

Re: [edk2-devel] [PATCH v5 2/4] OvmfPkg/VmgExitLib: Add support for hypercalls with SEV-ES.

2021-07-19 Thread Ashish Kalra via groups.io
Hello Tom, On Fri, Jul 16, 2021 at 09:16:00AM -0500, Tom Lendacky wrote: > On 7/8/21 9:08 AM, Ashish Kalra wrote: > > From: Ashish Kalra > > > > The subject isn't correct since the #VC handler already supports > hypercalls. It should say something like "Make the #VC handler aware of > the

Re: [edk2-devel] [PATCH v5 1/4] OvmfPkg/BaseMemEncryptLib: Support to issue unencrypted hypercall

2021-07-19 Thread Ashish Kalra via groups.io
Hello Tom, On Fri, Jul 16, 2021 at 09:11:23AM -0500, Tom Lendacky wrote: > On 7/8/21 9:07 AM, Ashish Kalra wrote: > > From: Ashish Kalra > > > > The patch subject is a bit confusing. Something more like "Add API to > issue hypercall on page encryption state change" or similar, since this is >

Re: [edk2-devel] [PATCH v2 10/11] OvmfPkg: add SevHashesBlobVerifierLib

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/19/21 2:47 PM, Dov Murik wrote: > On 19/07/2021 20:28, Tom Lendacky wrote: >> On 7/6/21 3:55 AM, Dov Murik wrote: > >>> +[Defines] >>> + INF_VERSION= 0x00010005 >>> + BASE_NAME = SevHashesBlobVerifierLib > > But is this BASE_NAME okay? > > Or

Re: [edk2-devel] [PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity

2021-07-19 Thread Dov Murik
On 19/07/2021 10:09, Ard Biesheuvel wrote: > On Mon, 19 Jul 2021 at 05:14, Ni, Ray wrote: >> >> This change generates the reset vector binary which only contains 1G page >> table. If a platform doesn't support 1G page table, this will cause system >> hang. >> >> To Ard and Jordan, >> Can you

Re: [edk2-devel] [PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/19/21 2:09 AM, Ard Biesheuvel via groups.io wrote: > On Mon, 19 Jul 2021 at 05:14, Ni, Ray wrote: >> >> This change generates the reset vector binary which only contains 1G page >> table. If a platform doesn't support 1G page table, this will cause system >> hang. >> >> To Ard and Jordan,

Re: [edk2-devel] [PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

2021-07-19 Thread Dov Murik
On 19/07/2021 18:19, Brijesh Singh wrote: > > > On 7/19/21 7:22 AM, Dov Murik wrote: >>> The patch itself is okay. Just curious, do we also need to add a >>> verification for the QEMU FW cfg file ? >>> >> >> I don't really understand.  This patch adds the VerifyBlob() call on >> blobs that

Re: [edk2-devel] [PATCH v2 10/11] OvmfPkg: add SevHashesBlobVerifierLib

2021-07-19 Thread Dov Murik
On 19/07/2021 20:28, Tom Lendacky wrote: > On 7/6/21 3:55 AM, Dov Murik wrote: >> Add an implementation for BlobVerifierLib that locates the SEV hashes >> table and verifies that the calculated hashes of the kernel, initrd, and >> cmdline blobs indeed match the expected hashes stated in the

Re: [edk2-devel] [PATCH v2 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page

2021-07-19 Thread Dov Murik
On 19/07/2021 19:19, Tom Lendacky wrote: > On 7/6/21 3:54 AM, Dov Murik wrote: >> Round up the size of the SEV launch secret area to a whole page, as >> required by BuildMemoryAllocationHob. This will allow the secret >> area defined in the MEMFD to take less than a whole 4KB page. >> >> Cc:

Re: [edk2-devel] [PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

2021-07-19 Thread Dov Murik
On 19/07/2021 18:57, Tom Lendacky wrote: > On 7/6/21 3:54 AM, Dov Murik wrote: >> In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content >> of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a >> call to VerifyBlob after fetching to allow BlobVerifierLib >>

Re: [edk2-devel] [PATCH v2 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation

2021-07-19 Thread Dov Murik
On 19/07/2021 18:50, Tom Lendacky wrote: > On 7/6/21 3:54 AM, Dov Murik wrote: >> BlobVerifierLib will be used to verify blobs fetching them from QEMU's >> firmware config (fw_cfg) in platforms that enable such verification. >> >> The null implementation NullBlobVerifierLib treats all blobs as

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Dov Murik
On 19/07/2021 18:21, Tom Lendacky wrote: > On 7/6/21 3:54 AM, Dov Murik wrote: >> From: James Bottomley >> >> Support QEMU's -kernel option. >> >> OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c is an exact copy >> of OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c . > > Just a

Re: [edk2-devel] [PATCH v2 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-19 Thread Dov Murik
On 19/07/2021 18:14, Tom Lendacky wrote: > On 7/6/21 3:54 AM, Dov Murik wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 > > This BZ link should be part of all the commit messages in the series. > Oh I missed a few. I'll fix. Thanks. > Thanks, > Tom > >> >> Booting with

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Dov Murik
On 19/07/2021 15:56, Christoph Willing wrote: > Thanks for the clarification Dov. > > I've been trying with just "normal" VMs, not SEV. I did already find and try > the confidential-containers-demo sev-hashes-v2 branch but it didn't help - > not surprising if it's not relevant to normal VMs.

Re: [edk2-devel] [PATCH v2 11/11] OvmfPkg/AmdSev: Enforce hash verification of kernel blobs

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:55 AM, Dov Murik wrote: > In the AmdSevX86 build, use SevHashesBlobVerifierLib to enforce > verification of hashes of the kernel/initrd/cmdline blobs fetched from > firmware config. > > This allows for secure (measured) boot of SEV guests with QEMU's > -kernel/-initrd/-append switches

Re: [edk2-devel] [PATCH v2 10/11] OvmfPkg: add SevHashesBlobVerifierLib

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:55 AM, Dov Murik wrote: > Add an implementation for BlobVerifierLib that locates the SEV hashes > table and verifies that the calculated hashes of the kernel, initrd, and > cmdline blobs indeed match the expected hashes stated in the hashes > table. > > If there's a missing hash or a

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

2021-07-19 Thread Ard Biesheuvel
On Mon, 19 Jul 2021 at 17:46, Anthony PERARD wrote: > > On Fri, Jul 09, 2021 at 11:24:23AM +0800, Gary Lin wrote: > > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download > > the kernel, initrd, and kernel command line from QEMU's fw_cfg. > > > > Cc: Ard Biesheuvel > > cc:

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Ard Biesheuvel
On Mon, 19 Jul 2021 at 18:07, Anthony PERARD wrote: > > It would have been nice to have this patch in a patch series with > "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly to make it simpler > to understand the problem needed to be fixed. > > On Thu, Jul 08, 2021 at 12:05:49PM +0800, Gary

Re: [edk2-devel] [PATCH v2 09/11] OvmfPkg/AmdSev: reserve MEMFD space for for firmware config hashes

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > From: James Bottomley > > Split the existing 4KB page reserved for SEV launch secrets into two > parts: first 3KB for SEV launch secrets and last 1KB for firmware > config hashes. > > The area of the firmware config hashes will be attested (measured) by >

Re: [edk2-devel] [PATCH v2 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > Round up the size of the SEV launch secret area to a whole page, as > required by BuildMemoryAllocationHob. This will allow the secret > area defined in the MEMFD to take less than a whole 4KB page. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Anthony PERARD via groups.io
It would have been nice to have this patch in a patch series with "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly to make it simpler to understand the problem needed to be fixed. On Thu, Jul 08, 2021 at 12:05:49PM +0800, Gary Lin wrote: > There are several functions in OvmfPkg/Library using

Re: [edk2-devel] [PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content > of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a > call to VerifyBlob after fetching to allow BlobVerifierLib > implementations to add a verification step for these

Re: [edk2-devel] [PATCH v2 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > BlobVerifierLib will be used to verify blobs fetching them from QEMU's > firmware config (fw_cfg) in platforms that enable such verification. > > The null implementation NullBlobVerifierLib treats all blobs as valid. > > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

2021-07-19 Thread Anthony PERARD via groups.io
On Fri, Jul 09, 2021 at 11:24:23AM +0800, Gary Lin wrote: > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download > the kernel, initrd, and kernel command line from QEMU's fw_cfg. > > Cc: Ard Biesheuvel > cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > Cc: Jim

Re: [edk2-devel] [PATCH v5 1/4] OvmfPkg/BaseMemEncryptLib: Support to issue unencrypted hypercall

2021-07-19 Thread Ashish Kalra via groups.io
Hello Dov, On Mon, Jul 19, 2021 at 11:04:17AM +0300, Dov Murik wrote: > > > On 16/07/2021 15:29, Ashish Kalra wrote: > > Hello Dov, > > > > On Thu, Jul 15, 2021 at 11:58:17PM +0300, Dov Murik wrote: > >> Hi Ashish, > >> > >> On 08/07/2021 17:07, Ashish Kalra wrote: > >>> From: Ashish Kalra >

Re: [edk2-devel] [PATCH v5 4/4] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

2021-07-19 Thread Ashish Kalra via groups.io
Hello Dov, On Mon, Jul 19, 2021 at 10:31:10AM +0300, Dov Murik wrote: > Ashish, > > > On 08/07/2021 17:09, Ashish Kalra wrote: > > From: Ashish Kalra > > > > Check for SEV live migration feature support, if detected > > setup a new UEFI enviroment variable to indicate OVMF > > support for SEV

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > From: James Bottomley > > Support QEMU's -kernel option. > > OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c is an exact copy > of OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c . Just a nit, but this confused me initially. Maybe it should say

Re: [edk2-devel] [PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

2021-07-19 Thread Brijesh Singh via groups.io
On 7/19/21 7:22 AM, Dov Murik wrote: The patch itself is okay. Just curious, do we also need to add a verification for the QEMU FW cfg file ? I don't really understand. This patch adds the VerifyBlob() call on blobs that were read by FetchBlob(), which in turn reads the contents of

Re: [edk2-devel] [PATCH v2 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-19 Thread Lendacky, Thomas via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 This BZ link should be part of all the commit messages in the series. Thanks, Tom > > Booting with SEV prevented the loading of kernel, initrd, and kernel > command-line via QEMU fw_cfg interface

Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

2021-07-19 Thread Marcin Wojtas
Hi Ard, pon., 19 lip 2021 o 11:54 Ard Biesheuvel napisał(a): > > On Mon, 19 Jul 2021 at 11:31, Marcin Wojtas wrote: > > > > BBR 1.0 spec says that _STA is required for each device in DSDT or SSDT. > > Fix that for all platforms with the Marvell SoC's. > > > > Can we fix the BBR instead? If ACPI

Re: [edk2-devel] [PATCH 2/2] Fix variables may be used uninitialize

2021-07-19 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Hsu, WesleyX Sent: Sunday, July 18, 2021 8:59 PM To: devel@edk2.groups.io Cc: Hsu, WesleyX ; Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH 2/2] Fix variables may be used uninitialize

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Christoph Willing
Thanks for the clarification Dov. I've been trying with just "normal" VMs, not SEV. I did already find and try the confidential-containers-demo sev-hashes-v2 branch but it didn't help - not surprising if it's not relevant to normal VMs. Do you know whether this functionality (-kernel, -initrd,

Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value

2021-07-19 Thread wanghuiqiang via groups.io
+ Ard, Leif, Sami. All OSes which use 64KB page size and the PCIe resource allocation rely on BIOS initialization will encounter VF BAR resource allocation issue. Thanks! -Original Message- From: wanghuiqiang Sent: Monday, July 19, 2021 2:02 PM To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Christoph Willing
I have been using Qemu with -kernel,-initrd,-append options without OVMF for some time in my workflow. When booting with OVMF, I have found that the most recent tag in the edk2 public git repo that supports those options is vUDK2018. Therefore I'm extremely interested in this series of patches,

Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value

2021-07-19 Thread wanghuiqiang via groups.io
Hi Ray, 52 bit address ranges are supported only when using the 64KB translation granule for ARM64 platform, this is another scenario using 64K page size. We need set PcdSrIovSystemPageSize to 0x10 in such case to make BIOS resource assignment still appropriate even PCI DSM#5 function set as 0

Re: [edk2-devel] [PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

2021-07-19 Thread Dov Murik
On 18/07/2021 18:47, Brijesh Singh wrote: > > On 7/6/21 3:54 AM, Dov Murik wrote: >> In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content >> of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a >> call to VerifyBlob after fetching to allow BlobVerifierLib

Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-19 Thread Dov Murik
Chris, On 19/07/2021 7:46, Christoph Willing wrote: > I have been using Qemu with -kernel,-initrd,-append options without OVMF for > some time in my workflow. When booting with OVMF, I have found that the most > recent tag in the edk2 public git repo that supports those options is > vUDK2018.

[edk2-devel] [PATCH] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-19 Thread Heng Luo
https://bugzilla.tianocore.org/show_bug.cgi?id=3496 Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg, Send HTTP Events via EDKII_HTTP_CALLBACK_PROTOCOL when Dns/ConnectTcp/TlsConnectSession/InitSession occurs. Signed-off-by: Heng Luo Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu ---

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Anthony PERARD via groups.io
On Thu, Jul 08, 2021 at 12:05:49PM +0800, Gary Lin wrote: > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since > InitializeXenPlatform() didn't set

Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

2021-07-19 Thread Ard Biesheuvel
On Mon, 19 Jul 2021 at 11:31, Marcin Wojtas wrote: > > BBR 1.0 spec says that _STA is required for each device in DSDT or SSDT. > Fix that for all platforms with the Marvell SoC's. > Can we fix the BBR instead? If ACPI itself does not require _STA, BBR should not require it either. >

Re: [edk2-devel] [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs

2021-07-19 Thread Marcin Wojtas
Hi Ard, pon., 19 lip 2021 o 09:28 Ard Biesheuvel napisał(a): > > On Fri, 16 Jul 2021 at 19:32, Ard Biesheuvel wrote: > > > > On Mon, 12 Jul 2021 at 13:17, Jon Nettleton wrote: > > > > > > On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrote: > > > > > > > > Hi, > > > > > > > > wt., 29 cze

[edk2-devel] [edk2-platforms PATCH 7/7] Marvell: Armada7k8k/OcteonTx: Bump firmware to "EDK2 SH 1.0" revision

2021-07-19 Thread Marcin Wojtas
After the recent SystemReady ES compliance fixes, ACPI enhancements and other improvements bump revision of the Marvell-based platforms to "EDK2 SH 1.0". Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[edk2-devel] [edk2-platforms PATCH 6/7] Marvell/Drivers: SmbiosPlatformDxe: Update Type0 information

2021-07-19 Thread Marcin Wojtas
This patch updates 2 fields of the SMBIOS Type0 table. The "Vendor" and the BiosVersion strings are set according to the values of the newly introduced PCD's. Note, that the gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString could not be used, as its format does match the required by SMBIOS

[edk2-devel] [edk2-platforms PATCH 5/7] Marvell: Armada7k8k/OcteonTx: Switch to MonotonicCounterRuntimeDxe

2021-07-19 Thread Marcin Wojtas
From: Grzegorz Bernacki Since the beginning of the EDK2 port Marvell platfroms have been using a dated EmbeddedPkg's MonotonicCounter driver. Switch to the actively maintained MonotonicCounterRuntimeDxe, what fixes ACS3.0 BS.GetNextMonotonicCount test case. Signed-off-by: Grzegorz Bernacki

[edk2-devel] [edk2-platforms PATCH 4/7] SolidRun/Armada80x0McBin: AcpiTables: Introduce DBG2 table

2021-07-19 Thread Marcin Wojtas
The DBG2 table is mandatory as per SBBR v1.2 specification. Expose it via J25 jumper on the Armada 8040 MacchiatoBin platform. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin.inf | 1 + Silicon/Marvell/Armada7k8k/AcpiTables/AcpiHeader.h

[edk2-devel] [edk2-platforms PATCH 3/7] Marvell/Cn913xDbA: AcpiTables: Introduce DBG2 table

2021-07-19 Thread Marcin Wojtas
The DBG2 table is mandatory as per SBBR v1.2 specification. Introduce it via CP0_UART0 interface. Note: in order to use it, DPR58 and DPR59 must be switched to positions 2-3. Signed-off-by: Marcin Wojtas --- Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc | 4 +-

[edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

2021-07-19 Thread Marcin Wojtas
BBR 1.0 spec says that _STA is required for each device in DSDT or SSDT. Fix that for all platforms with the Marvell SoC's. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl| 56 +++

[edk2-devel] [edk2-platforms PATCH 1/7] Marvell: Armada7k8k: Add missing VariablePolicyHelperLib resolution

2021-07-19 Thread Marcin Wojtas
From: Grzegorz Bernacki The latest changes in MdeModulePkg/Universal/BdsDxe require VariablePolicyHelperLib resolution. Fix that for all platforms based on the Marvell SoCs. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 ++- 1 file changed, 2

[edk2-devel] [edk2-platforms PATCH 0/7] Marvell ACS improvements

2021-07-19 Thread Marcin Wojtas
Hi, This new series comes with the remaining improvements that allow the ACS3.0 test suite to pass the SBSA/FWTS/SCT to the maximum non-HW related extent. Missing _STA methods and DBG2 description are added to the ACPI tables. Moreover all platforms start using the maintained

Re: [edk2-devel] [PATCH v4 0/3] Enable Cloud Hypervisor support in edk2

2021-07-19 Thread Sami Mujawar
Hi Ard, On 16/07/2021, 18:28, "Ard Biesheuvel" wrote: On Fri, 16 Jul 2021 at 19:25, Ard Biesheuvel wrote: > > On Mon, 5 Jul 2021 at 12:06, Jianyong Wu wrote: > > > > Cloud Hypervisor is an open source Virtual Machine Monitor (VMM) that > > runs on top of KVM. Cloud

Re: [edk2-devel] [PATCH v5 1/4] OvmfPkg/BaseMemEncryptLib: Support to issue unencrypted hypercall

2021-07-19 Thread Dov Murik
On 16/07/2021 15:29, Ashish Kalra wrote: > Hello Dov, > > On Thu, Jul 15, 2021 at 11:58:17PM +0300, Dov Murik wrote: >> Hi Ashish, >> >> On 08/07/2021 17:07, Ashish Kalra wrote: >>> From: Ashish Kalra >>> >>> By default all the SEV guest memory regions are considered encrypted, >>> if a guest

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-07-19 Thread Sunny Wang
This is to fix the SCT BS.AllocatePages failures (not found) with the case that the Start address is not aligned to 64k. For example, The following is available memory region for testing: 82012000-EB6D9FFF 000696C8 With the current page alignment calculation, we

Re: [edk2-devel] [PATCH v1 1/1] ArmPlatformPkg/Scripts: Create add-symbol-file commands from UEFI console

2021-07-19 Thread Ard Biesheuvel
On Fri, 9 Jul 2021 at 11:03, PierreGondois wrote: > > More formally: > > Tested-by: Pierre Gondois > Merged as #1821 Thanks, > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77875): https://edk2.groups.io/g/devel/message/77875

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

2021-07-19 Thread Ard Biesheuvel
On Fri, 9 Jul 2021 at 05:24, Gary Lin wrote: > > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download > the kernel, initrd, and kernel command line from QEMU's fw_cfg. > > Cc: Ard Biesheuvel > cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > Cc: Jim Fehlig >

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Ard Biesheuvel
On Thu, 8 Jul 2021 at 06:05, Gary Lin wrote: > > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since > InitializeXenPlatform() didn't set PcdAcpiS3Enable as >

Re: [edk2-devel] [PATCH v5 4/4] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

2021-07-19 Thread Dov Murik
Ashish, On 08/07/2021 17:09, Ashish Kalra wrote: > From: Ashish Kalra > > Check for SEV live migration feature support, if detected > setup a new UEFI enviroment variable to indicate OVMF > support for SEV live migration. > > The new runtime UEFI environment variable is set via the >

Re: [edk2-devel] [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs

2021-07-19 Thread Ard Biesheuvel
On Fri, 16 Jul 2021 at 19:32, Ard Biesheuvel wrote: > > On Mon, 12 Jul 2021 at 13:17, Jon Nettleton wrote: > > > > On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrote: > > > > > > Hi, > > > > > > wt., 29 cze 2021 o 16:17 Marcin Wojtas napisał(a): > > > > > > > > Hi Leif, > > > > > > > > pon.,

Re: [edk2-devel] [PATCH] UefiCpuPkg: SecCoreNative without ResetVector

2021-07-19 Thread Ashraf Ali S
Hi., Ray BIOS boot to OS verified in Simics Successfully with the following changes. 1. SecCoreNative.inf with new GUID. 2. Removed IA32 resetvector code from SecCoreNative. 3. Removed the ResetVector Code from PlatformSecLib 4. Consumed the ResetVector Code from UefiCpuPkg/ResetVector The

Re: [edk2-devel] [PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity

2021-07-19 Thread Ard Biesheuvel
On Mon, 19 Jul 2021 at 05:14, Ni, Ray wrote: > > This change generates the reset vector binary which only contains 1G page > table. If a platform doesn't support 1G page table, this will cause system > hang. > > To Ard and Jordan, > Can you evaluate whether this change impacts OVMF? > I don't