Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

2021-07-28 Thread Wu, Hao A
Thanks for the patch. Some inline comments below: > -Original Message- > From: Wenyi Xie > Sent: Wednesday, July 28, 2021 1:58 PM > To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A > > Cc: songdongku...@huawei.com; xiewen...@huawei.com > Subject: [PATCH EDK2 v1 1/1]

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Yao, Jiewen
comment below thank you! Yao, Jiewen > 在 2021年7月29日,下午12:29,Brijesh Singh via groups.io > 写道: > >  >> On 7/28/21 9:44 PM, Xu, Min M wrote: >> Jiewen & Singh >> >> From the discussion I am thinking we have below rules to follow to the >> design the structure >> of TEE_WORK_AREA: >> 1.

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Digant H Solanki
Thanks for review and suggestion, Sai..!! -Original Message- From: Chaganty, Rangasai V Sent: Wednesday, July 28, 2021 11:24 PM To: Solanki, Digant H ; devel@edk2.groups.io Cc: Ni, Ray ; S, Ashraf Ali Subject: RE: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Brijesh Singh via groups.io
On 7/28/21 9:44 PM, Xu, Min M wrote: > Jiewen & Singh > > From the discussion I am thinking we have below rules to follow to the design > the structure > of TEE_WORK_AREA: > 1. Design should be flexible but not too complicated > 2. Reuse the current SEV_ES_WORK_AREA (PcdSevEsWorkAreaBase) as

[edk2-devel] AcpiViewApp is for ARM platform

2021-07-28 Thread Tiger Liu(BJ-RD)
Hi, All: I tried to comple ShellPkg\Application\AcpiViewApp I found the default compiled AcpiViewApp version is for ARM platform For example: I used it in shell on a x86 platform, found it checked GICC structure. So, Is there a X86 version? Thanks ?

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Min Xu
Jiewen & Singh From the discussion I am thinking we have below rules to follow to the design the structure of TEE_WORK_AREA: 1. Design should be flexible but not too complicated 2. Reuse the current SEV_ES_WORK_AREA (PcdSevEsWorkAreaBase) as TEE_WORK_AREA 3. TEE_WORK_AREA should be initialized

Re: [edk2-devel] [edk2-platforms] [PATCH V1 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

2021-07-28 Thread Nate DeSimone
The series has been pushed as 2959a92~.. 65c5a73 Thanks, Nate > -Original Message- > From: manickavasakam karpagavinayagam > Sent: Wednesday, June 16, 2021 2:44 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; fel...@ami.com; DOPPALAPUDI, > HARIKRISHNA ;

Re: [edk2-devel] [RFC PATCH v4 00/27] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-28 Thread Yao, Jiewen
Hi Brijesh Thanks for the patient. Most of my comment focus on the *common* part, and *interface* between SEV and common code. I will leave you to decide the detailed SEV specific implementation. Patch-04: Can we use consistent naming conversion? We have PcdOvmfSecGhcbPageTableBase,

Re: [edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

2021-07-28 Thread Wang, Jian J
Thanks for the RFC. I'm not object to this idea. The only concern from me is the potential security holes introduced by the changes. According to your description, it allows 3rd party software to violate memory protection policy. I'd like to see more explanations on how to avoid it to be

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Remove PPI from HOB

2021-07-28 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/8c9335e > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, July 9, 2021 9:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Benjamin Doron > > Subject: [edk2-platforms][PATCH

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Remove PPI from HOB

2021-07-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, July 9, 2021 9:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Benjamin Doron > > Subject: [edk2-platforms][PATCH v1 1/1] >

Re: [edk2-devel] [edk2-non-osi] [PATCH] ASpeed : ASpeedGopBinPkg : Add X64 ASpeedAst2500Gop UEFI Driver

2021-07-28 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-non-osi/commit/7c28b7d > -Original Message- > From: manickavasakam karpagavinayagam > Sent: Wednesday, June 16, 2021 2:51 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; fel...@ami.com; DOPPALAPUDI, > HARIKRISHNA ;

Re: [edk2-devel] [edk2-non-osi] [PATCH] ASpeed : ASpeedGopBinPkg : Add X64 ASpeedAst2500Gop UEFI Driver

2021-07-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: manickavasakam karpagavinayagam > Sent: Wednesday, June 16, 2021 2:51 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; fel...@ami.com; DOPPALAPUDI, > HARIKRISHNA ; Jha, Manish ; > Bobroff, Zachary ;

Re: [edk2-devel] [PATCH v2 0/3] Move the SEV specific changes in ResetVector in separate file

2021-07-28 Thread Yao, Jiewen
Pushed. https://github.com/tianocore/edk2/pull/1842 githash: dc485c556d5f5db21debe8de3a45a7564aacbe24..b461d67639f2deced77e9bb967d014b7cfcd75f8 > -Original Message- > From: Brijesh Singh > Sent: Wednesday, July 28, 2021 2:10 AM > To: devel@edk2.groups.io > Cc: Brijesh Singh ; James

Re: [edk2-devel] [edk2-platforms][PATCH v4 41/41] TigerlakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-07-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 25, 2021 2:21 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > > Subject: [edk2-platforms][PATCH v4 41/41] >

Re: [edk2-devel] [edk2-platforms][PATCH v4 40/41] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-07-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 25, 2021 2:21 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 40/41] > SimicsIch10Pkg/BasePchSpiCommonLib:

Re: [edk2-devel] [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify flash regions by GUID

2021-07-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 25, 2021 2:21 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify

Re: [edk2-devel] [edk2-platforms][PATCH v4 36/41] IntelSiliconPkg: Add flash region GUIDs

2021-07-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 25, 2021 2:21 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 36/41] IntelSiliconPkg: Add flash

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/PciHostBridgeLibSimple: Fix Mem.Limit assignment

2021-07-28 Thread Chiu, Chasel
Patch pushed: 69e6a5e160551fdd09ce367e9c97c25d8683a3ac Thanks, Chasel > -Original Message- > From: Benjamin Doron > Sent: Friday, July 23, 2021 10:27 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [PATCH v2]

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/PciHostBridgeLibSimple: Fix Mem.Limit assignment

2021-07-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Benjamin Doron > Sent: Thursday, July 22, 2021 7:27 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel] [PATCH v2]

Re: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp

2021-07-28 Thread Chiu, Chasel
Patch submitted: bee9efb7524dc06799ff65e6e056c7725a54c7e1 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Takuto > Naito > Sent: Wednesday, July 28, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Oram, Isaac W > ; Desimone, Nathaniel L > ;

Re: [edk2-devel] [edk2-platforms][PATCH v4 00/41] Consolidate SpiFlashCommonLib instances

2021-07-28 Thread Michael Kubacki
Sure. These packages were added to edk2-platforms throughout the lifetime of this patch series. Hopefully this is the last rebase... Regards, Michael On 7/28/2021 7:58 PM, Desimone, Nathaniel L wrote: Hi Michael, The change content looks good. However, after applying your patch series

Re: [edk2-devel] [edk2-platforms][PATCH v4 00/41] Consolidate SpiFlashCommonLib instances

2021-07-28 Thread Nate DeSimone
Hi Michael, The change content looks good. However, after applying your patch series PurleyOpenBoardPkg and WhitleyOpenBoardPkg no longer compile. Can you please fix these build errors? For your reference, these are the tests that I ran: build_bios.py -p BoardMtOlympus -t VS2015x86 -d

Re: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp

2021-07-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Takuto > Naito > Sent: Wednesday, July 28, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Oram, Isaac W > ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject:

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Yao, Jiewen
Comment below: > -Original Message- > From: Brijesh Singh > Sent: Thursday, July 29, 2021 2:59 AM > To: Yao, Jiewen ; devel@edk2.groups.io; Xu, Min M > > Cc: brijesh.si...@amd.com; Ard Biesheuvel ; > Justen, Jordan L ; Erdem Aktas > ; James Bottomley ; Tom > Lendacky > Subject: Re:

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Rebecca Cran
CC'ing the Tianocore stewards. I've had problems getting a recent patch committed just to make edk2-libc work against current edk2 master. Tianocore stewards: do we need new or additional maintainers for edk2-libc, or is there a plan to deprecate it? The current maintainers are listed

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Tim Lewis
I would point out that there was significant work on libc in the past (see https://github.com/andreiw/UefiToolsPkg) but never any help to upstream these fixes, including making sure that many Linux tools can easily be ported. I myself have used it to port several BSD utilities over, but each

Re: [edk2-devel] [PATCH edk2-platforms v2 5/6] .mergify: Add Mergify YML pull request rules configuration file

2021-07-28 Thread Michael D Kinney
The Mergify rules in edk2 repo were recently updated. Please align with the latest that uses the new Mergify queue feature along with other improvements. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of PierreGondois > Sent: Tuesday, July 27, 2021 9:50 AM >

[edk2-devel] [edk2-platforms][PATCH v2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

2021-07-28 Thread Benjamin Doron
BootManagerMenuApp is the default PcdBootManagerMenuFile. It allows choosing a boot device, but system configuration is performed in UiApp. Therefore, un-comment and fix UiApp boot option registration. Tested, UiApp can be entered through the new boot option. Cc: Eric Dong Cc: Liming Gao

Re: [edk2-devel] [PATCH v1] OvmfPkg: Add build options for 8MB and 16MB X64 OVMF images

2021-07-28 Thread Devon Bautista
Laszlo, I apologize for the delay. I've been heavily preoccupied in another work program I am involved in. On 5/27/21 3:12 AM, Laszlo Ersek wrote: > On 05/26/21 19:08, Devon Bautista wrote: >> Currently, the largest volume size for building OVMF images is 4MB. With >> the growth of the Linuxboot

Re: [edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

2021-07-28 Thread Taylor Beebe
Note: I'll be accepting feedback on this until Friday after which I will submit a patch series. On 7/22/2021 5:32 PM, Taylor Beebe via groups.io wrote: Current memory protection settings rely on FixedAtBuild PCD values (minus PcdSetNxForStack). Because of this, the memory protection

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Brijesh Singh via groups.io
On 7/28/21 11:26 AM, Yao, Jiewen wrote: I would say it is NOT the best software practice to define 2 enable fields to indicate one type. What if some software error, set both TdxEnable and SevEnable at same time? How do you detect such error? Hmm, aren't we saying it is a software bug. In

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Chaganty, Rangasai V
Digant, The notation "PATCH 3/3" indicates part 3 of a 3 patch series. However since this is a single patch, the subject line could simply indicate [PATCH v3]. Something to consider for future reviews. Thanks, Sai -Original Message- From: Chaganty, Rangasai V Sent: Wednesday, July

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Solanki, Digant H Sent: Thursday, July 22, 2021 4:47 AM To: devel@edk2.groups.io Cc: Solanki, Digant H ; Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD

Re: [edk2-devel] [PATCH v5 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-28 Thread Dov Murik
On 28/07/2021 19:41, Yao, Jiewen wrote: > For OvmfPkg, reviewed-by: Jiewen Yao > For ArmVirtPkg, acked-by: Jiewen Yao > Thanks Jiewen! -Dov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78303):

Re: [edk2-devel] [Patch V3] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-28 Thread Maciej Rabeda
Change merged: https://github.com/tianocore/edk2/pull/1840 On 28-Jul-21 15:50, Maciej Rabeda wrote: Reviewed-by: Maciej Rabeda On 28-Jul-21 13:58, Heng Luo wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3496 Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg, Send HTTP Events

Re: [edk2-devel] [Patch V3] NetworkPkg: Making the HTTP IO timeout value programmable with PCD

2021-07-28 Thread Maciej Rabeda
Change merged: https://github.com/tianocore/edk2/pull/1840 Corrections applied: 1. NetworkPkg.dsc: [PdcsDynamic] -> [PdcsDynamicDefault] 2. NetworkPkg.dsc: PcdHttpTimeout -> PcdHttpIoTimeout On 28-Jul-21 15:59, Maciej Rabeda wrote: Reviewed-by: Maciej Rabeda On 28-Jul-21 14:16, Heng Luo

Re: [edk2-devel] [PATCH v5 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-28 Thread Yao, Jiewen
For OvmfPkg, reviewed-by: Jiewen Yao For ArmVirtPkg, acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dov Murik > Sent: Wednesday, July 28, 2021 3:07 AM > To: devel@edk2.groups.io > Cc: Dov Murik ; Tobin Feldman-Fitzthum > ; Tobin Feldman-Fitzthum ;

Re: [edk2-devel] [RFC PATCH v4 00/27] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-28 Thread Yao, Jiewen
Sounds good. Thank you to confirm that. I will send my feedback. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh > Singh via groups.io > Sent: Wednesday, July 28, 2021 11:22 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: brijesh.si...@amd.com; James Bottomley

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Yao, Jiewen
I would say it is NOT the best software practice to define 2 enable fields to indicate one type. What if some software error, set both TdxEnable and SevEnable at same time? How do you detect such error? If some code may check the SEV only, and some code may check TDX only, then both code can

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Brijesh Singh via groups.io
Hi Yao Jiewen, I guess I am still trying to figure out why we need the header in the work area. Can't we do something like this: typedef struct { UINT8SevEsEnabled; // If Es is enabled then this field must be zeroed UINT8MustBeZero; UINT8

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Rebecca Cran
I think it's mostly been abandoned, and people are expected to use native UEFI functions instead. Personally I'd like to see it continue to be maintained. -- Rebecca Cran On 7/28/21 9:45 AM, Maciej Rabeda wrote: Naturally. Since it is there, why is it not used for brotli, openssl in

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Maciej Rabeda
Naturally. Since it is there, why is it not used for brotli, openssl in CryptoPkg or jansson in RedfishPkg? On 28-Jul-21 17:34, Rebecca Cran wrote: Are you aware of the edk2-libc project at https://github.com/tianocore/edk2-libc ? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

[edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp

2021-07-28 Thread Takuto Naito
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3511 The PCD PcdDebugLoadImageMethod, which is consumed by PeCoffExtraActionLibDebug.inf is only for the DEBUG build. Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Takuto Naito ---

[edk2-devel] [edk2-platforms PATCH v1 0/1] Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp

2021-07-28 Thread Takuto Naito
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3511 https://github.com/naitaku/edk2-platforms/tree/FixWilsonCityRvpRelease_v1 Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Takuto Naito (1): Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Rebecca Cran
Are you aware of the edk2-libc project at https://github.com/tianocore/edk2-libc ? -- Rebecca Cran On 7/27/21 9:48 AM, Maciej Rabeda wrote: Hi, I have submitted a new edk2-staging branch named "StdLibPkg". https://github.com/tianocore/edk2-staging/tree/StdLibPkg Branch contains initial

Re: [edk2-devel] [RFC PATCH v4 00/27] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-28 Thread Brijesh Singh via groups.io
Hi Yao Jiewen, On 7/28/21 3:16 AM, Yao, Jiewen wrote: Hi Brijesh I reviewed the patch set. I have some basic questions. Please help me understand before I post my comment If a platform supports SEV-SNP, can we assume SEV-ES is supported? The SEV-SNP depends on SEV and SEV-ES support. The

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Yao, Jiewen
Hi Brijesh Thanks! I think if we want to reuse this, we need rename the data structure. First, we should use a generic name. Second, I don’t think it is good idea to define two *enable* fields. Since only one of them should be enabled, we should use 1 field as enumeration. Third, we should

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

2021-07-28 Thread Stefan Berger
I now filed this bug: https://bugzilla.tianocore.org/show_bug.cgi?id=3510     Stefan On 7/28/21 10:38 AM, Michael Kubacki wrote: The main commit of the series Bret mentioned (in edk2-platforms) is here:

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

2021-07-28 Thread Michael Kubacki
The main commit of the series Bret mentioned (in edk2-platforms) is here: https://github.com/tianocore/edk2-platforms/commit/bfabeef4c9a63374784bd19f18a869aa2769e011 Regards, Michael On 7/27/2021 12:25 PM, Yao, Jiewen wrote: Oops. Sorry for late response. The code is NOT in EDKII, but

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Brijesh Singh via groups.io
Hi Jiewen and Min, See my comments below. On 7/28/21 2:54 AM, Yao, Jiewen wrote: Yes. I am thinking the same thing. [CC Flag memory location] 1) A general purpose register, such as EBP. 2) A global variable, such as .data TeeFlags: DD 0 3) A fixed region in stack, such as dword[STACK_TOP -

Re: [edk2-devel] [Patch V3] NetworkPkg: Making the HTTP IO timeout value programmable with PCD

2021-07-28 Thread Maciej Rabeda
Reviewed-by: Maciej Rabeda On 28-Jul-21 14:16, Heng Luo wrote: From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507 HTTP boot has a default set forced timeout value of 5 seconds for getting the recovery image from a remote source. This change allows the HTTP

Re: [edk2-devel] [Patch V3] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-28 Thread Maciej Rabeda
Reviewed-by: Maciej Rabeda On 28-Jul-21 13:58, Heng Luo wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3496 Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg, Send HTTP Events via EDKII_HTTP_CALLBACK_PROTOCOL when Dns/ConnectTcp/TlsConnectSession/InitSession occurs.

[edk2-devel] [Patch V3] NetworkPkg: Making the HTTP IO timeout value programmable with PCD

2021-07-28 Thread Heng Luo
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507 HTTP boot has a default set forced timeout value of 5 seconds for getting the recovery image from a remote source. This change allows the HTTP boot flow to get the IO timeout value from the PcdHttpIoTimeout.

[edk2-devel] [Patch V3] NetworkPkg: Add HTTP Additional Event Notifications

2021-07-28 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3496 Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg, Send HTTP Events via EDKII_HTTP_CALLBACK_PROTOCOL when Dns/ConnectTcp/TlsConnectSession/InitSession occurs. Signed-off-by: Heng Luo Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu ---

[edk2-devel] [Patch] BaseTools: use shutil.copyfile instead shutil.copy2

2021-07-28 Thread Bob Feng
In Split tool, the copy file actions only need to copy file content but not need to copy file metadata. copy2() copies the file metadata that causes split unit test failed under edk2-basetools CI environment. So this patch changes the call of copy2() to copyfile(). Signed-off-by: Bob Feng Cc:

Re: [edk2-devel] [PATCH v6 00/11] Secure Boot default keys

2021-07-28 Thread Ard Biesheuvel
On Wed, 28 Jul 2021 at 12:39, Ard Biesheuvel wrote: > > On Wed, 28 Jul 2021 at 09:44, gaoliming wrote: > > > > Sunny: > > Yes. This patch set is ready to be merged. > > > > Samer: > > Would you help merge this patch set? > > > > I can pick it up if you could please create the release notes

Re: [edk2-devel] [edk2-platforms PATCH v2 0/2] Fix some issues on SynQuacer

2021-07-28 Thread Masami Hiramatsu
2021年7月28日(水) 19:44 Ard Biesheuvel : > > On Mon, 26 Jul 2021 at 10:28, Masami Hiramatsu > wrote: > > > > Hello, > > > > Here is the 2nd version of the patches to fix 2 issues on SynQuacer > > platform support. > > I and Sakamoto-san found these issues in edk2-test testcases on SynQuacer > >

Re: [edk2-devel] [edk2-platforms PATCH v2 0/2] Fix some issues on SynQuacer

2021-07-28 Thread Ard Biesheuvel
On Mon, 26 Jul 2021 at 10:28, Masami Hiramatsu wrote: > > Hello, > > Here is the 2nd version of the patches to fix 2 issues on SynQuacer platform > support. > I and Sakamoto-san found these issues in edk2-test testcases on SynQuacer > DeveloperBox platfrom. > > Previous version are here; > >

Re: [edk2-devel] [PATCH v6 00/11] Secure Boot default keys

2021-07-28 Thread Ard Biesheuvel
On Wed, 28 Jul 2021 at 09:44, gaoliming wrote: > > Sunny: > Yes. This patch set is ready to be merged. > > Samer: > Would you help merge this patch set? > I can pick it up if you could please create the release notes entry? Thanks. > Thanks > Liming > > -邮件原件- > > 发件人:

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Min Xu
I noticed SEV has the memory region of SEV_ES_WORK_AREA (gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase) in MEMFD The definition is below: typedef struct _SEC_SEV_ES_WORK_AREA { UINT8SevEsEnabled; UINT8Reserved1[7]; UINT64 RandomData; UINT64 EncryptionMask; }

Re: [edk2-devel] [RFC PATCH v4 00/27] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-28 Thread Yao, Jiewen
Hi Brijesh I reviewed the patch set. I have some basic questions. Please help me understand before I post my comment If a platform supports SEV-SNP, can we assume SEV-ES is supported? Or is it a valid case that SecSnp==YES, SevEs==NO? I am trying to understand how many cases we need support. I

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Yao, Jiewen
Yes. I am thinking the same thing. [CC Flag memory location] 1) A general purpose register, such as EBP. 2) A global variable, such as .data TeeFlags: DD 0 3) A fixed region in stack, such as dword[STACK_TOP - 4] 4) A new CC common fixed region, such as dword[CC_COMMON_FLAGS] 5) A fixed

回复: [edk2-devel] [PATCH v6 00/11] Secure Boot default keys

2021-07-28 Thread gaoliming
Sunny: Yes. This patch set is ready to be merged. Samer: Would you help merge this patch set? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sunny Wang > 发送时间: 2021年7月21日 11:41 > 收件人: Samer El-Haj-Mahmoud ; > devel@edk2.groups.io; g...@semihalf.com; Ard Biesheuvel > ;

回复: [edk2-devel] [PATCH v4 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-07-28 Thread gaoliming
Etienne: I check the build log. Two build failure here. Can you update the patch to fix them? 1. Two modules are only for AARCH64. They should be specified in [Components.AARCH64] in ArmPkg\ArmPkg.dsc ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Min Xu
On July 28, 2021 2:05 PM, Yao, Jiewen wrote: > It does not necessary to be a working area. > > We just need a common TEE flag to indicate if the system run in legacy, SEV, > or > TDX, right? Right. We need somewhere to store this flag, either in a Register or in Memory. If it is memory, then in

Re: [edk2-devel] [PATCH v4 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-07-28 Thread Ard Biesheuvel
On Wed, 28 Jul 2021 at 08:41, Sami Mujawar wrote: > > Hi Liming, > > I will look into this shortly. > I submitted it here https://github.com/tianocore/edk2/pull/1823 but it triggered a CI failure that was not immediately obvious to me, and I haven't had time yet to dig into it. > >

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Digant H Solanki
Please help review this patch to make it official soon. Thanks..!! -Original Message- From: Solanki, Digant H Sent: Friday, July 23, 2021 7:25 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: RE: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to

Re: [edk2-devel] [PATCH v4 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-07-28 Thread Sami Mujawar
Hi Liming, I will look into this shortly. Regards, Sami Mujawar From: gaoliming Sent: Wednesday, 28 July 2021, 7:33 am To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; a...@kernel.org Cc: Sami Mujawar; 'Etienne Carriere'; Achin Gupta; 'Ard Biesheuvel';

回复: [edk2-devel] [PATCH v4 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-07-28 Thread gaoliming
Ard and Sami: Will you help merge this patch set for 202108 stable tag? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2021年7月20日 17:21 > 收件人: devel@edk2.groups.io; a...@kernel.org > 抄送: 'Sami Mujawar' ; 'Etienne Carriere' > ; 'Achin Gupta' ; 'Ard > Biesheuvel'

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-28 Thread Yao, Jiewen
It does not necessary to be a working area. We just need a common TEE flag to indicate if the system run in legacy, SEV, or TDX, right? thank you! Yao, Jiewen > 在 2021年7月28日,下午1:07,Xu, Min M 写道: > > On July 27, 2021 8:46 PM, Yao, Jiewen wrote: >> HI Min >> I agree with Brijesh. >> >> The

[edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

2021-07-28 Thread wenyi,xie via groups.io
Main Changes : Adding unit test for UefiSortLib. Wenyi Xie (1): MdeModulePkg/UefiSortLib:Add UefiSortLib unit test MdeModulePkg/Test/MdeModulePkgHostTest.dsc| 6 + MdeModulePkg/Library/UefiSortLib/UnitTest/UefiSortLibUnitTest.inf | 32

[edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

2021-07-28 Thread wenyi,xie via groups.io
Adding unit test for UefiSortLib. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Wenyi Xie --- MdeModulePkg/Test/MdeModulePkgHostTest.dsc| 6 + MdeModulePkg/Library/UefiSortLib/UnitTest/UefiSortLibUnitTest.inf | 32