Re: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check

2021-08-28 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/4060974 -Original Message- From: devel@edk2.groups.io On Behalf Of Benjamin Doron Sent: Saturday, August 28, 2021 12:42 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Liming Gao ; Desimone, Nathaniel L Subject: [edk2-devel]

[edk2-devel] Event: TianoCore Design Meeting - APAC/NAMO - 09/03/2021 #cal-reminder

2021-08-28 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST

Re: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check

2021-08-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Benjamin Doron Sent: Saturday, August 28, 2021 12:42 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Liming Gao ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH v1]

[edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment

2021-08-28 Thread Nate DeSimone
A comment in OpenBoardPkgPcd.dsc states that FSP dispatch mode is not supported, which is inaccurate. Cc: Sai Chaganty Cc: Heng Luo Signed-off-by: Nate DeSimone --- .../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

2021-08-28 Thread Benjamin Doron
Hi Nate, Thanks for the feedback on this patchset, I've addressed it in V2. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79919): https://edk2.groups.io/g/devel/message/79919 Mute This Topic: https://groups.io/mt/84670593/21656 Group

[edk2-devel] [edk2-platforms][PATCH v2 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

2021-08-28 Thread Benjamin Doron
Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++-

[edk2-devel] [edk2-platforms][PATCH v2 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile

2021-08-28 Thread Benjamin Doron
Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 10 ++

[edk2-devel] [edk2-platforms][PATCH v2 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

2021-08-28 Thread Benjamin Doron
Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Benjamin Doron ---

[edk2-devel] [edk2-platforms][PATCH v2 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

2021-08-28 Thread Benjamin Doron
Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++-

[edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check

2021-08-28 Thread Benjamin Doron
If CreateFvBootOption() fails, RegisterFvBootOption() will return LoadOptionNumberUnassigned, which is non-zero. Therefore, correct the check when attempting to register hotkeys, to be able to detect if UiApp is not present. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by:

[edk2-devel] [edk2-platforms] [BUG] Some Features/Intel PCDs include all the duplicate modules

2021-08-28 Thread Benjamin Doron
Hi all, As I noted in a previous patch ( https://github.com/tianocore/edk2-platforms/commit/109380a7a8667b56b5495eda4d06d2bf5f353f82 ) , there is a bug in AcpiDebugFeaturePkg where if both the DXE and SMM modules are included, two ACPI tables will be installed with colliding definitions. The

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg: remove TcgMorLockSmm driver

2021-08-28 Thread Qi Zhang
I created a new PR and pass CI. https://github.com/tianocore/edk2/pull/1924 Thanks! Qi Zhang > -Original Message- > From: Yao, Jiewen > Sent: Friday, August 27, 2021 9:44 PM > To: Zhang, Qi1 ; devel@edk2.groups.io > Cc: Wang, Jian J ; Kumar, Rahul1 > ; Ni, Ray > Subject: RE: [PATCH]