[edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Remove asm code and sharing libraries

2021-09-28 Thread Guo Dong
From: Guo Dong Remove asm code used for payload entry. Use patchable PCD instead a fixed PCD PcdPayloadStackTop to avoid potential conflict. Based on the removal, use same HobLib regardless UNIVERSAL_PAYLOAD. Use same PlatformHookLib regardless UNIVERSAL_PAYLOAD. The original PlatformHookLib

Re: [edk2-devel] [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg

2021-09-28 Thread Abner Chang
BZ #3665 is created for this. I will mention it in the cover letter. Abner From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, September 29, 2021 9:43 AM To: devel@edk2.groups.io ; Schaefer, Daniel Cc: 'Ard Biesheuvel' ; 'Leif Lindholm' ; 'Sami

[edk2-devel] [PATCH] Define FIT 4 record

2021-09-28 Thread Holland, Michael
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81265): https://edk2.groups.io/g/devel/message/81265 Mute This Topic: https://groups.io/mt/85940948/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-28 Thread Ni, Ray
Thanks everyone. We will post patches to this mailing list that aligns to this proposal. Thanks, Ray -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Wednesday, September 29, 2021 8:51 AM To: 'Brian J. Johnson' ; devel@edk2.groups.io; Ni, Ray ; 'Marvin Häuser'

Re: [edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table

2021-09-28 Thread Ni, Ray
Guo, Thank you!:) -Original Message- From: Dong, Guo Sent: Wednesday, September 29, 2021 1:20 AM To: Ni, Ray ; devel@edk2.groups.io Cc: Ma, Maurice ; You, Benjamin Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Sure. I updated the patch per

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/be67e47 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, September 28, 2021 6:03 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Benjamin Doron Subject: [edk2-devel] [edk2-platforms] [PATCH

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build

2021-09-28 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/437dd50 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, September 28, 2021 6:03 PM To: devel@edk2.groups.io Cc: Chiu, Chasel Subject: [edk2-devel] [edk2-platforms] [PATCH V1]

Re: [edk2-devel] [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg

2021-09-28 Thread Abner Chang
Oops..I should create one for this. Thanks for the reminder. Abner Get Outlook for Android From: devel@edk2.groups.io on behalf of gaoliming Sent: Wednesday, September 29, 2021 9:30:44 AM To: devel@edk2.groups.io ; Chang, Abner (HPS

回复: [edk2-devel] [PATCH V3] MdeModulePkg/BootManagerMenuApp: Limit string drawing within one line

2021-09-28 Thread gaoliming
I just merge it. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Gao, Zhichao > 发送时间: 2021年9月29日 9:32 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: Wang, Jian J ; Ni, Ray > 主题: Re: [edk2-devel] [PATCH V3] MdeModulePkg/BootManagerMenuApp: > Limit string drawing

回复: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name

2021-09-28 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 > PierreGondois > 发送时间: 2021年9月24日 19:57 > 收件人: gaoliming ; devel@edk2.groups.io; 'Bob > Feng' ; 'Sami Mujawar' > 抄送: 'Christopher Jones' > 主题: Re: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name > > Hi Liming,

Re: [edk2-devel] [PATCH V3] MdeModulePkg/BootManagerMenuApp: Limit string drawing within one line

2021-09-28 Thread Gao, Zhichao
I have created the PR at: https://github.com/tianocore/edk2/pull/2019. It shows all the checks are passed. Can you help to add your 'push' label and reopen it? Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Tuesday, September 28, 2021

回复: [edk2-devel] [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg

2021-09-28 Thread gaoliming
Abner: Is there one BZ for this change? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Abner Chang > 发送时间: 2021年9月29日 8:54 > 收件人: Schaefer, Daniel ; devel@edk2.groups.io > 抄送: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Jiewen Yao > ; Jordan Justen ; Gerd > Hoffmann ;

回复: 回复: [edk2-devel] [PATCH v3 0/2] BaseTools: Switch to downloading the ARM and AARCH64 compilers from Arm's site

2021-09-28 Thread gaoliming
Create PR https://github.com/tianocore/edk2/pull/2020. Thanks Liming > -邮件原件- > 发件人: Leif Lindholm > 发送时间: 2021年9月28日 18:49 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: 'Rebecca Cran' ; 'Bob Feng' > ; 'Yuwei Chen' ; 'Sean > Brogan' ; 'Sami Mujawar' > ; 'Ard Biesheuvel' >

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build

2021-09-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, September 29, 2021 9:03 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build > > Commit d281e9e broke the build for

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, September 29, 2021 9:03 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] > KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual

回复: [edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD

2021-09-28 Thread gaoliming
Daniel: We should try to keep single patch in one package. For this patch set, patch 3 depends on patch 2, every patch doesn't break the platform. So, I agree to keep them as the separate one. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Daniel > Schaefer > 发送时间: 2021年9月29日

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Nate DeSimone
AspireVn7Dash572G currently does not build with Visual Studio. This is due to the Visual C++ compiler generating warnings with the GCC compiler does not. The two classes of issues are unused local variables and implicit integer casts that could result in truncation. Visual C++ requires an explicit

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build

2021-09-28 Thread Nate DeSimone
Commit d281e9e broke the build for KabylakeOpenBoardPkg due to DxeMultiBoardAcpiSupportLib having a dependency on BoardAcpiTableLib that was never declared. This change adds a correct declaration of the library dependency and fixes the build. Cc: Chasel Chiu Signed-off-by: Nate DeSimone ---

Re: [edk2-devel] [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs

2021-09-28 Thread Abner Chang
> -Original Message- > From: Schaefer, Daniel > Sent: Wednesday, September 29, 2021 7:36 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Ard > Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Gerd > Hoffmann ;

Re: [edk2-devel] [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg

2021-09-28 Thread Abner Chang
> -Original Message- > From: Schaefer, Daniel > Sent: Wednesday, September 29, 2021 7:12 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Jiewen Yao > ; Jordan Justen ; Gerd > Hoffmann ; Sunil V L ; > Liming

Re: [edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD

2021-09-28 Thread Abner Chang
> -Original Message- > From: Schaefer, Daniel > Sent: Wednesday, September 29, 2021 7:11 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Ard > Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Gerd > Hoffmann ;

回复: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-28 Thread gaoliming
Johnson: I also agree this proposal to make BufferOneElement parameter mandatory. Thanks Liming > -邮件原件- > 发件人: Brian J. Johnson > 发送时间: 2021年9月29日 6:26 > 收件人: devel@edk2.groups.io; ray...@intel.com; Marvin Häuser > ; fanjianf...@byosoft.com.cn; 'gaoliming' > ; Chan, Amy ; 'Andrew >

Re: [edk2-devel] [PATCH V2 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg

2021-09-28 Thread Abner Chang
> -Original Message- > From: Schaefer, Daniel > Sent: Wednesday, September 29, 2021 7:41 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Jiewen Yao > ; Jordan Justen ; Gerd > Hoffmann ; Sunil V L > Subject:

Re: [edk2-devel] [PATCH V2 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg

2021-09-28 Thread Daniel Schaefer
Oh and this also needs to be followed up with a change to edk2-platforms. On 9/29/21 07:16, Daniel Schaefer wrote: > Please fix the issue in the maintainers file. > Looks good otherwise: > > Reviewed-By: Daniel Schaefer > > On 9/28/21 16:31, Abner Chang wrote: >> Relocate PciPcdProducerLib to

Re: [edk2-devel] [PATCH V2 3/9] ArmPkg: Use PcdPciIoTranslation PCD from MdePkg

2021-09-28 Thread Daniel Schaefer
Good so far. Reviewed-By: Daniel Schaefer But it needs an update to edk2-platforms, too. Lots of platform use this PCD. On 9/28/21 16:31, Abner Chang wrote: > PcdPciIoTranslation PCD is relocated to MdePkg and leveraged by > both ARM and RISC-V arch. This patch removes the one from ArmPkg > and

Re: [edk2-devel] [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs

2021-09-28 Thread Daniel Schaefer
Also here. I think this should be combined into patch 8. On 9/28/21 16:31, Abner Chang wrote: > PcdPciMmio32Translation and PcdPciMmio64Translation PCDs are added > to MdePkg as the common PCDs for ARM and RSIC-V archs. > > The one under ArmPkg is removed in the next patch. > > Signed-off-by:

Re: [edk2-devel] [PATCH V2 9/9] ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt

2021-09-28 Thread Daniel Schaefer
Reviewed-By: Daniel Schaefer On 9/28/21 16:31, Abner Chang wrote: > Relocate VirtioFdtDxe to OvmfPkg/Fdt, this driver is leverage by > both ARM and RISC-V archs. > > Signed-off-by: Abner Chang > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Jordan Justen

Re: [edk2-devel] [PATCH V2 5/9] ArmVirtPkg/HighMemDxe: Relocate HighMemDxe to OvmfPkg

2021-09-28 Thread Daniel Schaefer
The comments at the top of the files in HighMemDxe.{c,inf} say it's for ARM VMs. We should add RISC-V there, too. On 9/28/21 16:31, Abner Chang wrote: > Relocate HighMemDxe to OvmfPkg/Fdt, this library is leverage by > both ARM and RISC-V archs. > > Signed-off-by: Abner Chang > Cc: Ard

Re: [edk2-devel] [PATCH V2 8/9] ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt

2021-09-28 Thread Daniel Schaefer
Looks good. Just one minor typo in the comment. Reviewed-By: Daniel Schaefer On 9/28/21 16:31, Abner Chang wrote: > Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt, this library is > leverage by both ARM and RISC-V archs. Also use > PcdPciMmio32Translation and PcdPciMmio64Translation > PCDs

Re: [edk2-devel] [PATCH V2 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg

2021-09-28 Thread Daniel Schaefer
Please fix the issue in the maintainers file. Looks good otherwise: Reviewed-By: Daniel Schaefer On 9/28/21 16:31, Abner Chang wrote: > Relocate PciPcdProducerLib to OvmfPkg/Fdt, this library is > leverage by both ARM and RISC-V archs. > > Add OvmfPkg/Fdt maintainers in Maintainers.txt > >

Re: [edk2-devel] [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg

2021-09-28 Thread Daniel Schaefer
Is there CI to check that the ArmVirtPkg platforms still builds with this? I assume you haven't checked, Abner? On 9/28/21 16:30, Abner Chang wrote: > In V2: Remove HPE license on the files that just moved around or >the changes in the file are just code removal. > > This pacthes set is

Re: [edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD

2021-09-28 Thread Daniel Schaefer
I think it would make sense to combine this patch with 3/9 ArmPkg: Use PcdPciIoTranslation PCD from MdePkg It's pointless by itself. On 9/28/21 16:31, Abner Chang wrote: > This PCD is moved from ArmPkg that is used to set the base address > of PCI MMIO window that provides I/O access. We

Re: [edk2-devel] [PATCH V2 1/9] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg

2021-09-28 Thread Daniel Schaefer
Looks good. I checked and you got all instances. Reviewed-By: Daniel Schaefer On 9/28/21 16:30, Abner Chang wrote: > This is one of the series patches to restructure the location of modules under > ArmVirtPkg for RiscVVirtPkg. RiscVVirtPkg leverage FDT Client protocol to > parse FDT nodes. > >

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-28 Thread Brian J. Johnson
I'll add my agreement to Marvin and Jeff: a low-level sort routine like this should let the caller be in charge of memory allocation, so it can be used in the widest variety of contexts (SEC, exception handlers, APs, etc.) So let's make the BufferOneElement parameter mandatory. Brian J.

Re: [edk2-devel] [edk2-platforms PATCH v2 0/6] Some BeagleBoardPkg fixes

2021-09-28 Thread Rebecca Cran
I should note that this doesn't completely fix the BeagleBoardPkg: it gets further, but now fails trying to send data over I2C because the bus appears to always be busy. -- Rebecca Cran On 9/28/21 1:33 PM, Rebecca Cran wrote: Since we still have quite a lot of 32-bit ARM code in the tree,

[edk2-devel] [edk2-platforms PATCH v2 6/6] Platform/BeagleBoard: Add Readme.rst

2021-09-28 Thread Rebecca Cran
Add a Readme.rst file to explain what this package is for, link to additional information etc. Signed-off-by: Rebecca Cran --- Platform/BeagleBoard/BeagleBoardPkg/Readme.rst | 28 1 file changed, 28 insertions(+) diff --git a/Platform/BeagleBoard/BeagleBoardPkg/Readme.rst

[edk2-devel] [edk2-platforms PATCH v2 5/6] Platform/BeagleBoard: bump Fv size to 768KB to fix NOOPT build

2021-09-28 Thread Rebecca Cran
The NOOPT build currently exceeds the Fv size of 704KB. Since we're not restricted, bump it to 768KB. Signed-off-by: Rebecca Cran --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [edk2-platforms PATCH v2 3/6] BeagleBoardPkg: Align PE sections to 4K

2021-09-28 Thread Rebecca Cran
Add build options to BeagleBoardPkg.dsc to align PE sections to 4K. This avoids warnings during boot when loading drivers. Signed-off-by: Rebecca Cran --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel] [edk2-platforms PATCH v2 4/6] Omap35xxPkg: InterruptDxe: add gEfiCpuArchProtocolGuid runtime dependency

2021-09-28 Thread Rebecca Cran
InterruptDxe requires gEfiCpuArchProtocolGuid: change the Depex line for TexasInstruments/Omap35xxPkg/InterruptDxe so the driver that provides gEfiCpuArchProtocolGuid is loaded before it. Signed-off-by: Rebecca Cran --- Silicon/TexasInstruments/Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 2 +-

[edk2-devel] [edk2-platforms PATCH v2 2/6] BeagleBoardPkg: Remove PerformanceLib from build

2021-09-28 Thread Rebecca Cran
PerformanceLib is related to building the ACPI Firmware Performance Data Table (FPDT). Since BeagleBoardPkg targets 32-bit ARM systems where ACPI isn't relevant, remove it. Signed-off-by: Rebecca Cran --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 --- 1 file changed, 3

[edk2-devel] [edk2-platforms PATCH v2 1/6] BeagleBoardPkg: Remove the configuration and image headers from flash

2021-09-28 Thread Rebecca Cran
Remove the configuration and image headers from the flash image. This was likely intended for the UEFI firmware to be loaded by the ROM code, but the BeagleBoard only has 64KB SRAM and so EDK2 needs to be executed as a second stage loader. Signed-off-by: Rebecca Cran ---

[edk2-devel] [edk2-platforms PATCH v2 0/6] Some BeagleBoardPkg fixes

2021-09-28 Thread Rebecca Cran
Since we still have quite a lot of 32-bit ARM code in the tree, it would be nice to have a physical platform to verify that it still works correctly. I recently got one of the original BeagleBoard boards and have been working to get EDK2 booting on it again. These patches let it get further,

Re: [edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table

2021-09-28 Thread Guo Dong
Sure. I updated the patch per comments. Thanks, Guo -Original Message- From: Ni, Ray Sent: Monday, September 27, 2021 7:11 PM To: Dong, Guo ; devel@edk2.groups.io Cc: Ma, Maurice ; You, Benjamin Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI

[edk2-devel] [`edk2-devel][PATCH V2] UefiPayloadPkg: Build a HOB from bootloader ACPI table

2021-09-28 Thread Guo Dong
From: Guo Dong V2: Update BuildHobFromAcpi() to return a HOB pointer. For universal UEFI payload, build a HOB from the ACPI table, so that other modules could use this info from HOB at very early DXE phase. This code are shared by universal payload and non universal payload. Cc: Ray Ni Cc:

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-28 Thread Brijesh Singh via groups.io
[AMD Official Use Only] May I ask to use the OvmfMetadata instead of the of TdxMetadata for the Guided structure name label (same as what I did in SNP series patch #4). If you can send the metadata introduction as a patch separately then add the TDX descriptor in TDX series. I can try to make

Re: [edk2-devel] [PATCH V2 6/9] ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg

2021-09-28 Thread Gerd Hoffmann
Hi, > -# VALID_ARCHITECTURES = ARM AARCH64 > +# VALID_ARCHITECTURES = ARM AARCH64 RISCV64 > -#ifdef MDE_CPU_AARCH64 > +#if defined(MDE_CPU_AARCH64) || defined(MDE_CPU_RISCV64) That isn't just relocation. Please split into two patches: One moving around the file

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-09-28 Thread Leif Lindholm
On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote: > I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for > AARCH64 systems. I've attached two patches to implement support for it > in the DXE phase, based on code in EmulatorPkg and UefiCpuPkg. It's added > under ArmPkg for now,

Re: 回复: [edk2-devel] [PATCH v3 0/2] BaseTools: Switch to downloading the ARM and AARCH64 compilers from Arm's site

2021-09-28 Thread Leif Lindholm
Could one of the BaseTools maintainers merge this set? On Fri, Sep 24, 2021 at 08:44:42 +0800, gaoliming wrote: > Leif: > I gave my Acked-by for this patch set V2. I think it can be merged now. > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > > 发送时间:

Re: [edk2-devel] [PATCH v3 12/28] AmpereAltraPkg: Add Ac01PcieLib library instance

2021-09-28 Thread Leif Lindholm
Apart from the request to break out Ac01PcieConfigRW and Ac01PcieCfgIn/Out# I noticed a further thing. On Wed, Sep 15, 2021 at 22:55:11 +0700, Nhi Pham wrote: > +/** > + Get RootBridge disable status. > + > + @param[in] HBIndex Index to identify of PCIE Host bridge. > +

Re: [edk2-devel] [PATCH v3 15/28] Ampere: PCIe: Add PciSegmentLib library instance

2021-09-28 Thread Leif Lindholm
+Liming, Zhiguang On Fri, Sep 24, 2021 at 15:16:05 +0200, Ard Biesheuvel wrote: > On Wed, 15 Sept 2021 at 18:00, Nhi Pham wrote: > > > > From: Vu Nguyen > > > > Provides wrapper calls to the Ac01PcieLib to handle the PCIe access. > > As Ampere Altra processor supports upto 16 PCIe Root

[edk2-devel] [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs

2021-09-28 Thread Abner Chang
PcdPciMmio32Translation and PcdPciMmio64Translation PCDs are added to MdePkg as the common PCDs for ARM and RSIC-V archs. The one under ArmPkg is removed in the next patch. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2-devel] [PATCH V2 9/9] ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt

2021-09-28 Thread Abner Chang
Relocate VirtioFdtDxe to OvmfPkg/Fdt, this driver is leverage by both ARM and RISC-V archs. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel Schaefer Cc: Sunil V L ---

[edk2-devel] [PATCH V2 5/9] ArmVirtPkg/HighMemDxe: Relocate HighMemDxe to OvmfPkg

2021-09-28 Thread Abner Chang
Relocate HighMemDxe to OvmfPkg/Fdt, this library is leverage by both ARM and RISC-V archs. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel Schaefer Cc: Sunil V L ---

[edk2-devel] [PATCH V2 8/9] ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt

2021-09-28 Thread Abner Chang
Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt, this library is leverage by both ARM and RISC-V archs. Also use PcdPciMmio32Translation and PcdPciMmio64Translation PCDs provided by MdePkg instead of ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD

2021-09-28 Thread Abner Chang
This PCD is moved from ArmPkg that is used to set the base address of PCI MMIO window that provides I/O access. We relocate this PCD because this PCD is common to ARM and RSIC-V arch. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg

2021-09-28 Thread Abner Chang
In V2: Remove HPE license on the files that just moved around or the changes in the file are just code removal. This pacthes set is to migrate some modules from ArmVirtPkg to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage those modules without the dependency with Arm*Pkg.

[edk2-devel] [PATCH V2 3/9] ArmPkg: Use PcdPciIoTranslation PCD from MdePkg

2021-09-28 Thread Abner Chang
PcdPciIoTranslation PCD is relocated to MdePkg and leveraged by both ARM and RISC-V arch. This patch removes the one from ArmPkg and address the corresponding changes required for other modules under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar

[edk2-devel] [PATCH V2 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg

2021-09-28 Thread Abner Chang
Relocate PciPcdProducerLib to OvmfPkg/Fdt, this library is leverage by both ARM and RISC-V archs. Add OvmfPkg/Fdt maintainers in Maintainers.txt Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel

[edk2-devel] [PATCH V2 6/9] ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg

2021-09-28 Thread Abner Chang
Relocate QemuFwCfgLib to OvmfPkg/Library/QemuFwCfgLib and rename it to QemuFwCfgLibMMIO, this library is leverage by both ARM and RISC-V archs. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel

[edk2-devel] [PATCH V2 1/9] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg

2021-09-28 Thread Abner Chang
This is one of the series patches to restructure the location of modules under ArmVirtPkg for RiscVVirtPkg. RiscVVirtPkg leverage FDT Client protocol to parse FDT nodes. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Cc: Daniel Schaefer

Re: [edk2-devel] [PATCH 07/23] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-09-28 Thread Min Xu
On September 11, 2021 9:16 AM, Erdem Aktas wrote: > > On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote: > > +UINT8 > > +EFIAPI > > +TdMmioRead8 ( > > + IN UINTN Address > > + ) > > +{ > > + UINT64 Value; > > + UINT64

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-28 Thread Min Xu
On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patch in the next version. > > Can you also add a comment block documenting the format? Not only those > parts