If an EFI application frequently repeats SetTime and GetTime,
the I2C bus can be busy and failed to start. To fix this issue,
add waiting loop for the bus busy status. (Usually, it is
enough to read 3 times for checking, but for safety this
sets 10 for timeout.)
This also clean up the code path a
For OvmfPkg change, Acked-by: Jiewen Yao
Need ARM/RISC-V expert to give Reviewed-by.
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abner
> Chang
> Sent: Thursday, September 30, 2021 8:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif
Thanks Liming for the review.
Help push the patches if no other feedback is received.
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent: 2021年9月28日 13:31
To: devel@edk2.groups.io; Zeng, Star
Subject: 回复: [edk2-devel] [PATCH V2 0/2] Add
Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt, this library is
leverage by both ARM and RISC-V archs. Also use
PcdPciMmio32Translation and PcdPciMmio64Translation
PCDs provided by MdePkg instead of ArmPkg.
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc:
PcdPciMmio32Translation and PcdPciMmio64Translation PCDs are added
to MdePkg as the common PCDs for ARM and RSIC-V archs.
The one under ArmPkg is removed in the next patch.
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Abner Chang
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Cc: Sunil V L
Reviewed-by: Daniel Schaefer
---
OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Relocate VirtioFdtDxe to OvmfPkg/Fdt, this driver is leverage by
both ARM and RISC-V archs.
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Cc: Sunil V L
Reviewed-by: Daniel Schaefer
In V3: Address comments on V2.
In V2: Remove HPE license on the files that just moved around or
the changes in the file are just code removal.
edk2 BZ #: 3665
edk2 platform corresponding changes will be submitted after
this pactch set is reviewed.
This pacthes set is to migrate some
This PCD is moved from ArmPkg that is used to set the base address
of PCI MMIO window that provides I/O access. We relocate this PCD
because this PCD is common to ARM and RSIC-V arch.
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Ard Biesheuvel
Cc: Leif
Relocate PciPcdProducerLib to OvmfPkg/Fdt, this library is
leverage by both ARM and RISC-V archs.
Add OvmfPkg/Fdt maintainers in Maintainers.txt
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Cc: Sunil V L
---
OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 2 +-
OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 7 ---
2 files changed, 5 insertions(+),
Relocate HighMemDxe to OvmfPkg/Fdt, this library is leverage by
both ARM and RISC-V archs.
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Cc: Sunil V L
---
Relocate QemuFwCfgLib to OvmfPkg/Library/QemuFwCfgLib and rename
it to QemuFwCfgLibMmio, this library is leverage by both ARM and
RISC-V archs.
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel
PcdPciIoTranslation PCD is relocated to MdePkg and leveraged by
both ARM and RISC-V arch. This patch removes the one from ArmPkg
and address the corresponding changes required for other modules
under ArmVirtPkg.
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
This is one of the series patches to restructure the location of modules under
ArmVirtPkg for RiscVVirtPkg. RiscVVirtPkg leverage FDT Client protocol to
parse FDT nodes.
Signed-off-by: Abner Chang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Add RISC-V VM in the file header.
Add RISC-V to the supported arch.
Signed-off-by: Abner Chang
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Cc: Sunil V L
---
OvmfPkg/Fdt/HighMemDxe/HighMemDxe.inf | 3 ++-
OvmfPkg/Fdt/HighMemDxe/HighMemDxe.c | 3 ++-
2 files changed, 4
Dun:
I understand this test is to make sure Edk2 change doesn't break
WhiskeylakeOpenBoard build. It is still for edk2 change.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 duntan
> 发送时间: 2021年9月30日 9:15
> 收件人: Ni, Ray ; devel@edk2.groups.io
> 抄送: Sean Brogan ; Bret Barkelew
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Guo
> Sent: Sunday, September 26, 2021 7:05 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Ma, Maurice ; You,
> Benjamin ; Dong, Guo
>
> Subject: [`edk2-devel][PATCH 0/8] Add SMM variable support for UEFI payload
>
> From: Guo
Yes. Merged.
499c4608b13df0738213329722cdcb0ac838f3ad..
bd298d75934a7a0cf6b9e2863a5e4975e9714285
> -Original Message-
> From: Stefan Berger
> Sent: Thursday, September 30, 2021 3:15 AM
> To: devel@edk2.groups.io; Yao, Jiewen
> Cc: mhaeu...@posteo.de; spbro...@outlook.com;
>
Hi ChengChieh,
You could directly build from this branch for the test.
https://github.com/gdong1/edk2/pull/new/for_linux_bootloader_test
Thanks,
Guo
-Original Message-
From: Dong, Guo
Sent: Wednesday, September 29, 2021 12:02 PM
To: devel@edk2.groups.io; chengch...@google.com
Cc: Ni,
On 9/14/21 6:26 PM, Yao, Jiewen wrote:
Reviewed-by: Jiewen Yao
I will wait for a week, to see if there is any feedback from AMD or Bhyve
reviewer.
I didn't see any more comments to v3
(https://listman.redhat.com/archives/edk2-devel-archive/2021-September/msg00641.html)
So maybe you can
Hi Ray,
I had updated the patch to update the commit message and fix some coding style.
Please help review V4 patch.
Thanks,
Guo
-Original Message-
From: Ni, Ray
Sent: Tuesday, August 24, 2021 5:35 PM
To: Cheng-Chieh Huang ; devel@edk2.groups.io
Cc: Schaefer, Daniel ; Trammell Hudson
From: Cheng-Chieh Huang
V4: Update commit message and coding style.
Used Linux kernel as a bootloader to boot linux.
To boot windows, UEFI service is required for the bootloader.
So update UEFI payload to support Linux bootloader in order to
boot UEFI OS.
Linux bootloader will provide platfrom
Hi ChengChieh,
Here is the update to this patch series:
1. UefiPayloadPkg: Add LINUXBOOT payload target
a) Ray asked to update commit message
b) There are still some coding style issues
I know it is a little difficult to fully follow EDKII coding style. I will
help update
Hi again,
Replies inline,
>
> Hi Joey,
> Thanks for the review, I answered inline:
>
>
> On 9/24/21 9:56 AM, Joey Gouly wrote:
> > Hi,
> >
> > This looks good to me!
> >
> > [...]
> >
> >> +
> >> +/** A parser for EArmObjFixedFeatureFlags.
> >> +*/
> >> +STATIC CONST CM_OBJ_PARSER
Hi,
Can you help to explain more why PeiAllocatePages does not have the problem
while PeiAllocatePool has?
Thanks,
Eric
-Original Message-
From: Lou, Yun
Sent: Wednesday, September 29, 2021 7:53 PM
To: devel@edk2.groups.io
Cc: Lou, Yun ; Ni, Ray ; Dong, Eric
; Laszlo Ersek ; Kumar,
Is this a patch to enable CI in edk2-platforms?
Package maintainers can directly check in changes to edk2-platforms. Then how
the CI is triggered?
Will the CI run because of a edk2 pull request?
Thanks,
Ray
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, September 29, 2021
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Guo
> Sent: Wednesday, September 29, 2021 1:19 AM
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
> ; You, Benjamin
>
> Subject: [`edk2-devel][PATCH V2] UefiPayloadPkg: Build a HOB from bootloader
> ACPI table
Thanks for providing a very clear commit message.
Reviewed-by: Ray Ni
> -Original Message-
> From: Lou, Yun
> Sent: Wednesday, September 29, 2021 7:53 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun ; Ni, Ray ; Dong, Eric
> ; Laszlo Ersek
> ; Kumar, Rahul1
> Subject: [PATCH v1]
Right. QemuFwCfgLibMmio - per my understanding.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abner
> Chang
> Sent: Wednesday, September 29, 2021 8:47 PM
> To: devel@edk2.groups.io; Yao, Jiewen ;
> sami.muja...@arm.com
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Justen,
Hi Jiewen,
It should be QemuFwCfgLibMmio instead of QemuFwCfgLibMMIO, right?
Abner
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Yao, Jiewen
> Sent: Wednesday, September 29, 2021 8:26 PM
> To: devel@edk2.groups.io; sami.muja...@arm.com
>
Thank you Sami.
We have a clear naming rule for EDKII project during development.
But I don’t know where it is documented. Maybe a good addition to the doc you
point out.
To summarize what I know:
1) Library name: []Lib[]
2) Driver Name:
For the example you point out, I see no problem,
Create a PR https://github.com/tianocore/edk2/pull/2030
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Wednesday, September 29, 2021 7:44 PM
To: pierre.gond...@arm.com; devel@edk2.groups.io; Liming Gao
; Sami Mujawar
Subject: Re: [edk2-devel] [PATCH v1 0/4]
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3634
The memory allocated through "PeiAllocatePool" is located in HOB, and
in DXE phase, the HOB will be migrated to a different location.
After the migration, the data stored in the HOB stays the same, but the
address of pointer to the
Reviewed-by: Bob Feng
-Original Message-
From: pierre.gond...@arm.com
Sent: Thursday, September 23, 2021 4:59 PM
To: devel@edk2.groups.io; Feng, Bob C ; Liming Gao
; Sami Mujawar
Subject: [PATCH v1 0/4] Set default Makefile name
From: Pierre Gondois
A Makefile name is not set in
Hi Jiewen,
Thank you for clarifying the library naming convention.
I could not find any references/examples as such in
https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/v/release%2F2.20/4_naming_conventions/42_file_names
and therefore had suggested following the file naming
PR 2020 failed because it has an additional commit "Merge branch 'master' into
BaseTools_Arm"
Create a new PR https://github.com/tianocore/edk2/pull/2029
-Original Message-
From: gaoliming
Sent: Wednesday, September 29, 2021 9:19 AM
To: 'Leif Lindholm' ; devel@edk2.groups.io
Cc:
Acked-by: Bob Feng
Sorry for the late response.
-Original Message-
From: Rebecca Cran
Sent: Monday, August 30, 2021 1:15 PM
To: Feng, Bob C ; Liming Gao ;
Chen, Christine ; Sean Brogan
; Sami Mujawar ; Leif Lindholm
; Ard Biesheuvel
Cc: Rebecca Cran ; devel@edk2.groups.io
Subject:
hi
I think the original name is correct.
The naming convention is : Lib
thank you!
Yao, Jiewen
> 在 2021年9月29日，下午5:45，Sami Mujawar 写道：
>
> Hi Abner,
>
> Thank you for this patch.
>
> I have a minor suggestion marked inline as [SAMI].
>
> Regards,
>
> Sami Mujawar
>
>
>> On 28/09/2021
Hi Abner,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Regards,
Sami Mujawar
On 28/09/2021 09:31 AM, Abner Chang wrote:
Relocate QemuFwCfgLib to OvmfPkg/Library/QemuFwCfgLib and rename
it to QemuFwCfgLibMMIO, this library is leverage by both ARM and
RISC-V
Currently the realpath is used when parse modules, which shows the
path with a drive letter in build log. In Windows 'subst' comand is
used to associates a path with a drive letter, when use the mapped
drive letter for build, with realpath function the build log will
have different disk letter
Hi,
Looks good to me...
Reviewed-by: Grzegorz Bernacki
pon., 27 wrz 2021 o 09:48 Nhi Pham via groups.io
napisał(a):
>
> The dbt and dbx keys are optional, the driver entry should return
> EFI_SUCCESS to start if they are not found in the firmware flash. This
> patch is to fix it and update the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3666
Currently, CoreLocateHandleBuffer() follows three steps:
1) get the size of protocol database firstly
2) allocate the buffer based on the size
3) get the protocol database into the buffer
There is no lock protection for the whole three
Hi all,
Since I don't have the administrator access of Tiano edk2 CI, I can't create a
new pipeline based on my .yml file to test my script. So I have to copy the
content in edk2-platforms.yml to Windows-VS2019.yml and change file in the
included path in .yml file to trigger the PR CI and
The edk2-platforms.yml contains the necessary github repo that will be
checked out, the platform name to build and the folders in edk2 which
will trigger the CI. The edk2platforms-run-steps.yml contains the main
steps to build WhiskeylakeOpenBoard.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael
45 matches
Mail list logo
