Yikes - that's embarrassing. Thanks for the fix.
Reviewed-by: Andrei Warkentin
From: Jeremy Linton
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io
Cc: p...@akeo.ie ; ardb+tianoc...@kernel.org
; l...@nuviainc.com ; Andrei
Warkentin ; sunny.w...@a
Seems smart to do.
Reviewed-by: Andrei Warkentin
From: Jeremy Linton
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io
Cc: p...@akeo.ie ; ardb+tianoc...@kernel.org
; l...@nuviainc.com ; Andrei
Warkentin ; sunny.w...@arm.com ;
samer.el-haj-mahm...
I may have misunderstood the flags as being valid ways of mapping the added
range. Should we also then take out WC and WT?
From: Jeremy Linton
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io
Cc: p...@akeo.ie ; ardb+tianoc...@kernel.org
; l...@nuvi
Pushed: https://github.com/tianocore/edk2-platforms/commit/bbb431a
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Friday, September 24, 2021 11:23 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric ; Maddy,
> Daniel ;
Reviewed-by: Andrei Warkentin
From: Jeremy Linton
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io
Cc: p...@akeo.ie ; ardb+tianoc...@kernel.org
; l...@nuviainc.com ; Andrei
Warkentin ; sunny.w...@arm.com ;
samer.el-haj-mahm...@arm.com ; Jeremy Li
Reviewed-by: Nate DeSimone
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Friday, September 24, 2021 11:23 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric ; Maddy,
> Daniel ; Michael Kubacki
>
> Subject: [edk2-pla
Reviewed-by: Andrei Warkentin
From: Jeremy Linton
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io
Cc: p...@akeo.ie ; ardb+tianoc...@kernel.org
; l...@nuviainc.com ; Andrei
Warkentin ; sunny.w...@arm.com ;
samer.el-haj-mahm...@arm.com ; Jeremy Li
In theory we should be properly cleaning up all the device drivers before
pulling the big switch. Particularly the partition mgr will issue
flush commands to attached disks as it goes down. This assures that
devices running in WB mode (that correctly handle flush/sync/etc) commands
are persisted to
The efi spec seems to indicate that the efi uncacheable attribute
should be mapped to device memory rather than normal-nc. This means
that the uefi mem attribute for the >3G ram doesn't match the remainder
of the RAM in the machine.
So, lets remove the uncacheable attribute to make it more consist
During review/merge of the linux ecam quirk, some logic
was added to require the quirk name to be exactly 6
characters, matching the MADT field its overriding.
As such, the rpi quirk here needed to be shorted by
a character to avoid confusion.
Signed-off-by: Jeremy Linton
---
Platform/Raspberry
The build has been tossing a warning about having two defaults
for a while now, lets fix it.
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigD
While debugging problems with the GET/SET_CLOCK mailbox calls it appeared
that the locking in most of the mailbox commands isn't perfectly
correct. All UEFI firmware calls to the RPi mailbox share a single
mDmaBuffer which is used to fill out the command passed to the vc firmware,
and record its re
This set is a few patches I've been collecting to fix minor issues I've seen
while debugging other problems, or just various things I think should probably
be changed. Generally I don't think they fix anything that is currently user
visible, although its quite possible some mysterious failures go a
One of the many issues with the PCIe on this platform is
its inbound DMA is either constrained to the lower 3G, or
on later SoC's a translation can be used. That translation
was problematic with some of the OS's expected to boot
on this platform. So, across the board a 3G DMA limit is
enforced duri
Some rpi4's haven't booted cleanly using DT for a few months. The primarly
problem is that the XHCI_NOTIFY_RESET mailbox call doesn't seem to be able
to correctly read the pcie translation state after we have set it up. So,
while linux appears to be able to adjust the PCIe subsystem to the demands
Hi Chasel,
My only feedback is let's not add the EDK1 style GUID definition to
FspNonVolatileStorageHob2.h. It is redundant with the EDK2 style definition.
Please see inline.
With that change...
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, Oct
Hi Sami,
>
> The EFI_RNG_PROTOCOL published by RngDxe has been updated to
> implement the EFI_RNG_ALGORITHM_RAW using the Arm FW-TRNG
> interface to provide access to entropy.
>
> Therefore, enable EFI_RNG_PROTOCOL for the Kvmtool guest/virtual
> firmware.
>
> Signed-off-by: Sami Mujawar
> ---
>
Hi Sami,
> TF-A for Juno has been updated to implement the Arm FW-TRNG interface
> that can be used to access entropy from the TRNG hardware on Juno.
>
> Similarly, the EFI_RNG_PROTOCOL in RngDxe has been updated to add
> EFI_RNG_ALGORITHM_RAW support using the FW-TRNG interface.
>
> Therefore, en
Hi Pierre,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlAddLpiState() to generates AML code to add an _LPI state
to an _LPI object created using AmlCreateLpiNode().
AmlAddLpiState incre
Hi Pierre,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
_LPI object provides a method to describe Low Power Idle
states that define the local power states for each node
in a hierarchical proce
Hi Pierre,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenMethodRetNameString() to generate AML code to create
a Method returning a NameString (NS).
AmlCodeGenMethodRetNameString
Hi Pierre,
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenReturnNameString() to generate AML code for a
Return object node, returning the object as a NameString.
AmlCodeGenReturn
Hi Pierre,
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenMethod() to generate code for a control method.
Hi Pierre,
Thank you for this patch. This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Remove the STATIC qualifier for the AmlUtility function
AmlNodeGetIntegerValue() and add the definit
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
ASL provides a ResourceTemplate macro that creates a Buffer in which
resource descriptor macros can be listed. The ResourceTempl
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Some AML object have a PkgLen which indicates the size of the
AML object. The package length can be encoded in 1 to 4 bytes.
Hi Pierre,
Thank you for this patch. This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenPackage() to generate AML code for declaring
a Package() object. This function genera
Hi Pierre,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add a helper function AmlCodeGenEndTag() to generate AML Resource Data
EndTag. The EndTag resource data is au
Hi Pierre,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenRegister() to generate AML code for the
Ge
Merged as 422e5d2f7f1a..22873f58c40c
Regards,
Sami Mujawar
On 30/09/2021 08:48 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch-set aggregates various modifications in the
DynamicTablesPkg:
- Extract an AcpiTableHelperLib from TableHelperLib to remove
the dependency o
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3674
Add ExtendedImageRevision in FSP_INFO_HEADER structure, also add
FSP_NON_VOLATILE_STORAGE_HOB2 header.
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Include/Guid/FspHeaderFile.h |
31 matches
Mail list logo
