[edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TDX guest supports LocalApicTimer. But in current OvmfPkg the supported timer is 8254TimerDxe. So gUefiOvmfPkgTokenSpaceGuid.PcdTimerSelector is introduced to select the running Timer. The Timer driver will check the TimerSelector in its

[edk2-devel] [PATCH V2 27/28] OvmfPkg: Update IoMmuDxe to support TDX

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 The IOMMU protocol driver provides capabilities to set a DMA access attribute and methods to allocate, free, map and unmap the DMA memory for the PCI Bus devices. The current IoMmuDxe driver supports DMA operations inside SEV guest. To

[edk2-devel] [PATCH V2 26/28] OvmfPkg/QemuFwCfgLib: Support Tdx in QemuFwCfgDxe

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In the previous QemuFwCfgDxe only SEV is supported. This commit introduce TDX support in QemuFwCfgDxe. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky

[edk2-devel] [PATCH V2 25/28] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Add Intel TDXhelper library. The library provides the routines to: - set or clear Shared bit for a given memory region. - query whether TDX is enabled. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James

[edk2-devel] [PATCH V2 23/28] OvmfPkg: Update AcpiPlatformDxe to alter MADT table

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDX the guest firmware is designed to publish a multiprocessor-wakeup structure to let the guest-bootstrap processor wake up guest-application processors with a mailbox. The mailbox is memory that the guest firmware can reserve so each

[edk2-devel] [PATCH V2 21/28] OvmfPkg: Update PlatformPei to support TDX

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel TDX has its own requirement in InitializePlatform (PlatformPei). 1. Publish the ram region Host VMM pass the memory region to TDVF in TD Hob. These memory are accepted by TDVF before they're available for access. TDVF publish

[edk2-devel] [PATCH V2 24/28] OvmfPkg: Add TdxDxe driver

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TdxDxe driver is dispatched early in DXE, due to being list in APRIORI. This module is responsible for below features: - Sets max logical cpus based on TDINFO - Sets PCI PCDs based on resource hobs Besides above features, TdxDxe driver

[edk2-devel] [PATCH V2 20/28] MdeModulePkg: EFER should not be changed in TDX

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDX IA32_ERER is RO to host VMM. It could not be changed. PcdIa32EferChangeAllowed is added in MdeModulePkg.dec and it is to be set to FALSE in Tdx guest. Cc: Jian J Wang Cc: Hao A Wu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James

[edk2-devel] [PATCH V2 22/28] UefiCpuPkg: Define ConfidentialComputingGuestAttr (Temp)

2021-10-04 Thread Min Xu
Add a new ConfidentialComputingGuestAttr PCD that can be used to query the memory encryption attribute. (This is AMD's patch) Signed-off-by: Brijesh Singh --- OvmfPkg/PlatformPei/IntelTdx.c| 8 ++ OvmfPkg/PlatformPei/PlatformPei.inf | 2 +-

[edk2-devel] [PATCH V2 19/28] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 If TDX is enabled then we do not support DMA operation in PEI phase. This is mainly because DMA in TDX guest requires using bounce buffer (which need to allocate dynamic memory and allocating a PAGE size'd buffer can be challenge in PEI

[edk2-devel] [PATCH V2 18/28] OvmfPkg: Enable Tdx in SecMain.c

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 When host VMM create the Td guest, the system memory informations are stored in TdHob, which is a memory region described in Tdx metadata. The system memory region in TdHob should be accepted before it can be accessed. So the major task of

[edk2-devel] [PATCH V2 17/28] MdePkg: Add EFI_RESOURCE_ATTRIBUTE_ENCRYPTED in PiHob.h

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 EFI_RESOURCE_ATTRIBUTE_ENCRYPTED is Physical memory encrypted attribute. It indicates the memory uses platform encrpytion capabilities for protection. If this bit is clear, the memory does not use platform encryption protection. Cc: Ard

[edk2-devel] [PATCH V2 16/28] OvmfPkg: Add TdxMailboxLib

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In Tdx BSP may issues commands to APs for some task, for example, to accept pages paralelly. BSP also need to wait until all the APs have done the task. TdxMailboxLib wraps these common funtions for BSP. Cc: Ard Biesheuvel Cc: Jordan

[edk2-devel] [PATCH V2 15/28] OvmfPkg: Add IntelTdx.h in OvmfPkg/Include/IndustryStandard

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 IntelTdx.h defines the defitions used by TDX in OvmfPkg: - Mailbox related defitions,such as the data structure, command code, AP relocation defitions. - EFI_HOB_PLATFORM_INFO describes the TDX platform information Cc: Ard Biesheuvel

[edk2-devel] [PATCH V2 14/28] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDX BSP and APs goes to the same entry point in SecEntry.nasm. BSP initialize the temporary stack and then jumps to SecMain, just as legacy Ovmf does. APs spin in a modified mailbox loop using initial mailbox structure. Its structure

[edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others are treated as APs. So MP intialization is rather simple. The processor info is retrieved by TDCALL, ApWorker is not supported, BSP is always the working processor,

[edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Add base support to handle #VE exceptions. Update the common exception handlers to invoke the VmTdExitHandleVe () function of the VmTdExitLib library when a #VE is encountered. A non-zero return code will propagate to the targeted exception

[edk2-devel] [PATCH V2 11/28] OvmfPkg: Implement library support for VmTdExitLib in Ovmf

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 The base VmTdExitLib library provides a default limited interface. As it does not provide full support, create an OVMF version of this library to begin the process of providing full support of TDX within OVMF. PcdIgnoreVeHalt is created in

[edk2-devel] [PATCH V2 10/28] OvmfPkg: Prepare OvmfPkg to use the VmTdExitLib library

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Various CpuExceptionHandlerLib libraries will updated to use the new VmTdExitLib library. To prevent any build breakage, update the OvmfPkg DSC files that use a form of the CpuExceptionHandlerLib library to include the VmTdExitLib library.

[edk2-devel] [PATCH V2 09/28] UefiPayloadPkg: Prepare UefiPayloadPkg to use the VmTdExitLib library

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Various CpuExceptionHandlerLib libraries will updated to use the new VmTdExitLib library. To prevent any build breakage, update the UefiPayloadPkg.dsc that use a form of the CpuExceptionHandlerLib library to include the VmTdExitLib library.

[edk2-devel] [PATCH V2 08/28] UefiCpuPkg: Add VmTdExitLibNull

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 VmTdExitLib performs the necessary processing to handle a #VE exception. VmTdExitLibNull is a NULL instance of VmTdExitLib which provides a default limited interface. A full feature version of VmTdExitLib should be created later (for

[edk2-devel] [PATCH V2 07/28] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed directly from/to CPU. Some should be accessed via explicit requests from the host VMM using TDCALL(TDG.VP.VMCALL). This is done by the help of TdxLib. Cc: Eric Dong Cc:

[edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel TDX architecture does not prescribe a specific software convention to perform I/O from the guest TD. Guest TD providers have many choices to provide I/O to the guest. The common I/O models are emulated devices, para-virtualized

[edk2-devel] [PATCH V2 05/28] MdePkg: Add TdxLib to wrap Tdx operations

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TdxLib is created with functions to perform the related Tdx operation. This includes functions for: - TdCall : Cause a VM exit to the Intel TDX module. - TdVmCall: It helps invoke services from the host VMM to pass/

[edk2-devel] [PATCH V2 04/28] MdePkg: Add Tdx.h

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx.h includes the Intel Trust Domain Extension definitions. Detailed information can be found in below document: https://software.intel.com/content/dam/develop/external/us/en/ documents/tdx-module-1eas-v0.85.039.pdf Cc: Michael D Kinney

[edk2-devel] [PATCH V2 00/28] Enable Intel TDX in OvmfPkg (Config-A)

2021-10-04 Thread Min Xu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3249 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A

[edk2-devel] [PATCH V2 03/28] OvmfPkg: Merge TEMP_MEM entries in Tdx metadata

2021-10-04 Thread Min Xu
Signed-off-by: Min Xu --- OvmfPkg/ResetVector/ResetVector.nasmb| 13 - OvmfPkg/ResetVector/X64/IntelTdxMetadata.asm | 28 +--- 2 files changed, 11 insertions(+), 30 deletions(-) diff --git a/OvmfPkg/ResetVector/ResetVector.nasmb

[edk2-devel] [PATCH V2 02/28] OvmfPkg: Enable TDX in ResetVector

2021-10-04 Thread Min Xu
Signed-off-by: Min Xu --- OvmfPkg/OvmfPkg.dec | 9 + OvmfPkg/OvmfPkgDefines.fdf.inc | 9 + OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm | 39 +++ OvmfPkg/ResetVector/Ia32/Flat32ToFlat64.asm | 11 + OvmfPkg/ResetVector/Ia32/IntelTdx.asm| 235

[edk2-devel] [PATCH V2 01/28] OvmfPkg: Copy Main.asm from UefiCpuPkg to OvmfPkg's ResetVector

2021-10-04 Thread Min Xu
Signed-off-by: Min Xu --- OvmfPkg/ResetVector/Main.asm | 103 +++ 1 file changed, 103 insertions(+) create mode 100644 OvmfPkg/ResetVector/Main.asm diff --git a/OvmfPkg/ResetVector/Main.asm b/OvmfPkg/ResetVector/Main.asm new file mode 100644 index

Re: [edk2-devel] [PATCH 1/1] ArmPkg: SmbiosMiscDxe: Don't populate ExtendedBiosSize when size < 16MB

2021-10-04 Thread Nhi Pham via groups.io
Thanks, Rebecca for the patch. Acked-by: Nhi Pham Best regards, Nhi On 05/10/2021 01:00, Sami Mujawar wrote: Hi Rebecca, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 04/10/2021 05:22 PM, Rebecca Cran wrote: According to

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, October 5, 2021 #cal-cancelled

2021-10-04 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/5] U540, U500: Add initrd command to boot Linux

2021-10-04 Thread Sunil V L
On Mon, Oct 04, 2021 at 07:28:27PM +0800, Daniel Schaefer wrote: > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 > ++- >

Re: [edk2-devel] [PATCH v1 4/5] U540: BuildCpuHob with 48 to indicate size memory space

2021-10-04 Thread Sunil V L
On Mon, Oct 04, 2021 at 01:23:58AM +0800, Daniel Schaefer wrote: > Otherwise it will crash on QEMU 6.0 with: > > > Loading driver at 0x000BF814000 EntryPoint=0x000BF81428A > > PciHostBridgeDxe.efi > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF BF351F98 > >

Re: [edk2-devel] [PATCH v1 5/5] Signal EndOfDxe in boot manager

2021-10-04 Thread Sunil V L
On Mon, Oct 04, 2021 at 01:23:59AM +0800, Daniel Schaefer wrote: > Otherwise we can't load a 3rd party image because we're still in DXE. > MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.c prevents > that. > > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > >

Re: [edk2-devel] [PATCH v1 2/5] RISC-V/CpuDxe: Ignore set memory attributes failure

2021-10-04 Thread Sunil V L
On Mon, Oct 04, 2021 at 01:23:56AM +0800, Daniel Schaefer wrote: > While enumerating the PCIe devices, the driver tries to set some caching > attributes on the memory. > > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer > --- >

Re: [edk2-devel] [PATCH v1 3/5] U540, U500: Add initrd command to boot Linux

2021-10-04 Thread Sunil V L
On Mon, Oct 04, 2021 at 01:23:57AM +0800, Daniel Schaefer wrote: > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 > +++ >

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

2021-10-04 Thread Sunil V L
The patch set for edk2 looks fine to me. Reviewed-by: Sunil V L Thanks Sunil On Thu, Sep 30, 2021 at 08:45:36AM +0800, Abner Chang wrote: > In V3: Address comments on V2. > In V2: Remove HPE license on the files that just moved around or >the changes in the file are just code removal.

Re: [edk2-devel] [PATCH v1 1/5] U540, U500: Add filesystem drivers

2021-10-04 Thread Sunil V L
Looks good to me. Reviewed-by: Sunil V L Thanks Sunil On Mon, Oct 04, 2021 at 01:23:55AM +0800, Daniel Schaefer wrote: > Not DiskIoDxe because we don't have a disk, just for loading from > Ramdisks. > > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer

Re: [edk2-devel] [PATCH v4 0/3] ArmVirtPkg: Disable the TPM 2 platform hierarchy

2021-10-04 Thread Stefan Berger
Yao,    I think this series has the needed R-b's and should be commit-able. Cheers!    Stefan On 9/24/21 7:42 AM, Stefan Berger wrote: This series of patches disables the TPM 2 platform hierarchy. We just added the same functionality to the OvmfPkg. However, on x86, we could use the

Re: [edk2-devel] [edk2-platforms][PATCH v3 3/5] Platform/Sgi: define memory region for GHES error status block

2021-10-04 Thread Sami Mujawar
Hi Omkar, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote: Allow platforms to define the base address and size of the memory region that is reserved for MM drivers to populate the GHES generic error status

Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Sami Mujawar
Hi Abner, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 04/10/2021 10:29 AM, Abner Chang wrote: Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that

Re: [edk2-devel] [PATCH 1/1] ArmPkg: SmbiosMiscDxe: Don't populate ExtendedBiosSize when size < 16MB

2021-10-04 Thread Sami Mujawar
Hi Rebecca, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 04/10/2021 05:22 PM, Rebecca Cran wrote: According to the SMBIOS specification, the ExtendedBiosSize field should be zero when the BIOS size is less than 16MB: "Size (n)

Re: [edk2-devel] [edk2-platforms][PATCH v3 5/5] ArmPlatformPkg: Add Readme file

2021-10-04 Thread Sami Mujawar
Hi Omkar, Thank you for adding this description. This is really helpful to understand the framework. I have a few minor suggestions marked inline as [SAMI]. With those changed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote: Added a

Re: [edk2-devel] [edk2-platforms][PATCH v3 2/5] ArmPlatformPkg: add definition for MM_HEST_ERROR_SOURCE_DESC_PROTOCOL

2021-10-04 Thread Sami Mujawar
Hi Omkar, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote: Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL protocol. This protocol can be implemented by MM drivers to publish error source

Re: [edk2-devel] [edk2-platforms][PATCH v3 4/5] EmbeddedPkg: Add helpers for HEST table generation

2021-10-04 Thread Sami Mujawar
Hi Omkar, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote: Add helper macros for the generation of the HEST ACPI table. Macros to initialize the HEST GHESv2 Notification Structure and Error Status Structure are

Re: [edk2-devel] [edk2-platforms][PATCH v3 3/5] ArmPlatformPkg: retreive error source descriptors from MM

2021-10-04 Thread Sami Mujawar
Hi Omkar, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote: Add a driver that retreives error source descriptors from MM and populates those into the HEST ACPI table. The error source descriptors that are available from

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/5] MdeModulePkg: Allow dynamic generation of HEST ACPI table

2021-10-04 Thread Sami Mujawar
Hi Omkar, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 24/08/2021 06:33 AM, Omkar Anand Kulkarni wrote: Introduce the HEST table generation protocol that allows platforms to build the table with multiple error source descriptors and install the table. The protocol

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/5] Add support to generate HEST ACPI table

2021-10-04 Thread Sami Mujawar
Hi Omkar, The subject for this patch series should be fixed. These patches are not for edk2-platforms. Regards, Sami Mujawar On 24/08/2021 06:33 AM, Omkar Anand Kulkarni wrote: Changes since v2: - Addressed the comments given by Sami. - Added Readme file with all cover letter information.

[edk2-devel] [PATCH 1/1] ArmPkg: SmbiosMiscDxe: Don't populate ExtendedBiosSize when size < 16MB

2021-10-04 Thread Rebecca Cran
According to the SMBIOS specification, the ExtendedBiosSize field should be zero when the BIOS size is less than 16MB: "Size (n) where 64K * (n+1) is the size of the physical device containing the BIOS, in bytes. FFh - size is 16MB or greater, see Extended BIOS ROM Size for actual size." Fix the

Re: [edk2-devel] [PATCH v5 1/4] MdePkg/BaseLib: Add QuickSort function on BaseLib

2021-10-04 Thread Marvin Häuser
04.10.2021 17:23:47 Kuo, IanX : > Hi Marvin > > Reply in mail > > Thanks, > Ian Kuo > > -Original Message- > From: Marvin Häuser > Sent: Monday, October 4, 2021 8:56 PM > To: devel@edk2.groups.io; Kuo, IanX > Cc: Chan, Amy ; Ni, Ray ; Kinney, > Michael D ; Liming Gao > ; Liu, Zhiguang

Re: [edk2-devel] [PATCH v5 1/4] MdePkg/BaseLib: Add QuickSort function on BaseLib

2021-10-04 Thread IanX Kuo
Hi Marvin Reply in mail Thanks, Ian Kuo -Original Message- From: Marvin Häuser Sent: Monday, October 4, 2021 8:56 PM To: devel@edk2.groups.io; Kuo, IanX Cc: Chan, Amy ; Ni, Ray ; Kinney, Michael D ; Liming Gao ; Liu, Zhiguang Subject: Re: [edk2-devel] [PATCH v5 1/4]

Re: [edk2-devel] [PATCH v5 4/4] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-04 Thread Marvin Häuser
Good day IanX, On 04/10/2021 07:03, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c

Re: [edk2-devel] [PATCH v5 1/4] MdePkg/BaseLib: Add QuickSort function on BaseLib

2021-10-04 Thread Marvin Häuser
Good day IanX, On 04/10/2021 07:03, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Add QuickSort function into BaseLib Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: IanX Kuo --- MdePkg/Include/Library/BaseLib.h

Re: [edk2-devel] [edk2-platforms][PATCH v3 5/5] Platform/Sgi: Add platform error handling driver

2021-10-04 Thread Sami Mujawar
Hi Omkar, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote: Enables firmware first error handling on the given platform. Installs and publishes the SDEI and HEST ACPI tables required for firmware first error handling.

Re: [edk2-devel] [edk2-platforms][PATCH v3 2/5] Platform/Sgi: dmc-620 firmware-first error handling

2021-10-04 Thread Sami Mujawar
Hi Omkar, I have a minor suggestion marked inline as [SAMI]. Other than that this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote: Enable the use of HEST table generation protocol, GHES error source descriptor

Re: [edk2-devel] [edk2-platforms][PATCH v3 4/5] Platform/Sgi: Define values for ACPI table header

2021-10-04 Thread Sami Mujawar
Hi Omkar, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote: For ACPI tables that are generated dynamically, define the ACPI table header values that have to be used to build the table header. Co-authored-by:

Re: [edk2-devel] [PATCH v3 12/28] AmpereAltraPkg: Add Ac01PcieLib library instance

2021-10-04 Thread Nhi Pham via groups.io
Hi Leif, There are two comments that I would like to clarify with you. On 23/09/2021 20:49, Leif Lindholm wrote: +VOID +Ac01PcieMmioWr ( + UINT64 Addr, + UINT32 Val + ) +{ + Ac01PcieCsrOut32Serdes ((VOID *)Addr, (UINT32)Val); +} + +VOID +Ac01PciePuts ( Wait, what. We have *two* sets of

Re: [edk2-devel] [PATCH v3 12/28] AmpereAltraPkg: Add Ac01PcieLib library instance

2021-10-04 Thread Nhi Pham via groups.io
Hi Leif, Thanks a lot for your review. We are heading to improve the Ac01PcieLib and addressing your comments in the PciSegmentLib, by decoupling the Ac01PcieLib into hierarchical modules. Hoping it will look better to you. Best regards, Nhi On 28/09/2021 17:34, Leif Lindholm wrote:

[edk2-devel] [edk2-platforms][PATCH v2 5/5] Signal EndOfDxe in boot manager

2021-10-04 Thread Daniel Schaefer
Otherwise we can't load a 3rd party image because we're still in DXE. MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.c prevents that. Cc: Abner Chang Cc: Sunil V L Cc: Leif Lindholm Reviewed-By: Sunil V L Signed-off-by: Daniel Schaefer ---

[edk2-devel] [edk2-platforms][PATCH v2 2/5] RISC-V/CpuDxe: Ignore set memory attributes failure

2021-10-04 Thread Daniel Schaefer
While enumerating the PCIe devices, the driver tries to set some caching attributes on the memory. Cc: Abner Chang Cc: Sunil V L Cc: Leif Lindholm Reviewed-By: Sunil V L Signed-off-by: Daniel Schaefer --- Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c | 4 ++-- 1 file changed, 2

[edk2-devel] [edk2-platforms][PATCH v2 3/5] U540, U500: Add initrd command to boot Linux

2021-10-04 Thread Daniel Schaefer
Cc: Abner Chang Cc: Sunil V L Cc: Leif Lindholm Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 ++- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 1 +

[edk2-devel] [edk2-platforms][PATCH v2 4/5] U540: BuildCpuHob with 48 to indicate size memory space

2021-10-04 Thread Daniel Schaefer
Otherwise it will crash on QEMU 6.0 with: > Loading driver at 0x000BF814000 EntryPoint=0x000BF81428A PciHostBridgeDxe.efi > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF BF351F98 > ProtectUefiImageCommon - 0xBF365BC0 > - 0xBF814000 - 0x000124C0 > PROGRESS CODE:

[edk2-devel] [edk2-platforms] PATCH v2 1/5] U540, U500: Add filesystem drivers

2021-10-04 Thread Daniel Schaefer
Not DiskIoDxe because we don't have a disk, just for loading from Ramdisks. Cc: Abner Chang Cc: Sunil V L Cc: Leif Lindholm Reviewed-By: Sunil V L Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 ++-

[edk2-devel] [edk2-platforms][PATCH v2 0/5] Improvements for booting to Linux on RISC-V

2021-10-04 Thread Daniel Schaefer
Changes from v1: - Remove ShellLib override in 3/5 Tested on the unpublshed riscvvirt branch and it can still boot to Linux. Cc: Abner Chang Cc: Sunil V L Cc: Leif Lindholm Daniel Schaefer (5): U540, U500: Add filesystem drivers RISC-V/CpuDxe: Ignore set memory attributes failure U540,

Re: [edk2-devel] [PATCH v1 4/5] U540: BuildCpuHob with 48 to indicate size memory space

2021-10-04 Thread Abner Chang
> -Original Message- > From: Sunil V L [mailto:suni...@ventanamicro.com] > Sent: Monday, October 4, 2021 7:02 PM > To: Schaefer, Daniel > Cc: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > ; Leif Lindholm > Subject: Re: [PATCH v1 4/5] U540: BuildCpuHob with 48 to

[edk2-devel] [edk2-platforms][PATCH 00/15] Changes to compliant with BZ:#3665

2021-10-04 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3665 BZ:#3665 is to migrate some modules from ArmVirtPkg to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage those modules without the dependency with Arm*Pkg. Refer to below message of the pacthes of edk2 portion.

[edk2-devel] [edk2-platforms][PATCH 13/15] Platform/Comcast: Use QemuFwCfgMmio provided by OvmfPkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 QemuFwCfg is relocated from ArmVirtPkg to OvmfPkg/Library/QemuFwCfgLib and renamed as QemuFwCfgMmio, use the OvmfPkg one instead of the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [edk2-platforms][PATCH 11/15] Platform/Comcast: Use PciPcdProducerLib in OvmfPkg.

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PciPcdProducerLib is relocated from ArmVirtPkg to OvmfPkg/Fdt, use OvmfPkg one instead. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Daniel Schaefer --- Platform/Comcast/RDKQemu/RDKQemu.dsc |

[edk2-devel] [edk2-platforms][PATCH 12/15] Platform/Comcast: Use HighMemDxe provided by OvmfPkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 HighMemDxe is relocated from ArmVirtPkg to OvmfPkg/Fdt, use the OvmfPkg one instead. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Daniel Schaefer --- Platform/Comcast/RDKQemu/RDKQemu.dsc | 2

[edk2-devel] [edk2-platforms][PATCH 10/15] Platform/Socionext: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [edk2-platforms][PATCH 06/15] Platform/Comcast: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [edk2-platforms][PATCH 09/15] Platform/SoftIron: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [edk2-platforms][PATCH 08/15] Platform/Phytium: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Leif Lindholm Cc: Peng

[edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Thomas

[edk2-devel] [edk2-platforms][PATCH 02/15] Platform/Hisilicon: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Leif Lindholm Cc: Ard

[edk2-devel] [edk2-platforms][PATCH 04/15] Platform/AMD: Use PcdPciIoTranslation PCD from MdePkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [edk2-platforms][PATCH 01/15] Platform/Comcast: Use FdtClientDxe from EmbeddedPkg

2021-10-04 Thread Abner Chang
Complaint with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 FdtClientDxe is relocated to under EmbeddedPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Daniel Schaefer --- Platform/Comcast/RDKQemu/RDKQemu.dsc | 2 +- 1 file changed, 1 insertion(+), 1

[edk2-devel] [edk2-platforms][PATCH 00/15] Changes to compliant with BZ:#3665

2021-10-04 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3665 BZ:#3665 is to migrate some modules from ArmVirtPkg to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage those modules without the dependency with Arm*Pkg. Refer to below message of the pacthes of edk2 portion.