Hey
Is that any update for this patch?
I did not see the v2 patch. Just want to ensure I did not miss that by mistake.
Thank you
Yao Jiewen
From: Bret Barkelew
Sent: Friday, August 13, 2021 11:22 AM
To: Yao, Jiewen ; devel@edk2.groups.io;
gaolim...@byosoft.com.cn; b...@corthon.com; Kinney,
HI Michael,
The actual changes are fine.
A couple of comments on the patch format.
* It's good to include the repository and package name, in the subject line
[Repo Name: [Optional] Patch Version# #/total #] PackageName:
* Commit message is missing the BugZilla reference.
* CC
Hey all,
I also don't think it makes much logical sense. They are distinct APIs
in separate libraries that happen to take a function with the same
prototype.
I think the patches look good now, thanks!
Best regards,
Marvin
On 08/10/2021 17:46, Michael D Kinney wrote:
Hi Liming,
In general
Merged as 30400318a278..769e63999ff5
Thanks.
Regards,
Sami Mujawar
On 08/10/2021 03:46 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v2:
- Update or error handling. [Sami/Pierre]
- Various comments. [Sami]
and
New patches:
DynamicTablesPkg: Remove unnecessary includes
Merged as 5ece2ad36caa..30400318a278
Thanks.
Regards,
Sami Mujawar
On 08/10/2021 06:59 AM, Gao, Zhichao wrote:
Yes, there is a typo. Please correct my email address
mailto:zhichao@intel.com>>.
Or you can directly copy the name from Maintainers.txt.
Thanks,
Zhichao
From: Sami Mujawar
Hi Liming,
In general it is not a good idea to include a library include file from another
library include file.
This becomes a hidden dependency.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming
> Sent: Thursday, October 7, 2021 7:16 PM
> To:
Hi Christine,
For the case that a directory is a symbol link, we should use os.path.realpath.
if os.path.islink(Dirname):
-Dirname = os.path.realpath(Dirname)
+Dirname = os.path.abspath(Dirname)
Thanks,
Bob
-Original
On Thu, 7 Oct 2021 at 13:02, Leif Lindholm wrote:
>
> On Thu, Oct 07, 2021 at 12:03:30 +0200, Ard Biesheuvel wrote:
> > On Thu, 7 Oct 2021 at 11:41, Leif Lindholm wrote:
> > >
> > > Ard/Sami - any comments?
> > >
> >
> > The code changes by itself look fine to me. The only problem I see is
> >
From: Pierre Gondois
In the GIC interrupt model, logical processors are required to
have a Processor Device object in the DSDT and must convey each
processor's GIC information to the OS using the GICC structure.
Additionally, _LPI objects may be needed as they provide a method
to describe Low
From: Pierre Gondois
Introduce the CM_ARM_LPI_INFO CmObj in the ArmNameSpaceObjects.
This allows to describe LPI state information, as described in
ACPI 6.4, s8.4.4.3 "_LPI (Low Power Idle States)".
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
.../Include/ArmNameSpaceObjects.h
From: Pierre Gondois
Add AmlAddLpiState() to generates AML code to add an _LPI state
to an _LPI object created using AmlCreateLpiNode().
AmlAddLpiState increments the count of LPI states in the LPI
node by one, and adds the following package:
Package() {
MinResidency,
From: Pierre Gondois
_LPI object provides a method to describe Low Power Idle
states that define the local power states for each node
in a hierarchical processor topology.
Therefore, add AmlCreateLpiNode() to generate code for a
_LPI object.
AmlCreateLpiNode ("_LPI", 0, 1, ParentNode, ) is
From: Pierre Gondois
Add AmlCodeGenMethodRetNameString() to generate AML code to create
a Method returning a NameString (NS).
AmlCodeGenMethodRetNameString (
"MET0", "_CRS", 1, TRUE, 3, ParentNode, NewObjectNode
);
is equivalent of the following ASL code:
Method(MET0, 1, Serialized, 3) {
From: Pierre Gondois
Add AmlCodeGenReturnNameString() to generate AML code for a
Return object node, returning the object as a NameString.
AmlCodeGenReturn ("NAM1", ParentNode, NewObjectNode) is
equivalent of the following ASL code:
Return(NAM1)
Reviewed-by: Sami Mujawar
Signed-off-by:
From: Pierre Gondois
Add AmlCodeGenMethod() to generate code for a control method.
AmlCodeGenMethod ("MET0", 1, TRUE, 3, ParentNode, NewObjectNode)
is equivalent of the following ASL code:
Method(MET0, 1, Serialized, 3) {}
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
ASL provides a ResourceTemplate macro that creates a Buffer in which
resource descriptor macros can be listed. The ResourceTemplate macro
automatically generates an End descriptor and calculates the checksum
for the resource template.
Therefore, add
From: Pierre Gondois
Some AML object have a PkgLen which indicates the size of the
AML object. The package length can be encoded in 1 to 4 bytes.
The bytes used to encode the PkgLen is itself counted in the
PkgLen value. So, if an AML object's size increments/decrements,
the number of bytes used
From: Pierre Gondois
Add AmlCodeGenPackage() to generate AML code for declaring
a Package() object. This function generates an empty package
node. New elements can then be added to the package's variable
argument list.
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
Add a helper function AmlCodeGenEndTag() to generate AML Resource Data
EndTag. The EndTag resource data is automatically generated by the ASL
compiler at the end of a list of resource data elements. Therefore, an
equivalent function is not present in ASL.
However,
From: Pierre Gondois
To fetch the Oem information from the ConfigurationManagerProtocol
and the AcpiTableInfo, and populate the SSDT ACPI header when
creating a RootNode via the AmlLib, create AddSsdtAcpiHeader().
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
Add AmlCodeGenRegister() to generate AML code for the
Generic Register Resource Descriptor. This function is
equivalent to the ASL macro Register().
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
.../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 87
From: Pierre Gondois
Remove the STATIC qualifier for the AmlUtility function
AmlNodeGetIntegerValue() and add the definition to the
header file so that it can be used by other AmlLib
sub-modules.
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
The node creation functions:
- AmlCreateRootNode()
- AmlCreateObjectNode()
- AmlCreateDataNode()
are now resetting the input pointer where the created node is stored.
Thus, it is not necessary to set some local variables to NULL or
check a node value before trying to delete
From: Pierre Gondois
Lists of Resource Data elements end with an EndTag (most of the time).
This function finds the EndTag (if present) in a list of Resource Data
elements and sets the checksum.
ACPI 6.4, s6.4.2.9 "End Tag":
"This checksum is generated such that adding it to the sum of all the
From: Pierre Gondois
Add AmlRdSetEndTagChecksum(), setting the CheckSum value contained in a
Resource Data element.
ACPI 6.4, s6.4.2.9 "End Tag":
"This checksum is generated such that adding it to the sum of all the
data bytes will produce a zero sum."
"If the checksum field is zero, the
From: Pierre Gondois
The following functions:
- AmlCreateRootNode()
- AmlCreateObjectNode()
- AmlCreateDataNode()
create a node and return it by populating a pointer. This pointer
should only be considered/used if the function returns successfully.
Otherwise, the value stored in this pointer
From: Pierre Gondois
ACPI 6.4, s6.4.2.9 "End Tag":
"This checksum is generated such that adding it to the sum of all the data
bytes will produce a zero sum."
"If the checksum field is zero, the resource data is treated as if the
checksum operation succeeded. Configuration proceeds normally."
To
From: Pierre Gondois
Add missing check of 'AcpiTableInfo' in AddAcpiHeader().
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Pierre Gondois
Some includes are not necessary. Remove them.
Reviewed-by: Sami Mujawar
Signed-off-by: Pierre Gondois
---
Notes:
v2:
- New patch. [Pierre]
.../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c| 2 --
From: Pierre Gondois
v2:
- Update or error handling. [Sami/Pierre]
- Various comments. [Sami]
and
New patches:
DynamicTablesPkg: Remove unnecessary includes
DynamicTablesPkg: Add missing parameter check
DynamicTablesPkg: Add AddSsdtAcpiHeader()
DynamicTablesPkg: Add AmlRdSetEndTagChecksum()
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlAddLpiState() to generates AML code to add an _LPI state
to an _LPI object created using AmlCreateLpiNode().
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
_LPI object provides a method to describe Low Power Idle
states that define the local power states for each node
in a
On Fri, 8 Oct 2021 at 12:34, Leif Lindholm wrote:
>
> The MADT GICC structure contains the field PhysicalBaseAddress, which
> is needed for a GICv1/v2 implementation, or to indicate legacy
> compatibility in modern GICs.
>
> Linux commit 9739f6ef053f1, included in v5.12, adds a warning message
>
Hi Pierre,
I think this v2 patch has introduced an issue (which was not there in
v1), see my comment marked inline as [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add
Hi Pierre,
Thank you for adding documentation for the steps for generating a Method.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenMethod() to generate code for a control method.
AmlCodeGenMethod
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
ASL provides a ResourceTemplate macro that creates a Buffer in which
resource descriptor macros can be listed. The
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add a helper function AmlCodeGenEndTag() to generate AML Resource Data
EndTag. The EndTag resource data is automatically
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenPackage() to generate AML code for declaring
a Package() object. This function generates an empty package
node.
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The node creation functions:
- AmlCreateRootNode()
- AmlCreateObjectNode()
- AmlCreateDataNode()
are now resetting the input
Hi Pierre,
There is a minor typo in the commit message that I will fix when pushing
the patch.
Otherwise, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The following functions:
-
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Lists of Resource Data elements end with an EndTag (most of the time).
This function finds the EndTag (if present) in a list of
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
ACPI 6.4, s6.4.2.9 "End Tag":
"This checksum is generated such that adding it to the sum of all the data
bytes will produce a
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlRdSetEndTagChecksum(), setting the CheckSum value contained in a
Resource Data element.
ACPI 6.4, s6.4.2.9 "End Tag":
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add missing check of 'AcpiTableInfo' in AddAcpiHeader().
Signed-off-by: Pierre Gondois
---
Notes:
v2:
- New
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
To fetch the Oem information from the ConfigurationManagerProtocol
and the AcpiTableInfo, and populate the SSDT ACPI header when
Hi Pierre,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Some includes are not necessary. Remove then.
Signed-off-by: Pierre Gondois
---
Notes:
Reviewed-by: Kathappan Esakkithevar
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, October 8, 2021 12:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Oram, Isaac W
> ; Desimone, Nathaniel L
> ; Luo, Heng ;
> Jeremy Soller ; Benjamin Doron
> ; Chaganty, Rangasai V
> ;
Reviewed-by: Kathappan Esakkithevar
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, October 8, 2021 12:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Chaganty, Rangasai V
> ; Kethi Reddy, Deepika
> ; Esakkithevar, Kathappan
>
> Subject:
Hi Pierre,
Thanks you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 07/10/2021 04:32 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenReturnNameString() to generate AML code for a
Return object node, returning the object as a NameString.
The MADT GICC structure contains the field PhysicalBaseAddress, which
is needed for a GICv1/v2 implementation, or to indicate legacy
compatibility in modern GICs.
Linux commit 9739f6ef053f1, included in v5.12, adds a warning message
when this field is populated but invalid:
[Firmware Bug]: CPU
Hi all,
Can you please help to review this patch? Thanks a lot.
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan
Sent: Wednesday, September 29, 2021 2:43 PM
To: devel@edk2.groups.io; Tan, Dun
Cc: Sean Brogan ; Bret Barkelew
; Kinney, Michael D ;
Liming Gao
gEdkiiVTdInfoPpiGuid notify could be called more than one time in PEI post
memory phase. The DMA buffer should be set only once to prevent the
memory overlap, because PeiIoMmuAllocateBuffer always allocate memory
from the same buffer.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3667
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Isaac Oram
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added PeiGetLargeVariable () to support the scenarios where the
variable data size is bigger
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Sai Chaganty
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
To simplify the implementation the variable Name/GUID has been
changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid
regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2
or FSP_NON_VOLATILE_STORAGE_HOB.
Cc: Nate DeSimone
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added PeiGetLargeVariable () to support the scenarios where the
variable data size is bigger
V3:
Fix another GCC build failure.
V2:
Fix GCC build failures.
V1:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added
62 matches
Mail list logo
