Sorry for the miss. PR create: https://github.com/tianocore/edk2/pull/2100
Thanks,
Zhichao
> -Original Message-
> From: Attar, AbdulLateef (Abdul Lateef)
> Sent: Wednesday, October 20, 2021 9:14 PM
> To: Gao, Zhichao ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: RE: [edk2-devel]
This patch follows new Intel SDM to define CPUID.(EAX=7,ECX=0):EDX[30].
Signed-off-by: Star Zeng
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Ray Ni
---
MdePkg/Include/Register/Intel/Cpuid.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Jie:
Thanks for the update. Reviewed-by: Wei6 Xu
BR,
Wei
-Original Message-
From: Yang, Jie
Sent: Tuesday, October 19, 2021 11:11 AM
To: devel@edk2.groups.io
Cc: gaolim...@byosoft.com.cn; Kinney, Michael D ;
Jiang, Guomin ; Xu, Wei6 ; Yang, Jie
Subject: [edk2-devel][PATCH v2]
Mike,
It‘s very good! It allows further NASM cleanup removing DB instructions.
Thanks,
Ray
-Original Message-
From: r...@edk2.groups.io On Behalf Of Michael D Kinney
Sent: Thursday, October 21, 2021 12:52 AM
To: devel@edk2.groups.io; Kinney, Michael D ;
r...@edk2.groups.io
Subject:
Bob:
Sorry for the late response. I have no comments for the code change.
But, I am not sure whether it is valid to use UEFI FirmwareManagement
Protocol in runtime phase, because I don't find such description for this
protocol in UEFI spec.
Mike, Guomin, Xuwei:
Have you any comments
Thank you Min
Series: Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Thursday, October 21, 2021 8:18 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Ard Biesheuvel
> ; Gerd Hoffmann ; Justen,
> Jordan L ; Brijesh Singh ;
> Erdem Aktas ; James Bottomley
> ; Yao,
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology
that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory
Encryption (MKTME) with a new kind of virutal machines guest called a
Trust Domain (TD). A
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In TDX when host VMM creates a new guest TD, some initial set of
TD-private pages are added using the TDH.MEM.PAGE.ADD function. These
pages typically contain Virtual BIOS code and data along with some clear
pages for stacks and heap. In
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Previously WORK_AREA_GUEST_TYPE was cleared in SetCr3ForPageTables64.
This is workable for Legacy guest and SEV guest. But it doesn't work
after Intel TDX is introduced. It is because all TDX CPUs (BSP and APs)
start to run from 0xfff0,
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Previously OvmfPkg/ResetVector uses the Main.asm in
UefiCpuPkg/ReseteVector/Vtf0. In this Main.asm there is only Main16
entry point.
This patch-set is to introduce Intel TDX into Ovmf. Main32 entry point
is needed in Main.asm by Intel TDX.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology
that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory
Encryption (MKTME) with a new kind of virutal machines guest called a
Trust Domain (TD). A
Hi, Any feedback on this?
Thanks,
-bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Morgan via
groups.io
Sent: Thursday, September 23, 2021 8:19 PM
To: devel@edk2.groups.io; gaolim...@byosoft.com.cn
Cc: michael.d.kin...@intel.com; guomin.ji...@intel.com;
Mike,
Sounds like a good plan.
Thanks,
Andrew Fish
> On Oct 20, 2021, at 9:51 AM, Michael D Kinney
> wrote:
>
> Hello,
>
> I would like to propose that we update to a newer version of NASM.
>
> https://www.nasm.us/
>
> The most recent stable version is 2.15.05.
>
>
Hi Mike,
Thanks for the review comments.
The PythonReadMe.txt available @
https://github.com/tianocore/edk2-libc/blob/master/AppPkg/Applications/Python/PythonReadMe.txt
is the readme file for Py2.7.2 and we don't need to retain this file. So I have
deleted this file as part of the patch sent
Hi Pierre,
On Wed, Oct 13, 2021 at 02:44 AM, PierreGondois wrote:
>
> Hi Khasim and Deepak,
>
> To check all the required Libraries, Pcds, ... are included correctly,
> it is faster to run the CI tests.
>
> The edk2 CI is currently not available for edk2-platforms. I created a
> branch that
Hello,
I would like to propose that we update to a newer version of NASM.
https://www.nasm.us/
The most recent stable version is 2.15.05.
https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/
NASM 2.15.05 Documentation:
https://nasm.us/xdoc/2.15.05/html/
Hi JP,
Can you also update the documentation to remove references to Python 2.x or
update for Python 3.x?
For example, the following file has Python 2.x references.
https://github.com/tianocore/edk2-libc/blob/master/AppPkg/Applications/Python/PythonReadMe.txt
Mike
> -Original
[AMD Official Use Only]
Gentle reminder to merge the code.
-Original Message-
From: Gao, Zhichao
Sent: 09 September 2021 07:54
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Ni, Ray
Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
From: Joseph Hemann
-add initial TCG2 protocol test for SubmitCommand()
-checkpoint for test function with GET_RANDOM Command
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Supreeth Venkatesh
Signed-off-by:
From: Joseph Hemann
-add initial TCG2 protocol test for GetEventLog()
-checkpoint for test function with invalid eventlog format
-checkpoint for test function with valid eventlog format
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc:
From: Joseph Hemann
-add initial TCG2 protocol test for HashLogExtendEvent()
-checkpoint for test of function with invalid parameters
-checkpoint for test of function with valid parameters
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
From: Joseph Hemann
-implement initial infrastructure for the TCG2 protocol test
including updates to .dsc file, inf file, GUID source files,
update to Category.ini.
-add initial TCG2 protocol test for GetCapability(), as
defined in the TCG EFI Protocol Spec 6.4.4.
-checkpoint for NULL
From: Joseph Hemann
-add initial TCG2 protocol test for GetActivePcrBanks()
-checkpoint for NULL pointer passed for buffer
-checkpoint for test of function with proper input
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc:
From: Joseph Hemann
This patch series implements a set of SCT tests,
for the TCG2 UEFI protocol as defined in the TCG
EFI Protocol Specification. The series implements
the code for the test, and the infrastructure
needed to run the test from the SCT UI.
Patch 1 adds header file with TCG2
From: Joseph Hemann
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Supreeth Venkatesh
Signed-off-by: Joseph Hemann
---
uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 174 +++
1 file changed, 174
Hi Chris,
Thanks for adding the comment that clarifies the usage.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/10/2021, 11:47, "Chris Jones" wrote:
Add a comment to clarify that in Acpiview the ItemPtr is not set until
after the FieldValidator has been called.
Add a comment to clarify that in Acpiview the ItemPtr is not set until
after the FieldValidator has been called.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Hi Pierre,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 14/10/2021 03:59 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Building the DynamicTablesPkg with the additional
-Wpointer-arith flag triggers the following error:
"pointer of type ‘void *’
Merged as 37a33f02aa1a..4fdf843c75d2
Thanks.
Regards,
Sami Mujawar
On 20/10/2021 10:40 AM, Sami Mujawar wrote:
Hi Moritz,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/10/2021 06:21 AM, Moritz Fischer wrote:
In the success case we should return
Hi Moritz,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/10/2021 06:21 AM, Moritz Fischer wrote:
In the success case we should return EFI_SUCCESS rather than returning
a potentially unitialized value of Status.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Hi Jiewen,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 19/10/2021 03:40 PM, Yao, Jiewen via groups.io wrote:
Good feedback. Thank you very much, Sami.
Response inline.
I proposed some naming change. Please let us know if that is OK.
Thank you
Yao, Jiewen
SystemTableInfo GUID is not a Spec defined GUID.
The latest SBL and CBL produces ACPI and SMBIOS table information.
So removing the SystemTableInfo GUID implementation.
Cc: Maurice Ma
Cc: Guo Dong
Cc: Ray Ni
Cc: Benjamin You
Cc: Zhiguang Liu
Signed-off-by: Guo Dong
Signed-off-by: Thiyagu
32 matches
Mail list logo
