BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
DxeTpm2MeasureBootLib supports TPM2 based measure boot. After
TeeMeasurementProtocol is introduced, TEE based measure boot needs to
be supported in DxeTpm2MeasureBootLib as well.
There are 2 major changes in this commit.
1.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
DxeTpmMeasurementLib supports TPM based measurement in DXE phase.
After TeeMeasurementProtocol is introduced, TD based measurement needs
to be supported in DxeTpmMeasurementLib as well.
In TpmMeasureAndLogData, TEE based measurement will be
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
If TEE-Guest firmware supports measurement and an event is created,
TEE-Guest firmware is designed to report the event log with the same data
structure in TCG-Platform-Firmware-Profile specification with
EFI_TCG2_EVENT_LOG_FORMAT_TCG_2
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
If TEE Guest firmware supports measurement and an event is created,
TEE Guest firmware is designed to report the event log with the same data
structure in TCG-Platform-Firmware-Profile specification with
EFI_TCG2_EVENT_LOG_FORMAT_TCG_2
[AMD Official Use Only]
Hi Nate,
I'm following below Leszlo's document to submit the patch.
Please let me know how to remove the groups.io web interface.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers
Thanks
AbduL
This patch is sent in behalf of Nickle Wang.
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 28, 2021 12:05 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) ; Liming
Update RedfishCollectionCommon.h header file. Remove the "Event"
field from REDFISH_COLLECTION_PRIVATE because the feature driver
is not started up by the EFI event that is registered by feature
driver itself anymore.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Sami Mujawar
> Sent: Wednesday, October 20, 2021 6:54 PM
> To: Christopher Jones ;
> devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao ; nd
>
> Subject: Re: [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set
Hi Mike,
Could you look into this PR?
Regards,
JP
-Original Message-
From: Jayaprakash, N
Sent: 25 October 2021 22:10
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Rebecca Cran
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python:
Remove py2.7.2 support from
Hi Prince,
There is a build failure when building BoardX58Ich10 of SimicsOpenBoardPkg by
GCC with the command "python build_bios.py -p BoardX58Ich10" in
edk2-platforms/Platform/Intel.
The build log shows "GenFv: ERROR 3000: Invalid.the required fv image size
0x17bcf0 exceeds the set fv
Hi Abdul,
I would prefer to clean up the technical debt and not have the APIC NMI if we
are in X2APIC mode. Is there any chance you could test this change with Windows
Server 2019? As long as semi-current Windows + Linux boots I'm fine with
merging your patch as-is.
Thanks,
Nate
On
Reviewed-by: Nate DeSimone
On 10/27/21, 5:00 AM, "Zeng, Star" wrote:
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Star Zeng
---
IntelFsp2Pkg/Tools/SplitFspBin.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Besides VmgExitLib -
https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Include/Library/VmgExitLib.h
We have another potential issue - MemEncryptSevLib -
https://github.com/tianocore/edk2/blob/master/OvmfPkg/Include/Library/MemEncryptSevLib.h
We might need rename it to MemEncryptionTeeLib.
This patch is sent in behalf of Nickle Wang.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 28, 2021 9:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) ; Liming Gao
>
> Subject: [edk2-devel]
Hi Gerd
I tend to agree with you on the direction to use one TEE specific Exception lib.
However, I have naming concern.
The VMG is very SEV specific term. I don't believe it is a right name to cover
the TEE exception lib.
If Brijesh agree to merge, I think we should rename it to a neutral
(This one is the same as RedfishLib under RedfishPkg.
The one under RedfishPkg will be removed because
RedfishLib is used by EDKII feature drivers which is belong
to EDK2 Redfish client implementation)
EDK2 port of DMTF libredfish project. We clone the necessary files
from open source project
Already reviewed this before sending this patch in behalf of Nickle Wang.
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 28, 2021 9:32 AM
> To: devel@edk2.groups.io
> Cc: Wang,
Already reviewed this before sending this patch set in behalf of Nickle Wang.
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 28, 2021 9:07 AM
> To: devel@edk2.groups.io
> Cc:
This is the helper library for EDKII Redfish feature drivers to
manipulate Redfish properties.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
RedfishClientPkg/RedfishClientPkg.dec |3 +
RedfishClientPkg/RedfishClientLibs.dsc.inc|3 +
Pedro,
I believe he DID reference Linux source
“ 2. I did't look at linux kernel(ext4) berfor send this patch, I cant
found any offcial document, so I refer to linux source as a standand
when send this patch”
Kevin D Davis
Security Strategist
Insyde Software
> On Oct 27, 2021, at 5:43 PM, qi
EDKII Redfish Platform Config Protocol is an abstract driver that abstracts
the platform configuration format and storage from EDK2 Redfish Feature
driver. This protocol provides the interfaces to get and set platform
configuration with the format and configuration storage agnostic to the
Redfish
This is the Implementation of EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL,
which is the EDKII Redfish Platform Config driver instance that accesses
EDK2 HII configuration format and storage.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
.../RedfishPlatformConfigDxe.inf
Enable RedfishPlatformConfigDxe driver and the corresponding
library to build.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
RedfishPkg/RedfishComponents.dsc.inc | 2 ++
RedfishPkg/RedfishLibs.dsc.inc | 2 ++
RedfishPkg/RedfishPkg.dsc| 4
Setting the Always-on Capability bit in GTDT table for
system PE timers in sbsa platform.This is also required
for ACS sbsa level 3 test compliancy.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Graeme Gregory
Signed-off-by: Shashi Mallela
---
Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 5 -
This is the helper library for using EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
RedfishPkg/RedfishPkg.dec | 5 +
.../RedfishPlatformConfigLib.inf | 41 +++
.../Library/RedfishPlatformConfigLib.h
EDKII Redfish Platform Config Protocol defines the protocol
interfaces that abstracts the platform configuration format
and storage from EDK2 Redfish Feature driver. This protocol
provides the interfaces to get and set platform configuration
with the format and configuration storage agnostic to
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ni, Ray
> 发送时间: 2021年10月22日 11:29
> 收件人: Zeng, Star ; devel@edk2.groups.io
> 抄送: Kinney, Michael D ; Liming Gao
> ; Liu, Zhiguang
> 主题: Re: [edk2-devel] [PATCH] MdePkg Cpuid.h: Define
> CPUID.(EAX=7,ECX=0):EDX[30]
>
>
This is the helper library for using EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
RedfishPkg/RedfishPkg.dec | 5 +
.../RedfishPlatformConfigLib.inf | 41 +++
.../Library/RedfishPlatformConfigLib.h
Enable RedfishPlatformConfigDxe driver and the corresponding
library to build.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
RedfishPkg/RedfishComponents.dsc.inc | 2 ++
RedfishPkg/RedfishLibs.dsc.inc | 2 ++
RedfishPkg/RedfishPkg.dsc| 4
This is the Implementation of EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL,
which is the EDKII Redfish Platform Config driver instance that accesses
EDK2 HII configuration format and storage.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
.../RedfishPlatformConfigDxe.inf
EDKII Redfish Platform Config Protocol defines the protocol
interfaces that abstracts the platform configuration format
and storage from EDK2 Redfish Feature driver. This protocol
provides the interfaces to get and set platform configuration
with the format and configuration storage agnostic to
EDKII Redfish Platform Config Protocol is an abstract driver that abstracts
the platform configuration format and storage from EDK2 Redfish Feature
driver. This protocol provides the interfaces to get and set platform
configuration with the format and configuration storage agnostic to the
Redfish
Hi Leif,
Thank you for your reply!
2021年10月27日(水) 20:21 Leif Lindholm :
>
> Hi Masami,
>
> Apologies for delay.
>
> Thank you, this set looks good.
> However, you cannot make legal statements on behalf of Sakamoto-san,
> only yourself. If you are happy with that, I could drop their
>
This line may do come form linux kernel, As you can see in the first
link I refers says this number (1UL << 15) is kind of magic number. If
you write somethimg linux standanrded, It is hard to keep abosultely no
any linux involued
I think even freebsd has some code from linux, like the second link
Hi Qi,
If you didn't use the Linux kernel (nor the documentation) as a reference,
can you please tell me what you've used? I'm asking because there's at
least a line that's suspiciously similar to Linux's code:
#define EXTENT_INIT_MAX_LEN (1UL << 15)
the UL looks redundant to me, since there's
[Public]
Hi Nate,
I tested on real hardware with latest linux(didn't tested with older
OSes).
Note that with X2APIC mode I don't see any issue having APIC NMI structure and
not having NMI structure.
In both cases OS boots without any issue. Just thought that why to include APIC
NMI
But I do googled
From: QiZhou
Sent: Wednesday, October 27, 2021 23:44
To: pedro.falc...@gmail.com
Cc: devel@edk2.groups.io
Subject: Re: [PATCH][Ext4Pkg] unwritten extent suuport
1. I am not familiar with freebsd, and don know if freebsd get the same issue,
But
1. I am not familiar with freebsd, and don know if freebsd get the same issue,
But I do found the freebsd has some code snippets related to unwritten extent,
see:
https://github.com/freebsd/freebsd-src/blob/b3f46656393f5c8a6e8305afeb5e8c3638025c26/sys/fs/ext2fs/ext2_extents.h#L37
From: "Qi Zhou"
Subject: [PATCH] unwritten extent suuport
the real lenght of uninitialized/unwritten extent should be (ee_len - (1UL <<
15)), and
all related block should been read as zeros. see:
On 10/26/21 13:38, Stefan Berger wrote:
Enable the physical presence interface for TPM 1.2. It is required for
the TPM 1.2 menu to work.
I am also extending the TPM 2 PPI QEMU code and I am trying to introduce
a variable there as well for holding physical presence flags.
When trying to
Hi Khasim,
+ Sami
Thanks for the new patch-set, everything looks good to me:
Reviewed-by: Pierre Gondois
Just a reminder for Sami about the _OSC method:
https://edk2.groups.io/g/devel/message/82724
Regards,
Pierre
On 10/26/21 18:39, Khasim Mohammed via groups.io wrote:
> This patch adds
There is a case for that tag, but it is not this one.
I'm not asking Masami to drop his S-o-b, and Sakamoto-san maintains
their authorship (via the From: tag) - so both will be acknowledged in
the end result.
On Wed, Oct 27, 2021 at 13:55:56 +, Samer El-Haj-Mahmoud wrote:
> For situations
Hi,
The patch looks OK despite the typos and lack of proper formatting on the
commit message.
But honestly, I don't know if this patch is even mergeable considering you
looked at the Linux kernel's source code for this. The patch was already
trivial enough
if you looked at the documentation and
For situations like this, maybe " Co-authored-by" can be used?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif
> Lindholm via groups.io
> Sent: Wednesday, October 27, 2021 7:22 AM
> To: Masami Hiramatsu
> Cc: Ard Biesheuvel ; devel@edk2.groups.io;
> Kazuhiko Sakamoto
This patch set is sent in behalf of Nickle Wang.
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Wednesday, October 27, 2021 6:36 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) ;
This patch set is sent in behalf of Nickle Wang.
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Wednesday, October 27, 2021 6:30 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) ;
Thanks Star.
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, October 27, 2021 8:00 PM
> To: devel@edk2.groups.io
> Cc: Zeng, Star ; Ma, Maurice ;
> Desimone, Nathaniel L ; Chiu, Chasel
>
> Subject: [PATCH] IntelFsp2Pkg SplitFspBin.py: Correct file
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Star Zeng
---
IntelFsp2Pkg/Tools/SplitFspBin.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelFsp2Pkg/Tools/SplitFspBin.py
b/IntelFsp2Pkg/Tools/SplitFspBin.py
index 24272e82af88..c3165dd4ae69 100644
Patch pushed:
https://github.com/tianocore/edk2/commit/9a95d11023ac2f2ee49a2958cf80658270442c42
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, October 26, 2021 4:06 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ma,
Hi Masami,
Apologies for delay.
Thank you, this set looks good.
However, you cannot make legal statements on behalf of Sakamoto-san,
only yourself. If you are happy with that, I could drop their
Signed-off-by: statements before I push. They would retain the
authorship.
Best Regards,
Leif
On
Dear All: I want to submit a new architecture called LoongArch on EDK2 and the USWG recommands us do "code first" because the UEFI specifitcation will easily accpet our arch. What can we do? Do I submit the part 1 code for new architecture on the "staging" branch? Hop you reply. :)
RedfishLib.h is the header file of RedfishLib
library under RedfishClientPkg. RedfishLib is
used by EDKII Redfish feature drivers.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
.../PrivateInclude/Library/RedfishLib.h | 611 ++
1 file changed, 611
Action in StartupContext is not set properly.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Liming Gao
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
On Tue, Oct 26, 2021 at 17:01:36 +0100, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> Add the edk2 repository as a submodule:
> https://github.com/tianocore/edk2
>
> Platforms in edk2-platforms often relies on modules available
> in the edk2 repository. In order to enable an upstream
Currently when parse VFR files to get the struct info,
BOOLEAN type struct is ignored, which caused offset errors.
This patch fixed these bugs.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Scripts/ConvertFceToStructurePcd.py | 4 ++--
1 file changed, 2 insertions(+), 2
Reviewed-by: Jenny Huang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sheng Wei
Sent: Thursday, October 21, 2021 5:11 AM
To: devel@edk2.groups.io
Cc: Kowalewski, Robert ; Huang, Jenny
; Ni, Ray ; Chaganty, Rangasai V
; Albecki, Mateusz ;
Kolakowski, Jacek
Subject:
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via groups.io
Sent: Friday, October 22, 2021 7:48 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-devel]
Hi Abdul,
I do agree with you that logically it seems to be the right thing to not
install the local APIC NMI structure if we install the X2APIC NMI structure
instead. However, I went and took a look at some of our internal closed source
code and it appears that even on X2APIC systems we
Hi Abdul,
First of all thank you for the patch series. One thing to take note of;
unfortunately, the groups.io web interface messes up the line endings and makes
it difficult to apply any patches sent through it. I was able to get your patch
series to apply, but in the future, would it be
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, October 26, 2021 4:06 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Ma, Maurice ;
Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH] IntelFsp2Pkg/SplitFspBin.py: adopt FSP 2.3 specification.
REF:
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, October 26, 2021 1:06 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Ma, Maurice ;
Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH] IntelFsp2Pkg/SplitFspBin.py: adopt FSP 2.3 specification.
REF:
Hey,
On 25.10.21 20:47, Teng, Lynn L wrote:
Hello all,
Please provide your feedback and comments to the Inclusive Language Plan below
over the next two weeks (10/25-11/05). Thank you in advance for your
contributions.
***
## Overview
To promote a more inclusive and open ecosystem,
Hi,
> > How about adding the tdx exception handler to the existing library, so we
> > don't
> > have the churn of adding a new library everywhere *again*?
> Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in
> CpuExceptionHandlerLib, then include the corresponding source file in
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3708
The original code will cause FWTS V21.08.00 testing failed.
spcr: SPCR PC-AT compatible IRQ 0xff is invalid
spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device
Now modify the SpcrAcpi for following:
1. Disable the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3708
The ogirinal code will cause FWTS V21.08.00 testing failed.
spcr: SPCR PC-AT compatible IRQ 0xff is invalid
spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device
Now modify the SpcrAcpi for following:
1. Disable the
Some system may has multi PCI root bridges. It needs to use PciRootBridgeIo
protocol to get the root bridge count. Scan each root bridge to get all
PCI devices.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3695
Signed-off-by: Robert Kowalewski
Signed-off-by: Sheng Wei
Cc: Jenny Huang
66 matches
Mail list logo
