Re: [edk2-devel] [Patch 1/1] BaseTools/VrfCompile: Fix uninitialized field from unnamed field

This patch is good to me. Reviewed-by: Bob Feng -Original Message- From: Kinney, Michael D Sent: Tuesday, November 2, 2021 1:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [Patch 1/1] BaseTools/VrfCompile: Fix uninitialized field from unnamed

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg: Extend measurement of microcode patches to TPM

Just offline discussed with Longlong, measuring the entire microcode buffer might spend more time comparing to only measuring the applied microcode, when the platform firmware includes lots of microcode. 10 comments embedded in code change in below. -Original Message- From:

Re: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do S.M.A.R.T. check if device support

> -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Monday, November 1, 2021 5:46 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray > Subject: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do > S.M.A.R.T. check if device support > > If

[edk2-devel] [PATCH V4 3/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 DxeTpmMeasurementLib supports TPM based measurement in DXE phase. After CcMeasurementProtocol is introduced, CC based measurement needs to be supported in DxeTpmMeasurementLib as well. In TpmMeasureAndLogData, CC based measurement will be

[edk2-devel] [PATCH V4 2/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 DxeTpm2MeasureBootLib supports TPM2 based measure boot. After CcMeasurementProtocol is introduced, CC based measure boot needs to be supported in DxeTpm2MeasureBootLib as well. There are 2 major changes in this commit. 1.

[edk2-devel] [PATCH V4 0/3] Introduce CcMeasurementProtocol into EDK2

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 If Confidential Computing (Cc) firmware supports measurement and an event is created, CC-Guest firmware is designed to report the event log with the same data structure in TCG-Platform-Firmware-Profile specification with

[edk2-devel] [PATCH V4 1/3] MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 CC guest is a Confidential Computing guest. If CC Guest firmware supports measurement and an event is created, CC Guest firmware is designed to report the event log with the same data structure in TCG-Platform-Firmware-Profile specification

[edk2-devel] 回复: [Patch V2 0/7] Reproduce builds across source format changes

Mike： Seemly, this change is for debug image build reproduce. But, if the fixed value is used, they are not correct for the debug image. If so, can RELEASE image be used for the binary comparison? Thanks Liming > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2021年11月2日 5:38 > 收件人:

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/02/2021 #cal-reminder

The following issues will be reviewed this week meeting. 3715 EDK2 Code unassig...@tianocore.org UNCO Some tools fail to compile for NOOPT with clang-13. Mon 04:51

[edk2-devel] 回复: [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to support reproduce builds

Mike: I add my comments. Thanks Liming > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2021年11月2日 5:38 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Zhiguang Liu > ; Michael Kubacki > > 主题: [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to support > reproduce builds > > REF:

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg: Extend measurement of microcode patches to TPM

Longlong, Your code creates a big buffer that holds microcode data for all threads. MicrocodeCpu[i] = MicrocodePatchHob->MicrocodePatchAddress + MicrocodePatchHob->ProcessorSpecificPatchOffset[i] BigBuffer = GetMicrocodeBuffer (MicrocodeOfCpu[0]) + GetMicrocodeBuffer

[edk2-devel] 回复: [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

Bret: What modules depend on this header file? Why need to move it from ArmPkg to MdePkg? Thanks Liming > -邮件原件- > 发件人: brbar...@microsoft.com > 发送时间: 2021年11月2日 3:57 > 收件人: devel@edk2.groups.io > 抄送: Leif Lindholm ; Ard Biesheuvel > ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ;

回复: [edk2-devel][PATCH v4] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yang Jie > 发送时间: 2021年10月29日 11:10 > 收件人: devel@edk2.groups.io > 抄送: jian.j.w...@intel.com; guomin.ji...@intel.com; > gaolim...@byosoft.com.cn; Yang Jie > 主题: [edk2-devel][PATCH v4] MdeModulePkg/DxeCapsuleLibFmp: Use new >

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/02/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

回复: [edk2-devel] [PATCH 1/1] BaseTools: Fix StructurePcd offset error.

Yuwei: Thanks for your information. I have no other comment for this change. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yuwei Chen > 发送时间: 2021年10月29日 13:35 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Feng, Bob C > 主题: Re: [edk2-devel] [PATCH

回复: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes

For the changes in MdePkg, Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chris Jones > 发送时间: 2021年10月18日 23:11 > 收件人: devel@edk2.groups.io > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; > zhiguang@intel.com; ray...@intel.com; zhichao@intel.com; >

[edk2-devel] 回复: [Patch 1/1] BaseTools/VrfCompile: Fix uninitialized field from unnamed field

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2021年11月2日 1:45 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen > 主题: [Patch 1/1] BaseTools/VrfCompile: Fix uninitialized field from unnamed > field > > REF:

回复: [edk2-devel] [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add runtime SetImage support

Bob: Thanks for your detail. PcdRuntimeFmpCapsuleImageTypeIdGuid is edk2 implementation solution. Have you the proposal on how to update UEFI spec to support runtime FMP protocol? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Bob Morgan > via groups.io > 发送时间: 2021年10月30日

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

It's good to me change the default the verify flag. Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vineel > Kovvuri > Sent: Friday, October 15, 2021 8:55 AM > To: Rabeda, Maciej ; Yao, Jiewen > ; jp...@microsoft.com; >

回复: [edk2-devel] 回复: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

Bob: Yes. 'BuildGather' is better. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Bob Morgan > via groups.io > 发送时间: 2021年10月30日 0:02 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: 'Jian J Wang' ; 'Guomin Jiang' > > 主题: Re: [edk2-devel] 回复: [PATCH]

回复: [edk2-devel] [PATCH 0/5] FmpDevicePkg: Add support for runtime FmpDxe driver

Bob: Seemly, there is no other comments for this change. I give my Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2021年10月21日 9:54 > 收件人: devel@edk2.groups.io; b...@nvidia.com > 抄送: michael.d.kin...@intel.com; guomin.ji...@intel.com; >

Re: [edk2-devel] [PATCH v1 00/16] Un-siloing Arm common code

Series: Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bret > Barkelew > Sent: Tuesday, November 2, 2021 3:57 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 00/16] Un-siloing Arm common code > > This series of patch commits moves a

Re: [edk2-devel] [PATCH v1 10/16] StandaloneMmPkg: Switch to the MmuLib abstraction

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bret > Barkelew > Sent: Tuesday, November 2, 2021 3:57 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar > ; Yao, Jiewen ; Supreeth > Venkatesh ; Sean Brogan > > Subject: [edk2-devel]

Re: [edk2-devel] [Patch V2 6/7] SecurityPkg: Reproduce builds across source format changes

Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, November 2, 2021 5:38 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Michael Kubacki > Subject: [Patch V2 6/7] SecurityPkg: Reproduce builds across source format > changes > >

Re: [edk2-devel] [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg to use TdxLib

On Monday, November 1, 2021 11:59 PM, Ma, Maurice wrote: > Minor comment on the subject "PreparePrepare UefiPayloadPkg to use TdxLib". > Duplicated "Prepare" ? Thanks much for the reminder. It will be fixed in the next version. > Otherwise, looks good to me. > > Reviewed-by: Maurice Ma > Thanks

[edk2-devel] [PATCH v2 2/2] ArmPkg: Update SMC calls to use the new ArmCallSmc1/2/3/4 functions

New SMC helper functions have been added to reduce the amount of template code. Update ArmSmcPsciResetSystemLib and Smbios/ProcessorSubClassDxe to use them. Signed-off-by: Rebecca Cran --- ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 10 ++-

[edk2-devel] [PATCH v2 1/2] ArmPkg: Add SMC helper functions

Add functions ArmCallSmc0/1/2/3 to do SMC calls with 0, 1, 2 or 3 arguments. The functions return up to 3 values. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/ArmSmcLib.h | 73 ArmPkg/Library/ArmSmcLib/ArmSmc.c| 122

[edk2-devel] [PATCH v2 0/2] ArmPkg: Add SMC helper functions

To reduce the amount of template code, introduce SMC helper functions. Update ArmSmcPsciResetSystemLib and Universal/Smbios to use them. Changes from v1 to v2: Added a patch to update code to use the new functions. Rebecca Cran (2): ArmPkg: Add SMC helper functions ArmPkg: Update SMC calls

[edk2-devel] [Patch V2 7/7] OvmfPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 6

[edk2-devel] [Patch V2 6/7] SecurityPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Jiewen Yao Cc: Jian J Wang Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- .../Include/Library/TcgStorageCoreLib.h | 26 +-- 1 file changed, 13

[edk2-devel] [Patch V2 4/7] MdeModulePkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Jian J Wang Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c| 2 +-

[edk2-devel] [Patch V2 3/7] ArmPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- .../Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-

[edk2-devel] [Patch V2 5/7] NetworkPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- NetworkPkg/Include/Library/NetLib.h | 8

[edk2-devel] [Patch V2 0/7] Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 New in V2 * Split MdePkg DebugLib class enhancements out into its own commit * Address ECC failures * Align macro continuation marks in same column This change is required to help verify that source code formatting changes

[edk2-devel] [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to support reproduce builds

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 * Add DEBUG_LINE_NUMBER define to DebugLib.h that is by default mapped to __LINE__. A build can define DEBUG_LINE_NUMBER to use a fixed value. * Add DEBUG_EXPRESSION_STRING(Expression) macros to DebugLib.h that is by default mapped

[edk2-devel] [Patch V2 2/7] MdePkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 * Use DEBUG_LINE_NUMBER instead of __LINE__. * Use DEBUG_EXPRESSION_STRING instead of #Expression. Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- MdePkg/Include/Library/UnitTestLib.h | 46

Re: [edk2-devel] [edk2-platforms PATCH] Ext4Pkg: Add uninitialized extents support

Quick PS: I CC'd the edk2-platforms stewards on the patch because there's no co-maintainer, and from what I gathered, that's what I'm supposed to do. If I'm mistaken, please let me know. Thanks, Pedro On Fri, Oct 29, 2021 at 2:04 AM Pedro Falcato via groups.io wrote: > Uninitialized extents

Re: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances

Thanks for looking at the series. I would also like to see the PCDs get consolidated if possible. Regards, Michael On 11/1/2021 4:43 PM, Oram, Isaac W wrote: Series Reviewed-by: Isaac Oram These PCD already exist:

Re: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances

Series Reviewed-by: Isaac Oram These PCD already exist: gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFF80|UINT32|0x1001 gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize|0x0080|UINT32|0x1002

Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

Thanks for pointing that out. This was a mistake in copying/pasting patch subject lines and your plan to extend WhitleyOpenBoardPkg to use IntelSiliconPkg sounds good. If the package names in the commit message can be corrected before pushing that would be great. Thanks, Michael On

Re: [edk2-devel] [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm

Reviewed-by: Isaac Oram -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm

Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

Reviewed-by: Isaac Oram Please note subject/title and message body indicate PurleyOpenBoardPkg, but actual file is located in WhitleyOpenBoardPkg. I don't see any content difference and think it would be better to modify INF to include IntelSiliconPkg/IntelSiliconPkg.dec. I can do this in the

[edk2-devel] [PATCH v1 16/16] ArmPlatformPkg/ArmPlatformPkg.dsc: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v1 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v1 15/16] ArmPkg/ArmPkg.dsc: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/ArmPkg.dsc | 8 1 file changed, 8 insertions(+) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index

[edk2-devel] [PATCH v1 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only

From: Bret Barkelew Drop X64 references. Update GUID. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c | 71

[edk2-devel] [PATCH v1 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/MmuLib/MmuLib.c | 120 ArmPkg/ArmPkg.dsc| 1 +

[edk2-devel] [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v1 09/16] MdeModulePkg: Swap to MmuLib instead of Arm-specific lib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Liming Gao Cc: Sean Brogan Signed-off-by: Bret Barkelew --- MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 4 ++-- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf

[edk2-devel] [PATCH v1 10/16] StandaloneMmPkg: Switch to the MmuLib abstraction

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew ---

[edk2-devel] [PATCH v1 08/16] MdePkg: Create the MMU access lib to abstract memory protection settings

From: Bret Barkelew There are a number of Arm-specific accesses that are abstracted behind this. It may need to be refactored to work better across architectures. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan

[edk2-devel] [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

From: Bret Barkelew Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Signed-off-by: Bret Barkelew --- {ArmPkg => MdePkg}/Include/AsmMacroIoLib.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) diff --git

[edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bob Feng Cc:

[edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3649 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v1 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

From: Bret Barkelew This extra interface is redundant and unnecessary. Dropping it is more EDK2-ish. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/ArmPkg.dec |

[edk2-devel] [PATCH v1 03/16] ArmPkg/StandaloneMmCoreEntryPoint: Swap to ArmMmuLib

From: Bret Barkelew StandaloneMmMmuLib has been turned into an implementation of the ArmMmuLib class. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew ---

[edk2-devel] [PATCH v1 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 37

[edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

From: Bret Barkelew Not sure what all module types this HAS been validated against, but it doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew ---

[edk2-devel] [PATCH v1 00/16] Un-siloing Arm common code

This series of patch commits moves a number of modules and libraries around in order to better un-silo the Arm-specific code. Unnecessary abstractions were removed, some duplicate code was abstracted, and generally things were cleaned up so that common code (e.g. MdePkg, MdeModulePkg,

Re: [edk2-devel] [edk2-libc Patch V4 6/6] AppPkg/Applications/Python: to fix readme files in edk2-libc

Series Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Monday, November 1, 2021 11:35 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Kinney, Michael D > ; Jayaprakash, N > > Subject: [edk2-libc Patch V4 6/6] AppPkg/Applications/Python: to fix

Re: [edk2-devel] [Patch 0/6] Reproduce builds across source format changes

For the series: Tested-by: Michael Kubacki On 11/1/2021 2:29 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 This change is required to help verify that source code formatting changes such as the use of uncrustify and line ending corrections do not have

[edk2-devel] [PATCH v2 1/1] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers

From: Shashi Mallela Setting the Always-on Capability bit in GTDT table for system PE timers in sbsa platform.This is also required for ACS sbsa level 3 test compliancy. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Graeme Gregory Signed-off-by: Shashi Mallela [fixed compilation error]

Re: [edk2-devel] [Patch 2/6] ArmPkg: Reproduce builds across source format changes

On Mon, Nov 01, 2021 at 11:29:38 -0700, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 > > Use DEBUG_LINE_NUMBER instead of __LINE__. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Michael Kubacki > Signed-off-by: Michael D Kinney Reviewed-by: Leif

Re: [edk2-devel] [Patch 1/6] MdePkg: Reproduce builds across source format changes

On Mon, Nov 01, 2021 at 11:29:37 -0700, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 > > * Add DEBUG_LINE_NUMBER define to DebugLib.h that is > by default mapped to __LINE__. A build can pre-define > DEBUG_LINE_NUMBER to use a fixed value. > * Add

Re: [edk2-devel] [edk2-libc Patch v3 5/5] AppPkg/Applications/Python: to update readme files in edk2-libc

Hi Mike, Submitted the updated PR. Regards, JP -Original Message- From: Jayaprakash, N Sent: 02 November 2021 00:01 To: Kinney, Michael D ; devel@edk2.groups.io Cc: Rebecca Cran Subject: RE: [edk2-libc Patch v3 5/5] AppPkg/Applications/Python: to update readme files in edk2-libc Hi

[edk2-devel] [edk2-libc Patch V4 1/6] AppPkg/Applications/Python: To remove the py2.7.2 uefi port code

-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83022): https://edk2.groups.io/g/devel/message/83022 Mute This Topic: https://groups.io/mt/86748855/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [edk2-libc Patch V4 6/6] AppPkg/Applications/Python: to fix readme files in edk2-libc

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589 This commit is to update remaining references to py 2.7.10 in StdLib/Readme.txt and StdLibPrivateInternalFiles/ReadMe.txt documents to py3.6.8. Cc: Rebecca Cran Cc: Michael D Kinney Signed-off-by: Jayaprakash N --- StdLib/ReadMe.txt

[edk2-devel] [edk2-libc Patch V4 5/6] AppPkg/Applications/Python: to update readme files in edk2-libc

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589 This commit is to update references to py 2.7.10 in StdLib/Readme.txt and StdLibPrivateInternalFiles/ReadMe.txt documents to py3.6.8. Cc: Rebecca Cran Cc: Michael D Kinney Signed-off-by: Jayaprakash N --- StdLib/ReadMe.txt

[edk2-devel] [edk2-libc Patch V4 4/6] AppPkg/Applications/Python: to remove py2.7.10 references from edk2-libc

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589 This commit is to remove the document references to py 2.7.10 UEFI port. Py2.7.10 is no more supported as it has reached EOL starting from 1st Jan 2020. You may use the version py 3.6.8 available for uefi shell from edk2-libc. Cc: Rebecca

[edk2-devel] [edk2-libc Patch V4 2/6] AppPkg/Applications/Python: to remove document references to py2.7.2

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589 This commit is to remove references to the py 2.7.2 UEFI port in all documents from edk2-libc repo. This python interpreter is no more supported on UEFI shell due to availability of py 3.6.8 on UEFI. Cc: Rebecca Cran Cc: Michael D Kinney

[edk2-devel] [edk2-libc Patch V4 3/6] AppPkg/Applications/Python: to remove py2.7.10 support from edk2-libc

-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83017): https://edk2.groups.io/g/devel/message/83017 Mute This Topic: https://groups.io/mt/86748823/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2 1/1] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers

On Mon, Nov 01, 2021 at 18:54:57 +0100, Marcin Juszkiewicz wrote: > From: Shashi Mallela > > Setting the Always-on Capability bit in GTDT table for > system PE timers in sbsa platform.This is also required > for ACS sbsa level 3 test compliancy. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel >

Re: [edk2-devel] [edk2-libc Patch v3 5/5] AppPkg/Applications/Python: to update readme files in edk2-libc

Hi Mike, I didn’t notice this. Will send an updated patch. Sorry for the inconvenience. Regards, JP -Original Message- From: Kinney, Michael D Sent: 01 November 2021 21:59 To: Jayaprakash, N ; devel@edk2.groups.io; Kinney, Michael D Cc: Rebecca Cran Subject: RE: [edk2-libc Patch

[edk2-devel] [Patch 4/6] NetworkPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- NetworkPkg/Include/Library/NetLib.h | 8

[edk2-devel] [Patch 2/6] ArmPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- .../Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-

[edk2-devel] [Patch 1/6] MdePkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 * Add DEBUG_LINE_NUMBER define to DebugLib.h that is by default mapped to __LINE__. A build can pre-define DEBUG_LINE_NUMBER to use a fixed value. * Add DEBUG_EXPRESSION_STRING(Expression) macrso to DebugLib.h that is by default

[edk2-devel] [Patch 3/6] MdeModulePkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Jian J Wang Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c| 2 +-

[edk2-devel] [Patch 0/6] Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 This change is required to help verify that source code formatting changes such as the use of uncrustify and line ending corrections do not have any functional differences. Source format changes may add or remove line endings that change

[edk2-devel] [Patch 6/6] OvmfPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 6

[edk2-devel] [Patch 5/6] SecurityPkg: Reproduce builds across source format changes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Jiewen Yao Cc: Jian J Wang Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- SecurityPkg/Include/Library/TcgStorageCoreLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [Patch 1/1] BaseTools/VrfCompile: Fix uninitialized field from unnamed field

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3687 If a C structure parsed by the VFR compiler contains an unnamed field, then mFieldName is left uninitialized, which generates random data in the VFR compiler output file. If the FieldName is NULL, then initialize pNewField->mFieldName to a

Re: [edk2-devel] [PATCH] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers

Hi Shashi, The build fails after applying this patch. Please resubmit after you have fixed *and* tested it. / Leif On Wed, Oct 27, 2021 at 21:07:56 -0400, Shashi Mallela wrote: > Setting the Always-on Capability bit in GTDT table for > system PE timers in sbsa platform.This is also required

Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

On Thu, Oct 28, 2021 at 09:53:34 +0900, Masami Hiramatsu wrote: > Hi Leif, > > Thank you for your reply! > > 2021年10月27日(水) 20:21 Leif Lindholm : > > > > Hi Masami, > > > > Apologies for delay. > > > > Thank you, this set looks good. > > However, you cannot make legal statements on behalf of

Re: [edk2-devel] [edk2-libc Patch v3 5/5] AppPkg/Applications/Python: to update readme files in edk2-libc

Hi JP, The updates to these 2 ReadMe.txt files is not complete and do not match the updated to AppPkg/ReadMe.txt. There is an additional paragraph with Python 2.x references. Mike > -Original Message- > From: Jayaprakash, N > Sent: Saturday, October 30, 2021 6:53 AM > To:

Re: [edk2-devel] [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg to use TdxLib

Minor comment on the subject "PreparePrepare UefiPayloadPkg to use TdxLib". Duplicated "Prepare" ? Otherwise, looks good to me. Reviewed-by: Maurice Ma > -Original Message- > From: Xu, Min M > Sent: Monday, November 1, 2021 6:16 > To: devel@edk2.groups.io > Cc: Xu, Min M ; Dong,

Re: [edk2-devel] [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg to use TdxLib

Reviewed-by: Guo Dong -Original Message- From: Xu, Min M Sent: Monday, November 1, 2021 6:16 AM To: devel@edk2.groups.io Cc: Xu, Min M ; Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Yao, Jiewen ; Gerd Hoffmann Subject: [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare

Re: [edk2-devel] [PATCH edk2 v1 0/3] Fix several issues in StanaloneMmPkg

Hi, Any comments about this series? On 10/15/21 5:06 PM, Ming Huang wrote: > Fix issues in StandaloneMmPkg for supporting communicate from > TF-A with secure buffer. > > Ming Huang (3): > StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field > StandaloneMmPkg: Replace DEBUG_INFO with

Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

Great. It seems we are all aligned. > -Original Message- > From: Sami Mujawar > Sent: Monday, November 1, 2021 9:55 PM > To: Yao, Jiewen ; Tom Lendacky > ; Brijesh Singh ; > kra...@redhat.com; Xu, Min M > Cc: devel@edk2.groups.io; Erdem Aktas ; James > Bottomley ; Dong, Eric ; Ni, Ray >

Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

Hi Jiewen, I agree using CC as in (EFI_CC_MEASUREMENT_PROTOCOL) would be much clearer. Regards, Sami Mujawar On 29/10/2021, 01:17, "Yao, Jiewen" wrote: I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO) Samy What do you

Re: [edk2-devel] [PATCH V2 2/3] SecurityPkg: Support TdProtocol in DxeTpm2MeasureBootLib

Hi Min, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On Tue, Oct 26, 2021 at 10:19 PM, Min Xu wrote: > > >> >>> + if (TdProtocol != NULL) { >>> + TdEvent = CreateTdEventFromTcg2Event (TdProtocol, Tcg2Event, >> >> EventSize); >> >>> + if (TdEvent == NULL) { >>> +

[edk2-devel] [PATCH V3 12/29] UefiCpuPkg: Define ConfidentialComputingGuestAttr

From: "Brijesh Singh via groups.io" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 While initializing APs, the MpInitLib may need to know whether the guest is running with active AMD SEV or Intel TDX memory encryption. Add a new ConfidentialComputingGuestAttr PCD that can be used to

[edk2-devel] [PATCH V3 11/29] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed directly from/to CPU. Some should be accessed via explicit requests from the host VMM using TDCALL(TDG.VP.VMCALL). This is done by the help of TdxLib. Please refer to

[edk2-devel] [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg to use TdxLib

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TdxLib is included in BaseXApicX2ApicLib. To prevent any build breakage, update the UefiPayloadPkg.dsc to include the TdxLib library. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Jiewen Yao Cc: Gerd Hoffmann

[edk2-devel] [PATCH V3 09/29] MdePkg: Support IoRead/IoWrite for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 This commit supports IoRead/IoWrite for SEV/TDX/Legacy guest in one binary. It checks the guest type in runtime and then call corresponding functions. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Brijesh Singh Cc: Erdem

[edk2-devel] [PATCH V3 06/29] MdePkg: Add helper functions for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel TDX architecture does not prescribe a specific software convention to perform I/O from the guest TD. Guest TD providers have many choices to provide I/O to the guest. The common I/O models are emulated devices, para-virtualized

[edk2-devel] [PATCH V3 05/29] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Add base support to handle #VE exceptions. Update the common exception handlers to invoke the VmTdExitHandleVe () function of the VmgExitLib library when a #VE is encountered. A non-zero return code will propagate to the targeted exception

[edk2-devel] [PATCH V3 08/29] MdePkg: Support IoFifo for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Previously IoFifo functions are in X64/IoFifoSev.nasm which supports both SEV guest and Legacy guest. IoLibFifo.c is introduced to support SEV/TDX/Legacy guest in one binary. It checks the guest type in runtime and call corresponding

[edk2-devel] [PATCH V3 01/29] MdePkg: Add Tdx.h

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx.h includes the Intel Trust Domain Extension definitions. Detailed information can be found in below document: https://software.intel.com/content/dam/develop/external/us/en/ documents/tdx-module-1eas-v0.85.039.pdf Cc: Michael D Kinney

[edk2-devel] [PATCH V3 07/29] MdePkg: Support mmio for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TDVF access MMIO with TDG.VP.VMCALL to invoke VMM provided emulation functions. If the access to MMIO fails, it fall backs to the direct access. BaseIoLibIntrinsic.inf is the IoLib used by other packages. It will not support I/O in Td

[edk2-devel] [PATCH V3 03/29] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception

RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 VmgExitLib performs the necessary processing to handle a #VC exception. VmgExitLibNull is a NULL instance of VmgExitLib which provides a default limited interface. In this commit VmgExitLibNull is extended to handle a #VE exception with a

  1   2   >