Hi, Gerd
> > +MmioExit (
> > + IN OUT EFI_SYSTEM_CONTEXT_X64 *Regs,
> > + IN TDCALL_VEINFO_RETURN_DATA *Veinfo
> > + )
> > +{
>
> > + do {
> > +OpCode = *Rip++;
> > +if (OpCode == 0x66) {
> > + OpSize = 2;
>
> Oh, wow. So the VE exit data doesn't provide the
When CET shadow stack feature is enabled, it needs to use IST for the
exceptions, and uses interrupt shadow stack for the stack switch.
Shadow stack should be 32 bytes aligned.
Check IST field, when clear shadow stack token busy bit when using retf.
REF:
On November 2, 2021 10:07 PM, Gerd Hoffmann wrote:
> Hi,
>
> > +UINT64 mTdSharedPageMask = 0;
> > +UINT32 mTdMaxVCpuNum = 0;
> > +UINT32 mTdVCpuNum= 0;
>
> > +UINT64
> > +EFIAPI
> > +TdSharedPageMask (
> > + VOID
> > + )
> > +{
> > + UINT64 Status;
> > +
Hi All,
I have update the patch for the comments, Please help review the patch.
-Original Message-
From: Jiang, Xiaolu
Sent: Monday, November 8, 2021 4:22 PM
To: devel@edk2.groups.io
Cc: Jiang, Xiaolu ; Feng, Bob C ;
Liming Gao ; Chen, Christine
Subject: [edk2-devel][PATCH]
Pushed via:
PR - https://github.com/tianocore/edk2/pull/2192
Commit -
https://github.com/tianocore/edk2/commit/a7b35aae13b2d69b9be68874f275f511b1367a5e
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Monday, November 8, 2021 4:12
Hi Rebecca,
Yes. They are useful. I would be better if it could be a CI job on either
Azure pipelines
or GitHub Actions could run the tool and publish the documents in TianoCore.
Perhaps an on
demand job against a specific tag.
Mike
> -Original Message-
> From: devel@edk2.groups.io
Reviewed-by: Rebecca Cran
On 11/8/21 9:53 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3724
Add typecast to fix build error with VS2019 X64 NOOPT converting
a UINT64 value to UINT32 value.
Cc: Rebecca Cran
Cc: Peter Grehan
Signed-off-by: Michael D Kinney
On November 8, 2021 10:18 PM, Sami Mujawar wrote:
> Hi Min,
>
> Thank you for the updated patch.
>
> I have a minor suggestion marked inline as [SAMI]. Otherwise, these changes
> look good to me.
>
> Reviewed-by: Sami Mujawar
>
> > + @retval EFI_SUCCESS Operation completed
On Tue, Nov 09, 2021 at 21:20:51 +, Michael D Kinney wrote:
> > > Setting up a development work environment also requires the installation
> > > of tools such as
> > > compilers, NASM, IASL, etc. These are not handled as part of BaseTools
> > > today.
> >
> > No, but users are not required
I've been hosting the Doxygen documentation for EDK2 at
https://bsdio.com/edk2/docs for a few years now. I previously had
versions for master, UDK2015, UDK2017, UDK2018 etc. but since migrating
my web server dropped everything except master.
I was wondering if people are finding it useful,
Sounds good, thanks for your help Liming. I am not familiar with the spec
update processes, so please let me know what other steps I should take.
To clarify the standard method to know whether the FMP protocol supports
runtime capsule processing is:
a) Runtime capsule processing by FMP is
Leif,
Comments below.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif Lindholm
> Sent: Tuesday, November 9, 2021 12:56 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Marvin Häuser ; Andrew Fish ;
> Michael Kubacki ;
> mikub...@linux.microsoft.com;
Hi Mike,
On Tue, Nov 09, 2021 at 16:33:31 +, Michael D Kinney wrote:
> > >> 1. If virtually everyone will need Uncrustify, why cannot it be built
> > >> along with BaseTools from a submodule? Especially
> > >> with the fork that makes sense, after that it depends on the upstream
> > >> (it
> On Nov 9, 2021, at 10:26 AM, Kinney, Michael D
> wrote:
>
> Andrew,
>
> Agree that we want it to be very simple and walk up and use.
>
> There is no requirement to use Visual Studio Code.
>
> There are multiple ways available for use by developers
> Visual Studio Code plugin.
> Run
> On Nov 9, 2021, at 10:39 AM, Michael D Kinney
> wrote:
>
> Hi Andrew,
>
> It looks like the EDK II CI agents were updated to use NASM 2.15.05 back in
> March of this year.
>
>
>
Hi Andrew,
It looks like the EDK II CI agents were updated to use NASM 2.15.05 back in
March of this year.
https://github.com/tianocore/edk2/blob/0ecdcb6142037dd1cdd08660a2349960bcf0270a/BaseTools/Bin/nasm_ext_dep.yaml
So I think the only remaining task is to update the developer
Andrew,
Agree that we want it to be very simple and walk up and use.
There is no requirement to use Visual Studio Code.
There are multiple ways available for use by developers
1. Visual Studio Code plugin.
2. Run uncrustify tool from command line.
3. Implement a githook that
Mike,
My main concern is there is an easy path for the developers. I don’t want to
have developers have to learn new development technologies just to run a
“required” tool. I’m not as concerned on how we do it. Hosting binaries from a
webpage that auto picks what to download would be fine with
Hi Marvin,
> -Original Message-
> From: Marvin Häuser
> Sent: Tuesday, November 9, 2021 8:13 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Andrew Fish ; Michael Kubacki
> ; Leif Lindholm ;
> mikub...@linux.microsoft.com; rebe...@nuviainc.com; Bret Barkelew
>
> Subject: Re:
Hey Mike,
On 09.11.21 16:43, Kinney, Michael D wrote:
Hi Marvin,
Comments below.
Mike
-Original Message-
From: devel@edk2.groups.io On Behalf Of Marvin Häuser
Sent: Monday, November 8, 2021 11:33 PM
To: Kinney, Michael D
Cc: Andrew Fish ; devel@edk2.groups.io; Michael Kubacki
;
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann
> Sent: Tuesday, November 9, 2021 6:10 AM
> To: Leif Lindholm
> Cc: devel@edk2.groups.io; Kinney, Michael D ;
> Andrew Fish ; Marvin Häuser
> ; Michael Kubacki ;
> mikub...@linux.microsoft.com;
Hi Marvin,
Comments below.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Marvin Häuser
> Sent: Monday, November 8, 2021 11:33 PM
> To: Kinney, Michael D
> Cc: Andrew Fish ; devel@edk2.groups.io; Michael Kubacki
> ; Leif Lindholm
> ; mikub...@linux.microsoft.com;
In BaseConfigBlockLib add function to get next config block from config blocks
table in order to iterate over blocks of the same type.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3700
Signed-off-by: Jakub Fedorowicz mailto:jakub.fedorow...@intel.com
Cc: Ray Ni mailto:ray...@intel.com
The patch set looks good to me.
Reviewed-by: Sunil V L
On Tue, Oct 19, 2021 at 04:09:37PM +0800, Abner Chang wrote:
> This is the patch set to incorporate opensbi v0.9 with edk2
> RISC-V port. There are many architecture changes to compliant
> with the RISC-V SBI implementation (opensbi) and
On Tue, Nov 09, 2021 at 12:36:30PM +, Leif Lindholm wrote:
> On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote:
> > Hi,
> >
> > > 3. Require use of uncrustify tool before submitting patch review
> > > emails or PRs.
> > > * The required version would be a formally
Liming,
* Uncrustify will not be run on any submodules.
* Uncrustify will not be run on BaseTools.
* The focus is firmware sources.
* We would like to look for opportunities to convert BaseTools C
components to Python. We already have specs/tools to format Python sources.
Submodule within which repo? What would be the proposed location?
Would a fork of uncrustify maintained as a repo under TianoCore work as well?
There are CI checks (including extensive unit tests) and release generation
that are built into uncrustify repo and I do not know if those will be
Main Changes :
1.add support for PEM-encoded certificate.
Wenyi Xie (1):
CryptoPkg/BaseCryptLib: Support PEM certification
CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 33 ++--
1 file changed, 31 insertions(+), 2 deletions(-)
--
2.20.1.windows.1
As PEM-encoded certificate is also necessary, add
support for PEM-encoded certificate in
X509ConstructCertificate.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Jiaxia Xu
Signed-off-by: Wenyi Xie
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 33
On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote:
> Hi,
>
> > 3. Require use of uncrustify tool before submitting patch review emails
> > or PRs.
> > * The required version would be a formally released version from
> > the fork maintained by Michael Kubacki until the
On Tue, 9 Nov 2021 at 12:57, Leif Lindholm wrote:
>
> On Mon, Nov 08, 2021 at 18:56:09 -0700, Rebecca Cran wrote:
> > Could I have some reviews on this please?
>
> I'm all for it. It's clunky, but less clunky than the situation
> without, and it improves readability at call sites.
>
> Ard had
Reviewed-by: Eric Dong
-Original Message-
From: Ni, Ray
Sent: Tuesday, October 19, 2021 2:42 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul1
Subject: [PATCH] UefiCpuPkg/UefiCpuLib: Add GetCpuFamilyModel and
GetCpuSteppingId
REF:
On Mon, Nov 08, 2021 at 18:56:09 -0700, Rebecca Cran wrote:
> Could I have some reviews on this please?
I'm all for it. It's clunky, but less clunky than the situation
without, and it improves readability at call sites.
Ard had some reservations for v1 not actually adding any users.
Ard - do you
On 09/11/2021 08:40, Gerd Hoffmann wrote:
3. Require use of uncrustify tool before submitting patch review emails or
PRs.
* The required version would be a formally released version from the
fork maintained by Michael Kubacki until the changes can be upstreamed.
*
> 2. Remove unnecessary algo in openssl config
> * Do you really want to enable all those algorithms? Such as SM2?
> Maybe revisit them again to see if they are really needed. I could see it
> might break other platform potentially.
Enabling only those algorithms which are actually
On 11/3/21 16:06, Gerd Hoffmann wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599
> Signed-off-by: Gerd Hoffmann
> Acked-by: Jiewen Yao
> ---
> OvmfPkg/Microvm/README | 50 ++
> 1 file changed, 50 insertions(+)
> create mode 100644
Hi,
> * OvmfPkg_Win_VS2019 - Passed
> * OvmfPkg_Ubuntu_GCC5 – Failed
> * INFO - GenFv: ERROR 3000: Invalid
> * INFO - the required fv image size 0xcb2ac0 exceeds the set fv image size
> 0xc0
Wow. That is a quite significant increase.
Is this the OVMF_IA32X64_FULL_NOOPT build?
That
On 11/3/21 16:06, Gerd Hoffmann wrote:
> FdtClient is unhappy without a device tree, so add an empty fdt
> which we can use in case etc/fdt is not present in fw_cfg.
>
> On ARM machines a device tree is mandatory for hardware detection,
> thats why FdtClient fails hard.
>
> On microvm the device
On 10/28/21 13:09, Gerd Hoffmann wrote:
> Rename TPM_ENABLE to TPM2_ENABLE so naming is in line with the
> ArmVirtPkg config option name.
>
> Add separate TPM1_ENABLE option for TPM 1.2 support.
>
> Signed-off-by: Gerd Hoffmann
> Tested-by: Stefan Berger
> ---
>
On 10/28/21 13:09, Gerd Hoffmann wrote:
> Drop TPM_CONFIG_ENABLE config option. Including TPM support in the
> build without also including the TPM configuration menu is not useful.
>
> Suggested-by: Stefan Berger
> Signed-off-by: Gerd Hoffmann
> Tested-by: Stefan Berger
> ---
>
On 10/28/21 13:09, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/Microvm/MicrovmX64.dsc | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daude
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
On 10/28/21 13:09, Gerd Hoffmann wrote:
> Split Tcg2ConfigPei.inf into two variants: Tcg12ConfigPei.inf with
> TPM 1.2 support included and Tcg2ConfigPei.inf supporting TPM 2.0 only.
> This allows x86 builds to choose whenever TPM 1.2 support should be
> included or not by picking the one or the
Hi,
> 3. Require use of uncrustify tool before submitting patch review emails or
> PRs.
> * The required version would be a formally released version from the
> fork maintained by Michael Kubacki until the changes can be upstreamed.
> *
Some options for your consideration.
1. Enlarge OVMF size
* I have seen discussion to 8M to 16M, but it seems not concluded.
2. Remove unnecessary algo in openssl config
* Do you really want to enable all those algorithms? Such as SM2? Maybe
revisit them again to see if they
44 matches
Mail list logo
