Re: [edk2-devel] [PATCH v3] IntelSiliconPkg/BaseConfigBlockLib: Add function to iterate over Config Blocks

2021-11-24 Thread Ni, Ray
+EFI_STATUS +EFIAPI +GetNextConfigBlock ( + IN VOID *ConfigBlockTableAddress, + IN VOID *ConfigBlockAddress, + OUTVOID **NextConfigBlockAddress + ) How about using following prototype? CONFIG_BLOCK * GetNextConfigBlock ( IN CONFIG_BLOCK_TABLE_HEADER *ConfigBlockTa

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/UhciDxe: Fix the UsbHc memory allocate and free issue

2021-11-24 Thread Wu, Hao A
Thanks for the fix. Reviewed-by: Hao A Wu Will hold the merging of the patch after the upcoming edk2-stable202111 tag. Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of 张家定 Sent: Thursday, November 25, 2021 11:20 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] MdeModulePkg

[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/UhciDxe: Fix the UsbHc memory allocate and free issue

2021-11-24 Thread 张家定
When use the UsbHcAllocMemFromBlock() and UsbHcFreeMem() to allocate memory and free memory for the UHC, it should use the corresponding host address but not the pci bus address. Signed-off-by: jdzhang --- MdeModulePkg/Bus/Pci/UhciDxe/UsbHcMem.c | 8 1 file changed, 4 insertions

[edk2-devel] Build.py Tools Code Failure

2021-11-24 Thread Iversen, Stephen
Hello, I obtained the following error when trying to build a BIOS image. Traceback (most recent call last): File "/workarea/Edk2/BaseTools/Source/Python/GenFds/GenFds.py", line 371, in GenFdsApi GenFds.GenFd('', FdfParserObj, BuildWorkSpace, ArchList) File "/workarea/Edk2/BaseTools/Sourc

[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/UhciDxe: Fix the UsbHc memory allocate and free issue

2021-11-24 Thread 张家定
When use the UsbHcAllocMemFromBlock() and UsbHcFreeMem() to allocate memory and free memory for the UHC, it should use the corresponding host address but not the pci bus address. Signed-off-by: jdzhang --- MdeModulePkg/Bus/Pci/UhciDxe/UsbHcMem.c | 8 1 file changed, 4 insertions(+), 4 d

Re: [edk2-devel] [Patch edk2-stable202111] NetworkPkg: Fix invalid pointer for DNS response token on error

2021-11-24 Thread Michael D Kinney
Hi Liming, I agree it is both low risk and prevents an ASSERT() condition that should never be triggered. I approve for edk2-stable202111 Mike From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Wednesday, November 24, 2021 5:53 PM To: devel@edk2.groups.io; Wu, Jiaxin ; Anbazhagan, Baran

[edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #1

2021-11-24 Thread Michael D Kinney
Hello, Michael Kubacki and I have prepared the patches required to apply the uncrustify changes and enable EDK II CI to check all submitted patches have been run through uncrustify. We have verified through the CompareBuild GitHub Action that the format changes performed by uncrustify have no fu

回复: [edk2-devel] [Patch edk2-stable202111] NetworkPkg: Fix invalid pointer for DNS response token on error

2021-11-24 Thread gaoliming
I suggest to merge this fix for the stable tag 202111. This fix is low risk. Thanks Liming 发件人: devel@edk2.groups.io 代表 Wu, Jiaxin 发送时间: 2021年11月25日 9:37 收件人: Anbazhagan, Baraneedharan ; devel@edk2.groups.io 抄送: maciej.rab...@linux.intel.com; Fu, Siyuan 主题: Re: [edk2-devel] NetworkPkg: Fix

Re: [edk2-devel] NetworkPkg: Fix invalid pointer for DNS response token on error

2021-11-24 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin From: Anbazhagan, Baraneedharan Sent: Thursday, November 25, 2021 9:28 AM To: devel@edk2.groups.io Cc: maciej.rab...@linux.intel.com; Wu, Jiaxin ; Fu, Siyuan Subject: RE: NetworkPkg: Fix invalid pointer for DNS response token on error Ref: https://bugzilla.tianocore.o

Re: [edk2-devel] NetworkPkg: Fix invalid pointer for DNS response token on error

2021-11-24 Thread Anbazhagan, Baraneedharan via groups.io
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3719 Token->RspData.H2AData is de-allocated on error but it is not set to NULL. HTTP module attempts to free again and cause assert. Signed-off-by: Baraneedharan Anbazhagan anbazha...@hp.com --- NetworkPkg/DnsDxe/DnsIm

[edk2-devel] [PATCH v5 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3748 Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance of source code to the EDK II C Coding Standards Specification. An external dependency is added in the plugin directory to retrieve

Re: [edk2-devel] [PATCH v4 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael Kubacki
Hi Mike, How about I quickly send a v5 with the lines commented out and follow up with a patch to uncomment them that we can review but merge when ready? Thanks, Michael On 11/24/2021 7:16 PM, Michael D Kinney wrote: The 2nd option I listed won't work. That will fail UncrustifyCheck as well

Re: [edk2-devel] [PATCH v4 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael D Kinney
The 2nd option I listed won't work. That will fail UncrustifyCheck as well because EDK II CI will insert missing file/function headers and the files will not match. We will need to comment out these 2 lines and submit an extra commit to re-enable. Mike > -Original Message- > From: Kin

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS

2021-11-24 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, November 24, 2021 1:26 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray ; Michael > Kubacki > Subject: [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS > > REF: https://bugzilla.tianocore.o

Re: [edk2-devel] [PATCH v4 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael D Kinney
Hi Michael, Unfortunately, enabling the templates in the uncrustify.cfg files modifies 340 files with missing file/function headers that will now fail UncrustifyCheck. cmt_insert_file_header = default_file_header.txt cmt_insert_func_header = default_function_header

Re: [edk2-devel] [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Sami Mujawar > Sent: Wednesday, November 24, 2021 2:55 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Supreeth Venkatesh > ; Sean Brogan ; Bret > Barkelew ; Liming > Gao ; Michael K

Re: [edk2-devel] [PATCH v4 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael D Kinney
Thanks. That makes sense. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Wednesday, November 24, 2021 2:55 PM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Liming Gao ; Sean Brogan > ; Bret Barkelew > > Subject: Re: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH v4 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael Kubacki
Yes. Those were redundant and detected by the Python configparser module when I used it to parse the config file. Thanks, Michael On 11/24/2021 5:45 PM, Michael D Kinney wrote: Hi Michael, I see a couple settings deleted from the uncrustify.cfg. Was that in purpose? Does it change the form

Re: [edk2-devel] CdePkgBlog 2021-11-14

2021-11-24 Thread Pedro Falcato
Hi Kilian, I agree with Maciej. There should be a big emphasis on getting an *open-source* libc available in EDK2, and not relying on a proprietary, opaque binary blob. In my opinion EDK2 should pivot to using a high-quality, license-compatible libc such as Newlib, musl, etc. If you believe your

Re: [edk2-devel] [PATCH v4 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael D Kinney
Hi Michael, I see a couple settings deleted from the uncrustify.cfg. Was that in purpose? Does it change the format? -nl_func_call_start_multi_line = true # Whether to add a newline after '(' in a function call if '(' and ')' are -# in diffe

[edk2-devel] [PATCH v4 1/1] .pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin

2021-11-24 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3748 Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance of source code to the EDK II C Coding Standards Specification. An external dependency is added in the plugin directory to retrieve

Re: [edk2-devel] CdePkgBlog 2021-11-14

2021-11-24 Thread Kilian Kegel
Hi Maciej, CdePkg is already integrated into EDK2 and satisfies all your needs for pre-/post-memory PEI, DXE, (SMM in latest releases only), BDS and UEFI Shell too. I have introduced CdePkg for POST usage 2 years ago without any interest of the “Tianocore Community”: https://edk2.groups.io/g/de

Re: [edk2-devel] [PATCH edk2-platforms v1 00/10] Fix Arm platforms CI errors

2021-11-24 Thread Chris Jones
This patch series looks good to me. Reviewed-by: Chris Jones Thanks, Chris -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84056): https://edk2.groups.io/g/devel/message/84056 Mute This Topic: https://groups.io/mt/87284484/21656 Group O

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze

2021-11-24 Thread Michael D Kinney
Hello, Quick update on the CompareBuild failures with EmulatorPkg VS2019 IA32/X64. It was pilot error running comparison against the incorrect git reference. PR #1 (Update EmulatorPkg Win Host [BuildOptions] MSFT CC_FLAGS to not force debug information) is required for both runs to do the compar

[edk2-devel] [PATCH edk2-platforms v1 10/10] Platform/ARM: Fix Ecc error 5005

2021-11-24 Thread PierreGondois
From: Pierre Gondois This patch fixes the following Ecc reported error: The body of a function should be contained by open and close braces that must be in the first column. Signed-off-by: Pierre Gondois --- .../ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c| 3 ++- 1 file changed

[edk2-devel] [PATCH edk2-platforms v1 09/10] Platform/ARM: Fix Ecc error 9005

2021-11-24 Thread PierreGondois
From: Pierre Gondois This patch fixes the following Ecc reported error: Only Doxygen commands '@bug', '@todo', '@example', '@file', '@attention', '@param', '@post', '@pre', '@retval', '@return', '@sa', '@since', '@test', '@note', '@par', '@endcode', '@code', '@{', '@}' are allowed to mark the cod

[edk2-devel] [PATCH edk2-platforms v1 04/10] Platform/ARM: Modify duplicated GUID in ArmVExpressPkg.dec

2021-11-24 Thread PierreGondois
From: Pierre Gondois The two following packages have the same GUID: - Platform/ARM/VExpressPkg/ArmVExpressPkg.dec - edk2/ArmPlatformPkg/ArmPlatformPkg.dec The gArmVExpressTokenSpaceGuid in Platform/ARM/VExpressPkg/ArmVExpressPkg.dec is also identical. All the GUIDs have been added at the same t

[edk2-devel] [PATCH edk2-platforms v1 08/10] Platform/ARM: Fix Ecc error 3003

2021-11-24 Thread PierreGondois
From: Pierre Gondois This patch fixes the following Ecc reported error: A comparison of any pointer to zero must be done via the NULL type Signed-off-by: Pierre Gondois --- Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 4 ++-- .../ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132Ata

[edk2-devel] [PATCH edk2-platforms v1 07/10] Platform/ARM: Fix Ecc error 1012

2021-11-24 Thread PierreGondois
From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no trailing white space in one line. Signed-off-by: Pierre Gondois --- Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform

[edk2-devel] [PATCH edk2-platforms v1 06/10] Platform/ARM: Fix Ecc error 1008

2021-11-24 Thread PierreGondois
From: Pierre Gondois This patch fixes the following Ecc reported error: File has invalid Non-ACSII char. Signed-off-by: Pierre Gondois --- .../Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Platform/ARM/SgiPkg/D

[edk2-devel] [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001

2021-11-24 Thread PierreGondois
From: Pierre Gondois This patch fixes the following Ecc reported error: 'TAB' character is not allowed in source code, please replace each 'TAB' with two spaces. The patch also format and document the InstallStructures function to comply to edk2 coding style. Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-11-24 Thread PierreGondois
From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLibSec.inf - Silicon/Hisilicon/Library/ ArmPlatformLibHisilicon/ArmPlatformLibSec.inf The inf file in the Platform/ARM/ folder is based on the one in Silicon/H

[edk2-devel] [PATCH edk2-platforms v1 02/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLib

2021-11-24 Thread PierreGondois
From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLib.inf - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibCTA15-A7/ArmVExpressLib.inf Both files were imported at the same time. Modify the GUID of the ArmVExp

[edk2-devel] [PATCH edk2-platforms v1 00/10] Fix Arm platforms CI errors

2021-11-24 Thread PierreGondois
From: Pierre Gondois Running the edk2 CI locally raised some warnings. Fix them. The patches also aim to enable a CI for the edk2-platforms repository. The changes can be seen at:https://github.com/PierreARM/edk2-platforms/tree/1957_Fix_Arm_platforms_CI_errors_v1 Pierre Gondois (10): Platfor

[edk2-devel] [PATCH edk2-platforms v1 01/10] Platform/ARM: Modify duplicated GUID in PciHostBridgeLib

2021-11-24 Thread PierreGondois
From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/Morello/Library/PciHostBridgeLib/ PciHostBridgeLibFvp.inf - Platform/ARM/SgiPkg/Library/PciHostBridgeLib/ PciHostBridgeLib.inf The module in the SgiPkg was created first. Update the GUID of the module in the Mo

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-24 Thread Yao, Jiewen
One more clarification: My comment below is only applicable for the TDVF platform, but not applicable to a general platform including OVMF. In TDVF, Feature X* is a very small set, but in OVMF or general platform, Feature X* is a large set. For example, if a platform need support S3 resume, Rec

回复: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

2021-11-24 Thread gaoliming
Xiaolu: BaseTools C source can directly use std libc API. You can use strlen() to get the length of the input ascii string. With this change, Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Xiaolu.Jiang > 发送时间: 2021年11月16日 9:42 > 收件人: devel@edk2.groups

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-24 Thread Yao, Jiewen
OK. Got it. Let me explain it in more detail. Let's assume PEI phase include 3 major classes {PEI Core, PEI Arch PEM*, Feature X*}. * means 0~multiple. To all of us what really matter is Feature X, the existence of PEI Core + PEI Arch PEIM* is to support Feature X*. From architecture perspectiv

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-24 Thread James Bottomley
On Wed, 2021-11-24 at 14:03 +, Yao, Jiewen wrote: > James > I am sorry that it is hard for me to understand your point. > > To be honest, I am not sure what is objective on the discussion. > Are you question the general threat model analysis on UEFI PI > architecture? The object is for me to

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-24 Thread James Bottomley
On Wed, 2021-11-24 at 11:08 +, Yao, Jiewen wrote: > > -Original Message- > > From: Gerd Hoffmann [...] > > There isn't much external input to process in PEI phase. Virtual > > machines are a bit different than physical machines. They need to > > process some input from the host here

Re: [edk2-devel] [PATCH v2 2/8] ArmPkg: PCD to select conduit for monitor calls

2021-11-24 Thread Leif Lindholm
On Wed, Nov 24, 2021 at 14:07:22 +0100, Ard Biesheuvel wrote: > On Wed, 24 Nov 2021 at 14:05, Leif Lindholm wrote: > > > > On Wed, Nov 24, 2021 at 14:03:51 +0100, Ard Biesheuvel wrote: > > > On Wed, 24 Nov 2021 at 13:07, Leif Lindholm wrote: > > > > > > > > Ard - how does this interact with e.g.

Re: [edk2-devel] [PATCH v2 2/8] ArmPkg: PCD to select conduit for monitor calls

2021-11-24 Thread Ard Biesheuvel
On Wed, 24 Nov 2021 at 14:05, Leif Lindholm wrote: > > On Wed, Nov 24, 2021 at 14:03:51 +0100, Ard Biesheuvel wrote: > > On Wed, 24 Nov 2021 at 13:07, Leif Lindholm wrote: > > > > > > Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib, > > > which reads its conduit out of the DT pas

Re: [edk2-devel] [PATCH v2 2/8] ArmPkg: PCD to select conduit for monitor calls

2021-11-24 Thread Leif Lindholm
On Wed, Nov 24, 2021 at 14:03:51 +0100, Ard Biesheuvel wrote: > On Wed, 24 Nov 2021 at 13:07, Leif Lindholm wrote: > > > > Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib, > > which reads its conduit out of the DT passed to it by QEMU? > > > > As long as ArmCallSmc() and ArmCallH

Re: [edk2-devel] [PATCH v2 2/8] ArmPkg: PCD to select conduit for monitor calls

2021-11-24 Thread Ard Biesheuvel
On Wed, 24 Nov 2021 at 13:07, Leif Lindholm wrote: > > Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib, > which reads its conduit out of the DT passed to it by QEMU? > As long as ArmCallSmc() and ArmCallHvc() continue to exist and behave as before, I don't think those libraries a

Re: [edk2-devel] [PATCH v2 3/8] ArmPkg: Add Arm Firmware TRNG library

2021-11-24 Thread Leif Lindholm
Hi Sami, On Tue, Nov 16, 2021 at 11:32:55 +, Sami Mujawar wrote: > Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) > > The Arm True Random Number Generator Firmware, Interface 1.0, > Platform Design Document > (https://developer.arm.com/documentation/den0098/latest/) > de

Re: [edk2-devel] [PATCH v2 2/8] ArmPkg: PCD to select conduit for monitor calls

2021-11-24 Thread Leif Lindholm
Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib, which reads its conduit out of the DT passed to it by QEMU? / Leif On Tue, Nov 16, 2021 at 11:32:54 +, Sami Mujawar wrote: > Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) > > Define a PCD 'PcdMonitor

Re: [edk2-devel] [Patch 03/12] ArmVirtPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Leif Lindholm
On Tue, Nov 23, 2021 at 13:21:13 -0800, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 > > Update package YAML files to ignore ECC errors that are > already present. These issues must be fixed in the future, > but should not block source code changes for these

Re: [edk2-devel] [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Leif Lindholm
On Tue, Nov 23, 2021 at 13:21:12 -0800, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 > > Update package YAML files to ignore ECC errors that are > already present. These issues must be fixed in the future, > but should not block source code changes for these

Re: [edk2-devel] [Patch 01/12] ArmPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Leif Lindholm
On Tue, Nov 23, 2021 at 13:21:11 -0800, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 > > Update package YAML files to ignore ECC errors that are > already present. These issues must be fixed in the future, > but should not block source code changes for these

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-24 Thread Yao, Jiewen
> -Original Message- > From: Gerd Hoffmann > Sent: Wednesday, November 24, 2021 4:12 PM > To: Yao, Jiewen > Cc: j...@linux.ibm.com; devel@edk2.groups.io; Xu, Min M > ; Ard Biesheuvel ; Justen, > Jordan L ; Brijesh Singh ; > Erdem Aktas ; Tom Lendacky > > Subject: Re: [edk2-devel] [PATC

Re: [edk2-devel] [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Sami Mujawar
Hi Mike, On 23/11/2021 09:21 PM, Michael D Kinney wrote: +"EccCheck": { +## Exception sample looks like below: +## "ExceptionList": [ +## "", "" +## ] +"ExceptionList": [ +"4002", "HobConstructor" +], I noticed there are othe

Re: [edk2-devel] [Patch 03/12] ArmVirtPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Sami Mujawar
Hi Mike, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/11/2021 09:21 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed

Re: [edk2-devel] [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Sami Mujawar
Hi Mike, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/11/2021 09:21 PM, Michael D Kinney via groups.io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues

Re: [edk2-devel] [Patch 01/12] ArmPkg: Update YAML to ignore specific ECC files/errors

2021-11-24 Thread Sami Mujawar
Hi Mike, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/11/2021 09:21 PM, Michael D Kinney via groups.io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues

[edk2-devel] [PATCH 2/2] UefiPayloadPkg: Add performance measurement feature

2021-11-24 Thread Zhiguang Liu
Add a Macro to enable performance measurement feature. For any platform that uses UniversalPayload, we assume it supports BaseCpuTimerLib and use it to align timerlib to get more accurate performance result. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Zhiguang Liu -

[edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add missing Guid gUefiAcpiBoardInfoGuid

2021-11-24 Thread Zhiguang Liu
The library PciSegmentInfoLibAcpiBoardInfo consumes the Guid gUefiAcpiBoardInfoGuid. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Zhiguang Liu --- UefiPayloadPkg/Library/PciSegmentInfoLibAcpiBoardInfo/PciSegmentInfoLibAcpiBoardInfo.inf | 3 +++ 1 file changed, 3

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-24 Thread Gerd Hoffmann
Hi, > 1. " the PEI domain has very limited exposure, it's the DXE domain that has > full exposure " > [Jiewen] I don’t understand how that is concluded, on " limited exposure ", " > full exposure ". exposure == "the need to process external input, which an attacker might use to exploit bugs