Re: [edk2-devel] [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.

2021-12-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Lin, JackX > Sent: Tuesday, December 21, 2021 2:48 PM > To: devel@edk2.groups.io > Cc: Lin, JackX ; Lin, JackX ; Chiu, > Chasel ; Dong, Eric > ; Yao, Jiewen ; Ni, Ray > ; Chaganty, Rangasai V > ; Kuo, Donald ; Kumar, > Chandana C >

[edk2-devel] [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.

2021-12-20 Thread JackX Lin
Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Dong Eric Cc: Jiewen Yao Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Donald Kuo Cc: Chandana C Kumar Cc: JackX Lin --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem

2021-12-20 Thread Wu, Hao A
Reviewed-by: Hao A Wu Will merge in a couple of days. Best Regards, Hao Wu > -Original Message- > From: Ke, VincentX > Sent: Friday, December 17, 2021 4:10 PM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Wu, Hao A ; > Ni, Ray ; Chiu, Ian ; Chu, Maggie > > Subject: [PATCH v4]

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 12/21/2021 #cal-reminder

2021-12-20 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] [PATCH v1 2/2] ArmPkg: MmCommunicationDxe: Update MM communicate input arguments checks

2021-12-20 Thread Kun Qin
Hi Sami, Thanks for your review. But this v1 patch was splitted into multiple patches as in https://edk2.groups.io/g/devel/message/85116. Please feel free leave feedback on the new series. Regards, Kun On 12/13/2021 13:03, Sami Mujawar wrote: Hi Kun, Thank you for this patch. These

Re: [edk2-devel] [PATCH v1 2/2] ArmPkg: MmCommunicationDxe: Update MM communicate input arguments checks

2021-12-20 Thread Kun Qin
Sure, the updated patches are sent here: https://edk2.groups.io/g/devel/message/85116. Please provide any further feedback. Any input is appreciated. Regards, Kun On 12/15/2021 00:52, Ard Biesheuvel wrote: On Tue, 30 Nov 2021 at 01:39, Kun Qin wrote: REF:

[edk2-devel] [PATCH v2 3/6] ArmPkg: MmCommunicationDxe: MM communicate function argument attributes

2021-12-20 Thread Kun Qin
Current MM communicate2 function from ArmPkg described input arguments `CommBufferPhysical`, `CommBufferVirtual` and `CommSize` as input only, which mismatches with the "input and output type" as in PI specification. This change updated function descriptions of MM communite2 to match input

[edk2-devel] [PATCH v2 6/6] ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength` check

2021-12-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751 Current MM communicate routine from ArmPkg would conduct few checks prior to proceeding with SMC calls. However, the inspection step is different from PI specification. This patch updated MM communicate input argument inspection routine to

[edk2-devel] [PATCH v2 4/6] ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**` checks

2021-12-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751 Current MM communicate routine from ArmPkg would conduct few checks prior to proceeding with SMC calls. However, the inspection step is different from PI specification. This patch updated MM communicate input argument inspection routine to

[edk2-devel] [PATCH v2 5/6] ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check

2021-12-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751 Current MM communicate routine from ArmPkg would conduct few checks prior to proceeding with SMC calls. However, the inspection step is different from PI specification. This patch updated MM communicate input argument inspection routine to

[edk2-devel] [PATCH v2 2/6] MdePkg: MmCommunication2: Update MM communicate2 function description

2021-12-20 Thread Kun Qin
Current MM communicate2 function definition described input arguments `CommBufferPhysical`, `CommBufferVirtual` and `CommSize` as input only, which mismatches with the "input and output type" as in PI specification. This change updated function descriptions of MM communite2 definition to match

[edk2-devel] [PATCH v2 1/6] MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message Length

2021-12-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709 In EDKII implementation of variable policy, the DXE runtime agent would communicate to MM to disable, register or query policies. However, these operations populate the value of MessageLength that includes communicate header to include MM

[edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy

2021-12-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/84140 v2 patches mainly focus on feedback for commits submitted in v1 patches: a.

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local functions.

2021-12-20 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Tuesday, December 21, 2021 8:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; Ni, Ray ; S, Ashraf Ali Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type

2021-12-20 Thread Chiu, Chasel
Thanks Ray! I have sent a code review for removing EFIAPI, please help to review. Thanks, Chasel > -Original Message- > From: Ni, Ray > Sent: Monday, December 20, 2021 1:15 PM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Kuo,

[edk2-devel] [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local functions.

2021-12-20 Thread Chiu, Chasel
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642 Local functions do not need EFIAPI. Cc: Nate DeSimone Cc: Star Zeng Cc: Ray Ni Cc: Ashraf Ali S Signed-off-by: Chasel Chiu --- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 1 -

Re: [edk2-devel] [PATCH] BaseTools/Brotli: update to latest brotli submodule

2021-12-20 Thread Pedro Falcato
Ross, This is a duplicate of https://edk2.groups.io/g/devel/message/84497, which has already been Rb'd and is just waiting for a maintainer to merge it. Best regards, Pedro On Mon, Dec 20, 2021 at 4:55 PM Ross Burton wrote: > Update to the latest Brotli commit, and extend the makefiles as

[edk2-devel] [PATCH] BaseTools/Brotli: update to latest brotli submodule

2021-12-20 Thread Ross Burton
Update to the latest Brotli commit, and extend the makefiles as needed. Specifically, this is needed for 0a3944 in brotli, to fix VLA parameter warnings with new compilers. Signed-off-by: Ross Burton Change-Id: I36d28cadb9bf2d9e01ac0341e69509fa1b8d6969 ---

Re: [edk2-devel] EDK build error

2021-12-20 Thread Andrew Fish via groups.io
Jacek, Since you are not subscribed to the mailing list this mail got sent to moderation…. Sometimes syntax errors in your build config files can crash the tools. This looks like a PCD value in a DSC might not be formatted correctly? If you have modified something in that area you can look

[edk2-devel] EDK build error

2021-12-20 Thread Kolakowski, Jacek
Hi I got the below build error. Can anybody help resolve it? Thanks, Jacek (Please send email to devel@edk2.groups.io for help, attaching following call stack trace!) (Python 3.8.6 on win32) Traceback (most recent call last): File

[edk2-devel] [PATCH 1/1] UsbBusDxe: fix NOOPT build error

2021-12-20 Thread Gerd Hoffmann
gcc-11 (fedora 35): /home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c: In function ‘UsbIoBulkTransfer’: /home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c:277:12: error: ‘UsbHcBulkTransfer’ accessing 80 bytes in a region of size 8 [-Werror=stringop-overflow=]

Re: [edk2-devel] [PATCH] Maintainers.txt: Replace Pete with Jeremy as RPi reviewer

2021-12-20 Thread Leif Lindholm
On Fri, Dec 17, 2021 at 17:54:09 +0100, Ard Biesheuvel wrote: > On Fri, 17 Dec 2021 at 17:52, Jeremy Linton wrote: > > > > First a huge thank you to Pete Batard for all the hard work > > landing the RPi code here, and keeping everyone in line. > > > > But, he has lots of commitments, and its time

Re: [edk2-devel] [PATCH 08/10] OvmfPkg: Update Sec to support Tdvf Config-B

2021-12-20 Thread Gerd Hoffmann
Hi, > > Why? Booting non-tdx guests without PEI shouldn't be fundamentally > > different from a TDX guest. Memory detection needs fw_cfg instead of the > > td_hob, and you have to skip some tdx setup steps, but that should be it. > > Code for all that exists in PlatformPei, it only needs to

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-20 Thread wenyi,xie via groups.io
On 2021/12/18 0:39, Sami Mujawar wrote: > Hi Ard, > > > On 17/12/2021, 16:34, "Ard Biesheuvel" wrote: > > On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote: > > > > Hi Leif, Ard, Wenyi, > > > > Is it possible to review and provde feedback for this change, please? >

[edk2-devel] [edk2-platforms: PATCH] REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3787

2021-12-20 Thread JackX Lin
System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space. Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Dong Eric Cc: Jiewen Yao Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Donald Kuo Cc: Chandana C Kumar Cc: JackX Lin ---