回复: [edk2-devel] 回复: [Patch 1/2] BaseTools: Update brotli submodule

2022-02-09 Thread gaoliming
Bob: I have no comments for this patch set. Reviewed-by: Liming Gao Now, we are in soft feature freeze phase. Does this patch set plan to catch this stable tag? If yes, please reply the mail and cc to Stewards. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Bob Feng >

回复: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: Replace Opcode with the corresponding instructions.

2022-02-09 Thread gaoliming
Ray, I have given my reviewed-by for the whole patch set. https://edk2.groups.io/g/devel/message/85499?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3A created%2C0%2Ccorresponding%2C20%2C2%2C20%2C88339058 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ni, Ray > 发送时间: 2022年2月10日 13:37 > 收件人:

Re: [edk2-devel] [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure

2022-02-09 Thread MohammedX Rehan
Done the below changes and raise new patch. -Original Message- From: Ni, Ray Sent: Thursday, February 10, 2022 8:17 AM To: Rehan, MohammedX ; devel@edk2.groups.io; Gao, Zhichao ; Esakkithevar, Kathappan ; Pethaiyan, Madhan Cc: Thirupugal, MadhaviX Subject: RE: [PATCH] ShellPkg: Fix

[edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg/SaveMemoryConfig: Variable may not be locked.

2022-02-09 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3829 Fixed the bug that existing variable will not be locked when it is identical with hob data by creating LockLargeVariable function, also switched to VariablePolicyProtocol for locking variables. This patch also modified SaveMemoryConfig

[edk2-devel] [PATCH V2 1/1] ShellPkg: Fix Ping GetTimerPeriod API failure

2022-02-09 Thread MohammedX Rehan
[edk2-devel] [Patch V2 1/1] REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3819 Ping GetTimerPeriod API returns sometime zero value when StallCounter has smaller value than RttTimerTick (divide by zero) which results some failure at ping UEFI shell command Signed-off-by: MohammedX Rehan

Re: [edk2-devel] [Patch 2/2] MdeModulePkg: update brotli submodule

2022-02-09 Thread Bob Feng
Hi, Do you have any comments on this patch? Would you review it? Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Wednesday, January 26, 2022 4:29 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A ; Bi, Dandan ; Gao, Liming ; Pedro Falcato

Re: [edk2-devel] 回复: [Patch 1/2] BaseTools: Update brotli submodule

2022-02-09 Thread Bob Feng
Liming, Do you have any more comments on this patch? Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Thursday, January 27, 2022 10:24 AM To: devel@edk2.groups.io; Gao, Liming Cc: Chen, Christine ; 'Pedro Falcato' Subject: Re: [edk2-devel] 回复:

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: Replace Opcode with the corresponding instructions.

2022-02-09 Thread Ni, Ray
Reviewed-by: Ray Ni Liming, Jian, can you give R-b as the package maintainers? -Original Message- From: Lou, Yun Sent: Monday, January 10, 2022 11:13 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Ni, Ray ; Bi, Dandan ; Gao, Liming Subject: [PATCH v2 1/6] MdeModulePkg: Replace Opcode

Re: [edk2-devel] [PATCH v2 4/6] UefiCpuPkg: Replace Opcode with the corresponding instructions.

2022-02-09 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Lou, Yun Sent: Monday, January 10, 2022 11:13 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Ni, Ray ; Dong, Eric ; Laszlo Ersek ; Kumar, Rahul1 Subject: [PATCH v2 4/6] UefiCpuPkg: Replace Opcode with the corresponding instructions. REF:

Re: [edk2-devel] [Patch V2 1/1] UefiPayloadPkg/PayloadLoaderPeim: Force UINTN before save Ptr

2022-02-09 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Jiang, Guomin Sent: Thursday, February 10, 2022 11:03 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [Patch V2 1/1] UefiPayloadPkg/PayloadLoaderPeim: Force UINTN before save Ptr REF:

Re: [edk2-devel] I think we need a Panic API...

2022-02-09 Thread Ni, Ray
Jeff, I understand what “EFI_SYSTEM_CONTEXT” is. I am curious of the need of “BOOLEAN ProcessSystemContext”. From: devel@edk2.groups.io On Behalf Of Jeff Fan Sent: Thursday, February 10, 2022 11:37 AM To: devel@edk2.groups.io; Ni, Ray ; 'Andrew Fish' Subject: Re: [edk2-devel] I think we need

Re: [edk2-devel] I think we need a Panic API...

2022-02-09 Thread Jeff Fan
Ray, EFI_SYSTEM_CONTEXT was defined in MdePkg/Include/Protocol/DebugSupport.h Jeff fanjianf...@byosoft.com.cn From: Ni, Ray Date: 2022-02-10 10:54 To: Andrew Fish; edk2-devel-groups-io Subject: Re: [edk2-devel] I think we need a Panic API... Andrew, I agree Panic is useful because ASSERT is

[edk2-devel] [Patch V2 1/1] UefiPayloadPkg/PayloadLoaderPeim: Force UINTN before save Ptr

2022-02-09 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0x when do the operation of UINT64 + INTN. V2: 1. Force the data type to UINTN to avoid high dword be filled with

Re: [edk2-devel] I think we need a Panic API...

2022-02-09 Thread Ni, Ray
Andrew, I agree Panic is useful because ASSERT is a NOP in the release build. Can you explain a bit more on ProcessSystemContext? -Original Message- From: Andrew Fish Sent: Thursday, February 3, 2022 12:37 PM To: edk2-devel-groups-io Cc: Ni, Ray Subject: I think we need a Panic

Re: [edk2-devel] [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure

2022-02-09 Thread Ni, Ray
+ if (TimerPeriod) { Please use "if (TimerPeriod != 0)" -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86538): https://edk2.groups.io/g/devel/message/86538 Mute This Topic: https://groups.io/mt/88978781/21656 Group Owner:

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 28/33] MdeModulePkg/Logo: Add LoongArch64 architecture.

2022-02-09 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Chao Li Sent: Wednesday, February 9, 2022 3:09 PM To: devel@edk2.groups.io Cc: Gao, Zhichao ; Ni, Ray Subject: [staging/LoongArch RESEND PATCH v1 28/33] MdeModulePkg/Logo: Add LoongArch64 architecture. Add LoongArch64 architecture to the

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 28/33] MdeModulePkg/Logo: Add LoongArch64 architecture.

2022-02-09 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Chao Li Sent: Wednesday, February 9, 2022 2:56 PM To: devel@edk2.groups.io Cc: Gao, Zhichao ; Ni, Ray ; Chao Li Subject: [staging/LoongArch RESEND PATCH v1 28/33] MdeModulePkg/Logo: Add LoongArch64 architecture. Add LoongArch64

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 01/33] FatPkg: Add LOONGARCH64 architecture for EDK2 CI.

2022-02-09 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Chao Li Sent: Wednesday, February 9, 2022 2:52 PM To: devel@edk2.groups.io Cc: Ni, Ray Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 01/33] FatPkg: Add LOONGARCH64 architecture for EDK2 CI. Add

Re: [edk2-devel] [Patch 2/3] UefiCpuPkg: Include for host based unit tests

2022-02-09 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Kinney, Michael D Sent: Thursday, February 10, 2022 10:42 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul1 Subject: [Patch 2/3] UefiCpuPkg: Include for host based unit tests REF:

[edk2-devel] [Patch 0/3] Update cmocka submodule to 5a4b15870efa

2022-02-09 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2853 cmocka issue and commit that increases the log message length: * https://gitlab.com/cmocka/cmocka/-/issues/51 * https://gitlab.com/cmocka/cmocka/-/commit/36c85066dee0113e0b743d886c001ae76ca1fea9 Update cmocka to a version that supports

[edk2-devel] [Patch 3/3] UnitTestFrameworkPkg: Update cmocka submodule to 5a4b15870efa

2022-02-09 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2853 cmocka issue and commit that increases the log message length: * https://gitlab.com/cmocka/cmocka/-/issues/51 * https://gitlab.com/cmocka/cmocka/-/commit/36c85066dee0113e0b743d886c001ae76ca1fea9 Update cmocka to a version that supports

[edk2-devel] [Patch 2/3] UefiCpuPkg: Include for host based unit tests

2022-02-09 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2853 Update cmocka to a version that supports longer log messages. This update requires to be included before . Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Michael D Kinney ---

[edk2-devel] [Patch 1/3] MdeModulePkg: Include for host based unit tests

2022-02-09 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2853 Update cmocka to a version that supports longer log messages. This update requires to be included before . Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Michael D Kinney --- .../DxeResetSystemLib/UnitTest/DxeResetSystemLibUnitTest.c

回复: [edk2-devel] [PATCH v2 1/1] MdePkg/Include: Add ARM specific definitions for CPER

2022-02-09 Thread gaoliming
Ming: Can you submit one BZ in https://bugzilla.tianocore.org/ for this change? Have you created pull request to verify this change in Edk2 CI? Now, we are on soft feature freeze for new stable tag 202202. So, this change may be merged after this stable tag. Thanks Liming >

Re: [edk2-devel][edk2-platforms][PATCH V1 0/8] Whitley ACPI Tables

2022-02-09 Thread Oram, Isaac W
Series Pushed as b6f9674389..d1e809a50c -Original Message- From: devel@edk2.groups.io On Behalf Of Oram, Isaac W Sent: Monday, February 7, 2022 11:03 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject:

[edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2022-02-09 Thread Ming Huang
The heap space will be rewrote if a StandloneMmPkg module create HOB by BuildGuidHob() interface and write data to HOB space. Add a PCD PcdMemoryHobSize for pre-allocation a space to create HOB to fix this issue. Signed-off-by: Ming Huang --- StandaloneMmPkg/Core/StandaloneMmCore.c | 17

[edk2-devel] [PATCH v1 1/2] StandaloneMmPkg/Hob: Assert or return NULL for create hob failed

2022-02-09 Thread Ming Huang
The rare case (create hob failed) should be considered. Assert for StandaloneMmCoreHobLib and return NULL for StandaloneMmobLib. Signed-off-by: Ming Huang --- StandaloneMmPkg/Library/StandaloneMmCoreHobLib/Arm/StandaloneMmCoreHobLib.c | 6 ++

[edk2-devel] [PATCH v1 0/2] Fix StandaloneMmPkg HOB issue

2022-02-09 Thread Ming Huang
Fix two issues in StandaloneMmPkg HOB. Ming Huang (2): StandaloneMmPkg/Hob: Assert or return NULL for create hob failed StandaloneMmPkg: Fix HOB space and heap space conflicted issue StandaloneMmPkg/Core/StandaloneMmCore.c | 17 -

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2022-02-09 Thread Ming Huang
Abandon this patch, send a new one for fixing this issue. 在 2/8/22 10:43 AM, Ming Huang 写道: > The heap space will be rewrote if a StandloneMmPkg module create HOB > by BuildGuidHob() interface and write data to HOB space. > Add a PCD PcdMemoryHobSize for pre-allocation a space to create HOB to >

[edk2-devel] [staging/LoongArch RESEND PATCH v1 33/33] Update self-introduction documentation

2022-02-09 Thread Chao Li
Add the summary, owner, timeline and links to related materials in the Readme.md to describe our work in this branch. Cc: Liming Gao Cc: Yuwei Chen Cc: Bob Feng Signed-off-by Chao Li --- ReadMe.md | 17 + 1 file changed, 17 insertions(+) create mode 100644 ReadMe.md diff

[edk2-devel] [staging/LoongArch RESEND PATCH v1 32/33] BaseTools: Add LoongArch64 binding.

2022-02-09 Thread Chao Li
Add LoongArch64 ProcessorBin.h and add LoongArch to Makefiles. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang --- BaseTools/Source/C/GNUmakefile| 3 + .../C/Include/LoongArch64/ProcessorBind.h | 80 +++ 2

[edk2-devel] [staging/LoongArch RESEND PATCH v1 31/33] NetworkPkg: Add LoongArch64 architecture.

2022-02-09 Thread Chao Li
Add LoongArch64 architecture in to NetworkPkg. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Chao Li --- NetworkPkg/Network.dsc.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc index

[edk2-devel] [staging/LoongArch RESEND PATCH v1 30/33] MdeModulePkg/DxeIplPeim : LoongArch DxeIPL implementation.

2022-02-09 Thread Chao Li
Implement LoongArch DxeIPL instance. Cc: Liming Gao Cc: Guomin Jiang Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang --- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 6 +- .../Core/DxeIplPeim/LoongArch64/DxeLoadFunc.c | 61 +++ 2 files changed, 66 insertions(+), 1

[edk2-devel] [staging/LoongArch RESEND PATCH v1 29/33] MdeModulePkg/CapsuleRuntimeDxe: Add LoongArch64 architecture.

2022-02-09 Thread Chao Li
Add LoongArch in INF for building CapsuleRuntimeDxe LoongArch64 image. Cc: Liming Gao Cc: Guomin Jiang Sigend-off-by: Chao Li --- .../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf| 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [staging/LoongArch RESEND PATCH v1 28/33] MdeModulePkg/Logo: Add LoongArch64 architecture.

2022-02-09 Thread Chao Li
Add LoongArch64 architecture to the Logo. Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Chao Li --- MdeModulePkg/Logo/Logo.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Logo/Logo.inf b/MdeModulePkg/Logo/Logo.inf index 70a66cae98..294482ccdc 100644 ---