Re: [edk2-devel] [edk2platforms][PATCH v4 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2022-02-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Chaganty, Rangasai V Sent: Tuesday, January 11, 2022 10:07 AM To: Czajkowski, Maciej ; devel@edk2.groups.io Cc: Ni, Ray Subject: RE: [edk2platforms][PATCH v4 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol Reviewed-by: Sai Chaganty

Re: [edk2-devel] [PATCH V2 05/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings

2022-02-13 Thread Min Xu
Hi > > --- a/OvmfPkg/Include/IndustryStandard/IntelTdx.h > > +++ b/OvmfPkg/Include/IndustryStandard/IntelTdx.h > > With this being more widely used it doesn't make sense to have it in > IntelTdx.h ... > I am thinking EFI_HOB_PLATFORM_INFO can be declared at

Re: [edk2-devel] [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase

2022-02-13 Thread Min Xu
Hi > > > > Add PcdTdxWorkAreaBase to indicate the area of memory where the > > > > TDX work area block lives. > > > > > > Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when > we > > > have a shared work area? > > PcdTdxWorkAreaBase mimics PcdSevEsWorkAreaBase. Yes, > TdxWorkAreaBase is

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/Include: Add ARM specific definitions for CPER

2022-02-13 Thread Ming Huang
在 2/11/22 9:12 AM, gaoliming 写道: > Ming: > You can refer to wiki > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > to know how to create PR. I have create PR: https://github.com/tianocore/edk2/pull/2519 > > You can refer to wiki >

Re: [edk2-devel] [edk2-platforms: PATCH v3] MinPlatformPkg/SaveMemoryConfig: Variable may not be locked.

2022-02-13 Thread Chiu, Chasel
Thanks Isaac! I will correct them when pushing the patch. > -Original Message- > From: Oram, Isaac W > Sent: Saturday, February 12, 2022 8:48 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone, Nathaniel L ; Gao, Liming > ; Dong, Eric > Subject: RE: [edk2-devel]

[edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build

2022-02-13 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3833 Move FspDebug to the root of BaseFspDebugLibSerialPort since the current nasm support for both IA32 and X64 Build, remove IA32 from INF file. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Kuo Ted Cc: Duggapu Chinni B Cc: Rangasai

[edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64 Build

2022-02-13 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3832 BaseFspSwitchStackLib Currently Support for IA32 build only, adding support for X64 build, fix typecasting issues for X64 build. 0x_ will be replaced by MAX_ADDRESS which is set based on the type of Library which is it building. if