Re: [edk2-devel] [PATCH v3 1/1] UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter

2022-02-21 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Jiang, Guomin Sent: Monday, February 21, 2022 2:44 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH v3 1/1] UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF:

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-21 Thread Ni, Ray
Grub runs later. Then what does “conflict” mean? From: Sean Rhodes Sent: Monday, February 21, 2022 3:48 PM To: Ni, Ray Cc: devel@edk2.groups.io; Dong, Guo ; Ma, Maurice ; You, Benjamin Subject: Re: [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable We would prefer to keep PCD, as Esc

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Use Boot Splash

2022-02-21 Thread Ni, Ray
+ gUefiPayloadPkgTokenSpaceGuid.PcdBootSplashImage Is this needed? -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Monday, February 21, 2022 3:55 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes, Sean ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject:

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build

2022-02-21 Thread Chiu, Chasel
Thanks Ray! @S, Ashraf Ali I think we need to return 64bit pointer in 64bit build, please help to verify and confirm. Thanks, Chasel > -Original Message- > From: Ni, Ray > Sent: Monday, February 14, 2022 4:27 PM > To: devel@edk2.groups.io; S, Ashraf Ali > Cc: Chiu, Chasel ;

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64 Build

2022-02-21 Thread Chiu, Chasel
Thanks for good catch, Ray! @Desimone, Nathaniel L and @Ma, Maurice, please also share your comments for this change. I think we could directly change CoreStack size and implementation to support 64bits build because both FspGlobalData and SwapStack() are FSP private/internal usage. @S,

[edk2-devel] [PATCH 0/2] Avoid Emulator Segmentation fault

2022-02-21 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668 Correct the logic to handle the case that XServer not present to avoid Segmentation fault Guomin Jiang (2): MdeModulePkg/GraphicsConsoleDxe: Check status to make sure no error EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully

[edk2-devel] [PATCH 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully

2022-02-21 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668 WindowOpen will fail in some case. for example, without XServer. Shouldn't set ModeInfo in this case to avoid the caller use it incorrectly Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/EmuGopDxe/GopScreen.c |

[edk2-devel] [PATCH 1/2] MdeModulePkg/GraphicsConsoleDxe: Check status to make sure no error

2022-02-21 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668 SetMode will fail in some case. for example, without XServer. Should handle these case when SetMode fail. If we don't handle it, it will Segmentation fault. Cc: Jian J Wang Cc: Liming Gao Cc: Zhichao Gao Cc: Ray Ni Signed-off-by:

[edk2-devel] [PATCH] ArmPkg: Invalidate Instruction Cache On MMU Enable

2022-02-21 Thread Ashish Singhal via groups.io
Even with MMU turned off, instruction cache can speculate and fetch instructions. This can cause a crash if region being executed has been modified recently. With this patch, we ensure that instruction cache is invalidated right after MMU has been enabled and any potentially stale instruction

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 02/22/2022 #cal-reminder

2022-02-21 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

[edk2-devel] MdeModulePkg fails to build with latest clang 14

2022-02-21 Thread Ross Burton
When building edk2 202111 with clang 14 I get the following errors: edk2/MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h:78:47: error: field Guid within 'FPDT_GUID_EVENT_RECORD' is less aligned than 'EFI_GUID' (aka 'GUID') and is usually due to 'FPDT_GUID_EVENT_RECORD' being packed,

Re: [edk2-devel] [PATCH] NetworkPkg: Fix incorrect unicode string of the AKM/Cipher Suite

2022-02-21 Thread Maciej Rabeda
Patch merged. PR: https://github.com/tianocore/edk2/pull/2536 Commit: https://github.com/tianocore/edk2/pull/2536/commits/18feb439545443e8a3488b82415023601d116fe4 W dniu 21-Feb-22 o 15:57, Maciej Rabeda pisze: Hi Heng, Thanks for the patch. Reviewed-by: Maciej Rabeda W dniu 26-Jan-22 o 

[edk2-devel] LoadImage in EFI_BOOT_SERVICES returning Access Denied

2022-02-21 Thread Gabriel Carvalho de Faria via groups.io
Greetings! We implemented a driver that runs an EFI application on the system using the LoadImage and StartImage functions present in the EFI_BOOT_SERVICES (gBS) structure. The source code of the main function that performs the load and start of the EFI application is presented below: /* * EFI

[edk2-devel] LoadImage in EFI_BOOT_SERVICES returning Access Denied

2022-02-21 Thread Gabriel Carvalho de Faria via groups.io
Greetings! We implemented a driver that runs an EFI application on the system using the LoadImage and StartImage functions present in the EFI_BOOT_SERVICES (gBS) structure. The source code of the main function that performs the load and start of the EFI application is presented below: > >

[edk2-devel] LoadImage in EFI_BOOT_SERVICES returning Access Denied

2022-02-21 Thread Gabriel Carvalho de Faria via groups.io
Greetings! We implemented a driver that runs an EFI application on the system using the LoadImage and StartImage functions present in the EFI_BOOT_SERVICES (gBS) structure. The source code of the main function that performs the load and start of the EFI application is presented below: /* *

Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

2022-02-21 Thread Brijesh Singh via groups.io
Hi Liming, The said PCD is applicable for the SNP. SNP is supported on x86 64-bit only, and most of the development is focused around Qemu/OVMF. In other words, the Bhyve, Xen, and CloudHV do not support the SNP yet. We can revisit it when those HV starts supporting the SNP. thanks Brijesh

[edk2-devel] There is a low probability that the XhciDxe will ASSERT

2022-02-21 Thread lurenjianullptr
Hi all, Please check the Xhci log below. There's a low probability that the Xhci module will assert during a machine startup. [20220210_16:41:22:796]UsbHcGetHostAddrForPciAddr-forloop: Block->Buf = 0xF8B4C000, Block->BufLen = 0x1 [20220210_16:41:22:796]UsbHcGetHostAddrForPciAddr:

[edk2-devel] [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup

2022-02-21 Thread Brijesh Singh via groups.io
This is the first of cleanup for SEV MemEncryptLib. The library uses the CPUID followed by the MSR read to determine whether SEV is enabled. Now that we have a workarea concept, the logic can be simplified to store the msr status in workarea and use that to build PCDs and then later simply use

[edk2-devel] [PATCH v2 1/2] OvmfPkg/ResetVector: cache the SEV status MSR value in workarea

2022-02-21 Thread Brijesh Singh via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3582 In order to probe the SEV feature the BaseMemEncryptLib and Reset vector reads the SEV_STATUS MSR. Cache the value on the first read in the workarea. In the next patches the value saved in the workarea will be used by the BaseMemEncryptLib.

[edk2-devel] [PATCH v2 2/2] OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from workarea

2022-02-21 Thread Brijesh Singh via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3582 Improve the MemEncryptSev{Es,Snp}IsEnabled() to use the SEV_STATUS MSR value saved in the workarea. Since workarea is valid until the PEI phase, so, for the Dxe phase use the PcdConfidentialComputingGuestAttr to determine which SEV

Re: [edk2-devel] [PATCH] NetworkPkg: Fix incorrect unicode string of the AKM/Cipher Suite

2022-02-21 Thread Maciej Rabeda
Hi Heng, Thanks for the patch. Reviewed-by: Maciej Rabeda W dniu 26-Jan-22 o 06:12, Heng Luo pisze: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3813 The size of buffer should be 3 CHAR16 for Null-terminated Unicode string. The first char is the AKM/Cipher Suite number, the second