Re: [edk2-devel] [PATCH v2 0/3] BaseTools: Add support for gdb and lldb

2022-04-08 Thread Bob Feng
Created the PR. https://github.com/tianocore/edk2/pull/2758 -Original Message- From: Rebecca Cran Sent: Thursday, April 7, 2022 6:34 AM To: devel@edk2.groups.io; Leif Lindholm ; Kinney, Michael D ; Wu, Hao A ; Feng, Bob C ; Gao, Liming ; Chen, Christine Cc: Andrew Fish Subject: Re:

Re: [edk2-devel] [PATCH v2 3/3] BaseTools: Scripts/efi_lldb.py: Add lldb EFI commands and pretty Print

2022-04-08 Thread Bob Feng
Reviewed-by: Bob Feng On Tue, Mar 22, 2022 at 04:21 AM, Rebecca Cran wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3500 > > Use efi_debugging.py Python Classes to implement EFI gdb commands: > efi_symbols, guid, table, hob, and devicepath > > You can attach to any standard gdb or

Re: [edk2-devel] [PATCH v3 0/3] BaseTools: fix gcc workaround

2022-04-08 Thread Bob Feng
Hi Gerd, Your patches are great but I think we can't take them because of the incompatible license. I think the new Toolchain definition, like GCC12, can not resolve this issue because Toolchain is not used for building BaseTools. So I'd prefer the second option of using 'gcc -dumpversion'.

Re: [edk2-devel] [PATCH v1 0/3] Add Variable Flash Info HOB

2022-04-08 Thread Michael Kubacki
Hi Hao, I addressed all of your feedback including abstraction of the information with a library API in v2. It did help clean up the consumption code quite a bit. https://edk2.groups.io/g/devel/message/88649 Thanks, Michael On 4/7/2022 7:56 PM, Michael Kubacki wrote: Yes, I considered that

[edk2-devel] [PATCH v2 8/8] UefiPayloadPkg: Add VariableFlashInfoLib

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance of VariableFlashInfoLib to the platform build as it is a new library class introduced in MdeModulePkg. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by:

[edk2-devel] [PATCH v2 7/8] OvmfPkg: Add VariableFlashInfoLib

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance of VariableFlashInfoLib to the platform build as it is a new library class introduced in MdeModulePkg. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Brijesh Singh Cc: Erdem Aktas Cc: Gerd Hoffmann

[edk2-devel] [PATCH v2 6/8] EmulatorPkg: Add VariableFlashInfoLib

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance of VariableFlashInfoLib to the platform build as it is a new library class introduced in MdeModulePkg. Cc: Andrew Fish Cc: Ray Ni Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Michael Kubacki

[edk2-devel] [PATCH v2 5/8] ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance of VariableFlashInfoLib to the platform build as it is a new library class introduced in MdeModulePkg. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Cc: Julien Grall

[edk2-devel] [PATCH v2 4/8] MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds support to the UEFI variable fault tolerant write (FTW) drivers to receive FTW base and size information dynamically via the Variable Flash Information library. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao

[edk2-devel] [PATCH v2 3/8] MdeModulePkg/Variable: Consume Variable Flash Info

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Updates VariableRuntimeDxe, VariableSmm, and VariableStandaloneMm to acquire variable flash information from the Variable Flash Information library. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by:

[edk2-devel] [PATCH v2 2/8] MdeModulePkg/VariableFlashInfoLib: Add initial library

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds a new library class VariableFlashInfoLib that abstracts access to variable flash information. The instance provided first attempts to retrieve information from the Variable Flash Info HOB. If that HOB is not

[edk2-devel] [PATCH v2 1/8] MdeModulePkg: Add Variable Flash Info HOB

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds a new GUID that is used to identify a HOB that passes variable flash information to UEFI variable drivers in HOB consumption phases such as DXE, Traditional MM, and Standalone MM. This information was previously

[edk2-devel] [PATCH v2 0/8] Add Variable Flash Info HOB

2022-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm, VariableStandaloneMm, etc. (and their dependent protocol/library stack), typically acquire UEFI variable store flash information with PCDs declared in

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-08 Thread Pedro Falcato
Is this a laptop? Things may not work there because video output is done through the Intel GPU, even when using the Nvidia GPU, although I'm not sure. On Fri, Apr 8, 2022 at 6:49 PM Mario Marietto wrote: > im trying to test the patch on my pc,that has two graphic cards,the intel > coffee lake

Re: [edk2-devel] GSoC 2022: Add S3 resume support to MinPlatform

2022-04-08 Thread Benjamin Doron
Hi Nate, Thanks! I've looked at the basics of I2C, but I've seen from the iGFX PRM that GMBUS implements some registers and error handling the NAKs differently, but I guess that I'll be dealing with that later. Yeah, I was thinking that if we wanted debug up as soon as possible, then the iGFX

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg\Applications\Python\Python-3.6.8\Lib: uuid.py module port for UEFI environment

2022-04-08 Thread Michael D Kinney
Thanks JP. That makes sense. Bypass all the OS specific services in UEFI environment and generate UUID using time and random number. Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Jayaprakash, N > Sent: Friday, April 8, 2022 10:19 AM > To: devel@edk2.groups.io;

[edk2-devel] [edk2-non-osi] [PATCH V2] ElkhartlakeSiliconBinPkg: Update EHL microcode

2022-04-08 Thread kokweich
Updated "production" microcode version m0190661_0016 Signed-off-by: kokweich Cc: Nate DeSimone Cc: Sai Chaganty Cc: jinjhuli --- .../Microcode/IntelMicrocodeLicense.txt | 8 .../Microcode/MicrocodeUpdates.inf | 4 ++-- .../Microcode/m0190661_0015.mcb

[edk2-devel] [PATCH] MdeModulePkg/dec: update the PcdCpuStackGuard property

2022-04-08 Thread Chen, Gang C
Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx. Meanwhile, remove the duplicate check for PcdCpuStackGuard for some limitation, which has been checked at the entry of InitializeMpExceptionStackSwitchHandlers. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3897 Cc: Jian

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-08 Thread Mario Marietto
im trying to test the patch on my pc,that has two graphic cards,the intel coffee lake and the nvidia. i tried to start the pc from the nvidia card and ive configured the xorg.conf file giving the proper bus id value. in addition ive loaded the kernel.ko file from the boot loader.conf i have

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg\Applications\Python\Python-3.6.8\Lib: uuid.py module port for UEFI environment

2022-04-08 Thread Jayaprakash, N
+ Aaron Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: 08 April 2022 22:12 To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg\Applications\Python\Python-3.6.8\Lib: uuid.py module port for UEFI

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg\Applications\Python\Python-3.6.8\Lib: uuid.py module port for UEFI environment

2022-04-08 Thread Jayaprakash, N
The UUID generation is done through the random number generation & time unix time stamp features available through the built-in python modules 'random' and 'time' respectively. The random number & time (unix time stamp or epoch) based method of generating the UUID is already there in uuid.py

[edk2-devel] [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields

2022-04-08 Thread Bo Chang Ke
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900 update smbiosview type 41 related fileds. Signed-off-by: Bo Chang Ke Cc: Dandan Bi Cc: Star Zeng --- .../SmbiosView/QueryTable.c | 24 +++ 1 file changed, 24 insertions(+) diff --git

Re: [edk2-devel] [GSoC 2022] Introducing myself & seeking for project ideas

2022-04-08 Thread Théo Jehl
Hello Nate, Thanks a lot for your answer ! I got myself a copy of "Beyond BIOS" to understand how UEFI works. The project sound very interesting, so if I understand correctly, OVMF only implements some of the services needed for QEMU support, porting what's present to MinPlatform and then

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg\Applications\Python\Python-3.6.8\Lib: uuid.py module port for UEFI environment

2022-04-08 Thread Michael D Kinney
How is a UUID generated in UEFI env? Is there a dependency on MAC address or random number generator? Can you add a description of the technique to the BZ and the commit message? Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jayaprakash, N > Sent:

Re: [edk2-devel] Applying for GSoC 2022: Add Rust Support to EDK II

2022-04-08 Thread Ayush Singh
Hi Nate Thanks for the response. For the std implementation, I do have some idea how to go about implementing it now. The most important thing I realized is that most of the std isn't actually std. For example, std::collection, Vector, Box, Rc, etc are all actually part of alloc and not std. The

Re: [edk2-devel] [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy

2022-04-08 Thread Yao, Jiewen
Can we remove inline keyword? I don't think it is really needed in EDKII project. Thank you Yao Jiewen > -Original Message- > From: Gerd Hoffmann > Sent: Friday, April 8, 2022 7:16 PM > To: devel@edk2.groups.io > Cc: Oliver Steffen ; Yao, Jiewen > ; Jiang, Guomin ; Wang, Jian > J ;

Re: [edk2-devel] [PATCH v2 0/8] CryptoPkg updates for openssl 3.0

2022-04-08 Thread Yao, Jiewen
With inline keyword removed in patch-7/8, Series reviewed-by: Jiewen Yao > -Original Message- > From: Gerd Hoffmann > Sent: Friday, April 8, 2022 7:16 PM > To: devel@edk2.groups.io > Cc: Oliver Steffen ; Yao, Jiewen > ; Jiang, Guomin ; Wang, Jian > J ; Xiaoyu Lu ; Pawel Polawski > ;

[edk2-devel] [edk2-libc Patch 1/1] AppPkg\Applications\Python\Python-3.6.8\Lib: uuid.py module port for UEFI environment

2022-04-08 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3899 This is commit contains the UEFI port of uuid.py module. Made necessary changes required to uuid.py module to support UEFI environment. Porting of this module to UEFI is required for open source tools such as Chipsec to function

[edk2-devel] [edk2-libc Patch 0/1] added support for uuid.py module for uefi environment

2022-04-08 Thread Jayaprakash, N
This patch contains the uuid.py updated module with the changes required to support it working on uefi environment. Jayaprakash Nevara (1): AppPkg\Applications\Python\Python-3.6.8\Lib: uuid.py module port for UEFI environment .../Python/Python-3.6.8/Lib/uuid.py | 94

Re: [edk2-devel] [PATCH 1/1] UEFI-SCT: SctPkg: Updated the check for monotonic count after restart

2022-04-08 Thread G Edhaya Chandran
Hi Barton, Thank you for the review. Could you please upstream the patch. With Warm Regards, Edhay > -Original Message- > From: Gao Jie > Sent: 08 April 2022 12:03 > To: devel@edk2.groups.io; G Edhaya Chandran > Subject: 回复: [edk2-devel] [PATCH 1/1] UEFI-SCT: SctPkg: Updated the

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 25/33] MdePkg/BaseCpuLib: LoongArch Base CPU library implementation.

2022-04-08 Thread Abner Chang
Recently there is a work to migrate UefiCpuLib to CpuLib (patch attached), you may want to sync up your changes with that patch set. RISC-V will do the same work later. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9,

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 32/33] BaseTools: Add LoongArch64 binding.

2022-04-08 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 4:02 PM > To: devel@edk2.groups.io > Cc: Bob Feng ; Liming Gao > ; Yuwei Chen ; Baoqi > Zhang > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 32/33] > BaseTools: Add

[edk2-devel] [PATCH v2 8/8] CryptoPkg/UnitTest: fix DH testcase

2022-04-08 Thread Gerd Hoffmann
openssl 3.0 wants at least 512 bytes, otherwise it throws an error: error:0280007E:Diffie-Hellman routines::modulus too small Signed-off-by: Gerd Hoffmann --- CryptoPkg/Test/UnitTest/Library/BaseCryptLib/DhTests.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [PATCH v2 3/8] CryptoPkg/CrtLibSupport: add INT_MIN

2022-04-08 Thread Gerd Hoffmann
Add #define for INT_MIN. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index

[edk2-devel] [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy

2022-04-08 Thread Gerd Hoffmann
strcpy() returns a pointer to the destination string, AsciiStrCpyS() does not. So a simple #define does not work. Create a inline function instead. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-)

[edk2-devel] [PATCH v2 6/8] CryptoPkg/CrtLibSupport: add off_t

2022-04-08 Thread Gerd Hoffmann
Add typedef for off_t. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index

[edk2-devel] [PATCH v2 5/8] CryptoPkg/CrtLibSupport: add MODULESDIR

2022-04-08 Thread Gerd Hoffmann
Add dummy MODULESDIR #define Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index

[edk2-devel] [PATCH v2 4/8] CryptoPkg/CrtLibSupport: add UINT_MAX

2022-04-08 Thread Gerd Hoffmann
Add define for UINT_MAX. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index

[edk2-devel] [PATCH v2 2/8] CryptoPkg/CrtLibSupport: add strstr()

2022-04-08 Thread Gerd Hoffmann
Add #define for strstr(). Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index

[edk2-devel] [PATCH v2 0/8] CryptoPkg updates for openssl 3.0

2022-04-08 Thread Gerd Hoffmann
First batch of patches which update CrtLibSupport so it has everything needed to build openssl3. Also a testcase update for openssl3. This does not update the openssl submodule, that'll happen in a followup patch series. v2: - rebase to latest master. - add codestyle exception for fcntl.h.

[edk2-devel] [PATCH v2 1/8] CryptoPkg/CrtLibSupport: add fcntl.h

2022-04-08 Thread Gerd Hoffmann
Add fcntl.h header file. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/fcntl.h | 9 + CryptoPkg/CryptoPkg.ci.yaml | 1 + 2 files changed, 10 insertions(+) create mode 100644 CryptoPkg/Library/Include/fcntl.h diff --git

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 30/33] MdeModulePkg/DxeIplPeim : LoongArch DxeIPL implementation.

2022-04-08 Thread Abner Chang
DxeLoadFunc.c is almost the same as RISC-V instance. However, I don't have idea how to leverage it because DxeLoadFunc is currently in the architecture-based folder. Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday,

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 27/33] MdePkg/BaseSafeIntLib: Add LoongArch64 architecture for BaseSafeIntLib.

2022-04-08 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:56 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 27/33] >

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 26/33] MdePkg/BaseSynchronizationLib: LoongArch cache related code.

2022-04-08 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:56 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Baoqi > Zhang > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 26/33] >

Re: [edk2-devel] Intel NUC platform firmware -- no serial I/O support?

2022-04-08 Thread Laszlo Ersek
On 04/08/22 11:48, Gerd Hoffmann wrote: > > Hi, > >> And It Just Works (TM), with the following two commands in the UEFI >> shell (after I copied the binaries to the USB stick, alongside the UEFI >> Shell binary I built earlier): >> >>> Shell> fs0: >>> FS0:\> cd efi\boot >>> FS0:\efi\boot\>

Re: [edk2-devel] Intel NUC platform firmware -- no serial I/O support?

2022-04-08 Thread Gerd Hoffmann
Hi, > And It Just Works (TM), with the following two commands in the UEFI > shell (after I copied the binaries to the USB stick, alongside the UEFI > Shell binary I built earlier): > > > Shell> fs0: > > FS0:\> cd efi\boot > > FS0:\efi\boot\> load SerialDxe.efi > > Image

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 24/33] MdePkg/BasePeCoff: Add LoongArch PE/Coff related code.

2022-04-08 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:56 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Baoqi > Zhang > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 24/33] >

Re: [edk2-devel] Intel NUC platform firmware -- no serial I/O support?

2022-04-08 Thread Laszlo Ersek
On 04/08/22 00:16, Desimone, Nathaniel L wrote: > Hi Laszlo, > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo >> Ersek >> Sent: Thursday, April 7, 2022 12:46 AM >> To: edk2-devel-groups-io >> Cc: r, ramesh ; Sivaraman Nainar >> ; KARPAGAVINAYAGAM, MANICKAVASAKAM

Re: [edk2-devel] Intel NUC platform firmware -- no serial I/O support?

2022-04-08 Thread Laszlo Ersek
Hi Manic, On 04/07/22 19:04, Manickavasakam Karpagavinayagam wrote: > Laszlo/Gred : > > Can you please let us know the GITHUB project location from where you have > downloaded the source ? I didn't download any new source code. I've just had my local edk2 clone as always, and the small patch

Re: 回复: [edk2-devel] [PATCH v3 0/5] Http Fixes (Take Two)

2022-04-08 Thread Maciej Rabeda
Alright. Reviewed-by: Maciej Rabeda Merge soon. On 7 kwi 2022 14:55, Oliver Steffen wrote: On Thu, Apr 7, 2022 at 2:46 PM Rabeda, Maciej wrote: 1. In HttpResponseWorker(): if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen ("HTTP/1.0")) == 0) { DEBUG ((DEBUG_VERBOSE,

[edk2-devel] [PATCH v3 4/6] OvmfPkg/VirtioGpuDxe: use GopQueryMode in GopSetMode

2022-04-08 Thread Gerd Hoffmann
Call GopQueryMode() in GopSetMode(), use the ModeInfo returned when setting the mode. This is needed to properly handle modes which are not on the static mGopResolutions list. Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtioGpuDxe/Gop.c | 60 -- 1 file

[edk2-devel] [PATCH v3 6/6] OvmfPkg/VirtioGpuDxe: query native display resolution from host

2022-04-08 Thread Gerd Hoffmann
Try query native display resolution from the host. When successfull setup PcdVideoHorizontalResolution and PcdVideoVerticalResolution accordingly and add the video mode to the GOP mode list if needed. Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtioGpuDxe/VirtioGpu.inf | 6 ++

[edk2-devel] [PATCH v3 5/6] OvmfPkg/VirtioGpuDxe: move code to GopInitialize

2022-04-08 Thread Gerd Hoffmann
Add new function to initialize the GOP, move over setup code. Handle initialization first, specifically before calling GopQueryMode(), so GopQueryMode is never called before GopInitialize() did complete. Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtioGpuDxe/Gop.c | 47

[edk2-devel] [PATCH v3 2/6] OvmfPkg/VirtioGpuDxe: add GetDisplayInfo to virtio-gpu spec header.

2022-04-08 Thread Gerd Hoffmann
Add GetDisplayInfo command, reply and data struct to the virtio-gpu specification header file. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Include/IndustryStandard/VirtioGpu.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v3 3/6] OvmfPkg/VirtioGpuDxe: add VirtioGpuGetDisplayInfo

2022-04-08 Thread Gerd Hoffmann
Add support for sending a GetDisplayInfo command. Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtioGpuDxe/VirtioGpu.h | 6 ++ OvmfPkg/VirtioGpuDxe/Commands.c | 20 2 files changed, 26 insertions(+) diff --git a/OvmfPkg/VirtioGpuDxe/VirtioGpu.h

[edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtioGpuDxe: use host display resolution

2022-04-08 Thread Gerd Hoffmann
QemuVideoDxe recently got support for picking up display resolution configuration from the host. This series does the same for VirtioGpuDxe. v3: - rebase to latest master. Gerd Hoffmann (6): OvmfPkg/VirtioGpuDxe: add VirtioGpuSendCommandWithReply OvmfPkg/VirtioGpuDxe: add GetDisplayInfo to

[edk2-devel] [PATCH v3 1/6] OvmfPkg/VirtioGpuDxe: add VirtioGpuSendCommandWithReply

2022-04-08 Thread Gerd Hoffmann
Extend VirtioGpuSendCommand() to support commands which return data, rename the function to VirtioGpuSendCommandWithReply() to indicate that. Add a new VirtioGpuSendCommand() function which is just a thin wrapper around VirtioGpuSendCommandWithReply() so existing code continues to work without

[edk2-devel] [PATCH 1/1] OvmfPkg: restore CompatImageLoaderDxe chunk

2022-04-08 Thread Gerd Hoffmann
Was dropped by accident. Fixes: b47575801e19 ("OvmfPkg: move tcg configuration to dsc and fdf include files") Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfPkgIa32.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index

[edk2-devel] [PATCH v4] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-08 Thread Corvin Köhne
From: Corvin Köhne QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl decided to use the same IO ports as QemuFwCfg. It's not possible to use both interfaces simultaneously. So, prefer QemuFwCfg over BhyveFwCtl. Signed-off-by: Corvin Köhne Acked-by: Gerd Hoffmann Acked-by:

Re: [edk2-devel] [PATCH V2 4/8] OvmfPkg/IntelTdx: Measure Td HobList and Configuration FV

2022-04-08 Thread Min Xu
On April 8, 2022 3:44 PM, Yao Jiewen wrote: > > Can we use a SecMeasurementLib here? Instead of implementing all things in > Startup. > Yes. SecMeasurementLib will be provided in the next version. Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH V2 1/8] Security: Add HashLibBaseCryptoRouterTdx

2022-04-08 Thread Min Xu
On April 8, 2022 3:42 PM, Yao Jiewen wrote: > > I am not sure if we really need router here. > TDX only supports SHA384. What if we just provide HashLibTdx? > Sure. It will be updated in the next version. Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [PATCH V2 2/8] CryptoPkg: Add SecCryptLib

2022-04-08 Thread Min Xu
On April 8, 2022 3:36 PM, Yao Jiewen wrote: > > Hi > The rule for lib instance is: It must provide all interfaces defined in .h > file. > > As such, please use NULL version other algorithms in SEC instance. > Thanks for reminder. It will be updated in the next version. Thanks Min

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 23/33] MdePkg/BaseIoLibIntrinsic: IoLibNoIo for LoongArch architecture.

2022-04-08 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:56 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 23/33] >

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 22/33] MdePkg/BaseCacheMaintenanceLib: LoongArch cache maintenance implementation.

2022-04-08 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:56 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 22/33] >

Re: [edk2-devel] [PATCH V2 4/8] OvmfPkg/IntelTdx: Measure Td HobList and Configuration FV

2022-04-08 Thread Yao, Jiewen
Can we use a SecMeasurementLib here? Instead of implementing all things in Startup. > -Original Message- > From: Xu, Min M > Sent: Friday, April 8, 2022 2:39 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Ard Biesheuvel > ; Yao, Jiewen ; Justen, > Jordan L ; Brijesh Singh ; > Aktas,

Re: [edk2-devel] [PATCH V2 1/8] Security: Add HashLibBaseCryptoRouterTdx

2022-04-08 Thread Yao, Jiewen
I am not sure if we really need router here. TDX only supports SHA384. What if we just provide HashLibTdx? If we really want to provide a router, then it should be HashLibCCRouter. And TDX should be the NULL instance. Thank you Yao Jiewen > -Original Message- > From: Xu, Min M >

Re: [edk2-devel] [PATCH V2 5/8] OvmfPkg: Add PCDs for LAML/LASA field in CC EVENTLOG ACPI table

2022-04-08 Thread Yao, Jiewen
Reiewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Friday, April 8, 2022 2:39 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Lu, Ken ; Sami Mujawar > ; Gerd Hoffmann > Subject:

Re: [edk2-devel] [PATCH V2 6/8] MdePkg: Define CC Measure EventLog ACPI Table

2022-04-08 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Friday, April 8, 2022 2:39 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Kinney, Michael D > ; Gao, Liming ; Liu, > Zhiguang ; Yao, Jiewen ; > Wang, Jian J ; Lu, Ken ; Sami > Mujawar ; Gerd Hoffmann > Subject:

Re: [edk2-devel] [PATCH V2 3/8] SecurityPkg: Add definition of EFI_CC_EVENT_HOB_GUID

2022-04-08 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Friday, April 8, 2022 2:39 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Gerd Hoffmann ; > Yao, Jiewen ; Sami Mujawar > ; Wang, Jian J > Subject: [PATCH V2 3/8] SecurityPkg: Add definition of >

Re: [edk2-devel] [PATCH V2 2/8] CryptoPkg: Add SecCryptLib

2022-04-08 Thread Yao, Jiewen
Hi The rule for lib instance is: It must provide all interfaces defined in .h file. As such, please use NULL version other algorithms in SEC instance. Thank you Yao Jiewen > -Original Message- > From: Xu, Min M > Sent: Friday, April 8, 2022 2:39 PM > To: devel@edk2.groups.io > Cc: Xu,

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 21/33] MdePkg/BaseLib: BaseLib for LOONGARCH64 architecture.

2022-04-08 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:56 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Baoqi > Zhang > Subject: [edk2-devel] [staging/LoongArch RESEND

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 16/33] BaseTools: Enable LoongArch64 architecture for LoongArch64 EDK2 CI.

2022-04-08 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:55 PM > To: devel@edk2.groups.io > Cc: Bob Feng ; Liming Gao > ; Yuwei Chen > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 16/33] > BaseTools:

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 15/33] BaseTools: BaseTools changes for LoongArch platform.

2022-04-08 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:55 PM > To: devel@edk2.groups.io > Cc: Bob Feng ; Liming Gao > ; Yuwei Chen ; Baoqi > Zhang > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1

[edk2-devel] [PATCH V2 8/8] OvmfPkg/IntelTdx: Enable RTMR based measurement and measure boot

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 Enable RTMR based measurement and measure boot for Td guest. Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Ken Lu Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Min Xu ---

[edk2-devel] [PATCH V2 7/8] OvmfPkg/IntelTdx: Add TdTcg2Dxe

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 TdTcg2Dxe mimics the Security/Tcg/Tcg2Dxe. It does below tasks: - Set up and install CC_EVENTLOG ACPI table - Parse the GUIDed HOB (gCcEventEntryHobGuid) and create CC event log - Measure handoff tables, Boot# variables etc -

[edk2-devel] [PATCH V2 6/8] MdePkg: Define CC Measure EventLog ACPI Table

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the event-log information. The event log created by the TD owner contains the hashes to reconstruct the MRTD and RTMR registers. Please refer to Sec 4.3.3 in blow link:

[edk2-devel] [PATCH V2 5/8] OvmfPkg: Add PCDs for LAML/LASA field in CC EVENTLOG ACPI table

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 Add PCDs to records LAML/LASA field in CC EVENTLOG ACPI table. Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Ken Lu Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Min Xu ---

[edk2-devel] [PATCH V2 4/8] OvmfPkg/IntelTdx: Measure Td HobList and Configuration FV

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 TdHobList and Configuration FV are external data provided by Host VMM. These are not trusted in Td guest. So they should be validated , measured and extended to Td RTMR registers. In the meantime 2 EFI_CC_EVENT_HOB are created. These 2

[edk2-devel] [PATCH V2 2/8] CryptoPkg: Add SecCryptLib

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 This is the Cryptographic library instance for SEC. The motivation of this library is to support SHA384 in SEC phase for Td guest. So only Hash/CryptSha512.c is included which supports SHA384 and SHA512. Cc: Jiewen Yao Cc: Jian J Wang

[edk2-devel] [PATCH V2 1/8] Security: Add HashLibBaseCryptoRouterTdx

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 This library provides hash service by registered hash handler in Td guest. It redirects hash request to each individual hash handler (currently only SHA384 is supported). After that the hash value is extended to Td RTMR registers which is

[edk2-devel] [PATCH V2 3/8] SecurityPkg: Add definition of EFI_CC_EVENT_HOB_GUID

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 EFI_CC_EVENT_HOB_GUID is the global ID of a GUIDed HOB used to pass TDX_DIGEST_VALUE from SEC to a DXE Driver ( This DXE driver will be introduced in the following commit in this patch-sets ). In that DXE driver this GUIDed HOB will be

[edk2-devel] [PATCH V2 0/8] Enable RTMR based measurement and measure boot for Td guest

2022-04-08 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A

回复: [edk2-devel] [PATCH 1/1] UEFI-SCT: SctPkg: Updated the check for monotonic count after restart

2022-04-08 Thread Gao Jie
Hi Eday, The patch looks good to me. Reviewed-by: Barton Gao Thanks Barton -邮件原件- 发件人: devel@edk2.groups.io 代表 G Edhaya Chandran 发送时间: 2022年3月3日 16:59 收件人: devel@edk2.groups.io 主题: [edk2-devel] [PATCH 1/1] UEFI-SCT: SctPkg: Updated the check for monotonic count after restart

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 14/33] BaseTools: BaseTools changes for LoongArch platform.

2022-04-08 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:55 PM > To: devel@edk2.groups.io > Cc: Bob Feng ; Liming Gao > ; Yuwei Chen ; Baoqi > Zhang > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 13/33] BaseTools: BaseTools changes for LoongArch platform.

2022-04-08 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:55 PM > To: devel@edk2.groups.io > Cc: Bob Feng ; Liming Gao > ; Yuwei Chen ; Baoqi > Zhang > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 13/33] > BaseTools:

Re: [edk2-devel] [PATCH v3] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-08 Thread Yao, Jiewen
Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Corvin > Köhne > Sent: Friday, April 8, 2022 1:53 PM > Cc: Corvin Köhne ; Köhne, Corvin > ; Ard Biesheuvel ; Yao, > Jiewen ; Justen, Jordan L ; > devel@edk2.groups.io; FreeBSD Virtualization