Min:
The change in MdePkg is good to me. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: Min Xu
> 发送时间: 2022年4月17日 11:01
> 收件人: devel@edk2.groups.io
> 抄送: Min Xu ; Michael D Kinney
> ; Liming Gao ;
> Zhiguang Liu ; James Bottomley
> ; Jiewen Yao ; Gerd Hoffmann
> ; Brijesh Singh
Zhihao:
I see three platforms in edk2-platforms to consume VariableStandaloneMm
module. So, I think this change will impact them. Can you confirm this change
with those platform owners?
Platform\ARM\SgiPkg\PlatformStandaloneMm.fdf
Platform\Socionext\DeveloperBox\DeveloperBoxMm.fdf
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Bo Chang Ke
> 发送时间: 2022年4月15日 16:35
> 收件人: Gao, Zhichao ; devel@edk2.groups.io
> 抄送: Liu, Zhiguang ; Bi, Dandan
> ; Zeng, Star ; Gao, Liming
> ; Kinney, Michael D
>
> 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update
Series reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Sunday, April 17, 2022 11:01 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Kinney, Michael D
> ; Gao, Liming ; Liu,
> Zhiguang ; James Bottomley ;
> Yao, Jiewen ; Gerd Hoffmann ;
> Brijesh Singh ; Aktas,
Guomin:
I understand the purpose. But, I don't see the complete solution to configure
DEBUG_FILE_PATH for every source file in order to meet with the debug image
reproducible builds. Have you verified this solution with the real
DEBUG_FILE_PATH for every source file? Or, you just set
On April 16, 2022 10:52 PM, Tom Lendacky wrote:
> On 4/15/22 19:13, Xu, Min M wrote:
> > On April 16, 2022 4:05 AM, Tom Lendacky wrote:
> >>>#define SEC_IDT_ENTRY_COUNT 34
> >>> @@ -738,6 +737,20 @@ SecCoreStartupWithStack (
> >>> UINT32Index;
> >>> volatile UINT8
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
TdIsEnabled() uses the CPUID instruction. At this point, exception
handling is not established and a CPUID instruction will generate
a #VC and cause the booting guest to crash.
CcProbe() checks Ovmf work area to return the guest type. So
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
Bad IO performance in SEC phase is observed after TDX features was
introduced. (after commit b6b2de884864 - "MdePkg: Support mmio for
Tdx guest in BaseIoLibIntrinsic").
This is because IsTdxGuest() will be called in each MMIO operation.
It
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
CcProbeLib is imported in BaseIoLibIntrinsicSev.
OvmfPkg/Library/CcProbeLib is the OvmfPkg version which checks
OvmfWorkArea to return the Cc guest type. It is included
in OvmfPkgX64.dsc and IntelTdx/IntelTdxX64.dsc.
Other .dsc include the
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
This is the OvmfPkg specific CcProbeLib. It checks the Ovmf WorkArea
(PcdOvmfWorkAreaBase) to return the guest type.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: James Bottomley
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
CcProbeLib is used to probe the Confidential Computing guest type.
This library is designed to run on SEC / PEI / DXE phases. A null
instance of the library always returns CCGuestTypeNonEncrypted.
A platform specific CcProbeLib will be
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
Replace GUEST_TYPE with CC_GUEST_TYPE which is defined in
MdePkg/Include/ConfidentialComputingGuestAttr.h.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
The confidential computing guest type (GUEST_TYPE) was defined in
OvmfPkg/Include/WorkArea.h. Now it is to be moved to
MdePkg/Include/ConfidentialComputingGuestAttr.h and renamed as
CC_GUEST_TYPE.
There are 2 reasons for this change.
1.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
Bad IO performance in SEC phase is observed after TDX features was
introduced. (after commit b6b2de884864 - "MdePkg: Support mmio for
Tdx guest in BaseIoLibIntrinsic").
This is because IsTdxGuest() will be called in each MMIO operation.
It
On April 16, 2022 11:09 PM, Lendacky, Thomas wrote:
> On 4/15/22 20:57, Xu, Min M wrote:
> > On April 16, 2022 4:52 AM, Lendacky, Thomas wrote:
> >>
> >> Unfortunately, this driver also breaks SEV-ES. I bypassed the TDX
> >> code in the SEC library, but then hit an issue because this driver is
>
Thanks,
I have updated my Proposal based on the discussion on the mailing
list, so feel free to give feedback on that.
As far as my views go, I agree that it's not realistic to convert all
edk2 to Rust. I think of this project to be about making Rust an
option to do firmware development in, and
On 4/15/22 20:57, Xu, Min M wrote:
On April 16, 2022 4:52 AM, Lendacky, Thomas wrote:
Unfortunately, this driver also breaks SEV-ES. I bypassed the TDX code in the
SEC library, but then hit an issue because this driver is loaded before the
AmdSevDxe driver. The AmdSevDxe driver performs a
Hi all,
Inspired by the current possible QemuOpenBoardPkg efforts in GSoC, I'm
interested in writing
something similar myself, in my spare time, possibly using the ARM or RISCV
virt machine types in QEMU as a basis.
The MinPlatform spec is (or at least, looks) pretty detailed on porting
platforms
HI Li,
No, you don’t have to remove the tailing “_”. You can check section 5.3.5. in
EDK2 C Coding Standards Spec.
Regards,
Abner
From: Chao Li
Sent: Tuesday, April 12, 2022 5:05 PM
To: Chang, Abner (HPS SW/FW Technologist)
Cc: "devel@edk2.groups.io" ; Michael D Kinney
; Liming Gao ; Zhiguang
On 4/15/22 19:13, Xu, Min M wrote:
On April 16, 2022 4:05 AM, Tom Lendacky wrote:
#define SEC_IDT_ENTRY_COUNT 34
@@ -738,6 +737,20 @@ SecCoreStartupWithStack (
UINT32Index;
volatile UINT8*Table;
+ #if defined (TDX_GUEST_SUPPORTED)
+ if (TdIsEnabled ()) {
Hi Li,
Maybe I forget to attach it. The cover letter of that CpuLib patch set attached.
Regards,
Abner
From: Chao Li
Sent: Wednesday, April 13, 2022 11:17 AM
To: Chang, Abner (HPS SW/FW Technologist)
Cc: "devel@edk2.groups.io" ; Michael D Kinney
; Liming Gao ;
I've submitted an updated version of my proposal document. There's a little
more detail and I've shifted from using the term "dynamic linking" to "code
sharing" to reflect the fact that the question of which solution will fit
best is not yet answered. If there are any more important matters not
22 matches
Mail list logo
