It looks good to me. Thanks for fixing it.
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kun Qin
> Sent: Wednesday, March 16, 2022 12:00 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Dong, Eric ; Ni,
> Ray ; Wang, Jian J ;
Minor comments:
It would be great if adding some descriptions to the fields to make its usage
more clear.
Maybe we need give this header file and structure a more generic name by using
"OS" instead of "LINUX" so that bootloader could pass command line to Android
and other OSes using same
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, April 22, 2022 11:51 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Dong, Guo ; You, Benjamin
> ; Rhodes, Sean
> ; Liu, Zhiguang
> Subject: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB
>
> Add
Add definition for UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE Hob.
This Hob is used to pass Linux Kernel command Line to Payload
Signed-off-by: Dun Tan
Cc: Ray Ni
Cc: Guo Dong
Cc: Benjamin You
Cc: Sean Rhodes
Cc: Zhiguang Liu
Signed-off-by: Dun Tan
---
Reviewed-by: Guo Dong
-Original Message-
From: Tan, Dun
Sent: Monday, April 18, 2022 5:51 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Dong, Guo ; You, Benjamin
; Liu, Zhiguang
Subject: [PATCH] UefiPayloadPkg: Fix IA32 entry build failure
The ObjCopyFlag and EntryOutputDir need to be
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Ke, Bo-ChangX
> Sent: Wednesday, April 20, 2022 2:42 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao
> Subject: [PATCH] ShellPkg: Update smbiosview type 0 with SMBIOS 3.5 fields
>
>
Change:
https://github.com/tianocore/edk2/pull/2797 is used to merge these two
patches.
Thanks
Liming
> -邮件原件-
> 发件人: Ke, Bo-ChangX
> 发送时间: 2022年4月21日 19:06
> 收件人: devel@edk2.groups.io; Ke, Bo-ChangX
> 抄送: Gao, Liming ; Kinney, Michael D
> ; Liu, Zhiguang ; Gao,
> Zhichao ; Bi,
Hello MdeModulePkg maintainers,
This patch series has received reviews for all patches. I have placed a
rebased branch with up-to-date review tags in the following PR:
https://github.com/tianocore/edk2/pull/2812
Please let me know if anything further is needed for you to merge the PR.
Thanks Mike I will send a new patch with inf file name untouched.
Mateusz
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89201): https://edk2.groups.io/g/devel/message/89201
Mute This Topic: https://groups.io/mt/88346995/21656
Group
Mateusz,
I recommend just adding PEIM to the existing INF and not changing the name
of the C/INF file. Please update the file headers for both the existing
INF and C file to describe the module types this library is compatible with.
This allows platform developers to understand the
Reviewed-by: Sean Brogan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89199): https://edk2.groups.io/g/devel/message/89199
Mute This Topic: https://groups.io/mt/90576240/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Sean Brogan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89198): https://edk2.groups.io/g/devel/message/89198
Mute This Topic: https://groups.io/mt/90576320/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Hi SMM maintainers,
A gentle ping on this. Could you please provide some feedback on the fix
below for allocating 0 sized pool when heap guard it on?
Thanks in advance,
Kun
On 3/28/2022 2:57 PM, Kun Qin wrote:
Thanks, Liming.
SMM owners/authors,
Could you please also review the original
The python BaseTools/Edk2ToolsBuild.py creates files in
BaseTools/BaseToolsBuild and should be ignored.
Signed-off-by: Jeff Brasen
---
BaseTools/.gitignore | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore
index
On 4/19/22 00:06, Yao, Jiewen wrote:
OK. Let me describe what I think.
PCI Express BAR need to be initialized by someone in the platform.
This initialization may require CFG8. That is understandable.
A good design is that: After the PCIE BAR is initialized, it can be accessed.
Requires
Link in pcie and host bridge bits. Enables support for PCIe in microvm
(qemu-system-x86_64 -M microvm,pcie=on).
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Microvm/MicrovmX64.dsc | 40 +-
Those old windows versions which need the vbeshim hack
will not run on microvm anyway.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/QemuVideoDxe/VbeShim.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.c b/OvmfPkg/QemuVideoDxe/VbeShim.c
index
microvm places the 64bit mmio space at the end of the physical address
space. So mPhysMemAddressWidth must be correct, otherwise the pci host
bridge setup throws an error because it thinks the 64bit mmio window is
not addressable.
On microvm we can simply use standard cpuid to figure the address
io range is not mandatory according to pcie spec,
so allow host bridges without io address space.
Signed-off-by: Gerd Hoffmann
---
.../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++-
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git
Needs two little tweaks in PCI code because microvm supports mmio only.
Other than that just wire up the existing code (the PCIe host adapter
used by microvm is the same (virtual) hardware used by the arm/aarch64
virtual machines).
v4:
- update PciHostBridge check (Abner Chang).
v3:
- rebase
Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we
want use that library.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 4 +++-
OvmfPkg/PlatformPei/PlatformPei.inf | 2 +-
OvmfPkg/Library/PlatformInitLib/MemDetect.c
io range is not mandatory according to pcie spec,
so allow bridge configurations without io address
space assigned.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Ard Biesheuvel
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Fri, Apr 08, 2022 at 10:22:44AM +0200, Gerd Hoffmann wrote:
> Was dropped by accident.
>
> Fixes: b47575801e19 ("OvmfPkg: move tcg configuration to dsc and fdf include
> files")
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 3 +++
> 1 file changed, 3 insertions(+)
>
>
I agree. Thanks to catch this.
From: Zeng, Star
Sent: Thursday, April 21, 2022 7:20 PM
To: devel@edk2.groups.io
Cc: brijesh.si...@amd.com; Ni, Ray ; Yao, Jiewen
; kra...@redhat.com
Subject: Shouldn't PcdSevEsIsEnabled be removed from UefiCpuPkg?
Hi,
After
Hi,
After
https://github.com/tianocore/edk2/pull/2269/commits/c6c83f98fabbe3e58bc0579bade3a807c93dd690,
no consumer to PcdSevEsIsEnabled anymore.
Shouldn't PcdSevEsIsEnabled be removed from UefiCpuPkg?
Thanks,
Star
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
Hi Liming, Mike,
Fix coding style issue,
And create a PR here: https://github.com/tianocore/edk2/pull/2811
The CI checks have passed.
Can you help push this PR?
Thank you very much.
Best Regards.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bo Chang Ke
Sent: Thursday,
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
update smbiosview type 9 related fileds.
Signed-off-by: Bo Chang Ke
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Liming Gao
Cc: Michael D Kinney
---
.../SmbiosView/PrintInfo.c| 9 +-
.../SmbiosView/QueryTable.c
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
update smbiosview type 9 related fileds.
Signed-off-by: Bo Chang Ke
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhiguang Liu
Cc: Zhichao Gao
Cc: Dandan Bi
Cc: Star Zeng
---
MdePkg/Include/IndustryStandard/SmBios.h | 177
Adding CFV and TD_HOB to MRTD is technically possible, but not desired.
In a typical trust boot use case, the verifier should have a way to distinguish
the *code* from *configuration*.
If you look at the TCG specification, the TPM has 24 PCRs. 8 of them are
allocated for BIOS. Each PCRs record
Patch looks good.
Reviewed-by: Bob Feng
-Original Message-
From: Li, Yi1
Sent: Monday, April 18, 2022 4:15 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/1] BaseTools: Move gPlatformFinalPcd to Datapipe and optimize
size
REF:
On Wed, Apr 20, 2022 at 10:29:11PM +, Yao, Jiewen wrote:
> The Root-of-Trust for Measurement (RTM) for TDX is TDX-Module. The TDX-Module
> will enforce the MRTD calculation for the TDVF code.
> Then TDVF can then act as Chain-of-Trust for Measurement (CTM) to setup RTMR
> and continue the
Hi Liming,
For Q2, all ECC errors is come from register naming. I think what you are
pointing out is not UEFI SPEC, we have the LoongArch ISA manual on GitHub where
all of register naming are defined. Dose that means it is a public SPEC? If
yes, what should I do to get the Azure CI ECC to
Thank you for your comment.
I will move the SmmCpuRendezvousLib.h file and NullLib implementation to MdePkg.
Thanks
Zhihao
-Original Message-
From: Michael Kubacki
Sent: Thursday, April 21, 2022 2:42 AM
To: devel@edk2.groups.io; Li, Zhihao
Cc: Wang, Jian J ; Gao, Liming
; Fu,
Merged - https://github.com/tianocore/edk2/pull/2810
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
> Sent: Thursday, April 21, 2022 8:53 AM
> To: devel@edk2.groups.io; Li, Yi1
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Declare
34 matches
Mail list logo
