Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of cbduggap
> Sent: Monday, April 25, 2022 12:39 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage
> address
>
> In Release
This patch looks good to me.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jake Garver via
groups.io
Sent: Friday, April 8, 2022 1:04 AM
To: devel@edk2.groups.io; jbra...@nvidia.com; ashishsin...@nvidia.com
Cc: Jake Garver
Subject: [edk2-devel]
Thanks Chasel. I pushed a branch rebased on the latest master branch
with R-b tags here in case that helps with merging:
https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1
Regards,
Michael
On 4/25/2022 12:08 AM, Chiu, Chasel wrote:
Thanks Michael!
Reviewed-by: Rebecca Cran
Maybe I'm misunderstanding, but the commit message looks wrong: there's
no OvmfPkg/BhyveBhfPkg - it's OvmfPkg/Bhyve .
--
Rebecca Cran
On 4/8/22 02:15, Corvin Köhne wrote:
From: Corvin Köhne
QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl
Thanks Jiewen. I added this R-b (and all others) to the V5 PR here:
https://github.com/tianocore/edk2/pull/2828
Regards,
Michael
On 4/25/2022 10:14 PM, Yao, Jiewen wrote:
Reviewed-by: Jiewen Yao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael
Kubacki
Sent:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
Hi Corvin
According to the process, we need
1) Reviewed-by from package maintainer. (or)
2) Reviewed-by from feature review + Acked-by from package maintainer.
You got 4 Acked-by now, including package maintainer.
We need one Reviewed-by at least, from either Bhyve reviewer or Ovmf maintainer.
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Tuesday, April 26, 2022 9:29 AM
> To: devel@edk2.groups.io
> Cc: Anthony Perard ; Ard Biesheuvel
> ; Brijesh Singh ; Aktas,
> Erdem ; Gerd Hoffmann ;
> James Bottomley ; Yao,
Hi Pierre,
Python Basetools module has enabled this feature recently, and this modules has
updated to 0.17, just as pip-requirements.txt:
https://github.com/tianocore/edk2-basetools/commit/74460f5e33ef3e3790797e069095fc12003f0d00
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: Gerd Hoffmann
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Andrew Fish
Cc: Ray Ni
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Michael Kubacki
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Cc: Julien Grall
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20220317T223602Z
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds support to the UEFI variable fault tolerant write (FTW) drivers
to receive FTW base and size information dynamically via the Variable
Flash Information library.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Updates VariableRuntimeDxe, VariableSmm, and VariableStandaloneMm
to acquire variable flash information from the Variable Flash
Information library.
Note: This introduces a dependency on VariableFlashInfoLib in these
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds a new library class VariableFlashInfoLib that abstracts access
to variable flash information. The instance provided first attempts
to retrieve information from the Variable Flash Info HOB. If that
HOB is not
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds a new GUID that is used to identify a HOB that passes variable
flash information to UEFI variable drivers in HOB consumption phases
such as DXE, Traditional MM, and Standalone MM.
This information was previously
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Platforms: This series introduces a new library class called
VariableFlashInfoLib. Platforms using the variable modules will
need to specify these library classes. See the patches at the
end of this series for
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3488
This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/87618
v2 patches mainly focus on feedback for commits submitted in v1 patches:
a. Added reviewed-by tags;
Patch v2 branch:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3488
Current free pool routine from PiSmmCore will inspect memory guard status
for target buffer without considering pool headers. This could lead to
`IsMemoryGuarded` function to return incorrect results.
In that sense, allocating a 0 sized
Hi Roger,
There is an update for SMBIOS type 0 at commit ID fdfbf1fd-a85ae8d9. Please
rebase the changes to edk2 master branch and send out the patch V2.
Thanks
Abner
From: Hsu, Roger (HPE ISS SW)
Sent: Friday, April 22, 2022 2:55 PM
To: devel@edk2.groups.io
*Tools, CI, Code base construction meeting series*
*When:*
04/25/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1475883 )
*Description:*
TianoCore community,
Thanks for your review. I will make that change.
Regards,
Michael
On 4/25/2022 12:05 PM, Sami Mujawar wrote:
Hi Michael,
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm,
Thanks for pointing those out. It looks like ArmVExpress.dsc.inc can
include it for both of those platforms. I'll add that in a V2.
Regards,
Michael
On 4/25/2022 12:06 PM, Sami Mujawar wrote:
Hi Michael,
There are other platforms in edk2-platforms that would possibly require
similar
Consume the host-provided specification of PCI host bridges if
available. Using the DxeHardwareInfoLib, populate a list of
hardware descriptors based on the content of the "hardware-info"
fw-cfg file, if provided. In the affirmative case, use the
resources and attributes specified by the
Read the "hardware-info" item from fw-cfg to extract specifications
of PCI host bridges and analyze the 64-bit apertures of them to
find out the highest 64-bit MMIO address required which determines
the address space required by the guest, and, consequently, the
FirstNonAddress used to calculate
Define the HardwareInfoLib API and create the PeiHardwareInfoLib
which implements it, specifically for Pei usage, supporting
only static accesses to parse data directly from a fw-cfg file.
All list-like APIs are implemented as unsupported and only a
fw-cfg wrapper to read hardware info elements is
Increased control is provided in Ovmf platforms to define and configure
the specifications of multiple PCI host bridges in the hypervisor. The
host propagates this information to the guest, initially through fw-cfg
interface.
In some AWS EC2 platforms, we expose a PCI topology including several
On Fri, 22 Apr 2022 at 09:37, Gerd Hoffmann wrote:
>
> io range is not mandatory according to pcie spec,
> so allow bridge configurations without io address
> space assigned.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Ard Biesheuvel
Could one of the MdeModulePkg maintainers please get
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3913
The original flow of PcRtcInit() is like:
1. Guarantee atomic accesses to the RTC time registers and
read out the value.
2. Program RTC register B. (adopt 12h mode or 24h mode. Current
bios code sets RTC to 24h mode by default).
3.
Ping. If someone could take a look, it would be much appreciated.
On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato
wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3745
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871
>
> Hi all,
>
> This patch-set attempts to address two open
Ping. If someone could take a look, it would be much appreciated.
On Thu, Apr 7, 2022 at 11:02 PM Pedro Falcato
wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871
>
> Add the CRC16-ANSI and CRC32C implementations previously found at
> Features/Ext4Pkg/Ext4Dxe/Crc{16,32c}.c to
Hi Michael,
There are other platforms in edk2-platforms that would possibly require
similar changes.
e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc,
Platform\ARM\JunoPkg\ArmJuno.dsc, etc.
Do you plan to submit patches to update these platforms as well?
Regards,
Sami Mujawar
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/04/2022 09:44 pm, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds support to the UEFI
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Updates VariableRuntimeDxe,
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds a new GUID that is used
Hi Michael,
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
Hello Yi1, Jiewen, and Bob,
As you mentioned in the cover letter, this patch relies on the following patch
bf9230a9f3dd ("BaseTools: Add the FeatureFlagExpression usage to the Source
Section")
https://github.com/tianocore/edk2/commit/bf9230a9f3dde065c3c8b4175ccd32e44e8f0362
I just wanted to
Hi all,
Are there any other comments or concerns regarding this patch?
Thanks,
Stacy
-Original Message-
From: Howell, Stacy
Sent: Friday, January 14, 2022 4:13 PM
To: Kinney, Michael D ; devel@edk2.groups.io;
spbro...@outlook.com; Gao, Liming
Cc: Bi, Dandan ; Howell, Stacy
Subject:
[Public]
Hi,
Please review the patch.
Thanks
AbduL
-Original Message-
From: Attar, AbdulLateef (Abdul Lateef)
Sent: 05 April 2022 11:25
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
; Eric Dong ; Liming Gao
Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1]
From: Ian Chiu
Add support process Port Speed field value of PORTSC according to Supported
Protocol Capability
(new design in xHCI spec 1.2 2019)
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3914
The value of Port Speed field in PORTSC bit[10:13] (xHCI spec 1.2 2019 section
5.4.8)
Hello maintainers,
Any interest in accepting this and the "BaseTools/Conf: Fix
Dynamic-Library-File template" patch?
Thanks,
Jake
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89268): https://edk2.groups.io/g/devel/message/89268
Mute
Hi,
does it require more review to get merged?
Best regards
Corvin
Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
-Original Message-
From: Corvin Köhne
Sent: Friday, April 8,
Thanks.
Reviewed-by: Abner Chang
> -Original Message-
> From: Gerd Hoffmann
> Sent: Monday, April 25, 2022 6:35 PM
> To: devel@edk2.groups.io
> Cc: Jiewen Yao ; Oliver Steffen
> ; Leif Lindholm ; Pawel
> Polawski ; Hao A Wu ;
> Chang, Abner (HPS SW/FW Technologist) ; Liming
> Gao ; Ray
On Mon, 25 Apr 2022 at 12:36, Gerd Hoffmann wrote:
>
> On Fri, Apr 08, 2022 at 10:23:27AM +0200, Gerd Hoffmann wrote:
> > QemuVideoDxe recently got support for picking up
> > display resolution configuration from the host.
> > This series does the same for VirtioGpuDxe.
> >
> > v3:
> > - rebase
On Mon, 25 Apr 2022 at 12:34, Gerd Hoffmann wrote:
>
> Needs two little tweaks in PCI code because microvm supports mmio only.
> Other than that just wire up the existing code (the PCIe host adapter
> used by microvm is the same (virtual) hardware used by the arm/aarch64
> virtual machines).
>
>
On Fri, Apr 08, 2022 at 10:23:27AM +0200, Gerd Hoffmann wrote:
> QemuVideoDxe recently got support for picking up
> display resolution configuration from the host.
> This series does the same for VirtioGpuDxe.
>
> v3:
> - rebase to latest master.
Ping. Anything blocking the merge id this
io range is not mandatory according to pcie spec,
so allow host bridges without io address space.
Signed-off-by: Gerd Hoffmann
---
.../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++-
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git
Link in pcie and host bridge bits. Enables support for PCIe in microvm
(qemu-system-x86_64 -M microvm,pcie=on).
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Microvm/MicrovmX64.dsc | 40 +-
microvm places the 64bit mmio space at the end of the physical address
space. So mPhysMemAddressWidth must be correct, otherwise the pci host
bridge setup throws an error because it thinks the 64bit mmio window is
not addressable.
On microvm we can simply use standard cpuid to figure the address
Those old windows versions which need the vbeshim hack
will not run on microvm anyway.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/QemuVideoDxe/VbeShim.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.c b/OvmfPkg/QemuVideoDxe/VbeShim.c
index
Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we
want use that library.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 4 +++-
OvmfPkg/PlatformPei/PlatformPei.inf | 2 +-
OvmfPkg/Library/PlatformInitLib/MemDetect.c
Needs two little tweaks in PCI code because microvm supports mmio only.
Other than that just wire up the existing code (the PCIe host adapter
used by microvm is the same (virtual) hardware used by the arm/aarch64
virtual machines).
v6:
- codestyle fix (Abner Chang).
v5:
- codestyle
io range is not mandatory according to pcie spec,
so allow bridge configurations without io address
space assigned.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Ard Biesheuvel
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
REF： https://bugzilla.tianocore.org/show_bug.cgi?id=3912
UefiCpuPkg define a new Protocol with the new services
SmmWaitForAllProcessor(), which can be used by SMI handler
to optionally wait for other APs to complete SMM rendezvous in
relaxed AP mode.
VariableSmm and VariableStandaloneMM driver
> +Usage
> +-
> +
> +Assuming TDX-QEMU/TDX-KVM are already built, one can start a TD virtual
> +machine as follows:
Not working (yet) with upstream qemu. This needs a clarification which
qemu repository you are talking about (and once tdx patches landed
upstream this should be replaced with
Reviewed-by: Ray Ni
+ @Wang, Jian J
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of cbduggap
> Sent: Monday, April 25, 2022 12:39 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing
> garbage address
>
> In Release
71 matches
Mail list logo
