Reviewed-by: Jenny Huang
-Original Message-
From: Sheng, W
Sent: Wednesday, June 8, 2022 10:11 PM
To: devel@edk2.groups.io
Cc: Kowalewski, Robert ; Ni, Ray
; Chaganty, Rangasai V ;
Huang, Jenny
Subject: [PATCH v3] IntelSiliconPkg/VTd: Add PCD for VTd Abort DMA Mode Support
PcdVTdSupportAbortDmaMode is used to enable/disable using VTd Abort DMA Mode.
Signed-off-by: Sheng Wei
Reviewed-by: Robert Kowalewski
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Jenny Huang
Change-Id: If999d2f4906bda887dffe8574ec17cb90346b710
---
.../Feature/VTd/IntelVTdDmarPei/IntelVTdDmar.c
Gerd,
I am interested in this patch sets. But I have some trouble to get all the
patches. Do you have a branch that contains all the changes?
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, June 3, 2022 8:27 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu,
For "3) Could you help to check if the DMA memory related codes in
MdeModulePkg\Bus\Ata\AhciPei\DmaMem.c can be covered by the 'PciIo' service in
EDKII_PCI_DEVICE_PPI?"
After a second thought, my take is that there will be no PciBusPei
implementation added in edk2.
So there will be no
Couple of general level comments/questions:
1) The implementation of functions AtaAhciPciDevicePpiInstallationCallback() &
AtaAhciInitPrivateDataFromPciDevice() has many duplications. Is it possible to
abstract a separate function to reduce duplicated codes?
2) What DevicePathLib instance should
>From the device controllers perspective, current drive implementation needs
>the below information:
* AHCI: HC MMIO BAR & DevicePath
* NVMe: HC MMIO BAR & DevicePath
* UFS: HC MMIO BAR
* SD/MMC: HC MMIO BAR
* USB - XHCI: HC MMIO BAR & USB controller type (I think this can be identified
by
Sorry for a question, if the EDKII_PCI_DEVICE_PPI were added to edk2, would
there be a plan to add support to:
* NVMe
* UFS
* SD/MMC
* USB (XHCI, EHCI and UHCI)
Best Regards,
Hao Wu
> -Original Message-
> From: Czajkowski, Maciej
> Sent: Monday, June 6, 2022 8:45 PM
> To:
Acked-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Heng Luo
> Sent: Monday, June 6, 2022 6:07 PM
> To: Desimone, Nathaniel L ;
> devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Sinha, Ankit
> ; Kubacki, Michael
>
> Subject: Re: [edk2-devel]
Mike,
This sounds like a conversation we had years ago? I think we concluded we
needed to write stuff in assembler and not depend on implementation choices of
the compiler with regard to registers usage? I want to say something broke with
Xcode clang. I think it might have been the Emulator
Reviewed-by: Nate DeSimone
-Original Message-
From: Oram, Isaac W
Sent: Tuesday, June 7, 2022 4:49 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Chiu, Chasel
Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1]
WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout
Reviewed-by: Nate DeSimone
-Original Message-
From: Oram, Isaac W
Sent: Tuesday, June 7, 2022 7:33 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Leif Lindholm
; Kinney, Michael D ;
Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1]
Hi,
On 07. 06. 22, 12:31, Gerd Hoffmann wrote:
The reason is TemporaryRamMigration() overwrites rbp unconditionally -- it
adds an offset to rbp even if rbp is NOT used as a frame pointer
Now, what is the right way to fix this? Do the SetJump/LongJump in assembly
and wrap it into push rbp/pop
From: fanwang2intel
Add "-T " parameter to provide fixed
FIT address on flash region. When this parameter is set
to a valid address in the input FD/FV file, tool will
directly generate FIT on this address.
It's users' responsibilities to reserve enough size for
FIT table and option modules on
Hi Ashish,
On 6/7/2022 10:58 PM, Kalra, Ashish wrote:
>
> Hello Nikunj,
>
> Yes we can move MemEncryptSevLiveMigrationIsEnabled() check here before
> calling SetMemoryEncDecHypercall3()
>
> but then we also need to remove the same check from inside
> SetMemoryEncDecHypercall3() function.
On 07. 06. 22, 13:07, Gerd Hoffmann wrote:
On Tue, Jun 07, 2022 at 12:38:46PM +0200, Jiri Slaby wrote:
Hi,
On 07. 06. 22, 12:31, Gerd Hoffmann wrote:
The reason is TemporaryRamMigration() overwrites rbp unconditionally -- it
adds an offset to rbp even if rbp is NOT used as a frame pointer
Hi Ashish,
For case with latest OVMF and older qemu that does not enable live migrations,
SetMemoryEncDecHypercall3() returns RETURN_UNSUPPORTED, which is correct.
But then its actually treated as an error and OVMF sees an assert. This is a
valid usecase
and OVMF should move ahead without live
Reviewed-by: Sai Chaganty
-Original Message-
From: Oram, Isaac W
Sent: Tuesday, June 07, 2022 7:33 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Leif Lindholm
; Kinney, Michael D ;
Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1]
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, June 7, 2022 7:33 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Leif Lindholm
> ; Kinney, Michael D
> ; Chaganty, Rangasai V
> ; Desimone, Nathaniel L
>
> Subject:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, June 7, 2022 7:24 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Leif Lindholm
> ; Kinney, Michael D
>
> Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainters.txt: Add
> Isaac
Reviewed-by: Lean Sheng Tan
On Mon, 6 Jun 2022 at 02:56, Benjamin Doron
wrote:
> Writes TianoCore debug logs into the CBMEM console ringbuffer, from
> where the user can retrieve them with the `cbmem` userspace utility.
>
> The intention is to aid in debugging non-fatal issues even in
Merged https://github.com/tianocore/edk2/pull/2956
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, June 8, 2022 6:10 PM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; James Bottomley
> ; Gao, Liming ; Tom
> Lendacky ; Brijesh Singh
> ; Gerd Hoffmann ; Justen,
> Jordan L
The ebp/rbp register can either be used for the frame pointer or
as general purpose register. With gcc (and clang) this depends
on the -f(no-)omit-frame-pointer switch.
This patch updates tools_def.template to explicitly set the compiler
option and also add a define to allow conditionally
> Apparently this not the case though. Maybe older gcc versions have
> different defaults. I'll investigate.
Using -fomit-frame-pointer for x64 and
-fno-omit-frame-pointer for ia32 passes CI for me
(https://github.com/tianocore/edk2/pull/2955), I'll send the new patch
i a moment.
take care,
On Wed, Jun 08, 2022 at 06:54:05AM +, Yao, Jiewen wrote:
> Hey Gerd
> CI failed - https://github.com/tianocore/edk2/pull/2954
Oh.
> Have you run the CI before you submit the patch?
Nope.
According to the gcc man page -fomit-frame-pointer is enabled by default
for -O1 (and higher levels),
Hey Gerd
CI failed - https://github.com/tianocore/edk2/pull/2954
Have you run the CI before you submit the patch?
Thank you
Yao Jiewen
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, June 7, 2022 10:58 PM
> To: kra...@redhat.com
> Cc: devel@edk2.groups.io; Pawel Polawski ;
Hi,
> > > But I still have some doubts about using linux-style page split.
> > > Because it's marked as not present:
> > > 1. Active code should not access data in the 2M region (stack is in the
> > > 2M region in our case)
> > > 2. Active code should not in the 2M region (how to guarantee
Hi,
> The container image provides the required compiler toolchains and Qemu
> for the supported architectures. These are then no longer downloaded at
> runtime, avoiding CI failures due to download errors. This approach also
> makes it easier to switch to other or newer compilers. It makes the
On Wed, Jun 08, 2022 at 12:06:28AM +, Xu, Min M wrote:
> On June 7, 2022 6:46 PM, Gerd Hoffmann wrote:
> > On Mon, Jun 06, 2022 at 10:59:55AM +0800, Min Xu wrote:
> > > From: Min M Xu
> > >
> > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
> > >
> > > Lazy accept page can be
28 matches
Mail list logo
