The file looks okay to me as an interface proposal but I agree with
Jiewen about deferring the edk2 submission until an implementation can
be reviewed with it as well.
Regards,
Michael
On 6/10/2022 9:09 PM, Yao, Jiewen wrote:
Thanks for the response.
1) Why we need "enable UEFI variable
Thanks for the response.
1) Why we need "enable UEFI variable write before permanent memory is
available"?
2) If the implementation is not ready, I do have concern to add it so early in
EDKII.
If I don’t have a big picture, I am not sure how to review the completeness.
Can we put it to
Acked-by: Michael Kubacki
On 6/10/2022 5:20 PM, Nate DeSimone wrote:
Changes in V2:
- Fixed instances where the new PPI was incorrectly reffered to as
"EDKII PEI Variable Protocol"
- Added OPTIONAL to the Attributes argument of GetVariable()
- Added description of initial calling
From: fanwang2intel
Add "-T " parameter to provide fixed
FIT address on flash region. When this parameter is set
to a valid address in the input FD/FV file, tool will
directly generate FIT on this address.
It's users' responsibilities to reserve enough size for
FIT table and option modules on
Hi Jiewen,
Thanks for the feedback, per your questions:
1. The primary use case for this is to enable UEFI variable writes before
permanent memory is available.
2. The implementation is a work in progress. We will provide it shortly. As
this will be a rather large patch set, I would like to
Adds definition of EDKII_PEI_VARIABLE_PPI, a pre-cursor
to enabling variable writes in the PEI environment.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Isaac Oram
Cc: Chasel Chiu
Cc: Gao Cheng
Cc: Di Zhang
Cc: Daocheng Bu
Cc: Michael Kubacki
Signed-off-by: Nate DeSimone
---
Changes in V2:
- Fixed instances where the new PPI was incorrectly reffered to as
"EDKII PEI Variable Protocol"
- Added OPTIONAL to the Attributes argument of GetVariable()
- Added description of initial calling conditions to GetNextVariableName()
- Clarified the function and format of
Hi Michael,
Thanks for the great feedback! I believe I have addressed all of it in the V2
patch. Please take a look when you get a chance.
Per your comment on the EFI_AUTHENTICATED_VARIABLE_HOB... this is one of those
old data structures migrated from the edk1 that has the EFI_ prefix even
From: dann frazier
Some Linux distributions are experimenting with builds that target a
higher x86-64 psABI, such as x86-64-v3. To avoid inheriting these
compiler defaults in edk2 builds, and therefore breaking compatibility
with machines using older CPUs, explicitly target the generic x86-64
Hi
I am curious why we need this interface. Why we need write variable capability
in PEI phase?
Where is the implementation of this? I prefer to see an implementation
submitted together with header file.
For example, what is the impact to secure boot related feature, how to write
auth
On Mon, May 16, 2022 at 03:42:19PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
>
> TdHobList and Configuration FV are external data provided by Host VMM.
> These are not trusted in Td guest. So they should be validated , measured
> and extended to Td RTMR
OK. I will revert this at first.
Let's figure out a right solution.
Acked-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Friday, June 10, 2022 7:03 PM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; James Bottomley
> ; Tom
Fixes problems due to code assuming it runs with frame pointers and thus
updates rbp / ebp registers when switching stacks.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Conf/tools_def.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
They are not used anywhere. Remove them.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Conf/tools_def.template | 2 --
1 file changed, 2 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index 5ed19810b727..a53199c9c76b 100755
---
My testing was busted, ran the tests with outdated tools_def
so I didn't notice the patch had zero effect ...
So, revert the broken patch, drop two lines which are not used
anywhere to reduce confusion, then just disable omit-frame-pointers
for ia32 and x64 to get the source tree back into
This reverts commit ff36b2550f94dc5fac838cf298ae5a23cfddf204.
Has no effect because GCC_IA32_CC_FLAGS and GCC_X64_CC_FLAGS are unused.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Sec/SecMain.c | 4
BaseTools/Conf/tools_def.template | 6 +++---
2 files changed, 3 insertions(+), 7
On Fri, 10 Jun 2022 at 10:13, Sunny Wang wrote:
>
> Reviewed-by: Sunny Wang
>
> -Original Message-
> From: Marcin Wojtas
> Sent: 10 June 2022 00:51
> To: devel@edk2.groups.io
> Cc: quic_llind...@quicinc.com; ardb+tianoc...@kernel.org; m...@semihalf.com;
> j...@semihalf.com;
Commit e7abb94d1 removed InitializeCpuExceptionHandlersEx
and updated DxeMain to call InitializeCpuExceptionHandlers
for exception setup. But the old behavior that calls *Ex() sets
up the stack guard as well. To match the old behavior,
the patch calls InitializeSeparateExceptionStacks.
Reviewed-by: Eric Dong for this serial.
Thanks,
Eric
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Monday, May 16, 2022 3:14 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v3 0/5] MpInitLib code refactoring
v2:
Updated 3/5: "Put SEV logic in
Reviewed-by: Sunny Wang
-Original Message-
From: Marcin Wojtas
Sent: 10 June 2022 00:51
To: devel@edk2.groups.io
Cc: quic_llind...@quicinc.com; ardb+tianoc...@kernel.org; m...@semihalf.com;
j...@semihalf.com; g...@semihalf.com; upstr...@semihalf.com; Sunny Wang
;
20 matches
Mail list logo
