[edk2-devel] [PATCH EDK2 v1 1/1] edksetup.sh:The version compare issue in shell script

2022-06-13 Thread wenyi,xie via groups.io
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3948 In function of SetupPython3, the version of python will be compared to get the new one. When python 3.10 is compared with python 3.4, the result is not right. Because the version number is treated as a float and 3.10 is smaller than 3.4. So

[edk2-devel] [PATCH EDK2 v1 0/1] edksetup.sh:The version compare issue in shell script

2022-06-13 Thread wenyi,xie via groups.io
Main Changes : 1.Using sort command to get the new version. Wenyi Xie (1): edksetup.sh:The version compare issue in shell script edksetup.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/14/2022 #cal-reminder

2022-06-13 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 06/14/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel][PATCH v1 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2

2022-06-13 Thread Wu, Hao A
Got it, thanks for the information. I am fine with the plan. Best Regards, Hao Wu > -Original Message- > From: Czajkowski, Maciej > Sent: Monday, June 13, 2022 9:20 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Liming > Subject: RE: [edk2-devel][PATCH v1 0/2] Add

Re: [edk2-devel][PATCH v1 2/2] MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device

2022-06-13 Thread Wu, Hao A
Thanks. For 2 (DevicePathLib PEIM instance), please ensure it is done before merging this series. For 3 (IOMMU codes in storage device PEIMs): Yes, you are right that we still need to consider the EDKII_ATA_AHCI_HOST_CONTROLLER_PPI case. As far as I can recall, this PPI was added for the

回复: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib

2022-06-13 Thread gaoliming
Pedro: Yes. You can merge this patch with my ACK. Thanks Liming 发件人: Pedro Falcato 发送时间: 2022年6月13日 22:45 收件人: gaoliming 抄送: edk2-devel-groups-io ; Leif Lindholm ; Michael D Kinney ; Zhiguang Liu 主题: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 06/13/2022 #cal-notice

2022-06-13 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* 06/13/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1519383 ) *Description:* TianoCore community,

Re: [edk2-devel] [edk2-rfc] RFC v2: Static Analysis in edk2 CI

2022-06-13 Thread Rebecca Cran
LLVM's tools also appear to be much easier to review, for other people to run etc. I'd suggest at least starting with clang-tidy + scan-build and possibly adding Coverity later. I've found the Coverity tools, while very powerful, tend to get ignored after a while because it's quite a process

Re: [edk2-devel] [edk2-rfc] RFC v2: Static Analysis in edk2 CI

2022-06-13 Thread Pedro Falcato
(Replying under Mike for devel visibility) Felix, Why coverity? I feel like we could run something akin to LLVM's clang-tidy + scan-build; it's open source (transparent *and* we can improve it or add UEFI quirks) and doesn't rely on a third-party service. I'm sure we could figure something out

Re: [edk2-devel] Physical Address of buffer

2022-06-13 Thread Pedro Falcato
Hi, Does this work for you? https://edk2-docs.gitbook.io/edk-ii-uefi-driver-writer-s-guide/18_pci_driver_design_guidelines/readme.5 On Mon, Jun 13, 2022 at 8:39 PM M.T. wrote: > Hello > > I'm trying to port some code which interacts with memory mapped hardware > registers. > The original code

Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: Add Definition of EDKII_PEI_VARIABLE_PPI

2022-06-13 Thread Nate DeSimone
Hi Jiewen, I am fine with deferring the submission of this to edk2 until the implementation is ready for review. I just wanted to get feedback on the API so that once the implementation patch series arrives we will at least that that piece of the review done. I would say this thread achieved

[edk2-devel] [PATCH v2 11/11] EmulatorPkg: Pipeline: Resolve SecureBootVariableLib dependency

2022-06-13 Thread Kun Qin
The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve pipeline builds. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Kun Qin --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1

[edk2-devel] [PATCH v2 10/11] OvmfPkg: Pipeline: Resolve SecureBootVariableLib dependency

2022-06-13 Thread Kun Qin
The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve pipeline builds. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan

[edk2-devel] [PATCH v2 09/11] SecurityPkg: SecureBootVariableLib: Added unit tests

2022-06-13 Thread Kun Qin
From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 This change added unit test and enabled it from pipeline for the updated SecureBootVariableLib. The unit test covers all implemented interfaces and certain corner cases. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu

[edk2-devel] [PATCH v2 08/11] SecurityPkg: SecureBootConfigDxe: Updated invocation pattern

2022-06-13 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909 This change is in pair with the previous SecureBootVariableLib change, which updated the interface of `CreateTimeBasedPayload`. This change added a helper function to query the current time through Real Time Clock protocol.

[edk2-devel] [PATCH v2 06/11] SecurityPkg: SecureBootVariableProvisionLib: Updated implementation

2022-06-13 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change is in pair with the previous SecureBootVariableLib, which removes the explicit invocation of `CreateTimeBasedPayload` and used new interface `EnrollFromInput` instead. The original `SecureBootFetchData` is also

[edk2-devel] [PATCH v2 07/11] SecurityPkg: Secure Boot Drivers: Added common header files

2022-06-13 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change added common header files to consumer drivers to unblock pipeline builds. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Signed-off-by: Kun Qin ---

[edk2-devel] [PATCH v2 05/11] SecurityPkg: SecureBootVariableLib: Added newly supported interfaces

2022-06-13 Thread Kun Qin
From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 This change updated the interfaces provided by SecureBootVariableLib. The new additions provided interfaces to enroll single authenticated variable from input, a helper function to query secure boot status, enroll all secure

[edk2-devel] [PATCH v2 03/11] SecurityPkg: SecureBootVariableLib: Updated time based payload creator

2022-06-13 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909 This change updated the interface of 'CreateTimeBasedPayload' by requiring the caller to provide a timestamp, instead of relying on time protocol to be ready during runtime. It intends to extend the library availability

[edk2-devel] [PATCH v2 04/11] SecurityPkg: SecureBootVariableLib: Updated signature list creator

2022-06-13 Thread Kun Qin
From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change removes the interface of SecureBootFetchData, and replaced it with `SecureBootCreateDataFromInput`, which will require caller to prepare available certificates in defined structures. This improvement will

[edk2-devel] [PATCH v2 02/11] SecurityPkg: PlatformPKProtectionLib: Added PK protection interface

2022-06-13 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 This patch provides an abstracted interface for platform to implement PK variable related protection interface, which is designed to be used when PK variable is about to be changed by UEFI firmware. This change also

[edk2-devel] [PATCH v2 01/11] SecurityPkg: UefiSecureBoot: Definitions of cert and payload structures

2022-06-13 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change added certificate and payload structures that can be consumed by SecureBootVariableLib and other Secure Boot related operations. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Signed-off-by: Kun Qin ---

[edk2-devel] [PATCH v2 00/11] Enhance Secure Boot Variable Libraries

2022-06-13 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 This is a revamp of a previously submitted patch series based on top of master branch:

[edk2-devel] Physical Address of buffer

2022-06-13 Thread M.T.
Hello I'm trying to port some code which interacts with memory mapped hardware registers. The original code was developed in 2015-18 on edk2, and does not want to compile anymore. The way it works is there are three 32 bit registers. The first is a status/command register which I read to

Re: [edk2-devel] RFC v2: Static Analysis in edk2 CI

2022-06-13 Thread Michael D Kinney
+devel@edk2.groups.io Mike > -Original Message- > From: r...@edk2.groups.io On Behalf Of Felix Polyudov > via groups.io > Sent: Monday, June 13, 2022 10:48 AM > To: r...@edk2.groups.io > Cc: Kinney, Michael D > Subject: [edk2-rfc] RFC v2: Static Analysis in edk2 CI > > This is

Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib

2022-06-13 Thread Pedro Falcato
Liming, Sorry for the question, but can I merge this with your Ack and my RB or do I have to wait for another RB? I want to solve this as soon as possible since right now Ext4Pkg won't build with upstream edk2. Thanks, Pedro On Thu, Jun 2, 2022 at 4:05 AM gaoliming wrote: > Pedro: > > Thanks

Re: [edk2-devel][PATCH v1 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2

2022-06-13 Thread Maciej Czajkowski
For now, the priority will be to add the support for AHCI and NVMe. However, in the future the plan is to have support in all of these drivers. Regards, Maciej -Original Message- From: Wu, Hao A Sent: czwartek, 9 czerwca 2022 04:47 To: Czajkowski, Maciej ; devel@edk2.groups.io Cc: Ni,

Re: [edk2-devel][PATCH v1 2/2] MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device

2022-06-13 Thread Maciej Czajkowski
Hello, 1. Yes, I will try to fix that in the v2 patch. 2. We have a review opened to add such instance - https://edk2.groups.io/g/devel/message/89970 3. For now it will be implemented in the silicon code, so you are right - we should keep them. Also, it would require a larger library refactor

Re: [edk2-devel] [PATCH 2/2] DxeMain: Fix the bug that StackGuard is not enabled

2022-06-13 Thread Sami Mujawar
Hi Ray, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 13/06/2022 04:39 am, Ni, Ray via groups.io wrote: Commit e7abb94d1 removed InitializeCpuExceptionHandlersEx and updated DxeMain to call InitializeCpuExceptionHandlers for

Re: [edk2-devel] [PATCH 1/2] ArmPkg/ArmExceptionLib: Follow new CpuExceptionHandlerLib APIs

2022-06-13 Thread Sami Mujawar
Hi Ray, Thank you for this patch. I have one minor suggestion marked inline as [SAMI], otherwise this patch looks good to me. With that updated. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 13/06/2022 04:39 am, Ray Ni wrote: CpuExceptionHandlerLib has been refactored with

Re: [edk2-devel] [PATCH v3 1/1] [edk2-platforms]Tools\FitGen: Add extra parameter fixed FIT address

2022-06-13 Thread Bob Feng
This patch looks good to me. Reviewed-by: Bob Feng -Original Message- From: Jiang, Wenyi Sent: Friday, June 10, 2022 9:15 AM To: devel@edk2.groups.io Cc: Chen, Christine ; Feng, Bob C Subject: [PATCH v3 1/1] [edk2-platforms]Tools\FitGen: Add extra parameter fixed FIT address From:

[edk2-devel] [edk2-staging][PATCH 5/5] edk2-staging/RedfishClientPkg: Add missing module

2022-06-13 Thread Nickle Wang
Add missing module import for conditional, RfCollection, RfResource, RfResourceRaw, hashlib and OrderedDict Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py | 5 -

[edk2-devel] [edk2-staging][PATCH 4/5] edk2-staging/RedfishClientPkg: Add ETag support

2022-06-13 Thread Nickle Wang
From: Nickle Wang Implement ETag support in HTTP header Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1sim/resource.py | 10 +-- .../v1sim/systems.py | 28 +++ 2 files changed, 25

[edk2-devel] [edk2-staging][PATCH 3/5] edk2-staging/RedfishClientPkg: Update patch method of computer system

2022-06-13 Thread Nickle Wang
From: Nickle Wang Remove attribute check during patch of computer system and return content-type with JSON format in HTTP header. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1sim/resource.py | 4 ++- .../v1sim/systems.py

[edk2-devel] [edk2-staging][PATCH 2/5] edk2-staging/RedfishClientPkg: Update computer system schema version

2022-06-13 Thread Nickle Wang
Update mock-up file and use computer system schema version 1.5.0 in order to support Boot.BootOrder attribute. Update UUID of 2M220101SL for working with Redfish Profile Simulator. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez ---

[edk2-devel] [edk2-staging][PATCH 1/5] edk2-staging/RedfishClientPkg: Update requirements.txt

2022-06-13 Thread Nickle Wang
From: Nickle Wang Updates the Python module dependency for Redfish Profile Simulator. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Tools/Redfish-Profile-Simulator/requirements.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git

[edk2-devel] [edk2-staging][PATCH 0/5] Update Redfish Profile Simulator

2022-06-13 Thread Nickle Wang
Update Redfish Profile Simulator in order to cooperating with Redfish feature driver. Computer system schema is updated to version 1.5.0 to include Boot.BootOrder attribute. "ETag" HTTP header is implemented to all Redfish method and fix missing module issue. Nickle Wang (5):

[edk2-devel] [PATCH v1 1/1] SecurityPkg: use SmmWaitForAllProcessor in TcgSmm and Tcg2Smm driver.

2022-06-13 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3855 In UefiCpuPkg, there are a new Protocol with the new service SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. This patch use the

Re: [edk2-devel] [PATCH v3 18/28] MdeModulePkg: Reference Null ProtectedVariableLib

2022-06-13 Thread Wu, Hao A
I suggest to combine this patch with: "[PATCH v3 07/28] MdeModulePkg: Add Null ProtectedVariable Library" Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Judah > Vang > Sent: Thursday, June 9, 2022 2:03 PM > To: devel@edk2.groups.io > Cc: Wang, Jian

[edk2-devel] [PATCH v4 1/1] MdeModulePkg: Use SmmWaitForAllProcessor() in VariableSmm driver.

2022-06-13 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3854 In UefiCpuPkg, there are a new Protocol with the new service SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. This patch use the

Re: [edk2-devel] [PATCH v3 08/28] MdeModulePkg: Add new Variable functionality

2022-06-13 Thread Wu, Hao A
For function GetNvVariableStore(), I think local variable 'FtwLastWriteData' is not used and will incur NULL pointer reference in this patch. Please help to check. With this addressed: Acked-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: Vang, Judah > Sent: Thursday,

Re: [edk2-devel] [PATCH v3 05/28] MdeModulePkg: Add new ProtectedVariable GUIDs

2022-06-13 Thread Wu, Hao A
I saw the GUID definitions are added SecurityPkg.dec. Not sure why the actual header file is added in MdeModulePkg. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Judah Vang > Sent: Thursday, June 9, 2022 2:03 PM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH v3 06/28] MdeModulePkg: Add new include files

2022-06-13 Thread Wu, Hao A
Please refer to inline comment below (tagged as "[Hao]"): > -Original Message- > From: devel@edk2.groups.io On Behalf Of Judah Vang > Sent: Thursday, June 9, 2022 2:03 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [edk2-devel] [PATCH v3

Re: [edk2-devel] [PATCH v3 01/28] MdeModulePkg: Add new GUID for Variable Store Info

2022-06-13 Thread Wu, Hao A
Please do not make the DEC file change ahead of the header file changes. You can either: * Break the changes in DEC file into the commits that update/add the header files, or * Reorder the commits to put the DEC file change after the commits that update/add the header files. Best Regards, Hao