Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-07-01 Thread dann frazier
Hi Pedro, Yeah, apparently GCC didn't document it until 8.1.0: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=c7cb6c178884 But it appears to have been introduced far earlier - best I can tell, in 4.1: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=3fec9fa9b726 It seems to be unrelated

[edk2-devel] [PATCH] UefiPayloadPkg: Set console rows and columns to 100

2022-07-01 Thread Sean Rhodes
Set the Pcd's relating to console to 100 to make UiApp fill the display Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[edk2-devel] Running Rust tests for UEFI

2022-07-01 Thread Ayush Singh
Hello everyone, the project has now reached the stage where it is possible to build for UEFI just like an std supporting Rust target. However, running tests is where it gets a bit tricky: While there are some rust targets that run on QEMU emulation for testing [1] (as opposed to just docker),

Re: [edk2-devel] [PATCH v3 3/3] [edk2-platforms] Silicon/Intel/FitGen: Support Startup ACM entries (Type 2) 0x200 Version

2022-07-01 Thread Oram, Isaac W
Reviewed-by: Isaac W Oram -Original Message- From: Lin, Jason1 Sent: Friday, July 1, 2022 8:10 AM To: devel@edk2.groups.io Cc: Lin, Jason1 ; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; Chiang, Dakota Subject: [PATCH v3 3/3] [edk2-platforms]

Re: [edk2-devel] [PATCH v3 2/3] [edk2-platforms] Silicon/Intel/FitGen: Reduce the typecasting and pointer usage

2022-07-01 Thread Oram, Isaac W
Reviewed-by: Isaac W Oram -Original Message- From: Lin, Jason1 Sent: Friday, July 1, 2022 8:10 AM To: devel@edk2.groups.io Cc: Lin, Jason1 ; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; Chiang, Dakota Subject: [PATCH v3 2/3] [edk2-platforms]

Re: [edk2-devel] [PATCH v3 1/3] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-07-01 Thread Oram, Isaac W
Reviewed-by: Isaac W Oram -Original Message- From: Lin, Jason1 Sent: Friday, July 1, 2022 8:10 AM To: devel@edk2.groups.io Cc: Lin, Jason1 ; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; Chiang, Dakota Subject: [PATCH v3 1/3] [edk2-platforms]

[edk2-devel] FreePool in PEI (was: Clarification of Memory management in PEI phase)

2022-07-01 Thread Brian J. Johnson
I've been looking at this a bit. It appears that implementing PEI FreePool in this way would require: * Adding a new HOB type EFI_HOB_TYPE_FREE_POOL to PiHob.h * Adding a new FreePool PEI service to PiPeiCis.h * Implementing the service in PeiMain.c and MemoryServices.c * Adding

[edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

2022-07-01 Thread Jeff Brasen via groups.io
Some platfoms may want to modify the ACPI table created. Add support for protocol that can provide an alternative implementation. Signed-off-by: Jeff Brasen --- DynamicTablesPkg/DynamicTablesPkg.dec | 3 + .../Protocol/SsdtPcieOverrideProtocol.h | 63 +++

[edk2-devel] [PATCH v2 1/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

2022-07-01 Thread Jeff Brasen via groups.io
The translation value in ACPI should be the difference between the CPU and PCIe address. Signed-off-by: Jeff Brasen --- .../Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

2022-07-01 Thread Jeff Brasen via groups.io
Add support for selecting to use index or segment number as UID and name. This allows the path of the nodes to be well known. Signed-off-by: Jeff Brasen --- DynamicTablesPkg/DynamicTablesPkg.dec | 3 +++ .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 19 ++-

[edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF

2022-07-01 Thread Jeff Brasen via groups.io
Add support for PCIe devices with UID > 0xF. This is done by using the next value in the name so PCI5, PC26, etc Signed-off-by: Jeff Brasen --- .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 11 +++ .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 2 +- 2 files changed,

[edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

2022-07-01 Thread Jeff Brasen via groups.io
Add fixes/features to dynamic PCIe support - Correct issue with translation in generated ACPI tables. - Allow for more than 16 controllers to be generated. - Allow optional use of segment number as UID for cases where ACPI path is needed in other places. - Add support for override protocol that

Re: [edk2-devel] [PATCH RESEND v1 5/7] MdePkg/AesLib: Definition for AES library class interface

2022-07-01 Thread Yao, Jiewen
> -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Friday, July 1, 2022 11:23 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Sami Mujawar ; Leif Lindholm > ; Ard Biesheuvel ; > Rebecca Cran ; Kinney, Michael D > ; Gao, Liming ; > Edward Pickup >

Re: [edk2-devel] [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

2022-07-01 Thread Jeff Brasen via groups.io
I don't think there are any requirements that this should be mapped this way which is why I added this under a PCD to enable it. We have a use case where it would be helpful to know the ACPI path of the PCIe controllers externally and using the segment number for that would allow us to do this

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

2022-07-01 Thread Jeff Brasen via groups.io
Currently we do the following in this call. Remove and replace the _OSC method on certain targets. I originally had this pass the template over but removed that when I added this more generic override support Add a _RST method to the root port device sub node Add a _DSD for device properties

Re: [edk2-devel] [PATCH 1/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

2022-07-01 Thread Jeff Brasen via groups.io
Yes, I'll try to add a v2 patch for this shortly. Thanks, Jeff > -Original Message- > From: Pierre Gondois > Sent: Friday, July 1, 2022 6:40 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: sami.muja...@arm.com; alexei.fedo...@arm.com > Subject: Re: [PATCH 1/4] DynamicTablesPkg:

Re: [edk2-devel] [PATCH RESEND v1 5/7] MdePkg/AesLib: Definition for AES library class interface

2022-07-01 Thread PierreGondois
On 7/1/22 16:40, Yao, Jiewen wrote: Please allow me to clarify my understanding: 1) You want to promote DrbgLib to MdePkg. -- That is a different topic. We should discuss that in other thread. Now, let’s assume it is OK. 2) You want to use AES as an implementation for DrbgLib. That is also

Re: [edk2-devel] [PATCH] ArmPkg/Drivers: ArmGicIsInterruptEnabled returns incorrect value

2022-07-01 Thread Ard Biesheuvel
On Fri, 1 Jul 2022 at 17:07, Robbie King wrote: > > The issue appears to have been introduced by: > > 41fb5d46 : ArmPkg/ArmGic: Use the GIC Redistributor instead of GIC > Distributor for GICv3 > > The changes to ArmGicIsInterruptEnabled() introduced the error where the > Boolean > result is

[edk2-devel] [PATCH v3 3/3] [edk2-platforms] Silicon/Intel/FitGen: Support Startup ACM entries (Type 2) 0x200 Version

2022-07-01 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3959 As per FIT BIOS Specification 1.2 Rules, the size bytes (3 bytes) / reserved byte (1 byte) / CheckSum byte (1 byte) in type 2 are must-be-zero (MBZ). These bytes could be override for the other usages. This change is used

[edk2-devel] [PATCH v3 2/3] [edk2-platforms] Silicon/Intel/FitGen: Reduce the typecasting and pointer usage

2022-07-01 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 FitGen tool exists lots of typecasting and pointer usage. This code change is used to reduce these in FillFitTable () and GetFitEntryInfo (). To make code more clearly and easy to read. Signed-off-by: Jason1 Lin Cc: Bob

[edk2-devel] [PATCH v3 1/3] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-07-01 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 Within current FitGen tool there had limitation only allow one S-ACM to generate the Type 2 entry. This code change is used to support multiple type 2 entries up to 0x20. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc:

Re: [edk2-devel] [PATCH] NetworkPkg: Add Wi-Fi Wpa3 support in WifiConnectManager

2022-07-01 Thread Maciej Rabeda
Reviewed-by: Maciej Rabeda On 24 cze 2022 09:59, Heng Luo wrote: https://bugzilla.tianocore.org/show_bug.cgi?id=3961 Add below Wpa3 support: WPA3-Personal: Ieee80211AkmSuiteSAE= 8 WPA3-Enterprise: Ieee80211AkmSuite8021XSuiteB= 11

[edk2-devel] [edk2-platforms][PATCH v2 1/1] IntelSiliconPkg/SpiFvbService: Add support for VariableFlashInfoLib

2022-07-01 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3478 Adds support for getting the variable flash information from VariableFlashInfoLib. This library abstracts the source of flash information so platforms could expect the information to come from a different source in

Re: [edk2-devel] [PATCH RESEND v1 5/7] MdePkg/AesLib: Definition for AES library class interface

2022-07-01 Thread Yao, Jiewen
Please allow me to clarify my understanding: 1) You want to promote DrbgLib to MdePkg. -- That is a different topic. We should discuss that in other thread. Now, let’s assume it is OK. 2) You want to use AES as an implementation for DrbgLib. That is also reasonable. Please note: MdePkg only

[edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs

2022-07-01 Thread Albecki, Mateusz
DevicePathLib utilities are useful in PEI to locate the devices which need an opal unlock on S3 resume. This commit reuses the implementation done for standalone MM support and makes the StandaloneMm library Base. Signed-off-by: Mateusz Albecki Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang

[edk2-devel] [PATCHv3 0/1] MdePkg/UefiDevicePathLib: Add support for PEIMs

2022-07-01 Thread Albecki, Mateusz
This patch adds support for PEIMs in UefiDevicePathLib. Although this library and DEVICE_PATH_PROTOCOL itself was initially intended for DXE the use case of unlocking opal-locked storage devices during S3 resume makes it useful in PEI. As it is the change will break the users who will need to

Re: [edk2-devel] [PATCH 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy Server for HTTP Boot

2022-07-01 Thread Maciej Rabeda
Hi Saloni, This patch contains several problems. At minimum: 1. HttpBootLoadFile() logic around calling HttpBootGetBootFile() is becoming more complex - and BZ 2504 patch adds to it. I am becoming convinced that this part of HttpBootLoadFile() should have a separate function with a

Re: [edk2-devel] [PATCH RESEND v1 5/7] MdePkg/AesLib: Definition for AES library class interface

2022-07-01 Thread PierreGondois
Hello Jiewen, On 7/1/22 13:55, Yao, Jiewen wrote: I have two concern: 1) I am worried that this API might be misused. Usually, a crypto API should be secure enough to avoid misuse. For example, if a program wants to use AES encryption, it must NOT use this AES API. Instead it must use

[edk2-devel] Issue in building the StdLibc using Clang38 for 64 bit build on Ubuntu 20.02

2022-07-01 Thread Jayaprakash, N
Hi All, I am trying to build AppPkg under edk2-libc project using the clang compiler tool chain from Ubuntu 20.04 system. While doing so I am encountering an error, which I am not able to resolve. This error is coming from the Standard C Library module as shown below. Any clues to solve this

Re: [edk2-devel] Building EDK2 without Azure Pipelines

2022-07-01 Thread Demeter, Miki
Hi G Instructions for Building EDK II on Linux and Windows can be found here: https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with-EDK-II -miki -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90979):

[edk2-devel] Building EDK2 without Azure Pipelines

2022-07-01 Thread greg123123 via groups.io
Good morning. I am looking to build EDK2 without using Azure. I have looked through the execution flow.azurepipelines/Ubuntu-GCC5.yml but as far as I can see there is no list of commands or steps in there that can be executed by any non-Azure component such as `make` or gcc.I see there are

Re: [edk2-devel] [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

2022-07-01 Thread PierreGondois
Hello Jeff, From "PCI Firmware Specification Revision 3.3", s4.1.2. "MCFG Table Description", the "PCI Segment Group Number" field of the MCFG table must match the value returned by the _SEG object in the corresponding object. I didn't find any constraint about the _UID value. Would it be

Re: [edk2-devel] [PATCH 1/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

2022-07-01 Thread PierreGondois
Hello Jeff, The patch is correct, but there will be an issue if AddrMapInfo->CpuAddress - AddrMapInfo->PciAddress < 0 AmlCodeGenRdDWordIo() takes an 'IsPosDecode' argment, would it be possible to set IsPosDecode to FALSE in such case ? Regards, Pierre On 6/30/22 17:48, Jeff Brasen wrote: The

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

2022-07-01 Thread PierreGondois
Hello Jeff, Is it possible to know what the UpdateTable() function would do ? Maybe it would be possible to integrate the alternative implementation without adding a new protocol. Regards, Pierre On 6/30/22 17:48, Jeff Brasen wrote: Some platfoms may want to modify the ACPI table created. Add

Re: [edk2-devel] [PATCH] NetworkPkg/HttpBootDxe: Add Support for HTTP Boot Basic Authentication

2022-07-01 Thread Maciej Rabeda
Hi Saloni, One remark. Scenario flow: 1. First HttpBootLoadFile() call. 2. HttpBootGetBootFile() is called for the first time. Authorization header is not added. 3. HTTP server requires the authorization header, so it responds with 401 status. 4. HttpBootCallback is called so that user

Re: [edk2-devel] [PATCH RESEND v1 5/7] MdePkg/AesLib: Definition for AES library class interface

2022-07-01 Thread Yao, Jiewen
I have two concern: 1) I am worried that this API might be misused. Usually, a crypto API should be secure enough to avoid misuse. For example, if a program wants to use AES encryption, it must NOT use this AES API. Instead it must use AES_CCB + MAC or AES_GCM. (or equivalent) I doubt if this

Re: [edk2-devel] [PATCH RESEND v1 0/9] Add DrbgLib

2022-07-01 Thread PierreGondois
Hello Yao, On 6/30/22 03:16, Yao, Jiewen wrote: More question: Please educate me how you plan to include DrbgLib to openssl? Currently, it is using RngLib. https://github.com/tianocore/edk2/blob/master/CryptoPkg/Library/OpensslLib/OpensslLib.inf#L634? There was a discussion about the DrbgLib

Re: [edk2-devel] [PATCH RESEND v1 5/7] MdePkg/AesLib: Definition for AES library class interface

2022-07-01 Thread PierreGondois
Hello Yao, On 6/30/22 02:29, Yao, Jiewen wrote: Hi 1) Would you please educate me, how this library be used in cryptolib? - https://github.com/tianocore/edk2/blob/master/CryptoPkg/Include/Library/BaseCryptLib.h#L1091 Currently, we have AES_CBC. We are going to add AES_GCM in near future.

Re: [edk2-devel] [PATCH RESEND v1 0/9] Add DrbgLib

2022-07-01 Thread PierreGondois
Hello Mike, On 6/30/22 02:15, Kinney, Michael D wrote: Hi Pierre, Can you add to the Patch #0 Summary and the BZ the difference between the existing RngLib and this new DrbgLib? There was a discussion in late 2020 about the DrbgLib at: https://edk2.groups.io/g/devel/topic/78823009#71619 The

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformCI: add IntelTdxBuild.py

2022-07-01 Thread Yao, Jiewen
Merged - https://github.com/tianocore/edk2/pull/3038 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Friday, July 1, 2022 2:09 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Aktas, Erdem ; James Bottomley > ; Tom Lendacky ; Gerd > Hoffmann ; Ard

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformCI: add IntelTdxBuild.py

2022-07-01 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Sunday, May 15, 2022 7:33 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; James Bottomley ; Tom > Lendacky ; Gerd Hoffmann ; > Yao, Jiewen ; Ard Biesheuvel > Subject: [PATCH 1/1] OvmfPkg/PlatformCI: