[edk2-devel] [PATCH 3/3] UefiPayloadPkg: Allow DxeMain.inf to consume the new DebugLib and SerialPortLib

2022-07-13 Thread kavya
Let DxeMain.inf consume new DebugLib and SerialPortLib to support multiple channel debug message on early DXE. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Kavya --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff

[edk2-devel] [PATCH 2/3] UefiPayloadPkg: Implement a new SerialPortLib instance

2022-07-13 Thread kavya
Add new Serial port library instance that consumes the HOB defined in MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h to support multiple UART's. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Kavya ---

[edk2-devel] [PATCH 1/3] UefiPayloadPkg: Implement a new DebugLib instance

2022-07-13 Thread kavya
Add new Debug library instance to support multiple channel debug message. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Kavya --- UefiPayloadPkg/Library/BaseDebugLibHob/BaseDebugLibHob.c | 295

Re: [edk2-devel] [PATCH edk2-platforms v3 09/12] Platform/Ampere: JadePkg: Update for IORT revision macro renaming

2022-07-13 Thread Nhi Pham via groups.io
Reviewed-by: Nhi Pham Thanks, Nhi On 12/07/2022 21:40, Sami Mujawar wrote: The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

2022-07-13 Thread Nhi Pham via groups.io
Hi Sami, Could you help update for Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? Thanks, Nhi On 12/07/2022 21:40, Sami Mujawar wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Add an instance for the library class VariableFlashInfoLib that was

Re: [edk2-devel] [edk2-platforms][PATCH v1 6/7] AmpereAltraPkg: Pipeline: Resolving newly introduced dependency

2022-07-13 Thread Nhi Pham via groups.io
Thanks for the patch. Reviewed-by: Nhi Pham On 09/07/2022 04:02, Kun Qin wrote: The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve AmpereAltraPkg platforms build. Cc: Nhi

[edk2-devel] [edk2-staging][PATCH v2 1/3] EDK2 Code First: PI Specification: New peripheral subclass for TPM

2022-07-13 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 This change includes specification update markdown file that describes the proposed PI Specification v1.7 Errata A in detail and potential impact to the existing codebase. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc:

[edk2-devel] [edk2-staging][PATCH v2 3/3] SecurityPkg: SubClassTpm: Updated default value

2022-07-13 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 This change updated the default value of TPM device subclass PCD to `0x010E` in order to match the definition of EFI_PERIPHERAL_TPM from PI specification. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by:

[edk2-devel] [edk2-staging][PATCH v2 2/3] MdePkg: MmCommunication: Add TPM subclass definition to MdePkg

2022-07-13 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 This change introduces a new peripheral subclass definition. The new subclass definition will cover system reboot events under the status reports from Trusted Platform Modules (TPMs). These definition could provide helpful datapoints to

[edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass definition

2022-07-13 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/91075 v2 patch changes include feedback for v1 series: a. Removed PCD replacement related code change; >From PI Specification v1.7 Errata A,

Re: [edk2-devel] [edk2-staging][PATCH Kun,v1 0/7] Add TPM subclass definition

2022-07-13 Thread Kun Qin
Thanks, Mike. I will drop the applicable code change and send a v2 series shortly. Regards, Kun On 7/13/2022 5:47 PM, Michael D Kinney wrote: Hi Kun, I would prefer to focus on the spec issue with this patch set and only update DEC and .H file. The idea of removing all the status code

Re: [edk2-devel] [edk2-staging][PATCH Kun,v1 0/7] Add TPM subclass definition

2022-07-13 Thread Michael D Kinney
Hi Kun, I would prefer to focus on the spec issue with this patch set and only update DEC and .H file. The idea of removing all the status code related PCDs and updating all the source files to use the #defines is a different change. And that change may impact many downstream modules/libs that

Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition

2022-07-13 Thread Kun Qin
Hi Mike, The intention was to encourage the usage of new definition in .H file once the definition is updated. The PCD is left as is only to serve as backwards compatibility purpose. Do you think only updating the DEC and .H file is more ideal? I could drop the other changes if so desired.

Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition

2022-07-13 Thread Michael D Kinney
Hi Kun, Why was the PCD usage not preserved and only the value updated in the DEC file and .H file? Mike > -Original Message- > From: Kun Qin > Sent: Wednesday, July 13, 2022 5:21 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 > ; Andrew

Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition

2022-07-13 Thread Kun Qin
Hi SecurityPkg maintainers & EDK2 stewards, I sent out this patch series intending to update/fix the PI spec through code first process. Could you please shed some light on it and let me know if any feedback? Thanks in advance! Regards, Kun On 7/5/2022 8:38 PM, Kun Qin via groups.io wrote:

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] IntelSiliconPkg/SpiFvbService: Add support for VariableFlashInfoLib

2022-07-13 Thread Oram, Isaac W
Pushed as 9935472b19..bc93dea9b9 -Original Message- From: Chaganty, Rangasai V Sent: Wednesday, July 13, 2022 9:49 AM To: devel@edk2.groups.io; mikub...@linux.microsoft.com Cc: Ni, Ray ; Oram, Isaac W ; Desimone, Nathaniel L Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 1/1]

[edk2-devel] [PATCH v3 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTP Boot Basic Authentication

2022-07-13 Thread Saloni Kasbekar
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2504 Add support for TLS Client Authentication using Basic Authentication for HTTP Boot Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- MdePkg/Include/IndustryStandard/Http11.h | 8 ++

Re: [edk2-devel] [NetworkPkg] Clarification on EFI_TCP6_PROTOCOL Destruction Behavior

2022-07-13 Thread Ayush Singh
Thanks. I'm not sure if I will use it directly, but it gives a very good idea about using these protocols in Rust std. On Wed, Jul 13, 2022 at 11:07 PM Kinney, Michael D wrote: > > It may be simpler to use the following lib class that layers on top of the > TCP protocols. > >

Re: [edk2-devel] [NetworkPkg] Clarification on EFI_TCP6_PROTOCOL Destruction Behavior

2022-07-13 Thread Michael D Kinney
It may be simpler to use the following lib class that layers on top of the TCP protocols. https://github.com/tianocore/edk2/blob/master/NetworkPkg/Include/Library/TcpIoLib.h The implementation of this lib shows the correct sequence:

Re: [edk2-devel] [PATCH v5 8/8] DynamicTablesPkg: IORT generator updates for Rev E.d spec

2022-07-13 Thread Sami Mujawar
Hi Pierre, Thank you for the feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 13/07/2022 01:18 pm, Pierre Gondois wrote: Hi Sami,   @@ -37,9 +37,11 @@ Requirements:     - EArmObjSmmuV1SmmuV2     - EArmObjSmmuV3     - EArmObjPmcg +  - EArmObjRmr     -

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] IntelSiliconPkg/SpiFvbService: Add support for VariableFlashInfoLib

2022-07-13 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Michael Kubacki Sent: Tuesday, July 12, 2022 4:04 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Ni, Ray ; Oram, Isaac W ; Desimone, Nathaniel L Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1]

[edk2-devel] [NetworkPkg] Clarification on EFI_TCP6_PROTOCOL Destruction Behavior

2022-07-13 Thread Ayush Singh
Hello everyone. I am trying to implement Network Support in Rust std for UEFI. While trying to use the TCP6_PROTOCOL, I am not quite sure how to deal with destructing the protocol. Since TCP6_PROTOCOL is created using a EFI_SERVICE_BINDING_PROTCOL, it should be destroyed using the

Re: [edk2-devel] [PATCH v5 6/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.d spec

2022-07-13 Thread Sami Mujawar
Hi Pierre, Thank you for the feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 13/07/2022 01:10 pm, Pierre Gondois wrote: Hi Sami, +   /**     Helper Macro for populating the IORT Node header in the ACPI_PARSER array.   @@ -108,15 +160,15 @@

Re: [edk2-devel] [PATCH v5 6/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.d spec

2022-07-13 Thread Sami Mujawar
Hi Pierre, Thank you for the feedback. Please find my response inline marked [SAMI] On 13/07/2022 01:10 pm, Pierre Gondois wrote: Hi Sami, +   /**     Helper Macro for populating the IORT Node header in the ACPI_PARSER array.   @@ -108,15 +160,15 @@ ValidateItsIdArrayReference (    

Re: [edk2-devel] [PATCH v5 4/8] DynamicTablesPkg: IORT set reference to interrupt array if present

2022-07-13 Thread PierreGondois
// Add PMU Interrupt Array -if ((SmmuNode->NumPmuInterrupts > 0) && -(NodeList->PmuInterruptToken != CM_NULL_TOKEN)) -{ +if (SmmuNode->NumPmuInterrupts != 0) { + if (NodeList->PmuInterruptToken == CM_NULL_TOKEN) { +Status = EFI_INVALID_PARAMETER; +

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] IntelSiliconPkg/SpiFvbService: Add support for VariableFlashInfoLib

2022-07-13 Thread Oram, Isaac W
Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Tuesday, July 12, 2022 4:04 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Ni, Ray ; Oram, Isaac W ; Desimone, Nathaniel L Subject: Re: [edk2-devel] [edk2-platforms][PATCH

Re: [edk2-devel] [edk2-platforms Patch v2 0/3] Remove all UGA support

2022-07-13 Thread Michael D Kinney
Series Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin Jiang > Sent: Wednesday, July 13, 2022 12:32 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms Patch v2 0/3] Remove all UGA support > > REF:

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

2022-07-13 Thread PierreGondois
Hi Sami, I think Silicon/NXP/NxpQoriqLs.dsc.inc also requires the VariableFlashInfoLib library. Otherwise: Reviewed-by: Pierre Gondois On 7/12/22 16:40, Sami Mujawar wrote: This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0 macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00

[edk2-devel] [PATCH] BaseTools/VolInfo: Correct alignment attributes display

2022-07-13 Thread Konstantin Aladyshev
Alignment attribute is not a bitmask, therefore we need to compare field value with all alignment defines. Remove duplicate print statements. Unify indent with other attribute print statements. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 198

Re: [edk2-devel] [PATCH v5 6/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.d spec

2022-07-13 Thread PierreGondois
Hi Sami, + /** Helper Macro for populating the IORT Node header in the ACPI_PARSER array. @@ -108,15 +160,15 @@ ValidateItsIdArrayReference ( @param [out] ValidateIdArrayReference Optional pointer to a function for validating the ID

Re: [edk2-devel] [PATCH v5 8/8] DynamicTablesPkg: IORT generator updates for Rev E.d spec

2022-07-13 Thread PierreGondois
Hi Sami, @@ -37,9 +37,11 @@ Requirements: - EArmObjSmmuV1SmmuV2 - EArmObjSmmuV3 - EArmObjPmcg + - EArmObjRmr - EArmObjGicItsIdentifierArray - EArmObjIdMappingArray - - EArmObjGicItsIdentifierArray I think EArmObjGicItsIdentifierArray should be conserved. + -

Re: [edk2-devel] [PATCH v5 6/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.d spec

2022-07-13 Thread PierreGondois
Hi Sami, + /** Helper Macro for populating the IORT Node header in the ACPI_PARSER array. @@ -108,15 +160,15 @@ ValidateItsIdArrayReference ( @param [out] ValidateIdArrayReference Optional pointer to a function for validating the ID

Re: [edk2-devel] [PATCH v5 4/8] DynamicTablesPkg: IORT set reference to interrupt array if present

2022-07-13 Thread PierreGondois
On 7/12/22 16:31, Sami Mujawar wrote: The IORT generator is populating the reference field for Context and PMU interrupts even if their count is zero. Update the IORT generator to set the references only if the interrupt count is not 0. Also add checks to ensure a valid reference token has

Re: [edk2-devel] [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0

2022-07-13 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Lin, Jason1 Sent: Wednesday, July 13, 2022 1:56 PM To: devel@edk2.groups.io Cc: Lin, Jason1 ; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; Chiang, Dakota Subject: [PATCH v1] Silicon/Intel/FitGen:

Re: [edk2-devel] [edk2-platforms Patch v2 3/3] OptionRomPkg: Remove all UGA support

2022-07-13 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Jiang, Guomin > Sent: Wednesday, July 13, 2022 3:32 PM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-platforms Patch v2 3/3] OptionRomPkg: Remove all UGA support > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 >

回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs

2022-07-13 Thread gaoliming via groups.io
That's great. I give my reviewed-by for this patch. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Kun Qin via > groups.io > 发送时间: 2022年7月12日 5:30 > 收件人: gaoliming ; devel@edk2.groups.io; > Kinney, Michael D ; 'Albecki, Mateusz' > > 抄送: 'Liu, Zhiguang'

回复: [edk2-devel] [PATCH v5 5/8] MdePkg: IORT header update for IORT Rev E.d spec

2022-07-13 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sami > Mujawar > 发送时间: 2022年7月12日 22:32 > 收件人: devel@edk2.groups.io > 抄送: Sami Mujawar ; alexei.fedo...@arm.com; > ardb+tianoc...@kernel.org; quic_llind...@quicinc.com; > pierre.gond...@arm.com; matteo.carl...@arm.com; >

[edk2-devel] [edk2-platforms Patch v2 3/3] OptionRomPkg: Remove all UGA support

2022-07-13 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA support Cc: Ray Ni Signed-off-by: Guomin Jiang --- .../CirrusLogic5430Dxe/CirrusLogic5430.c | 91 +--- .../CirrusLogic5430Dxe/CirrusLogic5430.h | 21 +- .../CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf | 9 +-

[edk2-devel] [edk2-platforms Patch v2 0/3] Remove all UGA support

2022-07-13 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA support Guomin Jiang (3): PurleyOpenBoardPkg: Remove All UGA support BoardModulePkg: Remove all UGA support OptionRomPkg: Remove all UGA support .../CirrusLogic5430Dxe/CirrusLogic5430.c | 91 +---

[edk2-devel] [edk2-platforms Patch v2 2/3] BoardModulePkg: Remove all UGA support

2022-07-13 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA support Cc: Eric Dong Cc: Liming Gao Signed-off-by: Guomin Jiang --- .../BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platforms Patch v2 1/3] PurleyOpenBoardPkg: Remove All UGA support

2022-07-13 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA support in PurleyOpenBoardPkg Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Guomin Jiang --- .../BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [edk2-devel] [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0

2022-07-13 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Lin, Jason1 Sent: Tuesday, July 12, 2022 10:56 PM To: devel@edk2.groups.io Cc: Lin, Jason1 ; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; Chiang, Dakota Subject: [PATCH v1]