Re: [edk2-devel] [PATCH v3] UefiPayloadPkg: Add macro to support selective driver in UPL

Created PR, please help to push UefiPayloadPkg: Add macro to support selective driver in UPL by jameslu8 * Pull Request #3065 * tianocore/edk2 (github.com) Thanks, James From: Ni, Ray Sent: Friday, July 8, 2022 12:47 AM To: Lu, James ;

Re: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security implications in ECDH and BN.

Reviewed-by: Heng Luo > -Original Message- > From: Tan, Ming > Sent: Friday, July 15, 2022 1:35 PM > To: devel@edk2.groups.io; Li, Yi1 > Cc: Luo, Heng > Subject: RE: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed > possible security implications in ECDH and BN. > >

Re: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security implications in ECDH and BN.

Reviewed-by: Ming Tan -Original Message- From: devel@edk2.groups.io On Behalf Of yi1 li Sent: Friday, July 15, 2022 1:30 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Tan, Ming ; Luo, Heng Subject: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security

[edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security implications in ECDH and BN.

1. Origenal code mixes up the input/output parameters for the BN_rshift() function - the output is actually the first parameter and not the second one. Now we correct BnRShift() param order. 2. NID_X9_62_prime192v1() and NID_secp224r1 prohibited by Intel Crypto/TLS Guidelines (due to being

Re: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fix issues from crypto code review.

Yi: I have the following suggestion. 1. Suggest to split the patch to several patchs. Special the code which modify the logical. 2. Change the commit title, "fix the issues the code review" sounds like show that the reviewers did not good job at before  BR/Tan Ming. -Original

Re: [edk2-devel] [Patch v2 04/11] EmulatorPkg: Remove All UGA Support

Guomin, Did you try booting the Emulator Win and Linux with this change? > -Original Message- > From: Jiang, Guomin > Sent: Friday, July 15, 2022 9:51 AM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Andrew Fish ; Ni, Ray > > Subject: [Patch v2 04/11] EmulatorPkg: Remove All UGA Support >

Re: [edk2-devel] [Patch v2 01/11] UefiPayloadPkg: Remove All UGA Support

Reviewed-by: Ray Ni > -Original Message- > From: Jiang, Guomin > Sent: Friday, July 15, 2022 9:51 AM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Dong, Guo ; Ni, Ray > ; Maurice Ma > ; You, Benjamin ; Rhodes, Sean > > Subject: [Patch v2 01/11] UefiPayloadPkg: Remove All UGA Support >

Re: [edk2-devel] [Patch v2 05/11] ShellPkg: Remove All UGA Support

Reviewed-by: Ray Ni > -Original Message- > From: Jiang, Guomin > Sent: Friday, July 15, 2022 9:51 AM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Ni, Ray ; Gao, > Zhichao > Subject: [Patch v2 05/11] ShellPkg: Remove All UGA Support > > From: GuoMinJ > > REF:

Re: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fix issues from crypto code review.

Reviewed-by: Heng Luo > -Original Message- > From: Li, Yi1 > Sent: Friday, July 15, 2022 10:07 AM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Tan, Ming ; Luo, Heng > > Subject: [staging/crypto-new-api PATCH] CryptoPkg: Fix issues from crypto code > review. > > Details: > 1. Some APIs

[edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fix issues from crypto code review.

Details: 1. Some APIs need more detail comment. 2. Correct BnRShift() param order. 3. Remove unsecure ECC curve from GroupToNid(). 4. Add full public key validating procedures to EcDhDeriveSecret(). Cc: Ming Tan Cc: Heng Luo Signed-off-by: Yi Li --- CryptoPkg/Driver/Crypto.c

[edk2-devel] [Patch v2 04/11] EmulatorPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in EmulatorPkg. Signed-off-by: Guomin Jiang Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmuGopDxe/Gop.h | 10 +-- EmulatorPkg/EmuGopDxe/GopScreen.c | 14 ++--

[edk2-devel] [Patch v2 06/11] OvmfPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Delete PcdConOutGopSupport, it is unnecessary any more. Signed-off-by: Guomin Jiang Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Min

[edk2-devel] [Patch v2 02/11] ArmVirtPkg: Remove All UGA Support

From: GuoMinJ REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove PcdConOutGopSupport, it is unnecessary any more. Remove All UGA Support in ArmVirtPkg Signed-off-by: Guomin Jiang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann ---

[edk2-devel] [Patch v2 00/11] Remove all UGA support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 The Plan: 1. Remove the upstream UGA code first but keep definition in Edk2 at first 2. Then downstream owner to remove UGA related code 3. Remove Edk2 definition last. GuoMinJ (9): UefiPayloadPkg: Remove All UGA Support ArmVirtPkg:

[edk2-devel] [Patch v2 05/11] ShellPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in ShellPkg. Signed-off-by: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 +---

[edk2-devel] [Patch v2 01/11] UefiPayloadPkg: Remove All UGA Support

From: GuoMinJ REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove PcdConOutGopSupport, it is unnecessary any more. Remove All UGA Support in UefiPayloadPkg. Signed-off-by: Guomin Jiang Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes ---

[edk2-devel] [Patch v2 03/11] ArmPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in ArmPkg. Signed-off-by: Guomin Jiang Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar --- ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h | 4 ++--

[edk2-devel] [Patch v2 07/11] MdeModulePkg/ConSplitterDxe: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove the PcdConOutGopSupport, it is unnecessary any more. Remove All UGA Support in ConSplitterDxe component. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Liming Gao Cc: Zhichao Gao Cc: Ray Ni ---

[edk2-devel] [Patch v2 11/11] MdePkg/UefiLib: Remove all UGA support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA code in MdePkg except the definition The reason why keep definition is because downstream need it to pass build. It will be removed when all downstream remove UGA support Signed-off-by: Guomin Jiang Cc: Michael D Kinney

[edk2-devel] [Patch v2 10/11] BaseTools: Remove all UGA support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove UGA code in BaseTools Signed-off-by: Guomin Jiang Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- .../Source/C/Include/Protocol/HiiFramework.h | 53 +- BaseTools/Source/C/Include/Protocol/UgaDraw.h | 161 --

[edk2-devel] [Patch v2 09/11] MdeModulePkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in MdeModulePkg, first remove from library. Remove the PcdConOutGopSupport definition. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Liming Gao Cc: Zhichao Gao Cc: Ray Ni Cc: Hao A Wu ---

[edk2-devel] [Patch v2 08/11] MdeModulePkg/GraphicsConsoleDxe: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in GraphicsConsoleDxe, remove comment about UGA in HiiDatabaseDxe. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Liming Gao Cc: Zhichao Gao Cc: Ray Ni Cc: Dandan Bi Cc: Eric Dong ---

Re: [edk2-devel] [edk2-staging][PATCH Kun,v1 0/7] Add TPM subclass definition

Hi SecurityPkg maintainers and EDK2 stewards, The updated patch series was sent here: https://edk2.groups.io/g/devel/message/91330 Please let me know if there is any other feedback on them. Thanks, Kun On 7/13/2022 6:19 PM, Kun Qin via groups.io wrote: Thanks, Mike. I will drop the

[edk2-devel] [PATCH v3 3/3] CryptoPkg: Need to enable crypto functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH v3 2/3] CryptoPkg: Sha1 functions causing build errors

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3991 Fix build issue when DiSABLE_SHA1_DEPRECATED_INTERFACES is defined. Percolate the #ifndef DiSABLE_SHA1_DEPRECATED_INTERFACES to all the Sha1 functions. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry

[edk2-devel] [PATCH v3 1/3] CryptoPkg: Fix memoryleak in BaseMemAllocation

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3990 Replace AllocatePool() with AllocatePages() and FreePool() with FreePages() because FreePool() is not supported in PEI phase. FreePool() does not free the allocated pool in PEI phase causing a memory leak. Cc: Jiewen Yao Cc: Jian J Wang

[edk2-devel] [PATCH v3 0/3] CryptoPkg bug fixes

https://bugzilla.tianocore.org/show_bug.cgi?id=3990 https://bugzilla.tianocore.org/show_bug.cgi?id=3991 https://bugzilla.tianocore.org/show_bug.cgi?id=3992 There is a memory leak issue with BaseMemAllocation. It calls AllocatePool() and FreePool() but FreePool() is not supported in PEI phase so

[edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Add FSP-I API for SMM support.

From: Hongbin1 Zhang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993 Add FSP-I API entry point for SMM support. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Signed-off-by: Hongbin1 Zhang --- IntelFsp2Pkg/FspSecCore/SecFspApiChk.c | 13 +

Re: [edk2-devel][PATCH v2 0/2] Update SEC_IDT_TABLE struct to reserve sufficient size in IdtTable for both IA32 and X64

This series has been merged: https://github.com/tianocore/edk2/commit/9ab389c01b875869c6173557aa053d397aaf14f1 https://github.com/tianocore/edk2/commit/470206ba7f118aaa1153d66689cf3ee4d17051b7 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kuo, Ted >

[edk2-devel] [PATCH edk2-platforms v4 13/17] Platform/Socionext: Fix missing dependency on VariableFlashInfoLib

The DeveloperBox platform firmware build breaks due to the missing dependency on VariableFlashInfoLib. Therefore, to satisfy the dependency include VariableFlashInfoLib in the LibraryClasses section. Signed-off-by: Sami Mujawar --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 + 1

[edk2-devel] [PATCH edk2-platforms v4 06/17] Platform/RaspberryPi: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 04/17] Silicon/AMD/Styx: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 10/17] Silicon/Phytium: Add VariableFlashInfoLib

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Add an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This allows the variable driver to build successfully as it has a dependency on this library class. Signed-off-by: Sami Mujawar

[edk2-devel] [PATCH edk2-platforms v4 01/17] Platform/ARM: FVP: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 16/17] Platform/NXP/LS1046aFrwyPkg: Fix build break due to change in ARM_CORE_INFO

The edk2 patch at 103fa647d159e3d76be2634d2653c2d215dd0d46 updated the ARM_CORE_INFO structure to remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in favor of a new Mpidr field. Therefore, fix the ArmPlatformLibrary instance for Platform/NXP/LS1046aFrwyPkg accordingly.

[edk2-devel] [PATCH edk2-platforms v4 02/17] Platform/ARM: Morello: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 08/17] Silicon/Ampere: Add VariableFlashInfoLib

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Add an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This allows the variable driver to build successfully as it has a dependency on this library class. Signed-off-by: Sami Mujawar

[edk2-devel] [PATCH edk2-platforms v4 12/17] Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib

The CelloBoard platform firmware build breaks due to the missing dependency on VariablePolicyHelperLib. Therefore, to satisfy the dependency include VariablePolicyHelperLib in the LibraryClasses.common section. Signed-off-by: Sami Mujawar Reviewed-by: Pierre Gondois ---

[edk2-devel] [PATCH edk2-platforms v4 17/17] Platform/NXP/LX2160aRdbPkg: Fix build break due to change in ARM_CORE_INFO

The edk2 patch at 103fa647d159e3d76be2634d2653c2d215dd0d46 updated the ARM_CORE_INFO structure to remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in favor of a new Mpidr field. Therefore, fix the ArmPlatformLibrary instance for Platform/NXP/LX2160aRdbPkg accordingly.

[edk2-devel] [PATCH edk2-platforms v4 15/17] Platform/NXP/LS1043aRdbPk: Fix build break due to change in ARM_CORE_INFO

The edk2 patch at 103fa647d159e3d76be2634d2653c2d215dd0d46 updated the ARM_CORE_INFO structure to remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in favor of a new Mpidr field. Therefore, fix the ArmPlatformLibrary instance for Platform/NXP/LS1043aRdbPkg accordingly.

[edk2-devel] [PATCH edk2-platforms v4 09/17] Platform/Ampere: JadePkg: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 11/17] Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 14/17] Silicon/NXP: Fix missing dependency on VariableFlashInfoLib

The NXP platform firmware build breaks due to the missing dependency on VariableFlashInfoLib. Therefore, to satisfy the dependency include VariableFlashInfoLib in the LibraryClasses.common section. Signed-off-by: Sami Mujawar --- Silicon/NXP/NxpQoriqLs.dsc.inc | 1 + 1 file changed, 1

[edk2-devel] [PATCH edk2-platforms v4 05/17] Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 07/17] Platform/ARM: N1SDP: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH edk2-platforms v4 00/17] Fix build breaks and update IORT revision macro

This v4 series includes 5 additional patches (13-17) that fix various build breaks caused by changes in edk2 repo. The patches 1-12 have not changed between v3 series, except updates to the r-b received. The v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0 macro to

[edk2-devel] [PATCH edk2-platforms v4 03/17] Platform/ARM: SGI: Update for IORT revision macro renaming

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of

[edk2-devel] [PATCH v6 7/8] DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.d

Bugzilla: 3458 - Add support IORT Rev E.d specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022 (https://developer.arm.com/documentation/den0049/) introduces the following updates,

[edk2-devel] [PATCH v6 8/8] DynamicTablesPkg: IORT generator updates for Rev E.d spec

Bugzilla: 3458 - Add support IORT Rev E.d specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022 (https://developer.arm.com/documentation/den0049/) introduces the following updates,

[edk2-devel] [PATCH v6 0/8] IORT Rev E.d specification updates

Bugzilla: 3458 - Add support IORT Rev E.d specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022 (https://developer.arm.com/documentation/den0049/) introduces the following updates,

[edk2-devel] [PATCH v6 6/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.d spec

Bugzilla: 3458 - Add support IORT Rev E.d specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022 (https://developer.arm.com/documentation/den0049/) introduces the following updates,

[edk2-devel] [PATCH v6 3/8] DynamicTablesPkg: IORT set reference to Id array only if present

The IORT table generator is setting up a reference to ID array for nodes even when the ID Mapping count is zero. This is not an issue as an OS would only access the ID Reference if the ID mapping count is not zero. However, it would be good to set the reference to ID array to zero when the ID

[edk2-devel] [PATCH v6 4/8] DynamicTablesPkg: IORT set reference to interrupt array if present

The IORT generator is populating the reference field for Context and PMU interrupts even if their count is zero. Update the IORT generator to set the references only if the interrupt count is not 0. Also add checks to ensure a valid reference token has been provided. Signed-off-by: Sami Mujawar

[edk2-devel] [PATCH v6 2/8] DynamicTablesPkg: Handle error when IdMappingToken is NULL

Add error handling when the IdMappingCount is not zero and the IdMappingToken is NULL. Signed-off-by: Sami Mujawar --- Notes: v6: - No changes since v3. Resending with v6 series. [SAMI] v5: - No changes since v3. Resending with v5 series. [SAMI]

[edk2-devel] [PATCH v6 5/8] MdePkg: IORT header update for IORT Rev E.d spec

Bugzilla: 3458 - Add support IORT Rev E.d specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022 (https://developer.arm.com/documentation/den0049/) introduces the following updates,

[edk2-devel] [PATCH v6 1/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment

Some field names in the IORT table parser were longer than the OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of the output print alignment. Therefore, abbreviate the field names. Signed-off-by: Sami Mujawar Reviewed-by: Zhichao Gao Reviewed-by: Pierre Gondois --- Notes:

Re: [edk2-devel] [edk2-platforms][PATCH v1 3/7] VExpressPkg: Pipeline: Resolving newly introduced dependency

Hi Kun, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91354): https://edk2.groups.io/g/devel/message/91354 Mute This Topic:

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/7] RaspberryPi: Pipeline: Resolving newly introduced dependency

Hi, On 7/8/22 16:02, Kun Qin wrote: The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve RaspberryPi platforms build. This applies cleanly, and fixes the build break when the

Re: [edk2-devel] [PATCH] MdeModulePkg/Variable: SCT run AuthVar_conf is failed

Ah.. good catch. I was not aware that EFI_VARIABLE_ATTRIBUTES_MASK doesn't include EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS bit. Thanks for fixing the issue, JunX1 Li and xueshengfeng. Moreover, I assumed that you haven't got Edhaya's and Samer's review, right? If so, you should use "Cc:" instead

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/QemuVideoDxe: Zero out PixelInformation in QueryMode

Looks good to me. Thanks for working on this, Dimitrije. I had an offline discussion with Dimitrije. Either this patch or the patch for SCT (https://edk2.groups.io/g/devel/topic/92068027) can fix the inconsistent test failure issue mentioned in

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

Looks good to me. Thanks for fixing the issue, Dimitrije. Add Chandni. She has run into this issue as well. Reviewed-by: Sunny Wang -Original Message- From: Dimitrije Pavlov Sent: 29 June 2022 16:59 To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Jeff Booher-Kaeding ; Samer

Re: [edk2-devel] [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: Update for IORT revision macro renaming

On 12/07/2022 15:40, Sami Mujawar wrote: The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

Oops, sorry. I just realized :) Reviewed-by: Nhi Pham Thanks, -Nhi On 14/07/2022 16:06, Sami Mujawar wrote: Hi Nhi, Looks like the file Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not in upstream edk2-platforms. See

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

Hi Nhi, Looks like the file Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not in upstream edk2-platforms. See https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/AmpereAltraPkg Regards, Sami Mujawar On 14/07/2022 08:40 am, Sami Mujawar via groups.io

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

Hi Sami, On Thu, 14 Jul 2022 at 17:01, Sami Mujawar wrote: > > Hi Masahisa, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 14/07/2022 07:38 am, Masahisa Kojima wrote: > > Hi Sami, > > > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > also

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

Hi Pierre, Thank you for the review. I have some comments marked inline as [SAMI]. Regards, Sami Mujawar On 14/07/2022 09:01 am, Sami Mujawar wrote: Hi Masahisa, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 14/07/2022 07:38 am, Masahisa Kojima wrote: Hi Sami,

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

Hi Masahisa, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 14/07/2022 07:38 am, Masahisa Kojima wrote: Hi Sami, Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc also requires the VariableFlashInfoLib library. I have checked that the build error is fixed with the

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

Hi Nhi, I will do that no problem. However, we really need an edk2-platforms CI to catch such issues. Regards, Sami Mujawar On 14/07/2022 04:34 am, Nhi Pham wrote: Hi Sami, Could you help update for Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? Thanks, Nhi On

Re: [edk2-devel] [PATCH 1/3] UefiPayloadPkg: Implement a new DebugLib instance

Why need a separate DebugLib instance? > -Original Message- > From: Sravanthi, K KavyaX > Sent: Thursday, July 14, 2022 12:31 PM > To: devel@edk2.groups.io > Cc: Sravanthi, K KavyaX ; Dong, Guo > ; Ni, Ray ; > Maurice Ma ; You, Benjamin ; > Rhodes, Sean > > Subject: [PATCH 1/3]

Re: [edk2-devel] [PATCH 2/3] UefiPayloadPkg: Implement a new SerialPortLib instance

The implementation looks good. But it limits the usage of SerialPortRead/Write to be called only from BSP because GetFirstGuidHob() can not be called from APs. An alternative implementation is to cache the UART instances data into a library global array so SerialPortRead/Write don't need to

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

Hi Sami, Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc also requires the VariableFlashInfoLib library. I have checked that the build error is fixed with the following modification. --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc +++