Signed-off-by: Benjamin Doron
---
Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c
| 12 ++-
Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c
Allocate memory to use on S3 resume.
TODO: Size calculation, confirm implementation goes in this module.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Ankit Sinha
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Benjamin Doron
---
Follow-up commits to MinPlatform (AcpiPlatform and
PeiFspWrapperHobProcessLib for memory) and FSP-related board libraries
required for successful S3 resume.
Cc: Nate DeSimone
Cc: Ankit Sinha
Cc: Sai Chaganty
Cc: Isaac Oram
Cc: Liming Gao
Signed-off-by: Benjamin Doron
---
S3 resume may require communication with SMM, for which we need the
SMM Control PPI. Therefore, port the DXE driver to a library, like there
is for SMM Access.
Tested, working on Kabylake. Further testing required after the refactor
for compatibility.
Cc: Nate DeSimone
Cc: Ankit Sinha
Cc: Ray
For proper S3 resume support, SMRAM must be opened first.
For security purposes, SMRAM lock must be performed.
It seems to me that this library is generic and applicable to all Intel
platforms in the tree using the MCH SMRAMC register.
Cc: Nate DeSimone
Cc: Ankit Sinha
Cc: Ray Ni
Cc: Rangasai
Implement S3 resume as an advanced feature to support additional
use-cases and improve portability and battery, particularly on mobile
platforms. Hopefully, this can encourage a greater MinPlatform community
and produce more competitive open-source firmware options too.
The intention is for the
Hi Foster,
Does this change provide the resource size requirements for each
root bridge so a rebalance or larger resource allocation can be
performed?
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Foster Nong
> Sent: Friday, July 22, 2022 2:10 AM
> To:
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=4000
Change flow to bus scan all root bridge instances even when any
one root bridge meet bus resource OUT_OF_RESOURCE case.
thus platform handler of "EfiPciHostBridgeEndBusAllocation" has
an chance to do relative pci bus rebalance to handle
Reviewed-by: Debkumar De
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, July 20, 2022 10:15 PM
To: devel@edk2.groups.io
Cc: Andrew Fish ; Leif Lindholm ;
Schaefer, Daniel ; Rhodes, Sean
; De, Debkumar ; Aktas, Erdem
; Gary Lin
Subject: [Patch v2 2/3] Maintainers.txt:
From: PaytonX Hsieh
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4006
Add CRYPTO_PROTOCOL_SUPPORT to decide CryptoDxe built into UPL.efi
If CRYPTO_PROTOCOL_SUPPORT is true, BIOS will use crypto protocol
instead of building OpensslLib into drivers.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Leverage common includes to reduce duplicated or low value code.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Isaac Oram
---
.../BoardMtOlympus/PlatformPkgConfig.dsc | 46 +---
.../BoardMtOlympus/PlatformPkgPcd.dsc | 52 +--
Leverage common includes to reduce duplicated or low value code.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Isaac Oram
---
.../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 +--
.../GalagoPro3/OpenBoardPkgPcd.dsc| 51 +-
Leverage common includes to reduce duplicated or low value code.
Cc: Nate DeSimone
Signed-off-by: Isaac Oram
---
.../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 +--
1 file changed, 12 insertions(+), 39 deletions(-)
diff --git
Remove SMI handler profile feature control.
Disable handler profiling on RELEASE builds.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Isaac Oram
---
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 -
1 file changed, 1 deletion(-)
diff --git
Leverage common includes to reduce duplicated or low value code.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Rangasai V Chaganty
Cc: Deepika Kethi Reddy
Cc: Kathappan Esakkithevar
Signed-off-by: Isaac Oram
---
.../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 +--
1 file
This is a commonly used set of settings modifications based on
the boot stage targeted.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
.../Include/Dsc/CommonStageConfig.dsc.inc | 37 +++
1 file changed, 37 insertions(+)
create mode 100644
Removed the logic that doesn't build some things only if you are doing a
shell boot. Since they are built for stage 1 or 2, there is no porting
benefit to this logic. Build simplified to build both sets of drivers.
Switched from PcdSmiHandlerProfileEnable to using RELEASE build type to
disable
Enable simpler initialation of the MinPlatformPkg feature
selection PCD. Most features and boards don't benefit from
initializing these.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
.../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++---
Leverage common includes to reduce duplicated or low value code.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Heng Luo
Signed-off-by: Isaac Oram
---
.../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 +--
1 file changed, 12 insertions(+), 40 deletions(-)
diff --git
Leverage common includes to reduce duplicated or low value code.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Isaac Oram
---
.../UpXtreme/OpenBoardPkgPcd.dsc | 51 +--
.../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 +--
2 files changed, 24
Leverage common includes for default feature values.
Remove PERFORMANCE_ENABLE in favor of PcdPerformanceEnable.
Use DpDynamicCommand instead of standalone DpApp.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
...blePerformanceMonitoringInfrastructure.dsc | 5 +--
Reduce the need for boards to initialize common
MinPlatformPkg PCD used in build files.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Isaac Oram
---
.../Dsc/MinPlatformFeaturesPcd.dsc.inc| 26 +++
Use MinPlatformFeaturesPcd.dsc.inc to initialize feature PCD
Move individual feature enabling examples to BoardPortTemplate
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
.../Aowanda/PlatformPkg.dsc | 3 --
.../BoardPortTemplate/PlatformPkg.dsc | 50
These changes simplify the logic for board porting by creating common include
files for initializing PCD and for
some stage specific logic commonly implemented.
Removes the PERFORMANCE_ENABLE flag and rely on the
gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable only.
Simplifies the
Patch merged:
https://github.com/tianocore/edk2/commit/5a3641bfcdcf99fd76817833488f2af8abb69383
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Friday, July 22, 2022 10:49 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone,
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Friday, July 22, 2022 10:49 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v4] IntelFsp2Pkg: Add FSPI_ARCH_UPD.
REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Also fixed a bug in SplitFspBin.py for FSP-I support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Good catch everyone!
The spec has been changed to the following:
typedef struct {
UINT8Revision;
UINT8Reserved[3];
UINT32 Length;
EFI_PHYSICAL_ADDRESS BootloaderSmmFvBaseAddress;
UINT64 BootloaderSmmFvLength;
EFI_PHYSICAL_ADDRESS
On Fri, 22 Jul 2022 at 17:20, Sami Mujawar wrote:
>
> Hi Ard,
>
> Thank you for this patch.
>
> I have just checked and that patch v2 1/2 from this series is no longer
> required but this patch v2 2/2 is still applicable.
>
> I have applied patch v2 2/2 on latest edk2 master and tested with FVP
>
Hi Sami,
On Thu, Jul 21, 2022 at 05:26 PM, Sami Mujawar wrote:
>
> Hi Rohit,
>
> On Wed, Jul 6, 2022 at 06:42 AM, Rohit Mathew wrote:
>
>> =20
>> @@ -86,6 +86,10 @@ CEntryPoint (
>> ArmEnableVFP ();
>> }
>> =20
>> + // Explicitly invoke the library constructor to resolve any library
>> + //
Hi Sami,
Thank you for the review. Please find my response inline -
On Thu, Jul 21, 2022 at 04:55 PM, Sami Mujawar wrote:
>
>
>
> Hi Rohit,
>
>
>
> Please find my response inline marked [SAMI].
>
>
>
> Regards,
>
>
>
> Sami Mujawar
>
> On 06/07/2022 02:42 pm, Rohit Mathew wrote:
>
On platforms that do not have the serial console port pre-initialized
prior to the SEC phase and due to the absence of a call to
"SerialPortInitialize", this results in missing debug logs. So, call
the auto-generated "ProcessLibraryConstructorList" function from SEC
phase to have all the dependent
On Tue, 12 Jul 2022 at 03:43, Masahisa Kojima
wrote:
>
> Hi Leif, Ard,
>
> A gentle ping again on this.
>
Merged as 2f5e841018d9..86759a1bf829
My apologies for the delay.
--
Ard.
>
>
> On Mon, 23 May 2022 at 13:58, Masahisa Kojima via groups.io
> wrote:
> >
> > Hi Leif, Ard,
> >
> > A
Hi,
+ Eric Jin
This is a good question.
GenerateCapsule.py can take input arguments from command line or a JSON file.
I think you have found a case where these two input options do not have
identical behavior.
* If EmbeddedDrivers are not provided through command line, then no warning
Output file GUIDs from the DXE and PEI apriori files.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 74
1 file changed, 74 insertions(+)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index
Hi Ard,
Thank you for this patch.
I have just checked and that patch v2 1/2 from this series is no longer
required but this patch v2 2/2 is still applicable.
I have applied patch v2 2/2 on latest edk2 master and tested with FVP
model and can boot Linux.
Reviewed-by: Sami Mujawar
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The EFI_RNG_PROTOCOL published by RngDxe has been updated to
implement the EFI_RNG_ALGORITHM_RAW using the Arm FW-TRNG
interface to provide access to entropy.
Therefore, enable EFI_RNG_PROTOCOL for the
From: Pierre Gondois
To re-use the AArch64/RngDxe.c for an Arm implementation,
rename AArch64/RngDxe.c to ArmRngDxe.c.
Signed-off-by: Pierre Gondois
---
.../RngDxe/{AArch64/RngDxe.c => ArmRngDxe.c}| 0
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf | 2 +-
From: Pierre Gondois
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
Add RngDxe support for Arm. This implementation uses the TrngLib
to support the RawAlgorithm and doens't support the RNDR instruction.
To re-use the RngGetRNG(), RngGetInfo() and FreeAvailableAlgorithms()
From: Pierre Gondois
PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm
used by the RNDR CPU instruction to generate a random number.
Add a debug warning if the Pcd is not set.
Signed-off-by: Pierre Gondois
---
.../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
RawAlgorithm is used to provide access to entropy that is suitable
for cryptographic applications. Therefore, add RawAlgorithm support
that provides access to entropy using the TrngLib.
Also remove unused
From: Pierre Gondois
RngGetBytes() relies on the RngLib. The RngLib might use the RNDR
instruction if the FEAT_RNG feature is present. RngGetInfo and
RngGetRNG both must check that RngGetBytes() is working before
advertising/using it.
To do so, allocate an array storing the available
From: Pierre Gondois
This patch:
-Update RngGetBytes() documentation to align the function
definition and declaration.
-Improve input parameter checking. Even though 'This'
it is not used, the parameter should always point to the
current EFI_RNG_PROTOCOL.
-Removes TimerLib inclusion as
From: Pierre Gondois
RngGetInfo() is one of the 2 functions of the EFI_RNG_PROTOCOL.
RngGetInfo() is currently a mere wrapper around
ArchGetSupportedRngAlgorithms() which is implemented differently
depending on the architecture used.
RngGetInfo() does nothing more than calling
From: Pierre Gondois
gEfiRngAlgorithmSp80090Ctr256Guid was used as the default algorithm
in RngGetRNG(). The commit below set the default algorithm to
PcdCpuRngSupportedAlgorithm, which is a zero GUID by default.
As the Pcd value is not defined for any platform in the edk2-platfoms
repository,
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
Rename RdRandGenerateEntropy() to GenerateEntropy() to provide a
common interface to generate entropy on other architectures.
GenerateEntropy() is intended to generate high quality entropy.
Also move the
From: Pierre Gondois
Add a ArmHasRngExt() to check for the FEAT_RNG extension.
Also add a mask for the RNDR bits.
Signed-off-by: Pierre Gondois
---
ArmPkg/Include/Library/ArmLib.h| 12 +++-
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 15 ++-
From: Pierre Gondois
The MdePkg must be self contained and not have external dependencies.
ArmReadIdIsar0() is defined in MdePkg/Library/BaseRngLib and is
limited to the scope of this library.
The same function will be required to check the FEAT_AES and FEAT_RNG
extensions in other libraries.
From: Pierre Gondois
Add a ArmReadIdIsar0() helper function to access the AArch64
ID_ISAR0_EL1 register.
Signed-off-by: Pierre Gondois
---
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 12 +++-
ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 7 ++-
2 files changed, 17
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0,
Platform Design Document
(https://developer.arm.com/documentation/den0098/latest/)
defines an interface between an Operating System (OS)
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0,
Platform Design Document
(https://developer.arm.com/documentation/den0098/latest/)
defines an interface between an Operating System (OS)
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The True Random Number Generator (TRNG) library defines an
interface to access the entropy source on a platform. On
platforms that do not have access to an entropy source, a
NULL instance of the TRNG library
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The NIST Special Publications 800-90A, 800-90B and 800-90C
provide recommendations for random number generation. The
NIST 800-90C, Recommendation for Random Bit Generator (RBG)
Constructions, defines the
From: Pierre Gondois
Add a Null instance of ArmHvcLib in case of library dependencies.
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.dsc | 1 +
ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c | 29 +++
.../Library/ArmHvcNullLib/ArmHvcNullLib.inf
From: Pierre Gondois
The ArmMonitorLib provides an abstract interface to issue
an HyperVisor Call (HVC) or System Monitor Call (SMC) depending
on the default conduit.
The PcdMonitorConduitHvc PCD allows to select the default conduit.
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.dsc
From: Pierre Gondois
The ArmMonitorLib provides an abstract interface to issue
an HyperVisor Call (HVC) or System Monitor Call (SMC) depending
on the default conduit.
The PcdMonitorConduitHvc PCD allows to select the default conduit.
The new library relies on the ArmHvcLib and ArmSmcLib
From: Sami Mujawar
Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for
monitor calls. PcdMonitorConduitHvc is defined as FALSE by default,
meaning the SMC conduit is enabled as default.
Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used
by virtual firmware
From: Pierre Gondois
Bugzilla: Bug 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0, specification
defines an interface between an Operating System (OS) executing at EL1 and
Firmware (FW) exposing a conditioned entropy
Change SMM to MM in naming according to the recent PI specifications.
Remove trailing whitespaces in some strings.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Hi Sami,
Thank you for the review.
Regarding the use of Dynamic Tables Framework, there are no short term plans to
migrate to it. Please find my response for your comment inline -
On Thu, Jul 21, 2022 at 01:42 PM, Sami Mujawar wrote:
>
> Hi Rohit,
>
> Have you considered moving to use
Hello Ard,
Looks there hasn't any feedback from other maintainers yet.
Would you like to merge this patch in or still wait for more feedback?
Could anyone else please review this patch? thank you!
Thanks
Annie
On 5/13/2022 7:28 AM, Annie.li wrote:
On 5/3/2022 12:25 PM, Ard Biesheuvel
Pushed as 57729d3c3466..2f5e841018d9
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91695): https://edk2.groups.io/g/devel/message/91695
Mute This Topic: https://groups.io/mt/90260402/21656
Group Owner:
Hi Pranav,
Apologies for the delay.
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/04/2022 07:48 am, Pranav Madhu wrote:
Replace EfiResetSystemLib library with ResetSystemLib library. UEFI
ResetSystem() API is implemented in both these libraries, and
Hi Zhiguan,
The ArmPkg/Library/* changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/07/2022 08:57 am, Zhiguang Liu wrote:
Hide the Exception implementation details in CpuExcetionHandlerLib and
caller only need to provide buffer
Cc: Eric Dong
Cc: Ray Ni
Cc:
Hi,
I would like to handle ‘DriverBinding protocol’ model in ‘RegisterFmpInstaller’
to get control of USBIO. Since there is no corresponding example for EDK2, this
part is not easy to implement. Can you provide an example of how
RegisterFmpInstaller handles the DriverBinding protocol, so as to
Since the API InitializeSeparateExceptionStacks is simplified and does't
use the struct CPU_EXCEPTION_INIT_DATA, CPU_EXCEPTION_INIT_DATA become
a inner implementation of CpuExcetionHandlerLib. Remove it from
MdeModulePkg. Also, two fields (Revision and InitDefaultHandlers)are
useless, can be
Hide the Exception implementation details in CpuExcetionHandlerLib and
caller only need to provide buffer
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Leif Lindholm
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Zhiguang Liu
---
The patch set is to hide the exception implementation details, so that
caller don't need to know anything about IDT when separate stack for it.
However, this patch set changes a library API, so I have to change
multiple packages inside one patch. Otherwise, I can make sure every
single commit can
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Monday, July 18, 2022 8:56 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ;
> Konstantin Aladyshev
> Subject: [PATCH] BaseTools/VolInfo: Increase define for highest
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Konstantin Aladyshev
> Sent: Wednesday, July 13, 2022 9:11 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ;
> Konstantin Aladyshev
> Subject: [edk2-devel] [PATCH]
70 matches
Mail list logo
