[edk2-devel] 回复: [PATCH v4 00/21] Add Raw algorithm support using Arm FW-TRNG interface

2022-07-24 Thread gaoliming via groups.io
Pierre: The change in MdePkg is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: pierre.gond...@arm.com > 发送时间: 2022年7月22日 22:32 > 收件人: devel@edk2.groups.io > 抄送: Sami Mujawar ; Leif Lindholm > ; Ard Biesheuvel ; > Rebecca Cran ; Michael D Kinney > ; Liming Gao ; > Jie

回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs

2022-07-24 Thread gaoliming via groups.io
This change has been merged in edk2 master. > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming via > groups.io > 发送时间: 2022年7月13日 15:48 > 收件人: devel@edk2.groups.io; kun@microsoft.com; 'Kinney, Michael D' > ; 'Albecki, Mateusz' > > 抄送: 'Liu, Zhiguang' > 主题: 回复: 回复: [edk2-devel] [PATC

回复: [edk2-devel] [PATCH v3] BaseTools/Capsule: Add support for signtool to input subject name to sign capsule file

2022-07-24 Thread gaoliming via groups.io
Jason: Thanks for you to add the detail usage model in BZ 3928. I have no other comments. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Lin, Jason1 > 发送时间: 2022年7月8日 19:42 > 收件人: devel@edk2.groups.io > 抄送: Jason1 Lin ; Bob Feng ; > Liming Gao ; Yuwei Che

[edk2-devel] [edk2-staging][PATCH v2 12/15] edk2-staging/RedfishClientPkg: Rename Memory feature driver

2022-07-24 Thread Nickle Wang
Rename Memory driver by removing Redfish prefix. Update memory feature driver and support all properties under Memory schema. Also support "Identify" action in this driver. Corresponding changes are made to honor newly introduced library and protocol. Signed-off-by: Nickle Wang Cc: Abner Chang C

[edk2-devel] [edk2-staging][PATCH v2 15/15] edk2-staging/RedfishClientPkg: Introduce Bios feature driver

2022-07-24 Thread Nickle Wang
Introduce new feature driver to support Bios version 1.0.9 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 741 .../Featu

[edk2-devel] [edk2-staging][PATCH v2 13/15] edk2-staging/RedfishClientPkg: Introduce Computer System collection driver

2022-07-24 Thread Nickle Wang
Introduce new feature driver to support Computer System Collection schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.c | 667 ++

[edk2-devel] [edk2-staging][PATCH v2 14/15] edk2-staging/RedfishClientPkg: Introduce Computer System feature driver

2022-07-24 Thread Nickle Wang
Introduce new feature driver to support Computer System version 1.5.0 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1_5_0/Common/ComputerSystemCommon.c | 1614 +++

[edk2-devel] [edk2-staging][PATCH v2 11/15] edk2-staging/RedfishClientPkg: Rename RedfishMemoryCollection driver

2022-07-24 Thread Nickle Wang
Rename RedfishMemoryCollectionDxe by removing Redfish prefix. Update memory collection driver to support "Identify" action and also have code refactoring to support Redfish operation. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../MemoryCollectionDxe.c}

[edk2-devel] [edk2-staging][PATCH v2 09/15] edk2-staging/RedfishClientPkg: Update RedfishLib

2022-07-24 Thread Nickle Wang
RedfishLib has no capability to return HTTP header in response. However, feature driver needs to know the information like "ETag" or "Location" in HTTP response header per Redfish specification. Add corresponding function to return HTTP header in response data. Signed-off-by: Nickle Wang Cc: Abne

[edk2-devel] [edk2-staging][PATCH v2 08/15] edk2-staging/RedfishClientPkg: Update Redfish feature core driver

2022-07-24 Thread Nickle Wang
Update Redfish feature core driver to support Redfish resource with multiple parents. A resource may be presented in different resource and the link in different resource point to the same location. Also add interchange data interface in feature core driver so feature core driver can talk to featur

[edk2-devel] [edk2-staging][PATCH v2 06/15] edk2-staging/RedfishClientPkg: Introduce RedfishConfigLangMap driver

2022-07-24 Thread Nickle Wang
Introduce Redfish configure language map driver. This driver keeps the mapping between configure language and Redfish URI for internal use. This saves the communication time between feature drivers and Redfish service. It also provides the history records so that feature drivers can do provisioning

[edk2-devel] [edk2-staging][PATCH v2 07/15] edk2-staging/RedfishClientPkg: Update ETag driver

2022-07-24 Thread Nickle Wang
Update ETag driver and use specific variable GUID. Also fix the typo in comment. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec| 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10 +- RedfishCli

[edk2-devel] [edk2-staging][PATCH v2 05/15] edk2-staging/RedfishClientPkg: Introduce resource identify library

2022-07-24 Thread Nickle Wang
Introduce resource identify library which works with resource config protocol to identify Redfish resource. This library provides the flexibility for platform to implement its own policy and identify resource. Two library implementation are provided as demonstration code. NULL version of library ac

[edk2-devel] [edk2-staging][PATCH v2 04/15] edk2-staging/RedfishClientPkg: Introduce Redfish resource config library

2022-07-24 Thread Nickle Wang
Add EdkIIRedfishResourceConfigLib in order to work with Redfish Config Protocol and do the communication between each feature drivers. Also introduce Redfish interchange data protocol to exchange data efficiently. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .

[edk2-devel] [edk2-staging][PATCH v2 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol

2022-07-24 Thread Nickle Wang
Update Redfish resource config protocol to support Identify action in order to identify remote resource and see if this is resource belongs to current owner or not. Use unicode string instead of ASCII string for all interfaces to align with HTTP interface. Signed-off-by: Nickle Wang Cc: Abner Cha

[edk2-devel] [edk2-staging][PATCH v2 02/15] edk2-staging/RedfishClientPkg: Introduce Redfish version library

2022-07-24 Thread Nickle Wang
Add RedfishVersionLib in order to get Redfish version hosted at BMC. When there is trouble to get Redfish support version, the default version is retrieved from pre-defined PCD value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Include/Library/RedfishVers

[edk2-devel] [edk2-staging][PATCH v2 01/15] edk2-staging/RedfishClientPkg: Introduce Redfish event library

2022-07-24 Thread Nickle Wang
Add RedfishEventLib to handle Redfish event. There are two events defined in this library. One is the event before feature driver provisioning and the other one is the event after all provisioning is finished. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../I

[edk2-devel] [edk2-staging][PATCH v2 00/15] Update RedfishClientpkg

2022-07-24 Thread Nickle Wang
In this series of patch files, additional three feature drivers are enabled. Corresponding libraries and protocols are introduced to help performing Redfish operation like provisioning, consuming and updating Redfish resource between UEFI HII driver and Redfish service hosted at BMC side. Nickle

[edk2-devel] [edk2-staging][PATCH v2 2/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBiosDxe driver

2022-07-24 Thread Nickle Wang
Add Hii2RedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Andrew Fish

[edk2-devel] [edk2-staging][PATCH v2 1/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBootDxe driver

2022-07-24 Thread Nickle Wang
Add Hii2RedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Andrew Fish

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Ext4Pkg: Code correctness and security improvements

2022-07-24 Thread Pedro Falcato
Hi Savva, Could you please send a new version of the patch, with a proper encoding (try 8bit encoding, quoted-printable is screwing up my git am) and addressing Marvin's concerns? Take the time and send a new version of the symlink patchset as well. Thanks, Pedro On Wed, Jul 20, 2022 at 6:36 AM

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Correct EFI_SECTION_VERSION display

2022-07-24 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Konstantin Aladyshev Sent: Monday, July 18, 2022 5:44 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [PATCH] BaseTools/VolInfo: Correct EFI_SECTION_VERSION display - Correct t

[edk2-devel] [edk2-platforms][PATCH v3 2/2] Ext4Pkg: Add base containing record macro for EXT4_FILE

2022-07-24 Thread Savva Mitrofanov
We shouldn't use direct casts, because in the future it could break the code, so using BASE_CR would be safe against possible structure changes and rearrangements Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h |

[edk2-devel] [edk2-platforms][PATCH v3 1/2] Ext4Pkg: Add symbolic links support

2022-07-24 Thread Savva Mitrofanov
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 Provided support for symlink file type. Added routine which allows reading and following them through recursive open() call. As a security meausure implemented simple symlink loop check with nest level limit equal 8. Also this patch moves Ext

[edk2-devel] [edk2-platforms][PATCH v3 0/2] Ext4Pkg: Add Symbolic Links support

2022-07-24 Thread Savva Mitrofanov
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 Hi all, In the third version I tried to correct all the remarks according detection logic of fast-symlink and its reading, code style and several mistakes. This patchset adds symbolic links support with simple recursion protection based on

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] Ext4Pkg: Add symbolic links support

2022-07-24 Thread Savva Mitrofanov
Hello, Marvin! Thank you for your time and this code-review > On 21 Jul 2022, at 01:15, Marvin Häuser wrote: > > > >> On 20. Jul 2022, at 08:17, Savva Mitrofanov > > wrote: >> >> Provided support for symlink file type. Added routine which allows >> reading and follo

[edk2-devel] [PATCH] BaseTools/VolInfo: Update copyright information

2022-07-24 Thread Konstantin Aladyshev
Add Konstantin Aladyshev to the copyright header. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolInfo/VolInfo.c index 28c6806cf0..428011ca04 100644 ---

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Parse apriori files

2022-07-24 Thread Bob Feng
Copyright (c) 2022, Konstantin Aladyshev Will be fine. Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Konstantin Aladyshev Sent: Sunday, July 24, 2022 4:34 PM To: Feng, Bob C Cc: devel@edk2.groups.io; Gao, Liming ; Chen, Christine Subject: Re: [edk2-devel] [P

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Parse apriori files

2022-07-24 Thread Konstantin Aladyshev
Hi, Bob! How should I update it? Should I increase a year for the Intel Corporation like this ``` Copyright (c) 1999 - 2022, Intel Corporation. All rights reserved. ``` Or should I enter my name on another string? ``` Copyright (c) 2022, Konstantin Aladyshev ``` Best regards, Konstantin Aladysh