Hi Ard, Mike,
Sorry, I did not see the your messages before responding.
Please ignore my last message. I will leave the change as is.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91988):
The definition for ARM_PROCESSOR_TABLE has been removed by
commit c8af26627a4e9a3659255dc147d75596da08248e
as it is a pseudo ACPI table.
This causes the JadePkg builds to fail. Therefore, update
Ampere/JadePkg to reflect this change.
Signed-off-by: Sami Mujawar
---
Hi Mike,
I have tried to revert the commit on my local branch as follows
git revert 2faefb2bbcc8083e1bd28908c0b29b5d18595298 -m 1
With this change the preceding commit is dropped.
git whatchanged -1
commit 54f3232f3e19387e3bc5eb79c4b46eb2daba99fd (HEAD -> test)
Author: Sami
Hi Ard,
I agree it will always be there.
I have added a branch protection rule to edk2-platforms/master
to require linear history. I would expect any future attempt
to push a merge commit will fail with an error.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
Reverting and reapplying kind of defeats the purpose, to be honest.
The merge commit is still part of the history, and so its effect
during a bisect will be there regardless.
So I suggest we just leave this as is.
On Fri, 29 Jul 2022 at 13:20, Kinney, Michael D
wrote:
>
> Hi Sami,
>
> There
Hi Sami,
There is one other instance of this in edk2-platform history.
It was immediately followed by a Revert.
--
commit 3e31cfea3de2fe49b49a67a1d6c9f9ca09e7f332
Author: Siyuan Fu
Date: Mon Feb 10 12:29:48 2020 +0800
Revert "Merge remote-tracking branch 'upstream/master'"
Of all the gin joints in all the towns in all the world, Rafael Machado had to
walk into mine at 11:40:00 on Friday, 29 July 2022 and say:
> Hi James, thanks for the answer.
>
> I will try to explain my scenario in simple words.
> In my case, what I would like to do is to create a runtime uefi
On Fri, 29 Jul 2022 at 13:13, Sami Mujawar wrote:
>
> Adding Leif and Mike.
>
> On 29/07/2022 08:54 pm, Sami Mujawar wrote:
> > Hi Ard,
> >
> > I have accidentally pushed a change to the edk2-platforms repo.
> >
> > The commit is
> >
> > 2faefb2bbcc8083e1bd28908c0b29b5d18595298 Merge branch
> >
Adding Leif and Mike.
On 29/07/2022 08:54 pm, Sami Mujawar wrote:
Hi Ard,
I have accidentally pushed a change to the edk2-platforms repo.
The commit is
2faefb2bbcc8083e1bd28908c0b29b5d18595298 Merge branch
'master' of github.com:/tianocore/edk2-platforms
Appologies for the trouble. Can you
Hi Ard,
I have accidentally pushed a change to the edk2-platforms repo.
The commit is
2faefb2bbcc8083e1bd28908c0b29b5d18595298 Merge branch
'master' of github.com:/tianocore/edk2-platforms
Appologies for the trouble. Can you advise on how this can be fixed, please?
Regards,
Sami Mujawar
Hi Kun,
Thank you for this patch.
This change fixes the build break for Phytium platforms.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 21/07/2022 09:07 pm, Kun Qin via groups.io wrote:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
Hi James, thanks for the answer.
I will try to explain my scenario in simple words.
In my case, what I would like to do is to create a runtime uefi var, that
would be changed only by one .exe I have developed.
So other .exe would not be able to perform changes at this uefi var.
Any ideia?
This changes tends to improve security of code sections by fixing
integer overflows, missing alignment checks, unsafe casts, also
simplified some routines, fixed compiler warnings and corrected some
code mistakes.
- Set HoleLen to UINT64 to prevent truncation in Ext4Read function
- Replace
Hi all,
This is the third version of patch in which I correct commit message and added
some
code-style corrections into conditions with bit operations.
REF:
https://github.com/savvamitrofanov/edk2-platforms/commits/ext4pkg_security_improvements
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly
On Thu, 28 Jul 2022 at 13:25, Jeff Brasen wrote:
>
>
> Adding Leif/Ard to CC incase they have any comments on this patch.
>
This generally looks ok to me. I just wonder if it wouldn't be simpler
to reuse the existing allocation descriptor if it is not being freed
entirely. Given the [presumably]
On 7/29/22 07:00, Kun Qin wrote:
Hi Pierre,
Thank you for your feedback. I will add more document/comments to the
newly define structure, as
well as the "break" as you suggested.
As per failure to locate "gEfiAcpiSdtProtocolGuid", my thought was that
this protocol could be enabled
per
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Dimitrije Pavlov
Sent: 20 July 2022 23:05
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Graeme Gregory ; Radoslaw
Biernacki ; Jeff Booher-Kaeding
; Samer El-Haj-Mahmoud
; Sunny Wang ; Jeremy Linton
Hi Pedro,
Thanks for pointing this problem, it is really complicated. As we discussed in
Element, EDKII uses CRLF in their codebase, so to send it correct we need to
use quoted-printable transfer encoding to preserve CRLF, otherwise the patches
will be damaged and force applying them will
Hi Christine!
I think the GenCrc32 usage is different because it just prepends the
data with the CRC32 value leaving the main data unmodified, opposed to
all of the encryption utilities that change the data itself.
Therefore in the case of the GenCrc32 produced section it is possible
to get the
Hi Marvin,
Thanks for comments!
> On 20 Jul 2022, at 23:54, Marvin Häuser wrote:
>
> On 20. Jul 2022, at 07:36, Savva Mitrofanov wrote:
>>
>> This changes tends to improve security of code sections by fixing
>> integer overflows, missing aligment checks, unsafe casts, also
>> simplified
As Cloud Hypervisor has its own PeiMemLib, change it in dsc file
accordingly.
Signed-off-by: Jianyong Wu
---
ArmVirtPkg/ArmVirtCloudHv.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc
index
Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory
layout for cloud hypervisor is changed, it needs a new meminfo lib.
Signed-off-by: Jianyong Wu
Jianyong Wu (2):
CloudHv/arm: add PeiMemInfoLib
CloudHv/arm: switch PeiMemLib to its own
ArmVirtPkg/ArmVirtCloudHv.dsc
Memory layout in CLoud Hypervisor for arm is changed and is different
with Qemu, thus we should build its own PeiMemInfoLib.
The main change in the memory layout is that normal ram may not contiguous
under 4G. The top 64M under 4G is reserved for 32bit device.
What this patch does:
1. get all of
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3962
Two SMM variables (mSmrrSupported & mSmmFeatureControlSupported) are global
variables, they control whether the SMRR and SMM Feature Control MSR will
be restored respectively.
To avoid the TOCTOU, add PCD to control SMRR & SmmFeatureControl
24 matches
Mail list logo