Sean:
I add my comments below.
> -邮件原件-
> 发件人: Sean Rhodes
> 发送时间: 2022年7月26日 16:15
> 收件人: devel@edk2.groups.io
> 抄送: Sean Rhodes ; Zhichao Gao
> ; Ray Ni ; Jian J Wang
> ; Liming Gao
> 主题: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of
> the Logo
>
> When set
The change is good. But the change in Smbios type 9 will impact
ShellPkg\Library\UefiShellDebug1CommandsLib\SmbiosView\PrintInfo.c. Please
also update ShellPkg.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sainadh
> Nagolu via groups.io
> 发送时间: 2022年7月28日 0:21
> 收件人:
This change is good to me. Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 sivaparvathi
> C via groups.io
> 发送时间: 2022年8月2日 13:00
> 收件人: devel@edk2.groups.io
> 抄送: Vasudevan Sambandan ; Sundaresan S
> ; Sivaparvathi Chellaiah
> 主题: [edk2-devel] [edk2]
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Samer
> El-Haj-Mahmoud
> 发送时间: 2022年8月3日 21:11
> 收件人: devel@edk2.groups.io; saina...@ami.com
> 抄送: Sundaresan S ; Vasudevan Sambandan
> ; gaolim...@byosoft.com.cn; Samer
> El-Haj-Mahmoud ; nd
> 主题: Re: [edk2-devel] [PATCH]
Hi Liming,
You mentioned patch rename the DevicePathUtilitiesStandaloneMm to
UefiDevicePathLibBase, but there are some consumer in intel platform still use
the DevicePathUtilitiesStandaloneMm, so downstream will failed in CI because it
cannot find DevicePathUtilitiesStandaloneMm. So the
Thanks for your update. This change is good to me. Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Konstantin
> Aladyshev
> 发送时间: 2022年7月27日 16:45
> 收件人: devel@edk2.groups.io
> 抄送: jian.j.w...@intel.com; gaolim...@byosoft.com.cn;
> dandan...@intel.com;
Yanbo:
Previous change has been reviewed and merged. Please see the detail
https://edk2.groups.io/g/devel/message/91799
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Huang, Yanbo
> 发送时间: 2022年8月5日 10:42
> 收件人: devel@edk2.groups.io
> 抄送: Yanbo Huang ; Michael D Kinney
> ; Liming
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: mikub...@linux.microsoft.com
> 发送时间: 2022年8月3日 2:04
> 收件人: devel@edk2.groups.io
> 抄送: Dandan Bi ; Guomin Jiang
> ; Hao A Wu ; Jian J Wang
> ; Liming Gao ; Ray Ni
>
> 主题: [PATCH v1 3/5] MdeModulePkg: Fix imbalanced debug macros
>
> From: Michael
From: Yanbo Huang
reback the DevicePathUtilitiesStandaloneMm to unblock the downstream sync
Signed-off-by: Yanbo Huang
CC: Michael D Kinney
CC: Liming Gao
CC: Zhiguang Liu
---
.../DevicePathUtilitiesStandaloneMm.c | 39 ++
.../UefiDevicePathLibStandaloneMm.inf | 75
Series merged via:
PR - https://github.com/tianocore/edk2/pull/3176
Commits:
https://github.com/tianocore/edk2/commit/86757f0b4750f672f346d955f89e5b76430ba6b4
https://github.com/tianocore/edk2/commit/a8f59e2eb44199040d2e1f747a6d950a25ed0984
Best Regards,
Hao Wu
> -Original Message-
>
Hi Chasel,
I have a few comments for you.
First, we should have a platform provided LibraryClass for running code in
between multi-phase actions. Right now you just have this comment in
IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c:
//
Hi Ard,
The term "Pipeline" is not applicable in the scope of edk2-platforms.
Thanks for catching it.
A new version was sent for this fix:
https://edk2.groups.io/g/devel/message/92128. Please let
me know if there is any other feedback.
Regards,
Kun
On 8/4/2022 3:26 AM, Ard Biesheuvel
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
PhytiumCommonPkg platforms build.
Cc: Leif Lindholm
Cc: Peng Xie
Cc: Ling Jia
Cc: Yiqi Shu
Signed-off-by: Kun Qin
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms build.
Cc: Abner Chang
Cc: Gilbert Chen
Cc: Daniel Schaefer
Signed-off-by: Kun Qin
---
Notes:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms build.
Cc: Nhi Pham
Cc: Vu Nguyen
Cc: Thang Nguyen
Cc: Chuong Tran
Cc: Leif Lindholm
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms build.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Masami Hiramatsu
Signed-off-by: Kun Qin
---
Notes:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
ArmVExpress platforms build.
Cc: Ard Biesheuvel
Cc: Thomas Abraham
Cc: Sami Mujawar
Signed-off-by: Kun Qin
Reviewed-by:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms build.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Jeremy Linton
Signed-off-by: Kun Qin
Reviewed-by:
This v4 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/92063
The only update in v4 patches is to update the commit titles to remove
"pipeline" references as this is not applicable to edk2-platforms.
Patch v4
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Implement MultiPhase wrapper handlers and only call to MultiPhase
handlers when FSP supports.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 33
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Adopt MultiPhase functions for both FspSecCoreS and FspSecCoreM.
For backward compatibility, new INF are created for new modules.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/SecFsp.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Provide FSP 2.4 MultiPhase wrapper support library.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c
| 337
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Provide FSP 2.4 MultiPhase interface and scripts
support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c | 176
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Add FSP 2.4 MultiPhase interfaces and implementation.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
Chasel Chiu (4):
IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase
Introduce NetworkCfgLib which will set PcdNetworkSupport based on
"etc/networking" qemu file.
If "etc/networking" (type bool) is TRUE, then PcdNetworkSupport will be
TRUE and vice versa.
In the following patch, PcdNetworkSupport will be used to enable/disable
VirtIo net driver so that VMM will
Host Interface details are discribed by the SMBIOS Type 42 table.
The table is published by the RedfishHostInterfaceDxe driver.
That driver supports PCI-E and USB host interface types.
The table is consumed by the RedfishGetHostInterfaceProtocolData function
in the RedfishDiscoverDxe driver.
That
Currently networking can only be enabled/disabled at compile time. This
patch series will add support to disable VirtIo net at runtime even if
the functionality is built into binary at compile time.
This will enable VMM to reduce attack surface without recompilation.
The changes can be seen at:
There is no function to send POST requets with the ContetntType different
from "application/json".
There is no function to send DELETE request with the body.
---
RedfishPkg/Include/Library/RedfishLib.h |
696
Enable/Disable VirtIo net based on the value of PcdNetworkSupport which
is controlled in NetworkCfgLib, which sets the PCD based on
"etc/networking" qemu file.
With this change, VMM can disable networking even if it is enabled at
compile time. This will allow to reduce attack surface by simply
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Tuesday, July 19, 2022 11:46 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Show FV section boundaries
Currently there
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Wednesday, July 20, 2022 10:08 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/GenSec: Support EFI_SECTION_FREEFORM_SUBTYPE_GUID
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Wednesday, July 20, 2022 8:01 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Parse EFI_SECTION_FREEFORM_SUBTYPE_GUID
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Tuesday, July 19, 2022 10:27 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [edk2-devel] [PATCH] BaseTools/GenSec:
On Thu, 28 Jul 2022 at 11:53, Oliver Steffen wrote:
>
> Hi everyone,
>
> I checked Rebecca's patch with my Qemu use case.
> All fine - we can use that patch instead of the series I posted here.
> Even better, because it prints the version information.
>
> Thanks!
>
Thanks for confirming.
On 08/04/22 11:58, Ard Biesheuvel wrote:
> On Thu, 4 Aug 2022 at 07:55, Laszlo Ersek wrote:
>>
>> On 08/04/22 04:52, Yuan Yu wrote:
>>> Currently networking can only be enabled/disabled at compile time. This
>>> patch series will add support to disable VirtIo net at runtime even if
>>> the
On Wed, 3 Aug 2022 at 16:36, Sami Mujawar wrote:
>
> This patch series adds support to build PRM for AARCH64 using GCC.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/2238_aarch64_prm_support_v1
>
> Jose Marinho (5):
> Basetools/GenFw: Allow AARCH64 builds to use the
On Wed, 3 Aug 2022 at 00:59, Kun Qin wrote:
>
> This v2 series is a follow up of previously submitted patches:
> https://edk2.groups.io/g/devel/message/91669
>
> The main update in v3 patches are:
> - Updated a commit message to include Review-by tag
> - Dumped a commit for Qemu platform as it
Hi Ray/ Jian/ Liming
Would you be able to review this patch please?
Many thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92109): https://edk2.groups.io/g/devel/message/92109
Mute This Topic:
On Thu, 4 Aug 2022 at 07:55, Laszlo Ersek wrote:
>
> On 08/04/22 04:52, Yuan Yu wrote:
> > Currently networking can only be enabled/disabled at compile time. This
> > patch series will add support to disable VirtIo net at runtime even if
> > the functionality is built into binary at compile time.
Fix using RmrNodeCount uninitliased by initliasing it to zero. Also, add
an additional check for ACPI version. This fixes a crash running on
kvmtool.
Signed-off-by: Edward Pickup
---
Change can be seen at
https://github.com/edpickup/edk2/tree/2322_rmrnodecount_uninitialised_v1
Merged as 444260d45ec2a84e8f8c192b3539a3cd5591d009
On Thu, 4 Aug 2022 at 07:02, Sean Rhodes wrote:
> Reviewed-by: Sean Rhodes
>
> On Wed, 3 Aug 2022 at 22:14, Dong, Guo wrote:
>
>> Reviewed-by: Guo Dong
>>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Sean
>>
Reviewed-by: Sean Rhodes
On Wed, 3 Aug 2022 at 22:14, Dong, Guo wrote:
> Reviewed-by: Guo Dong
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean Rhodes
> Sent: Tuesday, August 2, 2022 1:00 PM
> To: devel@edk2.groups.io
> Cc: Rhodes, Sean ; Dong, Guo ;
> Ni, Ray
>
Merged as 79aab22fcaecf0bd70099e97c92fe3e816e450ce
On Thu, 4 Aug 2022 at 07:01, Sean Rhodes wrote:
> Reviewed-by: Sean Rhodes
>
> On Wed, 3 Aug 2022 at 22:14, Guo Dong wrote:
>
>>
>> Reviewed-by: Guo Dong
>>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Sean
>>
Reviewed-by: Sean Rhodes
On Wed, 3 Aug 2022 at 22:14, Guo Dong wrote:
>
> Reviewed-by: Guo Dong
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean Rhodes
> Sent: Tuesday, August 2, 2022 1:00 PM
> To: devel@edk2.groups.io
> Cc: Rhodes, Sean ; Dong, Guo ;
> Ni, Ray
44 matches
Mail list logo
