Re: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of kavya Sent: Thursday, August 11, 2022 12:08 AM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Guo, Gua Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Return

Re: [edk2-devel] [PATCH v4 21/28] UefiPayloadPkg: Add ProtectedVariable reference

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Vang, Judah Sent: Wednesday, August 10, 2022 11:54 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Dong, Guo ; Ni, Ray ; Maurice Ma ; You, Benjamin ; Rhodes, Sean ; Mistry, Nishant C Subject: [PATCH v4 21/28] UefiPayloadPkg: Add

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix Coverity report defect

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of GregX Yeh Sent: Wednesday, August 10, 2022 11:46 PM To: devel@edk2.groups.io Cc: Yeh, GregX ; Dong, Guo ; Ni, Ray Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix Coverity report defect From: Gregx Yeh

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to control NvmExpressDxe

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Sravanthi, K KavyaX Sent: Wednesday, August 10, 2022 1:37 AM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Add macro to control NvmExpressDxe Add

Re: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Remove clearing CR0.WP when protecting pagetable

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Tan, Dun Sent: Tuesday, August 9, 2022 10:34 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Maurice Ma ; You, Benjamin ; Rhodes, Sean Subject: [Patch V2 2/2] UefiPayloadPkg: Remove clearing CR0.WP when protecting pagetable

Re: [edk2-devel][edk2-platforms][PATCH V1 3/3] PlatformPayloadFeaturePkg: Update contents to match feature conventions

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Oram, Isaac W Sent: Wednesday, August 10, 2022 3:47 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; Ni, Ray ; Dong, Guo Subject: [edk2-devel][edk2-platforms][PATCH V1 3/3]

Re: [edk2-devel][edk2-platforms][PATCH V1 1/3] PlatformPayloadPkg: Fix AdvancedFeaturePkg build issue

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Oram, Isaac W Sent: Wednesday, August 10, 2022 3:47 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; Ni, Ray ; Dong, Guo Subject: [edk2-devel][edk2-platforms][PATCH V1 1/3]

Re: [edk2-devel][edk2-platforms][PATCH V1 2/3] PlatformPayloadPkg: Rename to match other feature conventions

2022-08-12 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Oram, Isaac W Sent: Wednesday, August 10, 2022 3:47 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; Ni, Ray ; Dong, Guo Subject: [edk2-devel][edk2-platforms][PATCH V1 2/3]

Re: [edk2-devel][edk2-platforms][PATCH V1 2/3] PlatformPayloadPkg: Rename to match other feature conventions

2022-08-12 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Oram, Isaac W Sent: Wednesday, August 10, 2022 3:47 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; Ni, Ray ; Dong, Guo Subject: [edk2-devel][edk2-platforms][PATCH V1

Re: [edk2-devel][edk2-platforms][PATCH V1 1/3] PlatformPayloadPkg: Fix AdvancedFeaturePkg build issue

2022-08-12 Thread Chaganty, Rangasai V
Small cosmetic feedback. There is an (unnecessary) open "(" in line 145. Please remove it before checking in. # (Optional for variable modules debug output With that: Reviewed-by: Sai Chaganty -Original Message- From: Oram, Isaac W Sent: Wednesday, August 10, 2022 3:47 PM To:

[edk2-devel] [PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported

2022-08-12 Thread Igor Kulchytskyy via groups.io
Host Interface details are described by the SMBIOS Type 42 table. The table is published by the RedfishHostInterfaceDxe driver. That driver supports PCI-E and USB host interface types. The table is consumed by the RedfishGetHostInterfaceProtocolData function in the RedfishDiscoverDxe driver. The

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Add support to build _DSD

2022-08-12 Thread PierreGondois
Hi Jeff, Please find some inline comments below: On 8/5/22 17:14, Jeff Brasen via groups.io wrote: Add APIs needed to build _DSD with different UUIDs. This is per ACPI specification 6.4 s6.2.5. Adds support for building data packages with format Package {"Name", Integer} Signed-off-by:

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdePkg:Improved Smbios Type9 table and Smbios 3.5.0 spec changes

2022-08-12 Thread Sainadh Nagolu via groups.io
ShellPkg is updated and reviewed( message:92383 ( https://edk2.groups.io/g/devel/message/92383 ) ). Please help to review this patch and include in edk2-stable202208 tag. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92388):