[edk2-devel] [edk2-platforms][PATCH V1 11/16] Platform/Loongson: Add RealTime Clock lib.

2022-09-08 Thread xianglai
This library provides interfaces such as real-time clock initialization to get time and setting time. Signed-off-by: xianglai li --- .../LsRealTimeClockLib/LsRealTimeClock.h | 41 +++ .../LsRealTimeClockLib/LsRealTimeClockLib.c | 343 ++

[edk2-devel] [edk2-platforms][PATCH V1 01/16] Platform/Loongson: Add Serial Port library

2022-09-08 Thread xianglai
Serial Port library for LoongarchQemuPkg Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/Cpu.h| 344 ++ .../Include/LoongArchQemuPlatform.h | 103 +++ .../Library/SerialPortLib/SerialPortLib.c | 612 ++

[edk2-devel] [edk2-platforms][PATCH V1 08/16] Platform/Loongson: Add CPU DXE driver.

2022-09-08 Thread xianglai
The driver produces EFI_CPU_ARCH_PROTOCOL, Initialize the exception entry address. Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Drivers/CpuDxe/CpuDxe.c | 382 ++ .../LoongArchQemuPkg/Drivers/CpuDxe/CpuDxe.h | 153 +++ .../Drivers/CpuDxe/CpuDxe.inf |

[edk2-devel] [edk2-platforms][PATCH V1 02/16] Platform/Loongson: Support SEC And Add Readme.md

2022-09-08 Thread xianglai
Add SEC Code And Readme.md for LoongArchQemu Signed-off-by: xianglai li Signed-off-by: xianglai li --- Maintainers.txt | 4 + .../Include/LoongArchAsmMacro.h | 23 + .../Loongson/LoongArchQemuPkg/Loongson.dec| 38 ++

[edk2-devel] [edk2-platforms][PATCH V1 04/16] Platform/Loongson: Add QemuFwCfgLib.

2022-09-08 Thread xianglai
QemuFwCfgLib for PEI phase. This library obtains the QemuFWCfg base address by directly parsing the fdt, and reads and writes the data in the QemuFWCfg by operating on the QemuFWCfg base address. Signed-off-by: xianglai li --- .../Include/IndustryStandard/QemuFwCfg.h | 95

[edk2-devel] [edk2-platforms][PATCH V1 16/16] Platform/Loongson: Support for saving variables to flash.

2022-09-08 Thread xianglai
Added the function of saving non-volatile variables. Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Loongson.dec| 6 ++ Platform/Loongson/LoongArchQemuPkg/Loongson.dsc| 2 +- Platform/Loongson/LoongArchQemuPkg/Loongson.fdf| 14 ++

[edk2-devel] [edk2-platforms][PATCH V1 09/16] Platform/Loongson: Add PciCpuIoDxe driver.

2022-09-08 Thread xianglai
Add PCI CpuIo protocol.there is no fix translation offset between I/O port accesses and MMIO accesses. Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL to add the translation for IO access. Signed-off-by: xianglai li --- .../Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c | 548

[edk2-devel] [edk2-platforms][PATCH V1 00/16] Platform: Add Loongson support.

2022-09-08 Thread xianglai
The uploaded code generates firmware to support Linux launching on the LoongArch platform under qemu, So it will run in a virtual machine. LoongArch is the general processor architecture of Loongson. You can get the latest LoongArch documents or LoongArch tools at https://github.com/loongson/.

[edk2-devel] [edk2-platforms][PATCH V1 14/16] Platform/Loongson: Support Dxe

2022-09-08 Thread xianglai
Support Dxe for LoogArch. Signed-off-by: xianglai li --- .../Loongson/LoongArchQemuPkg/Loongson.dec| 14 +- .../Loongson/LoongArchQemuPkg/Loongson.dsc| 420 +- .../Loongson/LoongArchQemuPkg/Loongson.fdf| 243 ++ .../LoongArchQemuPkg/Loongson.fdf.inc

[edk2-devel] [edk2-platforms][PATCH V1 05/16] Platform/Loongson: Add MmuLib.

2022-09-08 Thread xianglai
Read the memory map information through the QemuFwCfg interface, then build the page table through the memory map information, and finally enable Mmu. Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/Cpu.h| 29 + .../LoongArchQemuPkg/Include/Library/MmuLib.h | 85 ++

[edk2-devel] [edk2-platforms][PATCH V1 15/16] Platform/Loongson: Add QemuFlashFvbServicesRuntimeDxe driver.

2022-09-08 Thread xianglai
This library provides flash read and write functionality and supports writing variables to flash. Signed-off-by: xianglai li --- .../QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 115 ++ .../FvbServicesRuntimeDxe.inf | 76 ++ .../FvbServicesSmm.inf| 70

[edk2-devel] [edk2-platforms][PATCH V1 07/16] Platform/Loongson: Support PEI phase.

2022-09-08 Thread xianglai
Platform PEI module for LoongArch platform initialization. Signed-off-by: xianglai li --- .../Loongson/LoongArchQemuPkg/Loongson.dec| 22 ++ .../Loongson/LoongArchQemuPkg/Loongson.dsc| 66 - .../Loongson/LoongArchQemuPkg/Loongson.fdf| 51

[edk2-devel] [edk2-platforms][PATCH V1 06/16] Platform/Loongson: Add StableTimerLib.

2022-09-08 Thread xianglai
This library provides a delay interface and a timing interface. Signed-off-by: xianglai li --- .../Include/Library/StableTimer.h | 42 +++ .../Library/StableTimerLib/Count.S| 26 ++ .../Library/StableTimerLib/TimerLib.c | 262 ++

[edk2-devel] [edk2-platforms][PATCH V1 10/16] Platform/Loongson: Add timer Dxe driver.

2022-09-08 Thread xianglai
This driver produces Timer Architectural Protocol, Registers a timer interrupt and initializes the timer. Signed-off-by: xianglai li --- .../Drivers/StableTimerDxe/Timer.c| 405 ++ .../Drivers/StableTimerDxe/Timer.h| 166 +++

[edk2-devel] [edk2-platforms][PATCH V1 03/16] Platform/Loongson: Add PeiServicesTablePointerLib.

2022-09-08 Thread xianglai
Use a register to save PeiServicesTable pointer, This lib Provides PeiServicesTable pointer saving and retrieval services. Signed-off-by: xianglai li --- .../PeiServicesTablePointer.c | 78 +++ .../PeiServicesTablePointerLib.inf| 32 2 files

[edk2-devel] [edk2-platforms][PATCH V1 13/16] Platform/Loongson: Add Reset System Lib.

2022-09-08 Thread xianglai
This library provides interfaces related to restart and shutdown. Signed-off-by: xianglai li --- .../BaseResetSystemAcpiGed.c | 155 ++ .../BaseResetSystemAcpiGedLib.inf | 42 +++ .../DxeResetSystemAcpiGed.c | 270 ++

[edk2-devel] [edk2-platforms][PATCH V1 12/16] Platform/Loongson: Add Platform Boot Manager Lib.

2022-09-08 Thread xianglai
The Library provides Boot Manager interfaces. Signed-off-by: xianglai li --- .../PlatformBootManagerLib/PlatformBm.c | 760 ++ .../PlatformBootManagerLib/PlatformBm.h | 112 +++ .../PlatformBootManagerLib.inf| 78 ++

[edk2-devel] GitHub PR code review, new EDK II Reviewers team, and the edk2-codereview repository

2022-09-08 Thread Michael D Kinney
Hello, I am exploring a proposal to use GitHub PR for code review. Specifically the last option listed in the following discussion: https://github.com/tianocore/edk2/discussions/3017 I am using the edk2-codereview repository to try different ideas out and to get feedback from the community

Re: [edk2-devel] [PATCH v3 0/8] Fix imbalanced debug macros

2022-09-08 Thread Michael Kubacki
Thanks Mike and reviewers - 3171 is merged On 9/8/2022 9:29 PM, Michael D Kinney wrote: Michael, You have all the reviews and commit messages are updated and you are a maintainer. So you are welcome to add push label. Thanks, Mike -Original Message- From: Michael Kubacki Sent:

Re: [edk2-devel] [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5

2022-09-08 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Michael Kubacki > Sent: Tuesday, September 6, 2022 8:27 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ard Biesheuvel > ; Abner Chang ; > Daniel Schaefer ; Sean Brogan > ; Barkelew, Bret > ; Kinney, Michael D > ; Gao,

Re: [edk2-devel] [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI

2022-09-08 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Tuesday, September 6, 2022 10:06 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Barkelew, Bret > ; Kinney, Michael D > ; Gao, Liming ; Wang, > Jian J > Subject: [PATCH v1 2/2]

Re: [edk2-devel] [PATCH v1 7/7] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI

2022-09-08 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Tuesday, September 6, 2022 8:19 PM > To: devel@edk2.groups.io > Cc: Barkelew, Bret ; Chiu, Chasel > ; Gao, Liming > ; Kinney, Michael D ; > Desimone, Nathaniel L > ;

Re: [edk2-devel] [PATCH v3 0/8] Fix imbalanced debug macros

2022-09-08 Thread Michael D Kinney
Michael, You have all the reviews and commit messages are updated and you are a maintainer. So you are welcome to add push label. Thanks, Mike > -Original Message- > From: Michael Kubacki > Sent: Thursday, September 8, 2022 6:03 PM > To: devel@edk2.groups.io; Kinney, Michael D >

Re: [edk2-devel] [edk2-platforms] [PATCH V3 0/6] KabylakeOpenBoardPkg: HDMI DDC I2C Bus Debugging

2022-09-08 Thread Nate DeSimone
The series has been pushed as 5f9e175~.. 4b2a5f4 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Thursday, September 8, 2022 6:07 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Oram, Isaac W ; Dong, Eric ; Gao, Liming ; Benjamin

[edk2-devel] [edk2-platforms] [PATCH V3 1/6] KabylakeOpenBoardPkg: Add HdmiDebugPchDetectionLib

2022-09-08 Thread Nate DeSimone
This library detects the type of PCH present on the system to the granualarity level needed to determine which GMBUS pins to use to access the HDMI DDC I2C bus. Cc: Chasel Chiu Cc: Sai Chaganty Cc: Isaac Oram Cc: Benjamin Doron Cc: Michael Kubacki Cc: Jeremy Soller Signed-off-by: Nate

[edk2-devel] [edk2-platforms] [PATCH V3 3/6] KabylakeOpenBoardPkg: Add HdmiDebugGpioInitLib

2022-09-08 Thread Nate DeSimone
This library initializes any GPIOs necessary for the HDMI DDC bus to operate. This can be called very early (SEC phase) to enable closed chassis debug through the HDMI DDC I2C bus. Cc: Chasel Chiu Cc: Sai Chaganty Cc: Isaac Oram Cc: Benjamin Doron Cc: Michael Kubacki Cc: Jeremy Soller

[edk2-devel] [edk2-platforms] [PATCH V3 5/6] MinPlatformPkg: Add PcdDefaultTerminalType support to SerialPortTerminalLib

2022-09-08 Thread Nate DeSimone
- Sets the terminal type GUID for ConIn, ConOut, and ConErr to the terminal type indicated by PcdDefaultTerminalType. - Some improvements to the comments in SerialPortTerminalLib Cc: Chasel Chiu Cc: Sai Chaganty Cc: Isaac Oram Cc: Eric Dong Cc: Liming Gao Cc: Benjamin Doron Cc: Michael

[edk2-devel] [edk2-platforms] [PATCH V3 2/6] KabylakeOpenBoardPkg: Add I2cHdmiDebugSerialPortLib

2022-09-08 Thread Nate DeSimone
Add new SerialPortLib implementation that routes log messages over the I2C bus included in the integrated graphics HDMI port. Normally this I2C bus is used to read the EDID data from the monitor. An unintended but useful property of this interface is that is does not require DMA to perform I/O.

[edk2-devel] [edk2-platforms] [PATCH V3 4/6] KabylakeOpenBoardPkg: Add SecBoardInitLib

2022-09-08 Thread Nate DeSimone
Adds a board-specific implementation of SecBoardInitLib. This implementation will invoke the GPIO initialization routine for the HDMI DDC Bus if the HDMI DDC Bus is being used for debug log output. Adds PCDs for enable/disable of using HDMI DDC I2C Bus as a Serial Port. Cc: Chasel Chiu Cc: Sai

[edk2-devel] [edk2-platforms] [PATCH V3 6/6] KabylakeOpenBoardPkg/GalagoPro3: Enable HDMI DDC Debug Port

2022-09-08 Thread Nate DeSimone
Enables usage of the HDMI DDC I2C Bus SerialPortLib implementation on the GalagoPro3 board. Cc: Chasel Chiu Cc: Sai Chaganty Cc: Isaac Oram Cc: Benjamin Doron Cc: Michael Kubacki Cc: Jeremy Soller Signed-off-by: Nate DeSimone --- .../GalagoPro3/OpenBoardPkg.dsc | 74

[edk2-devel] [edk2-platforms] [PATCH V3 0/6] KabylakeOpenBoardPkg: HDMI DDC I2C Bus Debugging

2022-09-08 Thread Nate DeSimone
Changes in V3: - Added new HdmiDebugPchDetectionLib to eliminate duplicated code between I2cHdmiDebugSerialPortLib and HdmiDebugGpioInitLib. - Removed duplicated register definitions - Removed commented out code - Removed TODOs Changes in V2: - Use SerialPortTerminalLib from

Re: [edk2-devel] [PATCH v3 0/8] Fix imbalanced debug macros

2022-09-08 Thread Michael Kubacki
The patch series has now received a R-b tag for each package. No content changes were requested in v3. I rebased the branch to edk2/master, added all v3 review tags, updated Nickle's email address, and pushed the changes to update the PR - https://github.com/tianocore/edk2/pull/3171. The PR

Re: [edk2-devel] [edk2-platforms] [PATCH V2 0/5] KabylakeOpenBoardPkg: HDMI DDC I2C Bus Debugging

2022-09-08 Thread Isaac Oram
For the series: Reviewed-by: Isaac Oram -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, September 6, 2022 11:28 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Oram, Isaac W ; Dong, Eric ; Gao, Liming ; Benjamin Doron ; Kubacki, Michael ; Soller,

Re: [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument

2022-09-08 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Thursday, September 8, 2022 9:28 AM > To: Ni, Ray ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous > debug

Re: [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument

2022-09-08 Thread Michael Kubacki
Still need this review. Patch has been on list for over a month and changes one line of code. On 9/6/2022 11:05 PM, Michael Kubacki wrote: Hello Ray, Can you please review this patch? FatPkg is the only package missing a review on the series. Thanks, Michael On 9/2/2022 6:22 PM, Michael

Re: [edk2-devel] ci problem

2022-09-08 Thread Ard Biesheuvel
On Thu, 8 Sept 2022 at 18:17, Michael D Kinney wrote: > > Hi Ard, > > I saw this message from Mergify for the first time yesterday in a different > sandbox. > > I will try closing the old PR and request Mergify to refresh the new one. > Ah right, I should have closed the old one - that makes

Re: [edk2-devel] ci problem

2022-09-08 Thread Michael D Kinney
Hi Ard, I saw this message from Mergify for the first time yesterday in a different sandbox. I will try closing the old PR and request Mergify to refresh the new one. Mike > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, September 8, 2022 9:14 AM > To: Kinney, Michael D

Re: [edk2-devel] ci problem

2022-09-08 Thread Ard Biesheuvel
On Thu, 8 Sept 2022 at 18:00, Kinney, Michael D wrote: > > If you look at timestamps, it shows that it failed to install cspell after 2 > hours. > > Can you resubmit and see if it happens again? > That gives me ⚠️ The sha of the head commit of this PR conflicts with #3315. Mergify cannot

Re: [edk2-devel] ci problem

2022-09-08 Thread Michael D Kinney
If you look at timestamps, it shows that it failed to install cspell after 2 hours. Can you resubmit and see if it happens again? Mike > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, September 8, 2022 8:53 AM > To: edk2-devel-groups-io ; Kinney, Michael D > ; Michael

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

2022-09-08 Thread Ard Biesheuvel
On Thu, 8 Sept 2022 at 17:39, Jeff Brasen wrote: > > > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, August 15, 2022 8:42 AM > > To: devel@edk2.groups.io; Jeff Brasen > > Cc: hao.a...@intel.com; ray...@intel.com; quic_llind...@quicinc.com; > >

[edk2-devel] ci problem

2022-09-08 Thread Ard Biesheuvel
Could someone please take a look at https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=61124=results and see what's going wrong? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93528):

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

2022-09-08 Thread Jeff Brasen via groups.io
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, August 15, 2022 8:42 AM > To: devel@edk2.groups.io; Jeff Brasen > Cc: hao.a...@intel.com; ray...@intel.com; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org > Subject: Re: [edk2-devel] [PATCH v2] >

[edk2-devel] [PATCH 1/1] Platform/ARM: Bump Dsdt/Ssdt ACPI table revision

2022-09-08 Thread PierreGondois
From: Pierre Gondois >From ACPI 5.1, s19.5.28 DefinitionBlock (Declare Definition Block): Note: For compatibility with ACPI versions before ACPI 2.0, the bit width of Integer objects is dependent on the ComplianceRevision of the DSDT. If the ComplianceRevision is less than 2, all

回复: 回复:[edk2-devel] [PATCH v1 00/34] Add a new architecture called LoongArch in EDK II

2022-09-08 Thread gaoliming via groups.io
Chao: This is a big feature for UEFI 2.10. Is there one feature request in https://bugzilla.tianocore.org/? Thanks Liming 发件人: lic...@loongson.cn 发送时间: 2022年9月8日 17:34 收件人: Chao Li ; devel 抄送: Ray Ni ; Liming Gao ; Michael D Kinney ; Guomin Jiang ; Wei6 Xu ; Maciej Rabeda ; Jiaxin

Re: [edk2-devel] [RFC PATCH 16/17] UefiCpuPkg/CpuDxe: Add RISC-V support in CpuDxe module

2022-09-08 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Sunil V L > Sent: Thursday, September 8, 2022 6:53 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; Jian J Wang ; Liming Gao > ; Eric Dong ; Ray Ni > ; Rahul Kumar ; Debkumar De > ; Catharine West ; > Daniel Schaefer ;

Re: [edk2-devel] [PATCH v3 0/3] Ovmf: Allow IPv4 and IPv6 to be disabled at runtime

2022-09-08 Thread Laszlo Ersek
On 09/07/22 07:46, Gerd Hoffmann wrote: > On Tue, Sep 06, 2022 at 01:59:23PM +0200, Ard Biesheuvel wrote: >> Add some generic plumbing and wire it up for the QEMU based Ovmf >> platform so that IPv4 and/or IPv6 networking can be turned off from the >> QEMU command line. >> >> This is a follow-up

Re: [edk2-devel] [RFC PATCH 16/17] UefiCpuPkg/CpuDxe: Add RISC-V support in CpuDxe module

2022-09-08 Thread Sunil V L
On Wed, Sep 07, 2022 at 12:46:59PM +, Chang, Abner wrote: > [AMD Official Use Only - General] > > > > > -Original Message- > > From: Sunil V L > > Sent: Wednesday, September 7, 2022 7:22 PM > > To: Chang, Abner > > Cc: devel@edk2.groups.io; Jian J Wang ; Liming Gao > > ; Eric Dong

回复:[edk2-devel] [PATCH v1 00/34] Add a new architecture called LoongArch in EDK II

2022-09-08 Thread Chao Li
Hi All,The LoongArch code repo is in GitHub, REF: https://github.com/loongson/edk2/tree/LoongArch, there is a PR, URL: https://github.com/loongson/edk2/pull/1. Thanks,Chao--原始邮件发件人: lichao收件人: devel抄送: Ray Ni,Liming Gao,Michael D

Re: [edk2-devel] [PATCH V3 09/12] OvmfPkg: Update ConstructFwHobList for lazy accept

2022-09-08 Thread Gerd Hoffmann
On Thu, Sep 08, 2022 at 12:48:05AM +, Xu, Min M wrote: > On September 7, 2022 1:42 PM, Gerd Hoffmann wrote: > > Hi, > > > > > + // > > > + // This memory region is split into 2 parts. The left part is > > > accepted. > > > + // > > > + PhysicalEnd=

Re: [edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode

2022-09-08 Thread Sami Mujawar
Hi Ard, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 07/09/2022, 16:28, "devel@edk2.groups.io on behalf of Ard Biesheuvel via groups.io" wrote: Don't allow spelling errors to break the CI build and inadvertently reject pull requests - spelling is

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for AHCI command retries

2022-09-08 Thread Wu, Hao A
Reviewed-by: Hao A Wu Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of Anbazhagan, Baraneedharan via groups.io Sent: Thursday, September 8, 2022 12:38 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Wu, Hao A ; Ni, Ray Subject: [edk2-devel] [PATCH v2] MdeModulePkg: Use

Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table

2022-09-08 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heng > Luo > Sent: Thursday, September 8, 2022 1:41 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Liu, Zhiguang ; Bi, > Dandan ; Zeng, Star ; Gao, > Zhichao > Subject: