[edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl

2022-09-11 Thread aryeh . chen
From: Aryeh Chen REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057 According to ASL Coding Guidelines - Device Identifiers "A Device should contain either an _ADR or a _HID object, never both." , so remove _ADR due to _HID exist. Signed-off-by: Aryeh Chen Cc: Chasel Chiu Cc: Nate

[edk2-devel] [PATCH v2] MinPlatformPkg: Remove _ADR from MinDsdt.asl

2022-09-11 Thread aryeh . chen
From: Aryeh Chen According to ASL Coding Guidelines - Device Identifiers "A Device should contain either an _ADR or a _HID object, never both." , so remove _ADR due to _HID exist. Signed-off-by: Aryeh Chen Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Ankit Sinha Cc: Liming Gao Cc:

[edk2-devel] [PATCH v1] MinPlatformPkg: Remove _ADR from MinDsdt.asl

2022-09-11 Thread aryeh . chen
From: Aryeh Chen According to ASL Coding Guidelines - Device Identifiers "A Device should contain either an _ADR or a _HID object, never both." , so remove _ADR due to _HID exist. Signed-off-by: Aryeh Chen Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Sinha, Ankit Cc: Liming Gao

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-11 Thread RichardHo [何明忠] via groups . io
Hi Abner, Ans #1. I think the USB network feature is better in the UsbNetworkPkg. It is easy to control USB network stack in this package. The package is same as NetworkPkg(The NetworkPkg gathers all network stack features). The UsbNetworkPkg could gather the USB network stack.

[edk2-devel] Event: Tools, CI, Code base construction meeting series - 09/12/2022 #cal-reminder

2022-09-11 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* 09/12/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1609020 ) *Description:* TianoCore

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and SgiPkg for ARM_CORE_INFO Mpidr change

2022-09-11 Thread Rebecca Cran
This is more correct than it previously was, but is still wrong for platforms where the cluster is in Aff2 and the core in Aff1. I haven’t checked which those are, but it’s at least the Neoverse N2. Rebecca On Sun, Sep 11, 2022, at 1:49 PM, Thomas Abraham wrote: > On 11/09/2022 20:15, Rebecca

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and SgiPkg for ARM_CORE_INFO Mpidr change

2022-09-11 Thread Thomas Abraham
On 11/09/2022 20:15, Rebecca Cran wrote: The ARM_CORE_INFO struct now has a single Mpidr field instead of separate ClusterId and CoreId fields. Update mCoreInfoTable in PlatformLib.c in Morello and SgiPkg to match. Signed-off-by: Rebecca Cran ---

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and SgiPkg for ARM_CORE_INFO Mpidr change

2022-09-11 Thread Rebecca Cran
The ARM_CORE_INFO struct now has a single Mpidr field instead of separate ClusterId and CoreId fields. Update mCoreInfoTable in PlatformLib.c in Morello and SgiPkg to match. Signed-off-by: Rebecca Cran --- Platform/ARM/Morello/Library/PlatformLib/PlatformLib.c | 8

Re: [edk2-devel][edk2-platforms][PATCH v2 4/6] S3FeaturePkg: Implement working S3 resume

2022-09-11 Thread Benjamin Doron
Hi Isaac, These SMM communication modules are S3 specific: - PiSmmCommunicationPei exits with EFI_UNSUPPORTED if BootMode != BOOT_ON_S3_RESUME ( https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c#L380-L383 ). - PiSmmCommunicationSmm installs an SMI

Re: [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include

2022-09-11 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Oram, Isaac W Sent: Saturday, September 10, 2022 6:52 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build:

Re: [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue

2022-09-11 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Oram, Isaac W Sent: Saturday, September 10, 2022 6:52 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing