Sivaparvathi:
Can you create edk2 pull request for this change? Then, I can get it from PR.
Thanks
Liming
发件人: sivaparvathic via groups.io
发送时间: 2022年9月12日 17:04
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity
scan
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 sivaparvathi
> C via groups.io
> 发送时间: 2022年8月2日 12:02
> 收件人: devel@edk2.groups.io; Sivaparvathi Chellaiah
>
> 抄送: Vasudevan Sambandan ; Sundaresan S
>
> 主题: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan
Few issues are submitted this week. Let’s cancel the meeting.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Group Notification
发送时间: 2022年9月13日 9:30
收件人: devel@edk2.groups.io
主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 09/13/2022
#cal-reminder
Reminder: TianoCore Bug
Ok, I will add them in the V2.
Thanks,
Chao
On 9月 13 2022, at 12:33 凌晨, "Kinney, Michael D"
wrote:
> Please add these links to the commit messages for each change.
>
> Thanks,
> Mike
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Chao Li
> > Sent:
Ok, I will change it in the V2.
Thanks,
Chao
On 9月 13 2022, at 12:32 凌晨, "Michael D Kinney"
wrote:
> Thanks! It looks like the link in the comment in the C file is out of date.
>
> Can you update patch to change
> ///
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Czajkowski, Maciej
> Sent: Saturday, September 10, 2022 2:11 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH v1] MdeModulePkg/AhciPei: Fix MMIO base assignment
>
> REF:
Add CONNECT HTTP command to create a tunnel from Proxy to EndPoint Server.
Add support to connect through proxy server using multi-URI DevicePath
sent to the Boot Manager.
Cc: Maciej Rabeda
Cc: Wu Jiaxin
Cc: Siyuan Fu
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Saloni Kasbekar
---
[AMD Official Use Only - General]
I am not the reviewer or maintainer of DynamicTablePkg, however this patch
looks good.
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sami
> Mujawar via groups.io
> Sent: Monday, September 12, 2022 10:19 PM
> To:
[AMD Official Use Only - General]
One question in below with tag [Abner],
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sami
> Mujawar via groups.io
> Sent: Monday, September 12, 2022 10:57 PM
> To: Girish Mahadevan ; devel@edk2.groups.io;
> Alexei Fedorov
> Cc: Samer
Merged via:
PR - https://github.com/tianocore/edk2/pull/3327
Commit -
https://github.com/tianocore/edk2/commit/db7afaee91423e988df3160624d04c3c534f294d
Best Regards,
Hao Wu
From: devel@edk2.groups.io On Behalf Of Wu, Hao A
Sent: Thursday, September 8, 2022 2:44 PM
To: devel@edk2.groups.io;
Hi,Mike:
Thank you for helping to review the code.
I feel sorry for the late reply, September 10 to September 12 is our
Mid-Autumn Festival holiday,
Happy Mid-Autumn Festival.
1.The list of s files in all patches is ：
./Library/MmuLib/Mmu.S This file is related to mmu
Reviewed-by: Bob Feng
-Original Message-
From: Kuo, Ted
Sent: Monday, August 29, 2022 5:28 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Hamel, Lee M
Subject: [edk2-devel][PATCH v1] BaseTools: 64bit FSP FV map file cannot be
created correctly
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
09/13/2022
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Series pushed as 1b02220269..9a7234827f
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Saturday, September 10, 2022 6:52 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Dong,
Eric
Subject:
Reviewed-by: Isaac Oram
-Original Message-
From: Benjamin Doron
Sent: Monday, September 12, 2022 10:13 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Sinha, Ankit ; Oram,
Isaac W ; Gao, Liming ; Dong,
Eric
Subject: [edk2-platforms][PATCH v3 3/4]
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
After EdkiiMemoryAcceptProtocol is implemented in TdxDxe driver, we can
call it to accept pages in DXE phase.
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Tom Lendacky
Acked-by: Gerd
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
Memory usage may exceed the amount accepted at the begining (SEC), TDVF
needs to accept memory dynamically when OUT_OF_RESOURCE occurs.
Another usage is in SetOrClearSharedBit. If a memory region is changed from
shared to
From: Jiaqi Gao
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
EdkiiMemoryAcceptProtocol is defined in MdePkg, the method AcceptMemory()
can be called when memory needs to be accepted.
EdkiiMemoryAcceptProtocol can be installed by architecture-specific
drivers such as TdxDxe. This
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
There are below major changes in PlatformInitLib/PlatformPei
1. ProcessHobList
The unaccepted memory is accepted if it is under 4G address.
Please be noted: in current stage, we only accept the memory under 4G.
We
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
ShellCommandRunMemMap() is updated to handle the case of unaccepted
memory type.
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Acked-by: Gerd
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
Unaccepted memory is a kind of new memory type,
CoreInitializeGcdServices() and CoreGetMemoryMap() are updated to handle
the unaccepted memory type.
Ref: microsoft/mu_basecore@97e9c31
Cc: Jian J Wang
Cc: Liming Gao
Cc:
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
Plase refer to:
UEFI Spec v2.9 Table 7-5 Memory Type Usage before ExitBootServices()
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc:
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED is defined in MdeModulePkg. The
files which use the definition are updated as well.
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Acked-by:
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory.
But this defitinion has not been officially in the PI spec. Base
on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at
From: Min M Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory.
But this defitinion has not been officially in the PI spec. Base
on the code-first we define BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED at
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937
UnacceptedMemory is one of the four defined types of TD memory in Intel
TDX guest. TDVF must invoke TDCALL [TDG.MEM.PAGE.ACCEPT] the unaccepted
memory before use it. See [TDVF] Section 7.1.
TDVF:
Reviewed-by: Isaac Oram
-Original Message-
From: Benjamin Doron
Sent: Monday, September 12, 2022 10:13 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Sinha, Ankit
; Chaganty, Rangasai V ;
Oram, Isaac W ; Gao, Liming
Subject: [edk2-platforms][PATCH v3 2/4] S3FeaturePkg:
Reviewed-by: Isaac Oram
-Original Message-
From: Benjamin Doron
Sent: Monday, September 12, 2022 10:13 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Sinha, Ankit
; Chiu, Chasel ; Soller, Jeremy
; Chaganty, Rangasai V ;
Oram, Isaac W
Subject: [edk2-platforms][PATCH v3 4/4]
Reviewed-by: Isaac Oram
-Original Message-
From: Benjamin Doron
Sent: Monday, September 12, 2022 10:13 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Oram, Isaac W
; Desimone, Nathaniel L
; Sinha, Ankit ; Chiu,
Chasel ; Gao, Liming ; Dong,
Eric
Subject:
*Tools, CI, Code base construction meeting series*
*When:*
09/12/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1609020 )
*Description:*
TianoCore community,
Reviewed-by: Sai Chaganty < rangasai.v.chaga...@intel.com >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93665): https://edk2.groups.io/g/devel/message/93665
Mute This Topic: https://groups.io/mt/93605308/21656
Group Owner:
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
09/12/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1609020 )
*Description:*
TianoCore
Hi Aryeh,
Can you please post the test results for this change. It would be good to note
that there is no change in behavior in the OS.
Thank you,
Ankit
> -Original Message-
> From: Chen, Aryeh
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ;
Hi Igor,
Section 6.1 of the ACPI specification describes this (Last line of the
paragraph below states what Aryeh was saying):
For any device that is on a non-enumerable type of bus (for example, an ISA
bus), OSPM enumerates the devices' identifier(s) and the ACPI system firmware
must supply
Consume S3 resume memory allocation on resume flow.
Also, include complementary FirmwarePerformanceDataTablePei module in
MinPlatform FV for S3 resume performance measurement.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Ankit Sinha
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by:
Use silicon code to detect S3 resume state. Apply some relevant policy
modifications.
PcdPeiMemSize must be in common scope, for a DXE module to allocate
required memory. Libraries that produce required PPIs are defined.
BootScriptExecutorDxe should only be linked against a functionally
Follow-up commits to MinPlatform (PeiFspWrapperHobProcessLib for
memory) and FSP-related board libraries (policy overrides)
required for successful S3 resume.
Factored allocation logic into new module to avoid MinPlatform
dependency on S3Feature package.
TODO: Can optimise required size.
Cc:
The LockBox is used for S3 resume in the follow-up patches, but might be
used to support other features too. So, the module is added to a
MinPlatform FV here.
Cc: Sai Chaganty
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Ankit Sinha
Cc: Chasel Chiu
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by:
MinPlatform is an open-source EDK2 firmware project that can boot some
mainstream boards. However, it lacked working support for S3 resume, an
important feature for mobile platforms, which means that its
applicability as-is to mainstream use is limited. Therefore, I have now
implemented working S3
Please add these links to the commit messages for each change.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chao Li
> Sent: Saturday, September 10, 2022 9:15 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Gao, Liming ; Liu, Zhiguang
>
>
Thanks! It looks like the link in the comment in the C file is out of date.
Can you update patch to change
/// http://www.ietf.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xml
to
/// https://www.iana.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xhtml
Thanks,
Mike
>
Hi All,
On 12/09/2022 03:18 pm, Sami Mujawar wrote:
The Section 6.1.3, SMBIOS specification version 3.6.0 describes the
handling of test strings in SMBIOS tables.
Test strings are added at the end of the formatted portion of the SMBIOS
[SAMI] Please read 'Test strings' as 'Text strings'. I
Hi Girish,
Thank you for this patch and for the effort for bringing forward dynamic
SMBIOS generation.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 26/08/2022 06:37 pm, Girish Mahadevan wrote:
Add a new CM object to describe memory devices and setup a new
Hi Girish,
Thank you for this patch.
I am having difficulty applying this patch locally. Is it possible to
share this patch series on a github branch as well, please? It will
greatly help me with the review. I normally include a link to my github
branch (after the --- line) when positng to
The Section 6.1.3, SMBIOS specification version 3.6.0 describes the
handling of test strings in SMBIOS tables.
Test strings are added at the end of the formatted portion of the SMBIOS
structure and are referenced by index in the SMBIOS structure.
Therefore, introduce a SmbiosStringTableLib to
Hello EDK2 Community,
Please review and comment on the EDK2 NetworkPkg PR:
https://github.com/tianocore/edk2/pull/3197
Patch of the PR is attached.
Firewalls are stopping the git-email capability, hence this email.
Thank you,
Zack
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
Reviewed-by: Gua Guo
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Tuesday, September 6, 2022 4:29 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; Dong, Guo ;
Ni, Ray ; Rhodes, Sean
Subject: [edk2-devel] [PATCH v2 16/17] UefiPayloadPkg: Remove
Hello Jeff,
Please find some remarks inline:
On 9/7/22 17:15, Jeff Brasen via groups.io wrote:
Add code to use a token attached to GICC to generate _CPC object on cpus.
Signed-off-by: Jeff Brasen
---
.../SsdtCpuTopologyGenerator.c| 211 +-
1 file
Hello Jeff,
Please find some remarks inline:
On 9/7/22 17:15, Jeff Brasen via groups.io wrote:
_CPC entries can describe CPU performance information.
The object is described in ACPI 6.4 s8.4.7.1.
"_CPC (Continuous Performance Control)".
Add AmlCreateCpcNode() helper function to add _CPC
Hello Jeff,
Please find some remarks inline:
On 9/7/22 17:15, Jeff Brasen via groups.io wrote:
Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects.
This allows to describe CPC information, as described in ACPI 6.4,
s8.4.7.1 "_CPC (Continuous Performance Control)".
Signed-off-by:
Hi gaolim...@byosoft.com.cn ,
Could you please review the changes?
Thanks,
Sivaparvathi C
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93645): https://edk2.groups.io/g/devel/message/93645
Mute This Topic:
Hi gaolim...@byosoft.com.cn ,
Could you please review the changes ?
Thanks,
Sivaparvathi C
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93644): https://edk2.groups.io/g/devel/message/93644
Mute This Topic:
Hi gaoliming,
When these changes will include in the EDK2 source? in next EDK2 release?
Thanks,
Sivaparvathi
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93643): https://edk2.groups.io/g/devel/message/93643
Mute This Topic:
On Mon, 12 Sep 2022 13:17:45 +0800
aryeh.c...@intel.com wrote:
> From: Aryeh Chen
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
>
> According to ASL Coding Guidelines - Device Identifiers
> "A Device should contain either an _ADR or a _HID object, never both."
> , so remove _ADR
[AMD Official Use Only - General]
Hi Richard, thanks for the reply. My feedback in line below,
> -Original Message-
> From: RichardHo [何明忠]
> Sent: Monday, September 12, 2022 11:48 AM
> To: Chang, Abner ; devel@edk2.groups.io;
> quic_rc...@quicinc.com
> Cc: Andrew Fish ; Leif Lindholm
>
55 matches
Mail list logo
