Reviewed-by: Jenny Huang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sheng, W
Sent: Monday, September 5, 2022 1:49 AM
To: devel@edk2.groups.io
Cc: Huang, Jenny ; Ni, Ray ; Chaganty,
Rangasai V ; Kowalewski, Robert
Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd:
[AMD Official Use Only - General]
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> via groups.io
> Sent: Wednesday, September 28, 2022 9:52 AM
> To: devel@edk2.groups.io
> Cc: Eric Dong ; Ray Ni ; Rahul
> Kumar
> Subject: [edk2-devel] [PATCH]
[AMD Official Use Only - General]
Not the maintainer or reviewer, however
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Li,
> Zhihao via groups.io
> Sent: Tuesday, September 27, 2022 8:58 PM
> To: devel@edk2.groups.io
> Cc: Eric Dong ; Ray Ni
Can you explain a bit more why this PCD is needed?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dionna Glaze
> via groups.io
> Sent: Wednesday, September 28, 2022 11:33 PM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Gerd Hoffmann ;
> James Bottomley
> ; Yao,
Hi Aryeh,
Thank you for testing.
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, September 21, 2022 12:34 AM
> To: Sinha, Ankit ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric
>
On 9/28/22 10:33, Dionna Glaze wrote:
From: Sophia Wolf
When a guest OS does not support unaccepted memory, the unaccepted
memory must be accepted before returning a memory map to the caller.
EfiMemoryAcceptProtocol is defined in MdePkg and is implemented /
Installed in AmdSevDxe for AMD
(cc some other maintainers)
On Wed, 28 Sept 2022 at 17:33, Dionna Glaze wrote:
>
> Add a simple protocol that enables the use of the unaccepted memory
> type. Must be called before ExitBootServices to be effective.
Calling protocols is generally not permitted after ExitBootServices()
anyway, so
Nate or Sai, this series should be a quick review if you could please
prioritize…
Benjamin,
Your series is reviewed but breaks several builds due to unrelated changes. My
plan is to get approval for mine, then submit both series as a batch to ensure
bisect not broken.
But I didn’t get a
On 2022-09-19 12:21, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The MdePkg must be self contained and not have external dependencies.
ArmReadIdIsar0() is defined in MdePkg/Library/BaseRngLib and is
limited to the scope of this library.
>
The same function will be required to check
Thank you Heng and all,
My responses:
1. Fixed.
2. Fixed, it was a missed change now added to the new patch.
3. Added CC.
Sending an updated patch file for reviewal.
Thanks,
Zack
-Original Message-
From: Luo, Heng
Sent: Tuesday, September 27, 2022 12:31 AM
To:
From: Zachary Clark-Williams
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845
Enables KVM and One Click Recovery WLAN capability with WiFi Profile
Sync feature and protocol. Adding WiFiProfileSyncProtocol, which
supports the profilesync driver operations for transferring WiFi profiles
On Wed, 28 Sept 2022 at 17:33, Dionna Glaze wrote:
>
> With the addition of the EfiUnacceptedMemory memory type, it is possible
> the EFI-enlightened guests do not themselves support the new memory
> type. This commit uses the new PcdEnableUnacceptedMemory to enable
> unaccepted memory support
On Wed, 28 Sept 2022 at 17:33, Dionna Glaze wrote:
>
> The default value of PcdEnableUnacceptedMemory should be FALSE in order
> for default safe behavior. If the next started image does not yet
> understand UEFI v2.9's new memory type, then it's stuck with most of its
> memory inaccessible.
>
>
On Wed, 28 Sept 2022 at 17:33, Dionna Glaze wrote:
>
> This Pcd is used to toggle whether ExitBootServices should not accept
> all unaccepted memory. It's the loaded image's responsibility to enable
> support so that it doesn't get memory types it doesn't understand in its
> memory map.
>
> Cc:
On Wed, 28 Sept 2022 at 17:33, Dionna Glaze via groups.io
wrote:
>
> From: Sophia Wolf
>
> When a guest OS does not support unaccepted memory, the unaccepted
> memory must be accepted before returning a memory map to the caller.
>
> EfiMemoryAcceptProtocol is defined in MdePkg and is implemented
Thanks, Isaac. Are these two S3 series ready to merge, or did I have more
review to address?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94475): https://edk2.groups.io/g/devel/message/94475
Mute This Topic:
Instead of eagerly accepting all memory in PEI, only accept memory under
the 4GB address. This allows a loaded image to use the
ENABLE_UNACCEPTED_MEMORY_PROTOCOL to indicate that it can interpret the
memory type accordingly.
This classification is safe since ExitBootServices will accept and
Add a simple protocol that enables the use of the unaccepted memory
type. Must be called before ExitBootServices to be effective.
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Ard Biesheuvel
Signed-off-by: Dionna Glaze
---
MdeModulePkg/Core/Dxe/DxeMain.h
With the addition of the EfiUnacceptedMemory memory type, it is possible
the EFI-enlightened guests do not themselves support the new memory
type. This commit uses the new PcdEnableUnacceptedMemory to enable
unaccepted memory support before ExitBootServices is called by not
accepting all
The default value of PcdEnableUnacceptedMemory should be FALSE in order
for default safe behavior. If the next started image does not yet
understand UEFI v2.9's new memory type, then it's stuck with most of its
memory inaccessible.
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom
This Pcd is used to toggle whether ExitBootServices should not accept
all unaccepted memory. It's the loaded image's responsibility to enable
support so that it doesn't get memory types it doesn't understand in its
memory map.
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom
These three patches build on the lazy-accept patch series
"Introduce Lazy-accept for Tdx guest"
by adding SEV-SNP support for the MemoryAccept protocol, and
importantly making eager memory acceptance the default behavior.
For unaccepted memory to be enabled, we must know that the booted image
From: Sophia Wolf
When a guest OS does not support unaccepted memory, the unaccepted
memory must be accepted before returning a memory map to the caller.
EfiMemoryAcceptProtocol is defined in MdePkg and is implemented /
Installed in AmdSevDxe for AMD SEV-SNP memory acceptance.
Cc: Gerd
[AMD Official Use Only - General]
I just had created PR to update edkII C coding standard spec for the file and
directory naming. We can review and confirm this update first and then go back
to the principles of EDK2 module reconstruction for archs.
Here is the PR:
From: Abner Chang
Add file and directory naming guidelines for EDKII modules. Also
consider the processor architecture and vendor implementation.
This is the draft version to community for the wide discussion.
PR
https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2
Got stuck with a segfault on Ubuntu 20.04 running EmulatorX64 (./Host).
This patch worked for me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94465): https://edk2.groups.io/g/devel/message/94465
Mute This Topic:
Hi Ard,
Any luck getting this one merged?
Thanks,
--Samer
> -Original Message-
> From: Sunny Wang
> Sent: Friday, August 19, 2022 10:47 AM
> To: Dimitrije Pavlov ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Jiewen Yao
> ; Liming Gao ; Jeff
> Booher-Kaeding ; Samer El-Haj-Mahmoud
> ;
@Sean Brogan and @Kinney, Michael D
Thanks for comment in Patch V3.
It updated now. https://github.com/tianocore/edk2/pull/3349
Thanks,
Gua
-Original Message-
From: Guo, Gua
Sent: Tuesday, September 27, 2022 12:40 PM
To: devel@edk2.groups.io
Cc: Guo, Gua
Subject: [PATCH v4 0/3]
On Thu, 22 Sept 2022 at 07:55, Gerd Hoffmann wrote:
>
> Traditional q35 memory layout is 2.75 GB of low memory, leaving room
> for the pcie mmconfig at 0xb000 and the 32-bit pci mmio window at
> 0xc000. Because of that OVMF tags the memory range above
> 0xb000 as uncachable via mtrr.
On Wed, 21 Sept 2022 at 07:30, Gerd Hoffmann wrote:
>
>
>
> Gerd Hoffmann (2):
> OvmfPkg/QemuBootOrderLib: allow slash in rom filenames
> OvmfPkg/QemuBootOrderLib: skip over unsupported entries in
> StoreQemuBootOrder
>
Reviewed-by: Ard Biesheuvel
Merged as #3425
(cc Jiewen and Jian)
On Wed, 28 Sept 2022 at 09:49, Yuan Yu wrote:
>
> SECSPERDAY is 86400 which exceeds the limit of a UINT16 which is 65536.
> Therefore DayRemainder cannot use UINT16. This patch makes it UINT32.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Anthony
SECSPERDAY is 86400 which exceeds the limit of a UINT16 which is 65536.
Therefore DayRemainder cannot use UINT16. This patch makes it UINT32.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Anthony Perard
Cc: Julien Grall
Signed-off-by: Yuan Yu
---
Some value uses UINT16 which is not wide enough to hold the values that
it is supposed to hold. This series fix it by using UINT32.
The changes can be seen at:
https://github.com/yyu/edk2/tree/overflow_fix_v1
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Anthony Perard
Cc: Julien
On Wed, Sep 28, 2022 at 03:33:45AM +, Ni, Ray wrote:
Hi Ray,
>
> 1. When a new arch's implementation is introduced to the existing module
> which was developed for the specific arch:
>
> 1. The folder reconstruction:
>
> * Create arch folder for the existing arch implementation
>
The stamp used to be generated is assumed 30day/month. Now adding a
new function which calculates time stamp with the correct days.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Wenyi Xie
---
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 71 +---
1 file changed, 63
Main Changes :
1.Adding a new function to calculate time stamp.
Wenyi Xie (1):
NetworkPkg/Dhcp6Dxe:Generate real time stamp
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 71 +---
1 file changed, 63 insertions(+), 8 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
36 matches
Mail list logo
