Hi Jiewen,
Yes it is, based on latest commit 3c9e2f239a38590b4e3a8c1ec2304227f2af0103.
I applied them to EDKII master branch successfully, not sure why.
Attachments are the successful patch files for reference, But they are same as
the patches in the mail.
Let me know if there are still
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Saturday, October 8, 2022 2:34 PM
> To: Li, Zhihao ; devel@edk2.groups.io
> Cc: Dong, Eric
> Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter
> when BSP Exit in
Hi Yi
Is this patch based on latest EDKII?
I failed to apply the patch 2/3.
The 1/3 and 3/3 are good.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Monday, October 10, 2022 10:47 AM
> To: Li, Yi1 ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu,
Sorry for confusing. This function is to format DataTimeStr to a DataTime
object through DataTime buffer.
So will change the function name to X509FormatDateTime() and modify this
comment to "Format DataTimeStr to a DataTime object in DataTime buffer".
Thanks!
-Original Message-
From:
Can OS call AcceptMemory protocol for those ranges that are not accepted?
> -Original Message-
> From: Xu, Min M
> Sent: Monday, October 10, 2022 11:08 AM
> To: devel@edk2.groups.io; Dionna Amalie Glaze ;
> Gao, Liming
> Cc: Gao, Zhichao ; Ni, Ray ;
> Aktas, Erdem ; 'Gerd Hoffmann'
> ;
On October 10, 2022 10:28 AM, Gao Liming wrote:
>
> Min:
> I have no comments for new unaccepted resource type and unaccepted gcd
> type. In fact, they are mapping to UEFI EfiUnacceptedMemoryType.
>
> For new protocol EfiMemoryAcceptProtocol, I see another patch serial
>
Acked-by: Michael D Kinney
Mike
> -Original Message-
> From: Li, Yi1
> Sent: Sunday, October 9, 2022 7:40 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Yao, Jiewen ; Kinney,
> Michael D ; Gao,
> Liming
> Subject: [PATCH V3 1/3] MdePkg: Add Tls configuration related define
>
>
Sivaparvathi C,
There is also a recently approved RFC to use CodeQL.
https://edk2.groups.io/g/devel/topic/93881031#94669
Michael Kubacki is leading the effort to phase in the checks supported by
CodeQL.
We would expect some overlap across different static analysis tools.
I recommend you
Thanks for the update.
For all patches, reviewed-by: Jiewen Yao
I think we need MdePkg owner to give R-B or A-B for TLS definition in MdePkg.
Mike or Liming?
Thank you
Yao Jiewen
> -Original Message-
> From: Li, Yi1
> Sent: Monday, October 10, 2022 10:40 AM
> To:
Hi Jiewen and Heng,
Thanks for review, I have corrected the comments and cipher suites name.
Thanks,
Yi
-Original Message-
From: Luo, Heng
Sent: Monday, October 10, 2022 9:37 AM
To: devel@edk2.groups.io; Yao, Jiewen ; Li, Yi1
Cc: Kinney, Michael D ; Gao, Liming
Subject: RE:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892
The implementation provides new Tls library functions
for Crypto EFI Driver and Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Driver/Crypto.c | 155
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892
1. TlsSetSignatureAlgoList(): Configure the list of TLS signature algorithms
that should be used as part of the TLS session establishment.
This is needed for some WLAN Supplicant connection establishment flows
that allow only specific TLS
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3892
Consumed by TlsSetEcCurve and TlsSetSignatureAlgoList.
Cc: Jiewen Yao
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Yi Li
---
MdePkg/Include/IndustryStandard/Tls1.h | 112 +
1 file changed, 75
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892
Review PR: https://github.com/tianocore/edk2/pull/3400
This patch sequence is used to extend Tls library, which are wrapped
over OpenSSL. The implementation provides library functions for EFI
DXE dirver and Protocol.
All APIs passed unit
Min:
I have no comments for new unaccepted resource type and unaccepted gcd
type. In fact, they are mapping to UEFI EfiUnacceptedMemoryType.
For new protocol EfiMemoryAcceptProtocol, I see another patch serial
https://edk2.groups.io/g/devel/message/94763 base on it to introduce
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4009
Check if there is usable memory below 4 GiB before testing for
allocation without the EFI_PCI_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute.
Cc: G Edhaya Chandran
Cc: Jeff Booher-Kaeding
Cc: Samer El-Haj-Mahmoud
Cc: Sunny Wang
Signed-off-by:
The code change is good to me.
Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Gerd
> Hoffmann
> 发送时间: 2022年10月4日 22:27
> 收件人: devel@edk2.groups.io
> 抄送: Pawel Polawski ; Liming Gao
> ; Jian J Wang ; Eric
> Dong ; Ray Ni ; Oliver Steffen
> ; Gerd Hoffmann
Reviewed-by: Ray Ni
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94857): https://edk2.groups.io/g/devel/message/94857
Mute This Topic: https://groups.io/mt/94178622/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Jiading:
Please check why NV variable data is required to be changed in PEI phase.
This will be helpful for this issue.
Thanks
Liming
发件人: Jiading Zhang
发送时间: 2022年10月10日 8:35
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei:
Hi Yi,
Please double check and update the comments:
https://www.rfc-editor.org/rfc/rfc5288,
> #define TLS_DHE_RSA_WITH_AES_256_GCM_SHA384{0x00, 0x9F}
https://www.rfc-editor.org/rfc/rfc5289, section 3.2
> #define TLS_ECDHE_ECDSA_AES128_GCM_SHA256 {0xC0, 0x2B} ->
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
> 发送时间: 2022年10月6日 20:45
> 收件人: Dionna Glaze
> 抄送: devel@edk2.groups.io; Min M. Xu ; Gerd
> Hoffmann ; James Bottomley ;
> Tom Lendacky ; Jiewen Yao
> ; Erdem Aktas ; Liming
> Gao (Byosoft address) ;
UEFI spec describes that the event presents the last opportunity to use
firmware interfaces in the boot environment.
So, I agree that this event notification is placed before Disable Timer.
Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Dionna Glaze
>
Merged https://github.com/tianocore/edk2/pull/3456
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, September 28, 2022 5:20 PM
> To: Yuan Yu ; Yao, Jiewen ;
> Wang, Jian J
> Cc: devel@edk2.groups.io; Justen, Jordan L ;
> Laszlo Ersek ; Anthony Perard
> ; Julien Grall
>
Hi liming:
Yes, NV Variable Data is not changed in PEI phase in normal case. This issue
was found when we did a special coding, and when found variable in the
IndexTable, it found the variable before the last changed if didn't add the
following condition:
" if ((VariableHeader->State ==
Hi
I feel the function name X509SetDateTime() is very confusing. From the function
comment, it means: "Format a DateTime object into DataTime Buffer".
I also find the comment in X509GetValidity(), "x509SetDateTime to get a
DateTime object from a DateTimeStr"
It seems "DataTimeStr" is "
Hi
1) I cannot find the new cipher suite definition in rfc-5246
(https://www.rfc-editor.org/rfc/rfc5246).
Would you please update comment as well, to let it point to right document?
///
/// TLS Cipher Suite, refers to A.5 of rfc-2246, rfc-4346 and rfc-5246.
///
...
#define
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
10/10/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610034 )
*Description:*
TianoCore
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4060
Function CreateDeviceNode may return NULL point when NodeLength is
smaller than a device path header or there is not enough
memory to allocate. But after calling CreateDeviceNode, the
pointer is dereferenced without checking its value.
So
Main Changes :
1.Adding null point check before pointer is dereferenced.
Wenyi Xie (1):
MdePkg/UefiDevicePathLib:Add NULL point check
MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 240
1 file changed, 240 insertions(+)
--
2.20.1.windows.1
29 matches
Mail list logo
