[AMD Official Use Only - General]
Hi Ray and module maintainers,
I think this patch set should be no problem as we agreed with the guidance
added to edk2 coding standard for the module source file naming that support
different processor archs/vendors.
Patches are attached, please help to review
From: Abner Chang
Updates 4.2 Directory names and 4.3 file names for
the guidelines of module directory and file naming.
PR:
https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2/files
Signed-off-by: Abner Chang
Cc: Ray Ni
Cc: Michael D Kinney
Cc: Sunil V L
Cc: Abdul
From: Abner Chang
Insert 4.2 Directory names as the placeholder and update
markdown file names and content of follow up sections.
PR:
https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2/files
Signed-off-by: Abner Chang
Cc: Ray Ni
Cc: Michael D Kinney
Cc: Sunil V L
From: Abner Chang
Updates 4.2 Directory names and 4.3 file names for
the guidelines of module directory and file naming.
PR:
https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2/files
Signed-off-by: Abner Chang
Cc: Ray Ni
Cc: Michael D Kinney
Cc: Sunil V L
Cc: Abdul
From: Abner Chang
Insert 4.2 Directory names as the placeholder and update
markdown file names and content of follow up sections.
PR:
https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2/files
Signed-off-by: Abner Chang
Cc: Ray Ni
Cc: Michael D Kinney
Cc: Sunil V L
[AMD Official Use Only - General]
Thanks! I will send out the V3 for the update. Will work on the spec
publication with Mike.
Abner
From: Ni, Ray
Sent: Wednesday, October 19, 2022 11:34 AM
To: Chang, Abner ; devel@edk2.groups.io
Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II
BIOS should keep MADT ordering by big core first then small core
Cc: Ray Ni
Cc: Donald Kuo
Cc: Jiewen Yao
Cc: Rangasai V Chaganty
Cc: Chandana C Kumar
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 149
Oh I see!
Reviewed-by: Ray Ni
From: Chang, Abner
Sent: Tuesday, October 18, 2022 5:50 PM
To: Ni, Ray ; devel@edk2.groups.io
Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding
Standard: Updates 4.2 and 4.3 sections
[AMD Official Use Only - General]
Hi Ray,
][].*
The
On October 19, 2022 9:18 AM, Gao Liming wrote:
>
> Min:
> I understand that they are for the different purpose and usage. But, their
> protocol name are very similar.
Yes. They do look very similar.
> If there is no better protocol name, I will also be fine.
Dionna, what's your thought?
>
Hi Liming, Christine,
Please help review this patch.
This patch can unblock the CI test for the change of Makefile/GNUmakefile.
https://github.com/tianocore/edk2/pull/3436
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Sunday, October 16, 2022
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Sunday, October 16, 2022 8:11 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version
> from 0.1.29 to 0.1.39
>
Hello Mateusz,
Thanks for the patch, I think the patch itself is good.
Sorry for one question came up when looking into the patch, for the
implementation of AhciRecoverPortError()
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c#L737:
Status =
Hello Baraneedharan Anbazhagan,
Could you help to check if this patch can resolve the issue
https://bugzilla.tianocore.org/show_bug.cgi?id=4011 when switching back to:
"#define AHCI_COMMAND_RETRIES 5"?
This change can be accessed for integration at:
[AMD Official Use Only - General]
BTW Ray, you can see SmmCpuFeaturesLib is renamed to IntelSmmCpuFeaturesLib in
the 1/2 of SmmCpuFeatureLib rearchitecture patch. AMD will upstream its own
SmmCpuFeaturesLib named as AmdSmmCpuFeaturesLib later. The naming is follow the
above guidelines.
Abner
Min:
I understand that they are for the different purpose and usage. But, their
protocol name are very similar.
If there is no better protocol name, I will also be fine.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Min Xu
> 发送时间: 2022年10月18日 9:13
> 收件人:
Jessy:
Thanks for your confirmation. The change should be fine. Reviewed-by: Liming
Gao
Thanks
Liming
发件人: devel@edk2.groups.io 代表 JessyX Wu
发送时间: 2022年10月18日 9:36
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v3] remove GCC build warning
I had
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Bob Feng
> 发送时间: 2022年10月19日 8:55
> 收件人: devel@edk2.groups.io; Feng, Bob C ; Gao,
> Liming ; Chen, Christine
> 主题: Re: [edk2-devel] [PATCH 1/1] pip-requirement: Upgrade the
> edk2-basetools version from 0.1.29 to 0.1.39
>
Hi Liming, Christine,
Please review this patch.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Sunday, October 16, 2022 8:11 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: [edk2-devel] [PATCH 1/1]
PS: With "emulates" I mean that it uses RAM to store variables. This
naturally ends up getting cleared on a reboot, which is possibly what
you're seeing.
On Tue, Oct 18, 2022 at 10:16 PM Pedro Falcato
wrote:
> Hi,
>
> (cc devel)
> NVRAM has nothing to do with disks or EFI partitions.
> Are you
Hi,
(cc devel)
NVRAM has nothing to do with disks or EFI partitions.
Are you using OVMF? How are you using it? OVMF itself emulates variable
storage if you run it in the wrong way.
On Tue, Oct 18, 2022 at 4:00 PM wrote:
> Hi EDK2 community,
>
> I have a used case, where I am trying to change
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4016
AtaAtapiPassThru driver was reporting recovery status on failed command
packets which led to incorrect flows in upper layers and to SCT tests
fails. This commit will change the logic to report command status.
Cc: Hao A Wu
Cc: Ray Ni
Fix for a bug introduced during SATA recovery implementation
Failing SCT: https://bugzilla.tianocore.org/show_bug.cgi?id=4016
Failing password input: https://bugzilla.tianocore.org/show_bug.cgi?id=4011
The bug was due to recovery status aliasing with command status. This patch
should resolve
Hi Girish,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 04/10/2022 11:43 pm, Girish Mahadevan via groups.io wrote:
Hello Sami
Thank you so much for your review, I apologize for the late response.
My comment in line about the handle manager [GM].
Best Regards
Some SMBIOS structure/table fields have dependency on other SMBIOS
structures/tables. These dependencies are established using handles
pointing to the dependent tables.
A SMBIOS table handle can be obtained by either installing a SMBIOS
table or by allocating a handle, which requires complex
Some SMBIOS tables have dependencies on other SMBIOS tables. These
dependencies are established using handles pointing to the dependent
SMBIOS tables.
This requires the dependent SMBIOS table to be installed before the
parent SMBIOS table can be installed.
To facilitate dynamic SMBIOS table
SMBIOS Structure Types 0 through 127 (7Fh) are reserved
for and defined by the SMBIOS specification. Types 128
through 256 (80h to FFh) are available for system and
OEM-specific information.
Therefore, define a new type 'SMBIOS_TABLE_TYPE' that
represents a SMBIOS structure type and include it in
[AMD Official Use Only - General]
Just fixed they all. Will send out the next version. Thanks Sunil.
Abner
> -Original Message-
> From: Sunil V L
> Sent: Tuesday, October 18, 2022 9:34 PM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; Ray Ni ; Michael D Kinney
> ; Attar, AbdulLateef
Please review this changes and provide comments.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95337): https://edk2.groups.io/g/devel/message/95337
Mute This Topic: https://groups.io/mt/92779099/21656
Group Owner:
Hi Abner,
Just few minor comments below. Otherwise,
Acked-by: Sunil V L
On Sat, Oct 15, 2022 at 07:47:57PM +0800, abner.ch...@amd.com wrote:
> From: Abner Chang
>
> Updates 4.2 Directory names and 4.3 file names for
> the guidelines of module directory and file naming.
>
> PR:
>
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The EFI_RNG_PROTOCOL published by RngDxe has been updated to
implement the EFI_RNG_ALGORITHM_RAW using the Arm FW-TRNG
interface to provide access to entropy.
Therefore, enable EFI_RNG_PROTOCOL for the
From: Pierre Gondois
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
Add RngDxe support for Arm. This implementation uses the TrngLib
to support the RawAlgorithm and doens't support the RNDR instruction.
To re-use the RngGetRNG(), RngGetInfo() and FreeAvailableAlgorithms()
From: Pierre Gondois
To re-use the AArch64/RngDxe.c for an Arm implementation,
rename AArch64/RngDxe.c to ArmRngDxe.c.
Acked-by: Leif Lindholm
Signed-off-by: Pierre Gondois
---
.../RngDxe/{AArch64/RngDxe.c => ArmRngDxe.c}| 0
From: Pierre Gondois
PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm
used by the RNDR CPU instruction to generate a random number.
Add a debug warning if the Pcd is not set.
Signed-off-by: Pierre Gondois
---
.../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
RawAlgorithm is used to provide access to entropy that is suitable
for cryptographic applications. Therefore, add RawAlgorithm support
that provides access to entropy using the TrngLib.
Also remove unused
From: Pierre Gondois
RngGetBytes() relies on the RngLib. The RngLib might use the RNDR
instruction if the FEAT_RNG feature is present. RngGetInfo and
RngGetRNG both must check that RngGetBytes() is working before
advertising/using it.
To do so, allocate an array storing the available
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
Rename RdRandGenerateEntropy() to GenerateEntropy() to provide a
common interface to generate entropy on other architectures.
GenerateEntropy() is intended to generate high quality entropy.
Also move the
From: Pierre Gondois
This patch:
-Update RngGetBytes() documentation to align the function
definition and declaration.
-Improve input parameter checking. Even though 'This'
it is not used, the parameter should always point to the
current EFI_RNG_PROTOCOL.
-Removes TimerLib inclusion as
From: Pierre Gondois
RngGetInfo() is one of the 2 functions of the EFI_RNG_PROTOCOL.
RngGetInfo() is currently a mere wrapper around
ArchGetSupportedRngAlgorithms() which is implemented differently
depending on the architecture used.
RngGetInfo() does nothing more than calling
From: Pierre Gondois
gEfiRngAlgorithmSp80090Ctr256Guid was used as the default algorithm
in RngGetRNG(). The commit below set the default algorithm to
PcdCpuRngSupportedAlgorithm, which is a zero GUID by default.
As the Pcd value is not defined for any platform in the edk2-platfoms
repository,
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0,
Platform Design Document
(https://developer.arm.com/documentation/den0098/latest/)
defines an interface between an Operating System (OS)
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The NIST Special Publications 800-90A, 800-90B and 800-90C
provide recommendations for random number generation. The
NIST 800-90C, Recommendation for Random Bit Generator (RBG)
Constructions, defines the
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0,
Platform Design Document
(https://developer.arm.com/documentation/den0098/latest/)
defines an interface between an Operating System (OS)
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The True Random Number Generator (TRNG) library defines an
interface to access the entropy source on a platform. On
platforms that do not have access to an entropy source, a
NULL instance of the TRNG library
From: Pierre Gondois
Add a Null instance of ArmHvcLib in case of library dependencies.
Reviewed-by: Leif Lindholm
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.dsc | 1 +
ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.c | 29 +++
From: Pierre Gondois
Sort the section containing HVC/SMC libraries prior to
adding new libraries in this specific section.
Reviewed-by: Leif Lindholm
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPkg/ArmPkg.dsc
From: Pierre Gondois
The ArmMonitorLib provides an abstract interface to issue
an HyperVisor Call (HVC) or System Monitor Call (SMC) depending
on the default conduit.
The PcdMonitorConduitHvc PCD allows to select the default conduit.
Reviewed-by: Leif Lindholm
Signed-off-by: Pierre Gondois
From: Pierre Gondois
The ArmMonitorLib provides an abstract interface to issue
an HyperVisor Call (HVC) or System Monitor Call (SMC) depending
on the default conduit.
The PcdMonitorConduitHvc PCD allows to select the default conduit.
The new library relies on the ArmHvcLib and ArmSmcLib
From: Pierre Gondois
Bugzilla: Bug 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0, specification
defines an interface between an Operating System (OS) executing at EL1 and
Firmware (FW) exposing a conditioned entropy
From: Sami Mujawar
Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for
monitor calls. PcdMonitorConduitHvc is defined as FALSE by default,
meaning the SMC conduit is enabled as default.
Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used
by virtual firmware
[AMD Official Use Only - General]
Hi Ray,
][].*
The simple naming rule was already defined in the 4.3.1 to 4.3.4
sections. We are not intending for defining the file naming style. This section
is mainly for the format of attaching and to the filename.
For example, how do we add AMD to
Hi Yoshinoya,
Could you provide some details about the platform on which you are trying to
run?
What tools you used for building the Python interpreter?
If you could raise a bug with relevant details, we can take a look at this
issue.
Regards,
JP
From: Yoshinoya
Sent: 11 October 2022 15:51
Hi Ard Biesheuvel :
We have researched a bit, the flash implementation of loongson may be
a bit unreasonable,
the corresponding flash implementation of loongson in qemu has not been
submitted to the community,
its final solution has not been determined,
we want to wait for the solution
For replace function, when target Ffs and new ffs are with
same size, the output file can not be generated successfully.
This patch fixes this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/FMMT/core/BiosTree.py | 4 ++--
edk2basetools/FMMT/core/FvHandler.py
Reviewed-by: Robert Kowalewski
-Original Message-
From: Sheng, W
Sent: Tuesday, October 18, 2022 8:43 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; Huang, Jenny ;
Kowalewski, Robert
Subject: [PATCH] IntelSiliconPkg/VTd: Refine VTd core driver
Refine the DRHD
Refine the DRHD table print message.
Remove unused variable.
Hsd-es-id: 15012152545
Signed-off-by: Sheng Wei
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Jenny Huang
Cc: Robert Kowalewski
---
.../Feature/VTd/IntelVTdDmarPei/IntelVTdDmar.c| 3 +--
All look good to me. Thanks for addressing my comments regarding simplifying
the rules.
Except for one minor comment: I still don't think we need to define rules for
source file names (4.3.5.4 EDK II source files within a Library/Module
instance).
And the rule "[][].*" doesn't specify what
56 matches
Mail list logo
