Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs

2022-10-23 Thread Yao, Jiewen
Sounds great! > -Original Message- > From: Kinney, Michael D > Sent: Monday, October 24, 2022 1:44 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin ; > Zurcher, Christopher ; Rebecca Cran > ; Ard Biesheuvel ; Li, Yi1 > >

[edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND

2022-10-23 Thread Ard Biesheuvel
Commit ("2355f0c09c52 BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile") fixed a latent issue in the BaseTools/Tests Makefile, but inadvertently broke the BaseTools build for cases where PYTHON_COMMAND is not set. As it turns out, running 'command' without a command argument makes th

Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs

2022-10-23 Thread Michael D Kinney
Hi Jiewen, I compared the builds of the CryptoPei, CryptoDxe, CryptoSmm using the same OpensslLib instance with EC disabled. I used an IA32 build of the MIN_PEI profile and an X64 build of the MIN_DXE_MIN_SMM profile for the comparison. Arch Profile DriverOldOld-LZMANew

Re: [edk2-devel] [PATCH v3] remove GCC build warning

2022-10-23 Thread Bob Feng
Reviewed-by: Bob Feng Thanks, Bob -Original Message- From: Wu, JessyX Sent: Tuesday, October 4, 2022 10:04 AM To: devel@edk2.groups.io Cc: Wu, JessyX ; Feng, Bob C ; Gao, Liming ; Chen, Christine Subject: [PATCH v3] remove GCC build warning Fix gcc: warning: -x c after last input f

[edk2-devel] [PATCH] IntelFsp2Pkg: FSP should support input UPD as NULL.

2022-10-23 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4114 FSP specification supports input UPD as NULL cases which FSP will use built-in UPD region instead. FSP should not return INVALID_PARAMETER in such cases. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/FspSecC

Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs

2022-10-23 Thread Yao, Jiewen
Sorry: I mean old configuration without ECC. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Monday, October 24, 2022 11:53 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin ; > Zurcher, Christopher

Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs

2022-10-23 Thread Yao, Jiewen
Thanks Mike The update looks good to me. Reviewed-by: Jiewen Yao Do you have any data of size difference before and after? Please share with us. I am more interested in the old configuration with ECC. Thank you Yao, Jiewen > -Original Message- > From: Kinney, Michael D > Sent: Friday,

[edk2-devel] Event: Tools, CI, Code base construction meeting series - 10/24/2022 #cal-reminder

2022-10-23 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* 10/24/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610036 ) *Description:* TianoCore communit