Re: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types support in FitGen.c

Hi Pavamana, I found there are few patch format issues. Please use edk2\BaseTools\Scripts\PatchCheck.py to check the patch and fix them. After that, I’ll merge it. Thanks, Bob From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Friday, October 28, 2022 9:11 AM To:

[edk2-devel] [Patch V2] UefiCpuPkg: Restore HpetTimer after CpuExceptionHandlerLib test

Disable/Restore HpetTimer before and after running the Dxe CpuExceptionHandlerLib unit test module. During the UnitTest, a new Idt is initialized for the test. There is no handler for timer intrrupt in this new idt. After the test module, HpetTimer does not work any more since the comparator value

[edk2-devel] [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4126 Common functions will have either 32bit or 64bit instances which having different return code size. Function header should support both scenarios. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu ---

Re: [edk2-devel] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Update proper device name for ScsiDisk drive

Thanks. Reviewed-by: Hao A Wu Will wait a couple of days before merging to see if comments from other reviewers. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Cheripally > Gopi via groups.io > Sent: Thursday, October 27, 2022 3:07 PM > To:

回复: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types support in FitGen.c

Michael: Thanks for your sharing. Pavamana: FIT spec 1.4 has been published. So, this change can be merged now. Thanks Liming 发件人: Holland, Michael 发送时间: 2022年10月28日 1:41 收件人: Gao, Liming ; Hv, Pavamana ; devel@edk2.groups.io; Chaganty, Rangasai V ; Lohr, Paul A ; Feng, Bob C

Re: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types support in FitGen.c

Hi Liming, Please see published FIT spec 1.4: https://edc.intel.com/content/www/us/en/design/products-and-solutions/software-and-services/firmware-and-bios/firmware-interface-table/ Thanks, Michael From: gaoliming Sent: Wednesday, October 26, 2022 07:59 PM To: Hv, Pavamana ; Holland, Michael

[edk2-devel] [PATCH v4 1/1] MdePkg: Use ANSI colors to indicate debug message severity

There currently isn't a way to differentiate the different levels of DEBUG output: DEBUG_ERROR, DEBUG_WARN, DEBUG_INFO etc. To improve this, wrap DEBUG_ERROR and DEBUG_WARN level messages in ANSI color code escape sequences. DEBUG_ERROR messages will be displayed in red text, and DEBUG_WARN in

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Remove AP support from PrePi/PrePeiCore

On Thu, 27 Oct 2022 at 19:31, Rebecca Cran wrote: > > Modern platforms use TF-A, so there's no need for support of > secondary cores in EDK2 since TF-A will keep them in a holding > pen until the PSCI_CPU_ON SMC call is received. > > Therefore, remove the code that handles secondary CPUs from >

[edk2-devel] [PATCH 1/1] ArmPlatformPkg: Remove AP support from PrePi/PrePeiCore

Modern platforms use TF-A, so there's no need for support of secondary cores in EDK2 since TF-A will keep them in a holding pen until the PSCI_CPU_ON SMC call is received. Therefore, remove the code that handles secondary CPUs from PrePeiCore and PrePi and add ASSERTs if a secondary core reaches

Re: [edk2-devel] [PATCH edk2-platforms] Platform/SbsaQemu: Switch to VirtNorFlashDxe

On Thu, 27 Oct 2022 at 12:48, Leif Lindholm wrote: > > On Wed, Oct 26, 2022 at 19:42:10 +0200, Ard Biesheuvel wrote: > > Switch to the OVMF version of the NOR flash DXE driver, which supports > > QEMU's NOR flash emulation specifically, and carries some optimizations > > that are therefore

Re: [edk2-devel] [PATCH 00/11] ArmVirtPkg: introduce VirtNorFlashDxe

On Thu, 27 Oct 2022 at 06:47, Sunil V L wrote: > > On Mon, Oct 24, 2022 at 07:01:11PM +0200, Ard Biesheuvel wrote: > > Create a new driver VirtNorFlashDxe that targets QEMU and KvmTool's NOR > > flash emulation specifically, and retire the ArmPlatformPkg one. > > > > This permits new virt

[edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Abner Chang --- book.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book.json b/book.json index d112b26..1fdd570 100644 --- a/book.json +++ b/book.json @@ -1,8 +1,7 @@ { "variables" : { -

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi app name

Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Thursday, October 27, 2022 2:53 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Kinney, Michael D > ; Jayaprakash, N > > Subject: [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi >

Re: [edk2-devel] [PATCH edk2-platforms 2/2] Maintainers.txt: update email address for Graeme Gregory

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > Sent: Thursday, October 27, 2022 4:05 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Graeme Gregory ; > Graeme Gregory ; Kinney, > Michael D ; Ard Biesheuvel > > Subject:

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Maintainers.txt: fix incorrect line ending

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > Sent: Thursday, October 27, 2022 4:05 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ni, Ray ; Kinney, > Michael D > Subject: [edk2-devel] [PATCH edk2-platforms 1/2]

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Fix the missing hyperlink

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Thursday, October 27, 2022 5:12 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Kinney, Michael D > Subject: [edk2-devel] [PATCH] edk II C Coding Standard:

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

> > btw it still fails in CoreTerminateMemoryMap() with the current upstream > kernel which is not aware of the lazy memory acceptance, is this > something known? Thanks, > It wasn't known. I'll take a look. Thanks for the report. -- -Dionna Glaze, PhD (she/her) -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

Hi Nickle, Pleased, see my comments on your questions below. Another point I missed in my previous mail. You have that function in the library to get credentials and it is used by RedfishCredentialsDxe driver to create the protocol which in its turn will be used by other Redfish modules. We do

[edk2-devel] [PATCH 1/2] MdePkg/IndustryStandard: add definitions for ACPI APMT

This adds #defines and struct typedefs for the various node types in the ACPI Arm Performance Monitoring Unit (APMT) table. Signed-off-by: Jeff Brasen --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 ++ .../ArmPerformanceMonitoringUnitTable.h | 69 +++ 2

[edk2-devel] [PATCH 2/2] ShellPkg/AcpiView: APMT Parser

Add a new parser for the Arm Performance Monitoring Unit Table. The APMT table describes the properties of PMU support implemented by components in an Arm-based system. Signed-off-by: Jeff Brasen --- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 21 .../Parsers/Apmt/ApmtParser.c

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

Hi Igor, Thank you for your help to review my changes. > And it will be blocked by our IPMI call. I see your point. So, BIOS should never be the person to shutdown credential service because BIOS always get executed prior to OS, right? > Should it be configured with some PCD? Maybe user may

[edk2-devel] [PATCH] edk II C Coding Standard: Fix the missing hyperlink

From: Abner Chang Correct the hyperlink of section 4.2 Directory Names in SUMMARY.md. Signed-off-by: Abner Chang Cc: Ray Ni Cc: Michael D Kinney --- SUMMARY.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SUMMARY.md b/SUMMARY.md index 32a575d..9be642c 100644 ---

Re: [edk2-devel] [PATCH edk2-platforms 2/2] Maintainers.txt: update email address for Graeme Gregory

On Thu, 27 Oct 2022 at 13:05, Leif Lindholm wrote: > > From: Leif Lindholm > > Signed-off-by: Leif Lindholm > Cc: Graeme Gregory > Cc: Graeme Gregory > Cc: Michael D Kinney > Cc: Ard Biesheuvel Acked-by: Ard Biesheuvel > --- > Maintainers.txt | 2 +- > 1 file changed, 1 insertion(+), 1

[edk2-devel] [PATCH edk2-platforms 2/2] Maintainers.txt: update email address for Graeme Gregory

From: Leif Lindholm Signed-off-by: Leif Lindholm Cc: Graeme Gregory Cc: Graeme Gregory Cc: Michael D Kinney Cc: Ard Biesheuvel --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 1a5b6828a867..bbf9c00c 100644

[edk2-devel] [PATCH edk2-platforms 1/2] Maintainers.txt: fix incorrect line ending

From: Leif Lindholm Commit 005ab4a11e22a ("Maintainers.txt: Update reviewers for IntelSiliconPkg") introduced incorrect line ending on the added line. Tidy this up. Signed-off-by: Leif Lindholm Cc: Ray Ni Cc: Michael D Kinney --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2-devel] [PATCH edk2-platforms] Platform/SbsaQemu: Switch to VirtNorFlashDxe

On Wed, Oct 26, 2022 at 19:42:10 +0200, Ard Biesheuvel wrote: > Switch to the OVMF version of the NOR flash DXE driver, which supports > QEMU's NOR flash emulation specifically, and carries some optimizations > that are therefore permitted. > > Cc: Leif Lindholm > Cc: Graeme Gregory Graeme

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi app name

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4124 This patch contains the changes to remove the substring 368 from the name of the python uefi interpreter app. With the changes in this patch the python interpreter app name will be changed from python368.efi to python.efi. This change was

[edk2-devel] [edk2-libc Patch 0/1] edk2-libc - to remove substring 368 from python uefi app name

This patch request contains the necessary changes to remove the substring 368 from the name of the python uefi interpreter app. The app name will change from python368.efi to python.efi Jayaprakash Nevara (1): edk2-libc: remove substring 368 from py uefi app name

Re: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types support in FitGen.c

Hi Liming, The spec is in process of being published. @Chaganty, Rangasai V @Lohr, Paul A Any update on FIT spec being published? Thanks, Michael From: gaoliming Sent: Tuesday, October 25, 2022 09:18 PM To:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

Comment inline. > On 26. Oct 2022, at 15:35, Yao, Jiewen wrote: > > That is good catch. > > Reviewed-by: Jiewen Yao > > >> -Original Message- >> From: Kinney, Michael D >> Sent: Wednesday, October 26, 2022 12:23 AM >> To: Pedro Falcato ; devel@edk2.groups.io >> Cc: Vitaly Cheptsov

[edk2-devel] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Update proper device name for ScsiDisk drive

ScsiDiskDxe driver updates ControllerNameTable with common string "SCSI Disk Device" for all SCSI disks. Due to this, when multiple SCSI disk devices connected, facing difficulty in identifying correct SCSI disk device. As per SCSI spec, standard Inquiry Data is having the fields to know Vendor

Re: [edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk

created pull request. Pull request link: MdeModulePkg/ScsiDiskDxe: Update proper device name for ScsiDisk drives by GopiCheripally · Pull Request #3537 · tianocore/edk2 (github.com) ( https://github.com/tianocore/edk2/pull/3537 ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all