Reviewed-by: S, Ashraf Ali
Regards,
Ashraf Ali S
Intel Technology India Pvt. Ltd.
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 10, 2022 11:54 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; Oram, Isaac W ; S,
Ashraf Ali
Subject: [Patch
On Fri, 11 Nov 2022 at 03:41, Jason A. Donenfeld wrote:
>
> Hi Ard,
>
> On Thu, Nov 10, 2022 at 2:48 PM Ard Biesheuvel wrote:
> >
> > Currently, we only expose EFI_RNG_PROTOCOL when running under QEMU if it
> > exposes a virtio-rng device. This means that generic EFI apps or
> > loaders have no
On Fri, 11 Nov 2022 at 04:53, gaoliming via groups.io
wrote:
>
> It has been merged at c8fb7240469b5753773da4fa5710b870b790c363
>
> Thanks
> Liming
Thank you.
I'll merge the remaining ones after the stable tag has been created.
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 gaoliming
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib is renamed as CcExitLib. The related section in
Maintainers.txt should be updated as well.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
APIs which are defined in CcExitLib.h are added with the CcExit prefix.
This is to make the APIs' name more meaningful.
This change impacts OvmfPkg/UefiCpuPkg.
Cc: Eric Dong
Cc: Ray Ni
Cc: Brijesh Singh
Cc: Erdem Aktas
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib once was designed to provide interfaces to support #VC handler
and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is
introduced, this library is updated to support #VE as well. Now the name
of
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib once was designed to provide interfaces to support #VC handler
and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is
introduced, this library is updated to support #VE as well. Now the name
of VmgExitLib cannot
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib is renamed as CcExitLib. The related section in
Maintainers.txt should be updated as well.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
APIs which are defined in CcExitLib.h are added with the CcExit prefix.
This is to make the APIs' name more meaningful.
This change impacts OvmfPkg/UefiCpuPkg.
Cc: Eric Dong
Cc: Ray Ni
Cc: Brijesh Singh
Cc: Erdem Aktas
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib once was designed to provide interfaces to support #VC handler
and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is
introduced, this library is updated to support #VE as well. Now the name
of
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib once was designed to provide interfaces to support #VC handler
and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is
introduced, this library is updated to support #VE as well. Now the name
of VmgExitLib cannot
Thanks Liming!!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming via groups.io
> Sent: Thursday, November 10, 2022 8:52 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Kinney,
> Michael D
> Cc: Desimone, Nathaniel L ; Zeng, Star
> ; S, Ashraf Ali ; Duggapu,
>
This change has been merged at 3182843f3bc92599fa2ed4fd13ffd3f75907fe9e
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chiu, Chasel
> 发送时间: 2022年11月11日 9:57
> 收件人: Gao, Liming ; devel@edk2.groups.io;
> Kinney, Michael D
> 抄送: Desimone, Nathaniel L ; Zeng, Star
> ; S, Ashraf Ali ;
Thanks Liming.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96239): https://edk2.groups.io/g/devel/message/96239
Mute This Topic: https://groups.io/mt/94952173/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
It has been merged at c8fb7240469b5753773da4fa5710b870b790c363
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2022年11月11日 8:42
> 收件人: 'Ard Biesheuvel' ; devel@edk2.groups.io
> 抄送: 'Rebecca Cran' ; 'Pierre Gondois'
> ; 'Leif Lindholm' ;
> 'Sami
Sainadh:
It has been merged at c17c3c24d8c7dd2107bfcca86179d5375dceb42b
Thanks
Liming
发件人: devel@edk2.groups.io 代表 gaoliming via groups.io
发送时间: 2022年11月11日 8:47
收件人: 'Sainadh Nagolu' ; devel@edk2.groups.io
主题: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH]
*Reminder: TianoCore Community Meeting - APAC/NAMO*
*When:*
Thursday, November 10, 2022
7:30pm to 8:30pm
(UTC-08:00) America/Los Angeles
*Where:*
Mike:
Thanks for your quick fix. I just merge it.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Michael D
> Kinney
> 发送时间: 2022年11月11日 10:24
> 收件人: devel@edk2.groups.io; Kinney, Michael D
>
> 抄送: Sean Brogan ; Michael Kubacki
> ; Gao, Liming
> 主题: Re: [edk2-devel] [Patch V2
Hi Liming,
The PR for this change is: https://github.com/tianocore/edk2/pull/3626
It is still running, but it has installed Python 3.10.6, and has gotten past
earlier failure point.
If it passes, you can make decision to merge and then see if the other failing
PRs will now pass.
Best
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed-by: Michael Kubacki
---
.github/workflows/codeql-analysis.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/.github/workflows/codeql-analysis.yml
b/.github/workflows/codeql-analysis.yml
I will update PR and patch for 3.10.6+
Mike
From: Michael Kubacki
Sent: Thursday, November 10, 2022 6:00 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch edk2-stable202211 1/1] .github/workflows:
Update CodeQL to install Python 3.9
Reviewed-by: Michael Kubacki
Reviewed-by: Michael Kubacki
Suggest to align the Python version with that in
edk2/platform-build-run-steps.yml at master · tianocore/edk2 (github.com) (
https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/platform-build-run-steps.yml
) for consistency.
Thanks Liming!!
> -Original Message-
> From: gaoliming
> Sent: Thursday, November 10, 2022 5:37 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Kinney,
> Michael D
> Cc: Desimone, Nathaniel L ; Zeng, Star
> ; S, Ashraf Ali ; Duggapu,
> Chinni B ; Kuo, Ted
> Subject: 回复:
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
.github/workflows/codeql-analysis.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/.github/workflows/codeql-analysis.yml
b/.github/workflows/codeql-analysis.yml
index 2eacb9c9e1a1..c8d9943b2292
Hi Mike,
We have the Azure Pipeline on 3.10.6+ because of the following issue we
encountered starting in Python 3.9.11.
3891 – Tar files fail with Python 3.9.11+ (tianocore.org) (
https://bugzilla.tianocore.org/show_bug.cgi?id=3891 )
I think it would be nice to align the Python version here
here is a PR with proposed change to install Python 3.9
https://github.com/tianocore/edk2/pull/3626
Mike
From: Kinney, Michael D
Sent: Thursday, November 10, 2022 5:40 PM
To: devel@edk2.groups.io; Gao, Liming ;
michael.kuba...@outlook.com; Kinney, Michael D
Cc: Kubacki, Michael ; 'Michael
The CodeQL GitHub Action:
https://github.com/tianocore/edk2/blob/master/.github/workflows/codeql-analysis.yml
Uses Windows-2019 image:
https://github.com/actions/runner-images/blob/main/images/win/Windows2019-Readme.md
That image include Python 3.7.9.
The latest version of Pytools required
Due to hardware freeze, it needs to wait after hardware freeze.
Reviewed-by: Gua Guo mailto:gua@intel.com>>
From: devel@edk2.groups.io On Behalf Of Jiading Zhang
Sent: Friday, November 11, 2022 8:56 AM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Define default
I'm looking at it now.
Thanks,
Michael
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96223): https://edk2.groups.io/g/devel/message/96223
Mute This Topic: https://groups.io/mt/94950299/21656
Group Owner: devel+ow...@edk2.groups.io
Chasel:
Seemly, this is a bug fix for the previous change. In soft feature freeze,
the bug is still allowed. Since this patch has passed review, I can help merge
it.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chiu, Chasel
> 发送时间: 2022年11月11日 9:08
> 收件人:
Mike:
Since there is no big change in soft feature freeze phase, I agree to merge
it for this stable tag.
Thanks
Liming
> -邮件原件-
> 发件人: Kinney, Michael D
> 发送时间: 2022年11月11日 9:10
> 收件人: Gao, Liming ; Kinney, Michael D
> ; devel@edk2.groups.io
> 主题: FW: [edk2-devel] [Patch v3 0/7]
Michael:
Can you help check this failure in open CI? The failure is in
https://github.com/tianocore/edk2/pull/3611
Thanks
Liming
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96220): https://edk2.groups.io/g/devel/message/96220
Liming,
The review for adding GoogleTest support to the UnitTestFrameworkPkg was started
before Soft Freeze and only had some minor documentation updates during the
Soft Freeze.
I would like to request this PR be merged for the stable tag.
https://github.com/tianocore/edk2/pull/3595
It has
Sorry for missing this message.
Since this patch is important for unblocking platform FSP implementation, @Gao,
Liming, @Kinney, Michael D, could you please help to merge it to catch this
stable tag?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
>
The following PCDs have no value in UefiPayloadPkg.dsc，and they can not pass
the Ecc tool check, so assign the default values the same as they are in *.dec
file.
gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport
Mike:
This patch is merged at 342813a3f7794bf67405a236053f27c916804d36
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2022年11月11日 8:38
> 收件人: devel@edk2.groups.io; michael.d.kin...@intel.com
> 抄送: 'Sean Brogan' ; 'Michael Kubacki'
> ; 'Andrew
Chasel:
Please see the announce mail https://edk2.groups.io/g/devel/message/96175
Now, we are in soft feature freeze. If the patch wants to catch this
stable tag, please highlight it and get approval from Stewards.
Thanks
Liming
> -邮件原件-
> 发件人: Chiu, Chasel
> 发送时间: 2022年11月11日 8:47
I see the failure that the code can’t clone success. I re-run it and check
again.
Thanks
Liming
发件人: sainadhn via groups.io
发送时间: 2022年11月10日 15:36
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH]
ShellPkg:Improved
Hi Liming, Michael,
May I know why we cannot merge this PR
https://github.com/tianocore/edk2/pull/3624 ?
Was it due to Hard Feature Freeze? But I thought we still have time right?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo,
> Ted
> Sent:
Ard:
The first patch is the bug fix. I agree to merge it for this stable tag. I
will help merge it today.
Thanks
Liming
> -邮件原件-
> 发件人: Ard Biesheuvel
> 发送时间: 2022年11月10日 21:48
> 收件人: devel@edk2.groups.io
> 抄送: Ard Biesheuvel ; Liming Gao
> ; Rebecca Cran ; Pierre
> Gondois ; Leif
Reviewed-by: Liming Gao
I agree this change to be merged now.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Michael D
> Kinney
> 发送时间: 2022年11月11日 0:59
> 收件人: devel@edk2.groups.io; Kinney, Michael D
> ; Gao, Liming
> 抄送: Sean Brogan ; Michael Kubacki
> ; Gao, Liming ;
> Andrew
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kuo, Ted
Sent: Wednesday, November 9, 2022 3:31 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star ; S, Ashraf
Ali ; Duggapu, Chinni B
Subject: [edk2-devel][PATCH v1]
Hi Rebecca,
Here is an alternate way to implement this feature. Just an
experiment because it does not follow the recommended methods
to add a feature that can be enabled/disabled. I have tested
this on EmulatorPkg and OvmfPkg and it works as expected.
Does not require any updates to any
Hi Michael,
This is a good idea to use a label.
Can dependabot PRs be marked as "Draft" PRs? May be another way to prevent.
Also, can a comment to the PR be done from the dependabot action?
My experience with mergify is that less logic is easier to maintain.
Thanks,
Mike
> -Original
Hi Mike,
One thing that comes to mind, is I can have the PR from dependabot
automatically have a label added (e.g. "do-not-merge") and then update
the mergify configuration to prevent merging of PRs with that label.
I can also have a comment automatically added to the PR that explains it
is
Reviewed-by: Sai Chaganty
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 10, 2022 10:24 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; Oram, Isaac W ; S,
Ashraf Ali
Subject: [Patch edk2-platforms] IntelSiliconPkg/IntelVTdDxe: Fix CLANG detected
Hi Rebecca,
In the edk2 repo, I see the following instances of the DebugPrintMarker() API
where you are currently adding he ANSI color sequences. Should all of these
be updated? I did not review the edk2-platforms repo. And there may be
downstream custom DebugLib instances. It would better if
CreateSecondLevelPagingEntryTable() has a return type of
VTD_SECOND_LEVEL_PAGING_ENTRY * and an error condition
returns a value of NULL.
Change return value of EFI_SUCCESS (value 0) to NULL to
address CLANG compiler detection of incorrect return type.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc:
Yes, Mike. Good point.
We will send a new patch to highlight: 1) incompatibility change, 2) how to
upgrade.
Thanks for the suggestion.
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, November 11, 2022 12:39 AM
> To: Yao, Jiewen ; Xu, Min M
> ; devel@edk2.groups.io;
Hi Liming,
PR: https://github.com/tianocore/edk2/pull/3619
All EDK II CI checks passed.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Wednesday, November 9, 2022 10:30 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Michael Kubacki
Hi Dionna,
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
I think you are at step 13. If you have not done so already, please update the
commit messages with all the Reviewed-by and Acked-by tags and make sure your
branch is rebased against the latest
Hi Michael,
Thanks. This feature is really useful to help keep our dependencies up to date.
For the EDK II Development Process, the PRs produced by dependabot would only
be informative and would never be merged directly. How do we mark these PRs
so they are never merged directly with a "push"
> Reviewed-by: Michael D Kinney
Great, thanks Michael. With all three patches reviewed/acked, does
that mean they get merged, or what else has to be done? I'm new to
this.
--
-Dionna Glaze, PhD (she/her)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Hi Jiewen,
Changing the name of a library is a non-backwards compatible change from a
platform DSC
file perspective for downstream consumers.
Whenever any type of non-backwards compatible change is made, we need to
highlight
that in the commit messages and the Patch #0.
The rename is clearly
*TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, November 10, 2022
8:00am to 9:00am
(UTC-08:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join
on
*Reminder: TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, November 10, 2022
8:00am to 9:00am
(UTC-08:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams
Add After Ready To Boot Event Definitions
Cc: Michael D Kinney [mdkinney]
Cc: Liming Gao [lgao4]
Cc: Zhiguang Liu [LiuZhiguang001]
Signed-off-by: Robert Phelps
---
MdePkg/Include/Guid/EventGroup.h | 5 +
MdePkg/MdePkg.dec| 3 +++
2 files changed, 8 insertions(+)
diff
Hi Ard,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/11/2022, 13:48, "Ard Biesheuvel" wrote:
ArmTrngLib crashes when run in DEBUG mode due to the fact that it passed
the [truncated] GUID value to a DEBUG() print statement instead of a
pointer
When build in DEBUG, the code asserts that 5LPage support is there
when the physical address width is larger than 48.
In a RELEASE build it will just force LA57 to 1 in CR4
even if CPUID(7).ECX[16] says it is not supported.
The hang (in the ASSERT) in DEBUG is not warranted as there are
legal
Expose the EFI_RNG_PROTOCOL based on RdRand, so that we don't have to
rely on QEMU providing a virtio-rng device in order to implement this
protocol.
Signed-off-by: Ard Biesheuvel
---
OvmfPkg/OvmfPkgIa32.dsc| 1 +
OvmfPkg/OvmfPkgIa32.fdf| 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
Currently, we only expose the EFI_RNG_PROTOCOL in ArmVirtQemu if QEMU
provides a virtio-rng device, and it doesn't do so by default.
Given that KVM exposes the ARM architected TRNG service (and has done so
for a while now), let's incorporate the RngDxe driver which has recently
grown support for
ArmTrngLib crashes when run in DEBUG mode due to the fact that it passed
the [truncated] GUID value to a DEBUG() print statement instead of a
pointer to the GUID which is what the %g conversion expects.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 2 +-
1 file
Currently, we only expose EFI_RNG_PROTOCOL when running under QEMU if it
exposes a virtio-rng device. This means that generic EFI apps or
loaders have no access to an entropy source if this device is
unavailable, unless they implement their own arch-specific handling to
figure out whether any CPU
From: Michael Kubacki
Enables dependabot in this repo so we can better alerted when
dependency updates are available.
This GitHub action will automatically create pull requests and
summarize the dependency details. Because it is a pull request,
the CI system will validate the dependency update
Reviewed-by: Ray Ni
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96186): https://edk2.groups.io/g/devel/message/96186
Mute This Topic: https://groups.io/mt/94881760/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
65 matches
Mail list logo
