On 9/7/22 13:36, Sunil V L wrote:
Add build infrastructure files to boot qemu virt machine.
EDK2 will boot as S-mode payload of opensbi. There is no
integrated opensbi (M-mode firmware) within EDK2 for virt
machine.
It relies on the RISC-V calling convention that M-mode firmware like
opensbi
On 9/7/22 13:36, Sunil V L wrote:
This library implements the TimerLib.h functionality. This library
is similar to CpuTimerLib but needs the library constructor.
Signed-off-by: Sunil V L
---
MdePkg/Library/ArchTimerLib/ArchTimerLib.inf | 40 +++
On 9/7/22 13:36, Sunil V L wrote:
RISC-V UEFI platforms need to implement RISCV_EFI_BOOT_PROTOCOL.
Add header file with the definitions of this protocol.
Signed-off-by: Sunil V L
Reviewed-by: Heinrich Schuchardt
---
MdePkg/Include/Protocol/RiscVBootProtocol.h | 35
On 9/7/22 13:36, Sunil V L wrote:
This library is required to make SBI ecalls from the S-mode EDK2.
Signed-off-by: Sunil V L
---
MdePkg/Library/RiscVSbiLib/RiscVSbiLib.inf | 27 +++
MdePkg/Include/Library/RiscVSbiLib.h | 129 +++
MdePkg/Library/RiscVSbiLib/RiscVSbiLib.c
On 9/7/22 13:36, Sunil V L wrote:
EDK2 in S-mode needs to use SSCRATCH register. Implement functions
to set/get the SSCRATCH register.
Signed-off-by: Sunil V L
---
MdePkg/Library/BaseLib/BaseLib.inf | 1 +
MdePkg/Include/Library/BaseLib.h| 10 ++
On 9/7/22 13:36, Sunil V L wrote:
RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL.
Add this protocol GUID definition.
Signed-off-by: Sunil V L
Reviewed-by: Heinrich Schuchardt
---
MdePkg/MdePkg.dec | 6 ++
1 file changed, 6 insertions(+)
diff --git
According to the Intel GHCI specification document section 2.4.1, the
goal for instructions that do not have a corresponding TDCALL is for the
handler to treat the instruction as a NOP.
INVD does not have a corresponding TDCALL. This patch makes the #VE
handler treat INVD as a NOP.
Apart from the comment given to 4/5, I am afraid those extern variables in C
file is not obey the section 5.4.2.1 extern in CCS.
Regards,
Abner
Abner
On Tue, Dec 6, 2022 at 09:23 PM, Abdul Lateef Attar wrote:
>
> ---
> .../AmdSmmCpuFeaturesLib.inf | 1 +
>
Hi Abdul,
This is a little bit confusing because there is one SmramSaveStae.c under
PismmCpuDxeSmm however another one is under SmmCpuFeaturesLib for AMD.
I would suggest we introduce SmramSaveState library under UefiCpuPkg/Library
which is used by both PismmCpuDxeSmm and SmmCpuFeaturesLib. This
On Thu, Dec 08, 2022 at 02:43:56AM +0100, Heinrich Schuchardt wrote:
>
>
> On 9/7/22 13:36, Sunil V L wrote:
> > EDK2 in S-mode needs to use SSCRATCH register. Implement functions
> > to set/get the SSCRATCH register.
> >
> > Signed-off-by: Sunil V L
> > ---
> >
On Thu, Dec 08, 2022 at 12:30:04AM +, Ni, Ray wrote:
> Sunil,
> Is there any source code sharing between Risc-V and IA32X64?
> From the patch, I cannot see any.
> If that's the case, I would prefer we don't mix the two separate
> implementations together into one component.
> Can you please
What tool do you use to write the pages?
It seems to be a mixture of markdown and HTML: for example I'm surprised
to see things like "C Compiler" - I'd expect something
like "**C Compiler**" instead.
--
Rebecca Cran
On 12/7/22 09:24, Michael Kubacki wrote:
From: Michael Kubacki
Adds a
Thanks.
For the patch:
Reviewed-by: Hao A Wu
Will merge the patch early next week.
For the open with regard to:
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c#L737
I think returning EFI_DEVICE_ERROR when something goes wrong in AhciResetPort()
Hi Abdul,
Because SmmCpuFeatureLib is expected to only be used by X86 vendors, we can
just have SmmCpuFeaturesLib under the root of module directory and rename it to
AmdSmmCpuFeaturesLib.c
Thanks
Abner
On Tue, Dec 6, 2022 at 09:23 PM, Abdul Lateef Attar wrote:
>
> From: Abdul Lateef Attar
>
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 +
Reviewed-by: Hao A Wu
Will wait a couple of days before merging to see if comments from other
reviewers.
Best Regards,
Hao Wu
> -Original Message-
> From: Chevron Li
> Sent: Wednesday, December 7, 2022 7:09 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Wang,
> Jian J ;
Pushed via:
PR - https://github.com/tianocore/edk2/pull/3733
Commit -
https://github.com/tianocore/edk2/commit/d9e7f6fe49738421c02381425d289767d7055ef1
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Wednesday, December 7, 2022
Hi Dun,
Sean Brogan and I have some feedback we'll send soon after we sync on
it. If anything is still open as of the upcoming TianoCore tools & CI
meeting and you're able to attend, we can talk there as well.
Thanks,
Michael
On 12/5/2022 11:46 PM, duntan wrote:
Hi Michael,
Thanks for the
Sunil,
Is there any source code sharing between Risc-V and IA32X64?
>From the patch, I cannot see any.
If that's the case, I would prefer we don't mix the two separate
implementations together into one component.
Can you please create a new CpuExceptionHandlerLib instance for Risc-V instead
of
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
> Sent: Wednesday, December 7, 2022 10:01 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Gao, Liming ;
> Wang, Jian J ; Ard
> Biesheuvel
> Subject: [edk2-devel] [PATCH]
On Wed, 7 Dec 2022 at 19:54, Kinney, Michael D
wrote:
>
> Hi Ard,
>
> Thank you. This is a really good find. How did you find it?
>
The 32-bit version of ArmVirtQemu got inadvertently broken by a change
that seemed unrelated, but resulted in the primary memory resource
descriptor hob to end
On Wed, Dec 07, 2022 at 11:22:10AM -0500, James Bottomley wrote:
> On Wed, 2022-12-07 at 17:04 +0100, Ard Biesheuvel wrote:
> > On Wed, 7 Dec 2022 at 17:02, Gerd Hoffmann wrote:
> > >
> > > On Wed, Dec 07, 2022 at 09:14:39AM -0500, James Bottomley wrote:
> > > > On Wed, 2022-12-07 at 15:09
Hi Ard,
Thank you. This is a really good find. How did you find it?
I am guessing this case may not have been noticed on IA32/X64 because
those archs tend to have FLASH device mapped just below 4GB and as a
result there is no system memory in the range just below 4GB. This
means the case
The page allocator code in CoreFindFreePagesI() uses a mask derived from
its UINTN Alignment argument to align the descriptor end address of a
MEMORY_MAP entry to the requested alignment, in order to check whether
the descriptor covers enough sufficiently aligned area to satisfy the
request.
From: "Chevron Li (WH)"
SD1.0 cards don't support CMD8 and CMD6
CMD8 result can be used to distinguish the card is SD1.0 or not.
CMD8 result can be used to decide following CMD6 is sent or skip.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Chevron Li
---
From: "Chevron Li (WH)"
SD1.0 cards don't support CMD8 and CMD6
CMD8 result can be used to distinguish the card is SD1.0 or not.
CMD8 result can be used to decide following CMD6 is sent or skip.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Chevron Li
---
Changes in
Hello,
Really sorry for missing the mails. Seems like my mail was misconfigured and I
didn't get the messages(had to check the group site).
"I cannot remember why EFI_SUCCESS is eventually returned for the above error
case. Could you help to remind me of the details? Thanks."
To answer this -
From: Michael Kubacki
Adds a reference to existing documents in the wiki with build
instructions to point to the new top-level build file.
The original files are left in place for information reference and
to prevent breaking links that may be pointing to them.
Cc: Sean Brogan
Cc: Michael D
From: Michael Kubacki
Adds a file that describes various build approaches in edk2 at a
high-level and points to the documents with specific instructions
for each approach.
This is a starting point for this file and it will likely be
expanded upon in the future.
Cc: Sean Brogan
Cc: Michael D
From: Chris Fernald
Covers:
- Container background
- Docker background and installation
- Local development with containers
- How to manually configure a container
- Integration with VS Code
- Containers in pipelines
Cc: Sean Brogan
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Michael Kubacki
From: Michael Kubacki
Adds a new document that comprehensively describes how to manually
set up a build environment using Stuart.
Covers the following topics:
1. Pre-requisites - Git, Python, compilers, SDKs, etc.
2. Initial steps - Cloning the repo, set up Python virtual env, etc.
3. Stuart
From: Michael Kubacki
This series adds a new set of build instructions and updates prior
instructions to point to the new version.
Some patches in this series are not being sent properly. Visit the
GitHub branch to see the changes:
On Tue, Dec 6, 2022 at 09:23 PM, Abdul Lateef Attar wrote:
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
>
> Adds an SMM SMRAM save-state map for AMD processors.
> SMRAM save state maps for the AMD processor family are now supported.
>
> Save state map structure is added based on
The Shell locates device path protocol instances from the database and
happily passes them to destructive device path operations, resulting in
the original protocol to get corrupted as well. So take a copy instead,
and discard it once we no longer need it.
Signed-off-by: Ard Biesheuvel
---
On Wed, 7 Dec 2022 at 17:02, Gerd Hoffmann wrote:
>
> On Wed, Dec 07, 2022 at 09:14:39AM -0500, James Bottomley wrote:
> > On Wed, 2022-12-07 at 15:09 +0100, Ard Biesheuvel wrote:
> > > So at some point, these drivers will be removed rather than kept
> > > alive by the core team unless someone
On Wed, Dec 07, 2022 at 09:14:39AM -0500, James Bottomley wrote:
> On Wed, 2022-12-07 at 15:09 +0100, Ard Biesheuvel wrote:
> > So at some point, these drivers will be removed rather than kept
> > alive by the core team unless someone steps up.
>
> How important is keeping them alive?
Most
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, December 6, 2022 9:23 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Kirkendall, Garrett
> ; Grimes, Paul ; Eric
> Dong
Bios feature driver utilizes RedfishAddendumLib and get additional data
before sending BIOS attributes to Redfish service.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../Features/Bios/v1_0_9/Common/BiosCommon.c | 100 ++
Implement RedfishAddendumLib to support Redfish Resource Addendum Protocol.
Feature driver calls this library to get addendum data before providing
data to Redfish service.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
Introduce Redfish Resource Addendum Protocol to Redfish feature driver.
Feature driver uses this protocol to query OEM resource from platform in
order to support Redfish OEM property. This protocol is also used to get
addendum data that is required by BMC to manage Redfish BIOS service.
Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish feature driver.
Feature driver uses this protocol to query OEM resource from platform in
order to support Redfish OEM property. This protocol is also used to get
addendum data that is required by BMC to manage Redfish BIOS service.
On Wed, 2022-12-07 at 15:09 +0100, Ard Biesheuvel wrote:
> So at some point, these drivers will be removed rather than kept
> alive by the core team unless someone steps up.
How important is keeping them alive? I can volunteer to "maintain"
them which I anticipate won't be much effort (plus I'm
Add two new iterfaces to Redfish Platform Config Library in order to
support GetAttribute() and GetDefaultValue() interfaces.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../Library/RedfishPlatformConfigLib.h| 44
Add two new iterfaces to Redfish Platform Config Protocol.
GetAttribute() return attribute details and GetDefaultValue() get default
value of attribute. These two interfaces are used to generate BIOS
Attribute Registry
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick
On Wed, 7 Dec 2022 at 08:41, Gerd Hoffmann wrote:
>
> Hi,
>
> > A patch mentioned above set MPT_SCSI_ENABLE=FALSE, that removed
> > support for LSI 53C1030 and SAS1068.
> > These SCSI controllers were emulated by VMware, Parallels and I guess
> > VitualBox.
> > This is generic setup for VMware
Implement GetQuestionDefault() in HiiUtilityLib. Caller can get question
default value from this interface. GetQuestionDefault() is created and
modifed from SetupBrowserDxe\Setup.c under MdeModulePkg.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
Introduce two new iterfaces to Redfish Platform Config Protocol:
- GetAttribute() returns attribute details from HII question.
- GetDefaultValue() returns default value of attribute.
They are used to generate BIOS attribute registry.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor
Hello Jeff,
I think the patch is not for the DynamicTablesPkg but for the
MdeModulePkg. FWIW, the patch looks good to me,
Regards,
Pierre
On 11/16/22 16:50, Jeff Brasen via groups.io wrote:
Skip error check if HardwareInstance is 0 as this either means that
FmpVersion < 3 and not supported or,
Hello Vivek,
I just have one minor comment,
On 2/14/22 13:13, Vivek Kumar Gautam via groups.io wrote:
From: Shriram K
The IO virtualization block on reference design platforms allow
connecting non-discoverable devices such as PL011 UART. On platforms
that support this, initialize the UART
Hello Vivek,
Sorry for the long wait. I think the whole patchset needs to be
rebased on latest master. I just have some comments for patches:
- [PATCH V1 2/6] Platform/Sgi: add ssdt table for non-discoverable IO
virtualization block
- [PATCH V1 3/6] Platform/Sgi: Initialize additional uart
Hi Gaoliming,
I have updated the commit message title with the package name.
Commit Message Title : ShellPkg: Displaying SMBIOS Type38 fields in formatted
manner
Kindly let us know if we need to make any changes.
Thanks,
Prakash K
From: gaoliming
Sent: Wednesday, December 7, 2022 8:07 AM
On 7/12/22 13:13, gaoliming wrote:
Alexey:
-邮件原件-
发件人: devel@edk2.groups.io 代表 Alexey
Kardashevskiy via groups.io
发送时间: 2022年12月1日 10:35
收件人: devel@edk2.groups.io
抄送: Ard Biesheuvel ; Jiewen Yao
; Jordan Justen ; Gerd
Hoffmann ; Brijesh Singh ;
Erdem Aktas ; James Bottomley
; Min
Apologies, I accidentally sent the message before I finished. The remaining
part of my reply is as below.
I think having the asserts in ProcessLibraryConstructorList() creates more
problem. It is very hard to debug issues if the serial port initialisation
fails.
Regards,
Sami Mujawar
Hi Ard,
On Sat, Nov 26, 2022 at 06:34 AM, Ard Biesheuvel wrote:
>
> The remaining code still looks a bit clunky to me. Can't we just
> return an error from the library constructor of the library cannot
> initialize due to a missing prerequisite?
The problem with returning an error code from a
Yes, the patch looks fine.
Reviewed-by: Zhiguang Liu
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, December 7, 2022 4:08 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Liu, Zhiguang ; Andrew Fish
> Subject: RE: [edk2-devel] [PATCH] EmulatorPkg/Win: Unload DLLs before
> reset
>
Zhiguang, can you please help to review this patch? I guess Andrew is busy on
something.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Monday, December 5, 2022 2:59 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Andrew Fish
> Subject: [edk2-devel]
57 matches
Mail list logo
