Re: [edk2-devel] [PATCH 0/4] Put APs in 64 bit long-mode before booting to OS.

2022-12-19 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yuanhao Xie > Sent: Tuesday, December 20, 2022 5:40 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/4] Put APs in 64 bit long-mode before booting > to OS. > > > Yuanhao Xie (4): > UefiC

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei

2022-12-19 Thread Gerd Hoffmann
On Mon, Dec 19, 2022 at 04:36:20PM +, Anthony PERARD via groups.io wrote: > From: Anthony PERARD > > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. > > QemuFwCfgLib expect this HOB to be present, or fails to do anything. > InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiL

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: add security warning

2022-12-19 Thread Gerd Hoffmann
Hi, > > Well, the OS can write directly to flash, bypassing the firmware. It > > can update secure boot efi variables without the firmware enforcing the > > usual restrictions (KEK signature being required for db/dbx updates > > etc). > > [Jiewen] I would say: It is the typical use case. But n

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-19 Thread joeyli via groups.io
Hi Jiewen, Sorry for I didn't create tiano CI on github in time. And thanks for your help to merge my patch. I will create tiano CI in next time after getting our Review-by tag. Thanks! Joey Lee On Sat, Dec 17, 2022 at 03:17:42AM +, Yao, Jiewen via groups.io wrote: > Thanks for the fix. >

Re: [edk2-devel] [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

2022-12-19 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Tuesday, December 20, 2022 2:42 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use ca

Re: [edk2-devel] [PATCH V3 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: abner.ch...@amd.com Sent: Tuesday, December 20, 2022 2:41 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V3 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification External

[edk2-devel] [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

2022-12-19 Thread Chang, Abner via groups.io
From: Abner Chang Add NULL function RedfishPlatformHostInterfaceNotification that returns EFI_UNSUPPORTED. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../RedfishPlatformHostInterfaceLib.c | 24 +++ 1 file changed, 24

[edk2-devel] [PATCH V3 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Chang, Abner via groups.io
From: Abner Chang For some use cases, Redfish host interface table relies on the certain EFI protocols installation at the driver connection. Redfish host interface DXE driver is not able to build the SMBIOS type 42h record at driver entry point. This patch adds the mechanism in Redfish host inte

Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Nickle Wang via groups.io
Hi Abner, I found another bug as below. + if (Status == EFI_UNSUPPORTED || EFI_ALREADY_STARTED) { +Status = RedfishCreateSmbiosTable42 (); Second condition check miss "Status ==" and RedfishCreateSmbiosTable42() is always called in driver entry. Thanks, Nickle -Original Message

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-19 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/3797 with minor format fix. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Saturday, December 17, 2022 11:18 AM > To: Lee, Chun-Yi ; devel@edk2.groups.io > Cc: Xu, Min M ; Gerd Hoffmann > ; Tom Lendacky ;

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs

2022-12-19 Thread Guo, Gua
@jdzh...@kunluntech.com.cn It’s checked in by below PR. UefiPayloadPkg: Define default values for the DynamicEX PCDs by gguo11837463 · Pull Request #3798 · tianocore/edk2 (github.com) Thanks, Gua From: Guo, Gua Sent:

Re: [edk2-devel] [PATCH v3 01/14] PrmPkg: Fix new typos reported

2022-12-19 Thread Ankit Sinha
Hi Michael, There is a typo that got missed in one of the modified comments. In file "b/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h": - Each PRM Module discovered is placed into a linked list so the list can br processsed in the future. + Each PRM Module discovered is placed into a linked

Re: [edk2-devel] [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

2022-12-19 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Ah ok, that would be good. Thanks Abner > -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 20, 2022 11:03 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray > ; Kirkendall, Garrett > Subject: RE: [PATCH

Re: [edk2-devel] [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

2022-12-19 Thread Wu, Hao A
Thanks, For this patch "MdeModulePkg/XhciPei: Unlinked XhciPei memory block", my take is that there will also be an updated version, right? If this is the case, could you help to send out a single 3-patch series for them instead of sending 3 separated patches? Thanks in advance. Best Regards, H

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions

2022-12-19 Thread Yao, Jiewen
Hi Mike You are right. I missed that part. Hi Judah Would you please file another patch to update DSC file, to make it align with readme? Thank you Yao, Jiewen > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, December 20, 2022 9:55 AM > To: devel@edk2.groups.io; Yao, Jie

Re: [edk2-devel] [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

2022-12-19 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Hao, That is the uncrustify check error. I already fixed it at "[PATCH V3] MdeModulePkg/Usb: Read a large number of blocks." Also, these three patches are passed the CI test. https://github.com/tianocore/edk2/pull/3794 Thanks Abner > -Original Message--

[edk2-devel] [PATCH V3] MdeModulePkg/Usb: Read a large number of blocks

2022-12-19 Thread Chang, Abner via groups.io
From: Abner Chang In V3: Address Uncrustify check errors. In V2: Add AMD copyright. Changes to allow reading blocks that greater than 65535 sectors. Signed-off-by: Kuei-Hung Lin Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Jiangang He --- MdeModulePkg/Bus/Usb/UsbBot

Re: [edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

2022-12-19 Thread Michael D Kinney
Judah, This was the feedback that I have back on 10/24/22 that was not incorporated into the CryptoPkg patches before they were merged today by Jiewen. Please generate an additional patch series to address (1) and (2). Mike > -Original Message- > From: Kinney, Michael D > Sent: Monday

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, December 20, 2022 #cal-reminder

2022-12-19 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, December 20, 2022 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions

2022-12-19 Thread Michael D Kinney
Hi Jiewen, I noticed that this patch is missing the update to the table in ReadMe.md to show the new PEI and SMM crypto services enabled by default in *CryptLib library instances. https://github.com/tianocore/edk2/tree/master/CryptoPkg#supported-cryptographic-families-and-services It did update

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions

2022-12-19 Thread Yao, Jiewen
Just merged - https://github.com/tianocore/edk2/pull/3796 > -Original Message- > From: Vang, Judah > Sent: Tuesday, December 20, 2022 8:44 AM > To: devel@edk2.groups.io; Vang, Judah > Cc: Yao, Jiewen ; Wang, Jian J > ; Xiaoyu Lu ; Jiang, Guomin > ; Mistry, Nishant C > Subject: RE: [edk

Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-19 Thread Guo, Gua
The goal reduce macro requirement to build UniversalPayloadBuild.py. For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate HOB data. So the change is move these PCD have compatibility FixedAtBuild only

Re: [edk2-devel] [PATCH 4/4] UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib.

2022-12-19 Thread Guo, Gua
Acked-by: Gua Guo -Original Message- From: devel@edk2.groups.io On Behalf Of Yuanhao Xie Sent: Tuesday, December 20, 2022 5:40 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 4/4] UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib. Add CpuPageTableLib required by MpIni

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs

2022-12-19 Thread Guo, Gua
@Lu, James Could you help us to add push label on it ? UefiPayloadPkg: Define default values for the DynamicEX PCDs by jiadingzhang · Pull Request #3792 · tianocore/edk2 (github.com) The change purpose is for resolving ECC

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions

2022-12-19 Thread Judah Vang
Hi Jiewen, Has this patch been merged? This is an important change for the UEFI Protected Variable feature. Judah -Original Message- From: devel@edk2.groups.io On Behalf Of Judah Vang Sent: Monday, November 7, 2022 2:16 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Wang, Jian J ; Xiaoy

[edk2-devel] [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

2022-12-19 Thread kasimx . liu
From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX

Re: [edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-19 Thread Tuan Phan
On Fri, Dec 16, 2022 at 4:06 PM Kinney, Michael D < michael.d.kin...@intel.com> wrote: > If that intrinsic is specific to RISCV, then should CompilerHelper.c go > into a RiscV64 subdir? > > Mike > > Hi Mike, While this intrinsic is not specific to RISCV, it is needed due to the GCC for RISCV64 do

[edk2-devel] [PATCH v2] UefiPayloadPkg: Move bdsdxe.inf from DXEFV to BDSFV

2022-12-19 Thread marsx . lin
From: MarsX Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4196 Since UefiPayload had supported multiple fv, move bdsdxe.inf to new firmware volume and modify the script of UniversalPayloadPkgBuild.py to support bdsdxe fv in elf file Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James

Re: [edk2-devel] [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2022-12-19 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] UsbHcFreeMemBlock()->IoMmuFreeBuffer()->mIoMmu->FreeBuffer(), which may end up calling PeiFreePages() depending on gEdkiiIoMmuPpiGuid implementation. Surely both will work since UsbHcFreeMemPool() can't be interrupted by any service call to use the memory just

[edk2-devel] [PATCH] UefiPayloadPkg: Move bdsdxe.inf from DXEFV to BDSFV

2022-12-19 Thread marsx . lin
From: MarsX Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4196 Since UefiPayload had supported multiple fv, move bdsdxe.inf to new firmware volume and modify the script of UniversalPayloadPkgBuild.py to support bdsdxe fv in elf file Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James

Re: [edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-19 Thread Tuan Phan
On Fri, Dec 16, 2022 at 5:59 PM Pedro Falcato wrote: > On Sat, Dec 17, 2022 at 12:06 AM Michael D Kinney < > michael.d.kin...@intel.com> wrote: > >> If that intrinsic is specific to RISCV, then should CompilerHelper.c go >> into a RiscV64 subdir? > > > Mike and Tuan, > > Two comments: > 1) __ctzd

Re: [edk2-devel] [PATCH 1/1] BaseTools: Fix IA32 UINT64 alignment for CLANG toolchains

2022-12-19 Thread Marvin Häuser
Revised version of last year’s https://edk2.groups.io/g/devel/message/79670 Initially caught by last year‘s https://edk2.groups.io/g/devel/message/79318 But now caught *yet again*, independently, via bugs during development. Cc stewards so this issue finally gets some attention. Might need validat

[edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-19 Thread Tuan Phan
The RiscV toolchain doesn't provide __ctzdi2 implementation when compiled with -nostdlib that needed by openssl library. So adding the implementation of __ctzdi2. Forcing to use CopyMem of EDK2 as memcpy buildin disabled for RiscV with -fno-builtin-memcpy flag. REF: https://bugzilla.tianocore.org

Re: [edk2-devel] [edk2-platforms][PATCH v2 03/11] Ext4Pkg: Fix global buffer overflow in Ext4ReadDir

2022-12-19 Thread Marvin Häuser
On 12. Dec 2022, at 15:46, Savva Mitrofanov wrote: > > Directory entry structure can contain name_len bigger than size of "." > or "..", that's why CompareMem in such cases leads to global buffer > overflow. So there are two problems. The first is that statement doesn't > check cases when name_le

Re: [edk2-devel] [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2022-12-19 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] Yes, it is the same issue discussed in https://edk2.groups.io/g/devel/topic/92833071#92165 MdeModulePkg\Bus\Pci\XhciPei\UsbHcMem.c for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) { // UsbHcUnlinkMemBlock (Pool->Head, Block); Us

[edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-19 Thread Lee, Chun-Yi
In the commit 4f173db8b4 "OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore", it introduced a PlatformValidateNvVarStore() function for checking the integrity of NvVarStore. In some cases when the VariableHeader->StartId is VARIABLE_DATA, the VariableHeader->State is not just one of th

[edk2-devel] [PATCH] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-19 Thread Tuan Phan
The RiscV toolchain doesn't provide __ctzdi2 implementation when compiled with -nostdlib that needed by openssl library when EC enabled. So adding the simple implementation of __ctzdi2. Forcing to use CopyMem of EDK2 as builtin memcpy disabled for RiscV with -fno-builtin-memcpy flag. Signed-off-

[edk2-devel] [PATCH] UefiPayloadPkg: Remove RTC_INDEX/TARGET from UplBuild macro list

2022-12-19 Thread kasimx . liu
From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, December 19, 2022 #cal-notice

2022-12-19 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, December 19, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650223 ) *Description:* TianoCore com

Re: [edk2-devel] [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2022-12-19 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] I will send the update according to the discussion. Thanks Abner > -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 20, 2022 8:27 AM > To: He, Jiangang ; Chang, Abner > ; devel@edk2.groups.io > Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray > ; Z

Re: [edk2-devel] [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2022-12-19 Thread Wu, Hao A
Thanks. You are right. I agree with you that aligning with XhciDxe is a better resolution. Best Regards, Hao Wu > -Original Message- > From: He, Jiangang > Sent: Tuesday, December 20, 2022 6:54 AM > To: Wu, Hao A ; Chang, Abner > ; devel@edk2.groups.io > Cc: Lin, Kuei-Hung (Timothy) ; N

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, December 19, 2022 #cal-reminder

2022-12-19 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, December 19, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650223 ) *Description:* Tia

[edk2-devel] [PATCH 4/4] UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib.

2022-12-19 Thread Yuanhao Xie
Add CpuPageTableLib required by MpInitLib in UefiPayloadPkg. Signed-off-by: Yuanhao Xie --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 723a50a422..05d53a85d0 100644 --- a/UefiP

[edk2-devel] [PATCH 3/4] OvmfPkg: Add CpuPageTableLib required by MpInitLib.

2022-12-19 Thread Yuanhao Xie
Add CpuPageTableLib required by MpInitLib in OvmfPkg. Signed-off-by: Yuanhao Xie --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 ++- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + OvmfPkg/IntelTdx/IntelTdxX64.dsc | 4 +++- OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++- OvmfPkg/OvmfPkgIa32X64.dsc | 1 + Ovmf

[edk2-devel] [PATCH 2/4] UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS.

2022-12-19 Thread Yuanhao Xie
During the finalization of Mp initialization before booting into the OS, depending on whether Mwait is supported or not, AsmRelocateApLoop places Aps in MWAIT-loop or HLT-loop. Since paging is necessary for long mode, the original implementation of moving APs to 32-bit was to disable paging to e

[edk2-devel] [PATCH 1/4] UefiCpuPkg: Duplicated AsmRelocateApLoop as AsmRelocateApLoopAmd

2022-12-19 Thread Yuanhao Xie
AsmRelocateApLoop is replicated for future Intel Logic Extraction, further brings AP into 64-bit, and enables paging. Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 52 +++--- UefiCpuPkg/Library/MpInitLib/MpEqu.inc| 2 + UefiCpuPkg/Library/MpInitLib/MpL

[edk2-devel] [PATCH 0/4] Put APs in 64 bit long-mode before booting to OS.

2022-12-19 Thread Yuanhao Xie
Yuanhao Xie (4): UefiCpuPkg: Duplicated AsmRelocateApLoop as AsmRelocateApLoopAmd UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS. OvmfPkg: Add CpuPageTableLib required by MpInitLib. UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib. OvmfPkg/AmdSev/AmdSevX64.dsc

Re: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets

2022-12-19 Thread Jake Garver via groups.io
Resend with BaseTools maintainers CC'd. Hi, folks. Is there interest in accepting this change? Any comments? Thanks, Jake From: Jake Garver Sent: Monday, December 19, 2022 11:36 AM To: devel@edk2.groups.io ; Jeff Brasen ; Ashish Singhal Subject: Re: [PATCH] B

[edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei

2022-12-19 Thread Anthony PERARD via groups.io
From: Anthony PERARD Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. QemuFwCfgLib expect this HOB to be present, or fails to do anything. InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not check if the HOB is actually present for example and try to use a NULL

Re: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets

2022-12-19 Thread Jake Garver via groups.io
Hi, folks. Is there interest in accepting this change? Any comments? Thanks, Jake From: Jake Garver Sent: Thursday, December 8, 2022 11:22 AM To: devel@edk2.groups.io ; Jeff Brasen ; Ashish Singhal Cc: Jake Garver Subject: [PATCH] BaseTools: Generate deps for

Re: [edk2-devel] [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

2022-12-19 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:52 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use ca

Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Nickle Wang via groups.io
Thanks for addressing my comment. Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:51 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platfor

Re: [edk2-devel] [PATCH 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] It could be removed by accident, V2 is sent. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Monday, December 19, 2022 10:39 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [PATCH 1/2] RedfishPkg/RedfishH

[edk2-devel] [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

2022-12-19 Thread Chang, Abner via groups.io
From: Abner Chang Add NULL function RedfishPlatformHostInterfaceNotification that returns EFI_UNSUPPORTED. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../RedfishPlatformHostInterfaceLib.c | 24 +++ 1 file changed, 24

[edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Chang, Abner via groups.io
From: Abner Chang For some use cases, Redfish host interface table relies on the certain EFI protocols installation at the driver connection. Redfish host interface DXE driver is not able to build the SMBIOS type 42h record at driver entry point. This patch adds the mechanism in Redfish host inte

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: add security warning

2022-12-19 Thread Yao, Jiewen
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, December 19, 2022 4:53 PM > To: Yao, Jiewen > Cc: devel@edk2.groups.io; Justen, Jordan L ; Ard > Biesheuvel ; Oliver Steffen > ; Pawel Polawski > Subject: Re: [edk2-devel] [PATCH 1/1] > Ovmf

Re: [edk2-devel] [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

2022-12-19 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:17 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use cauti

Re: [edk2-devel] [PATCH 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Nickle Wang via groups.io
Hi Abner, @@ -119,7 +123,7 @@ RedfishCreateSmbiosTable42 ( } else { NewProtocolRecords = ReallocatePool (CurrentProtocolsDataLength, NewProtocolsDataLength, (VOID *)ProtocolRecords); if (NewProtocolRecords == NULL) { -DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory fo

[edk2-devel] [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

2022-12-19 Thread Chang, Abner via groups.io
From: Abner Chang Add NULL function RedfishPlatformHostInterfaceNotification that returns EFI_UNSUPPORTED. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../RedfishPlatformHostInterfaceLib.c | 24 +++ 1 file changed, 24 insertions(+) diff --git

[edk2-devel] [PATCH 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

2022-12-19 Thread Chang, Abner via groups.io
From: Abner Chang For some use cases, Redfish host interface table relies on the certain EFI protocols installation at the driver connection. Redfish host interface DXE driver is not able to build the SMBIOS type 42h record at driver entry point. This patch adds the mechanism in Redfish host inte

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Allow for specified CPU names

2022-12-19 Thread Sami Mujawar
Merged as 05da2d24b08b..5fb3f5723a1e Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97557): https://edk2.groups.io/g/devel/message/97557 Mute This Topic: https://groups.io/mt/94869322/21656 Group Owner: de

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs

2022-12-19 Thread Jiading Zhang
Hi. I commit a PR again, and the PR passed all the test. https://github.com/tianocore/edk2/pull/3792/commits Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97556): https://edk2.groups.io/g/devel/message/97556 Mute This Topic: ht

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Allow for specified CPU names

2022-12-19 Thread Sami Mujawar
Hi Jeff, I think we can go ahead with this patch for now. We can revisit this with any modifications should we have any other requirement that needs addressing. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this gro

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: add security warning

2022-12-19 Thread Gerd Hoffmann
On Sat, Dec 17, 2022 at 03:10:25AM +, Yao, Jiewen wrote: > Hi Gerd > I would like to clarify a couple of things: > > 1) "Using these builds with writable flash is not secure." > > Whenever we say "secure" or "not secure", we need align the threat model at > first. > What component is trusted