Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-01-10 Thread Tinh Nguyen via groups.io
Hi, I have changed the Metronome driver from EmbeddedPkg to MdeModulePkg, but the performance is still very slow. - Tinh On 10/01/2023 12:07, Rebecca Cran wrote: You might still be using the Metronome driver from EmbeddedPkg instead of MdeModulePkg. That will for example cause gBS->Stall to

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB

2023-01-10 Thread Gerd Hoffmann
> > + Candidate = E820Entry->BaseAddr + E820Entry->Length; > > + if (Candidate >= BASE_4GB) { > > +return; > > + } > (1) This looks like a faithful conversion / extraction, but I'd vaguely > noticed something earlier, in the original code. Namely, when the > exclusive end of the range is

[edk2-devel] Implement IPMI_PROTOCOL on edk2-platforms

2023-01-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi stakeholders, Besides of below two IPMI related patch sets, we are going to implement IPMI Protocol on edk2-platforms. However, please help to review below two patches set then we can move forward. https://edk2.groups.io/g/devel/message/98051

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/7] Platform/Loongson: Support pflash for loongarch.

2023-01-10 Thread xianglai
Ok, I'll split it in the next version. Thanks, xianglai 在 2023/1/10 下午3:12, Chao Li 写道: I suggest to splitting this patch into two, one for adding new driver, and one for adjusting the code. Thanks, Chao 在 2023/1/10 09:16, xianglai 写道: Add pflash driver for loongarch. Cc: Ard Biesheuvel

[edk2-devel] [PATCH v2 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

2023-01-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements interfaces to read and write save state registers of AMD's processor family. Initializes processor SMMADDR and MASK depends on PcdSmrrEnable flag. Program or corrects the IP once control returns from

[edk2-devel] [PATCH v2 5/6] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib

2023-01-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds initial defination for AMD's SmmCpuFeaturesLib library implementation. All function's body either empty or just returns value. Its initial skeleton of library implementation. Cc: Paul Grimes Cc: Garrett

[edk2-devel] [PATCH v2 4/6] UefiCpuPkg: Implements SmmSmramSaveStateLib library class

2023-01-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements SmmSmramSaveStateLib Library class for AMD cpu family. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul

[edk2-devel] [PATCH v2 3/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

2023-01-10 Thread Abdul Lateef Attar via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds SmmSmramSaveStateLib Library class in UefiCpuPkg.dec. Adds function declaration header file. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul

[edk2-devel] [PATCH v2 1/6] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

2023-01-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 moves Intel-specific code to the arch-dependent file. Other processor families might have different implementation of these functions. Hence, moving out of the common file. Cc: Abner Chang Cc: Garrett Kirkendall

[edk2-devel] [PATCH v2 0/6] Adds AmdSmmCpuFeaturesLib

2023-01-10 Thread Abdul Lateef Attar via groups.io
V2 series addresses review comments from V1. Adds SmmSmramSaveStateLib library Removes global references across modules. drops S3 support patch. PR: https://github.com/tianocore/edk2/pull/3882 Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar

[edk2-devel] [PATCH V2 3/3] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2023-01-10 Thread Chang, Abner via groups.io
From: Abner Chang Unlink the XhciPei memory block when it has been freed. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin --- MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 31 +++-- 1 file changed, 29

[edk2-devel] [PATCH V2 2/3] MdeModulePkg/Usb: Read a large number of blocks

2023-01-10 Thread Chang, Abner via groups.io
From: Abner Chang Changes to allow reading blocks that greater than 65535 sectors. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin Reviewed-by: Hao A Wu --- MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 25 +++

[edk2-devel] [PATCH V2 1/3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

2023-01-10 Thread Chang, Abner via groups.io
From: Abner Chang Initialize XHCI DCI slot's context entries value. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin Reviewed-by: Hao A Wu --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++

[edk2-devel] [PATCH] Improved Smbios Type0 fields under smbiosview

2023-01-10 Thread Kanagavel S via groups.io
[PATCH] ShellPkg:Improved Smbios Type0 fields under SmbiosView Corrected few wrongly updated Smbios Type0 strings as per Smbios Spec under SmbiosView. Signed-off by: Kanagavel S CC: Srinivasan M CC: Sundaresan S CC: Prarthana S CC: Ramesh R ---

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, January 10, 2023 #cal-reminder

2023-01-10 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, January 10, 2023 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:*

[edk2-devel] [PATCH V3 6/6] OvmfPkg/AcpiPlatformDxe: Return error if installing NotifyProtocol failed

2023-01-10 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Installation of gQemuAcpiTableNotifyProtocol may fail. The error code should be returned so that the caller can handle it. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Cc:

[edk2-devel] [PATCH V3 5/6] OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol

2023-01-10 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Commit 9fdc70af6ba8 install the QemuAcpiTableNotifyProtocol at a wrong positioin. It should be called before TransferS3ContextToBootScript because TransferS3ContextToBootScript is the last operation in

[edk2-devel] [PATCH V3 4/6] OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables

2023-01-10 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Commit 9fdc70af6ba8 wrongly removed the log from InstallQemuFwCfgTables after ACPI tables are successfully installed. This patch add the log back after all operations succeed. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James

[edk2-devel] [PATCH V3 3/6] OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c

2023-01-10 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 The handle of mQemuAcpiHandle is not needed for anything, beyond the scope of the InstallQemuFwCfgTables(). So a local variable will suffice for storing the handle. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James Bottomley

[edk2-devel] [PATCH V3 2/6] OvmfPkg/AcpiPlatformDxe: Use local variable in CloudHvAcpi.c

2023-01-10 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 The handle of mChAcpiHandle is not needed for anything, beyond the scope of the InstallCloudHvTablesTdx (). A local variable (ChAcpiHandle) suffices for storing the handle. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James

[edk2-devel] [PATCH V3 1/6] OvmfPkg/AcpiPlatformDxe: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL

2023-01-10 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 The QEMU_ACPI_TABLE_NOTIFY_PROTOCOL structure is superfluous because NULL protocol interfaces have been used in edk2 repeatedly. A protocol instance can exist in the protocol database with a NULL associated interface.

[edk2-devel] [PATCH V3 0/6] Refactor installation of gQemuAcpiTableNotifyProtocol

2023-01-10 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Commit 9fdc70af6ba8 breaks log analysis and code cohesion in AcpiPlatformDxe. See the detailed information in BZ#4237. This patch-set contains below patches to fix above issues. #1: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL and delete

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-01-10 Thread Michael Brown
On 08/12/2022 03:44, RichardHo [何明忠] via groups.io wrote: +case PXE_OPFLAGS_RECEIVE_FILTER_DISABLE: + if (Cdb->CPBsize != PXE_CPBSIZE_NOT_USED) { +Cdb->StatFlags = PXE_STATFLAGS_COMMAND_FAILED; +Cdb->StatCode = PXE_STATCODE_INVALID_CDB; + } + + Nic->CanReceive

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-01-10 Thread Michael Brown
On 09/01/2023 23:50, Michael Brown wrote: Coincidentally, I have just implemented a fix for this.  It works by implementing a simple credit-based rate limiter.  Calls to UsbEthReceive() are limited to 10 per second while the receive datapath is idle.  No limiting takes place while the receive

Re: [edk2-devel] How to select boot device for current boot in response to IPMI System Boot Options commands?

2023-01-10 Thread Sean
Jeshua, I did ask my team how we have incorporated IPMI boot features into BDS.  There are two main points. 1.  The BDS you see in edk2 is very rarely used as is for commercial products.  In fact, most PC class systems and servers have a lot of customization in the BDS. 2. The BDS you see

Re: [edk2-devel] [PATCH 0/3] OVMF: support EFI_RNG_PROTOCOL without virtio-rng

2023-01-10 Thread Jason A. Donenfeld via groups.io
Could we get this merged? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98254): https://edk2.groups.io/g/devel/message/98254 Mute This Topic: https://groups.io/mt/94935839/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2 4/4] OvmfPkg/PlatformInitLib: Add PlatformReservationConflictCB

2023-01-10 Thread Laszlo Ersek
On 1/10/23 09:21, Gerd Hoffmann wrote: > Add PlatformReservationConflictCB() callback function for use with > PlatformScanE820(). It checks whenever the 64bit PCI MMIO window > overlaps with a reservation from qemu. If so move down the MMIO window > to resolve the conflict. > > This happens on

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-10 Thread Laszlo Ersek
On 1/10/23 09:21, Gerd Hoffmann wrote: > Add PlatformAddHobCB() callback function for use with > PlatformScanE820(). It adds HOBs for high memory and reservations (low > memory is handled elsewhere because there are some special cases to > consider). This replaces calls to

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB

2023-01-10 Thread Laszlo Ersek
Quoting the hunks out of order: On 1/10/23 09:21, Gerd Hoffmann wrote: > Add PlatformGetLowMemoryCB() callback function for use with > PlatformScanE820(). It stores the low memory size in > PlatformInfoHob->LowMemory. This replaces calls to > PlatformScanOrAdd64BitE820Ram() with non-NULL

Re: [edk2-devel] How to select boot device for current boot in response to IPMI System Boot Options commands?

2023-01-10 Thread Jeshua Smith via groups.io
Any input on this? It seems that the current behavior isn't ideal: * If BootNext is already set when PlatformBootManagerLib APIs are called, a new BootNext value from the PlatformBootManagerLib code will be ignored (because the original value is cached before the APIs have a chance to set

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

2023-01-10 Thread Sami Mujawar
Hi Moritz, I have merged this patch with a minor change to the commit message. Merged as 82dd766f2522..717f35a9f2d8 Thanks. Regards, Sami Mujawar On 09/01/2023, 16:42, "Moritz Fischer" wrote: Linux's cpu DT bindings call out arm,armv8 while the code previously used arm,arm-v8, add

Re: [edk2-devel] [PATCH v2 1/4] OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB

2023-01-10 Thread Laszlo Ersek
On 1/10/23 09:21, Gerd Hoffmann wrote: > First step replacing the PlatformScanOrAdd64BitE820Ram() function. > > Add a PlatformScanE820() function which loops over the e280 entries > from FwCfg and calls a callback for each of them. > > Add a GetFirstNonAddressCB() function which will store the

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

2023-01-10 Thread Lendacky, Thomas via groups.io
+ Garret On 1/10/23 03:36, Ni, Ray via groups.io wrote: The challenge is that the non-Itanium CPU archs that may depend on the current binary layout of these structures. This could be a binary PEI CPU module, DXE CPU module, SMM CPU module, MM CPU modules, UEFI App/Shell App that use the PPI

Re: [edk2-devel] [PATCH 0/4] BaseTools - various cleanups

2023-01-10 Thread Ard Biesheuvel
If there are no objections to these changes, I will merge them by the end of today, Thanks. On Mon, 9 Jan 2023 at 17:37, Ard Biesheuvel wrote: > > On Thu, 5 Jan 2023 at 17:05, Ard Biesheuvel wrote: > > > > Some cleanups for the tools_def template, mostly related to ARM but with > > some

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg: Export default shell delay as PCD

2023-01-10 Thread Tomas Pilar (tpilar)
Hi, Any chance you could review this change? It's fairly simple. Cheers, Tom On 03/01/2023 17:02, Tomas Pilar (tpilar) wrote: From: Tomas Pilar Create PcdShellDefaultDelay to configure the default delay the shell provides for the user at the start time if the user wishes to cancel the

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

2023-01-10 Thread Gerd Hoffmann
On Tue, Jan 10, 2023 at 09:36:59AM +, Ni, Ray wrote: > > >>> The challenge is that the non-Itanium CPU archs that may depend on the > > >>> current binary layout of these structures. This could be a binary > > >>> PEI CPU module, DXE CPU module, SMM CPU module, MM CPU modules, > > >>> UEFI

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

2023-01-10 Thread Ni, Ray
> >>> The challenge is that the non-Itanium CPU archs that may depend on the > >>> current binary layout of these structures. This could be a binary > >>> PEI CPU module, DXE CPU module, SMM CPU module, MM CPU modules, > >>> UEFI App/Shell App that use the PPI or HOB. The CPU health record is

[edk2-devel] [PATCH v2 4/4] OvmfPkg/PlatformInitLib: Add PlatformReservationConflictCB

2023-01-10 Thread Gerd Hoffmann
Add PlatformReservationConflictCB() callback function for use with PlatformScanE820(). It checks whenever the 64bit PCI MMIO window overlaps with a reservation from qemu. If so move down the MMIO window to resolve the conflict. This happens on (virtal) AMD machines with 1TB address space,

[edk2-devel] [PATCH v2 3/4] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-10 Thread Gerd Hoffmann
Add PlatformAddHobCB() callback function for use with PlatformScanE820(). It adds HOBs for high memory and reservations (low memory is handled elsewhere because there are some special cases to consider). This replaces calls to PlatformScanOrAdd64BitE820Ram() with AddHighHobs = TRUE. Also remove

[edk2-devel] [PATCH v2 2/4] OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB

2023-01-10 Thread Gerd Hoffmann
Add PlatformGetLowMemoryCB() callback function for use with PlatformScanE820(). It stores the low memory size in PlatformInfoHob->LowMemory. This replaces calls to PlatformScanOrAdd64BitE820Ram() with non-NULL LowMemory. Also change PlatformGetSystemMemorySizeBelow4gb() to likewise set

[edk2-devel] [PATCH v2 1/4] OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB

2023-01-10 Thread Gerd Hoffmann
First step replacing the PlatformScanOrAdd64BitE820Ram() function. Add a PlatformScanE820() function which loops over the e280 entries from FwCfg and calls a callback for each of them. Add a GetFirstNonAddressCB() function which will store the first free address (right after the last RAM block)

[edk2-devel] [PATCH v2 0/4] OvmfPkg: check 64bit mmio window for resource conflicts

2023-01-10 Thread Gerd Hoffmann
v2: - split up PlatformScanOrAdd64BitE820Ram() into scan function with callbacks, store results in PlatformInfoHob struct. Gerd Hoffmann (4): OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

2023-01-10 Thread Paweł Poławski
Hi everyone, If there is a chance you have some evaluation about this problem already? Best regards, Pawel W dniu 21.12.2022 o 09:03, Ni, Ray pisze: sure Mike. I will. -Original Message- From: Kinney, Michael D Sent: Wednesday, December 21, 2022 11:51 AM To: devel@edk2.groups.io;