Hi Pierre
On 2/3/23 21:26, Pierre Gondois wrote:
Hello Vivek,
Thanks for review the changes, please find my responses inline below.
On 1/27/23 10:23, Vivek Gautam wrote:
Arm reference design platforms have multiple IO virtualization blocks
that allow connecting PCIe root bus or non-PCIe
Hi Pierre,
On 2/3/23 21:28, Pierre Gondois wrote:
Hello Vivek,
On 1/27/23 10:23, Vivek Gautam wrote:
Arm reference design Fixed Virtual Platforms (FVPs) such as the RD-N2
platform variants have multiple IO virtualization blocks that allow
connecting PCIe root bus or non-PCIe SoC peripherals
Hi Pierre,
On 2/3/23 21:25, PierreGondois via groups.io wrote:
Hello Vivek,
Thanks for your review. Please find my responses inline below.
On 1/27/23 10:23, Vivek Gautam wrote:
From: Shriram K
The IO virtualization block on reference design platforms allow
connecting SoC expansion
Add -DOPENSSL_NO_AUTOALGINIT flag will reduce PEI size by ~60KB, based on patch
you attached.
This flag will break PKCS7, Authenticode and Ts, but will be fine if only used
in PEI builds.
Regards,
Yi
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann
Sent:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850
Add "-Y REPORT_INFO" option to build command to generate compile
information as part of BuildReport.
This option generates files to be used by external tools as IDE's
to enhance functionality.
Files are created inside build folder:
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, February 7, 2023
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Chen, Gang C
> Sent: Thursday, February 2, 2023 11:29 AM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for
> openssl
>
> Hi Jiewen,
>
> Here
Hao and Weipu:
I have no other comments for this change.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wu, Hao A
> 发送时间: 2023年2月2日 10:41
> 收件人: devel@edk2.groups.io; Zhu, Weipu
> 抄送: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> 主题: Re: [edk2-devel] [PATCH 2/2] MdePkg:
OK. I will merge it today.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Zhiguang Liu
> 发送时间: 2023年2月3日 15:49
> 收件人: devel@edk2.groups.io; Gao, Liming ;
> Wang, Jian J
> 抄送: Ni, Ray
> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning
> of
I can't see the Bugzilla you referenced so I requested security Bugzilla
access. But, yes, that's the bug to which I was referring :)
Once Ard's change to add Memory Attribute Protocol support to ARM
platforms is in, the change you linked may be palatable for the
upstream. However, ARM
*Tools, CI, Code base construction meeting series*
*When:*
Monday, February 6, 2023
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650238 )
*Description:*
TianoCore
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, February 6, 2023
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650238 )
*Description:*
Try to install lld in your machine.
https://www.howtoinstall.me/ubuntu/18-04/lld/
From: ritul guru
Sent: Monday, February 6, 2023 11:12:08 PM
To: Guo, Gua
Cc: devel@edk2.groups.io ; Mike Maslenkin
Subject: Re: [edk2-devel] regarding build uefipayload in debug
On Mon, 6 Feb 2023 at 23:40, Michael Kubacki
wrote:
>
> While CI involves several services, in the future you can check the following
> dashboard for any known widespread Pipeline service issues:
> https://status.dev.azure.com/
>
> In my experience though, issues (which are relatively rare) are
While CI involves several services, in the future you can check the following
dashboard for any known widespread Pipeline service issues:
https://status.dev.azure.com/
In my experience though, issues (which are relatively rare) are usually in some
other component executed after the agent is
NOT FOR MERGE
Add some DEBUG code to double check that the memory attributes have been
modified as expected by the code that manages read-only and/or non-exec
permissions for page allocations and loaded images.
---
MdeModulePkg/Core/Dxe/DxeMain.inf | 1 +
In preparation for introducing an implementation of the EFI memory
attributes protocol that is shared between ARM and AArch64, unify the
existing code that converts a page table descriptor into a
EFI_MEMORY_xxx bitfield, so it can be called from the generic code.
Signed-off-by: Ard Biesheuvel
Expose the protocol introduced in v2.10 that permits the caller to
manage mapping permissions in the page tables.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +
ArmPkg/Drivers/CpuDxe/CpuDxe.h | 3 +
ArmPkg/Drivers/CpuDxe/CpuDxe.inf| 2 +
The section-to-page attribute conversion takes the shareability and
execute-never attributes into account, whereas the page-to-section
counterpart does not. The result is that GetMemoryRegionPage () -which
takes a section attribute argument (via *RegionAttributes) that is
ostensibly based on the
Add the Memory Attribute Protocol definition, which was adopted and
included in version 2.10 of the UEFI specification.
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3519
Signed-off-by: Ard Biesheuvel
Reviewed-by: Liming Gao
---
MdePkg/Include/Protocol/MemoryAttribute.h | 142
v3:
- fix ARM32 bug in attribute conversion
- add Liming's ack to patch #1
- include draft patch (NOT FOR MERGE) used to test the changes
v2:
- drop patch to bump exposed UEFI revision to v2.10
- add missing permitted return values to protocol definition
Cc: Michael Kinney
Cc: Liming Gao
Cc:
On Sat, 4 Feb 2023 at 02:26, Michael Kubacki
wrote:
>
> Hi Ard,
>
> I'm not an admin on the tianocore Azure DevOps organization so I cannot
> view or do much more than you can.
>
> It appears to me to be a transient issue during provisioning on the
> particular agent. Normally, I'd use a "rerun
Thanks for the good catch Ashraf!
I have sent V2 patch for addressing your feedbacks, please help to review again.
Thanks,
Chasel
> -Original Message-
> From: S, Ashraf Ali
> Sent: Saturday, February 4, 2023 8:03 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Oram, Isaac W ;
When invalid VariableStore FV header detected, current SpiFvbService
will erase both FV and VariableStore headers from flash, however,
it will only rewrite FV header back and cause invalid VariableStore
header.
This patch adding the support for rewriting both FV header and
VariableStore header
ohh, it should retains value on VM reboot.
//
// Allocate storage for NV variables early on so it will be
// at a consistent address. Since VM memory is preserved
// across reboots, this allows the NV variable storage to survive
// a VM reboot.
//
*Thanks & RegardsRitul Guru+91-9916513186*
> On Feb 6, 2023, at 10:25 AM, ritul guru wrote:
>
> Thanks,
> so as it is memory, does it mean if anything written in variable store, and
> VM reboot happens then variable store will be flushed?
>
It looks like it is saved if you do an S3. S3 is ACPI speak for a sleep state
that puts RAM
is it right? llvm path also need to set?
*Thanks & RegardsRitul Guru+91-9916513186*
On Mon, Feb 6, 2023 at 10:21 PM ritul guru wrote:
> PATH=$PATH:/usr/bin/clang
>
> yes, set it as above.
>
>
>
> *Thanks & RegardsRitul Guru+91-9916513186*
>
>
> On Mon, Feb 6, 2023 at 8:43 PM Guo, Gua
Hi,
I have been using xen hypervisor and tianocore uefi BIOS on xen to boot to
ubuntu OS on virtualized disk.
and want to set a UEFI variable with UEFI runtime service SetVariable() to
a value and the same wants to read from UEFI bootloader either grubx64.efi
or botmgfw.efi,
So, Is it possible to
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
I received an Acked-by, but would like to request a Reviewed-by from a
BaseTools maintainer.
@gaolim...@byosoft.com.cn I would like to request that this change be
included in the stable tag.
This change updates edk2-pytool-library and edk2-pytool-extensions to the
latest release, which
brings in
PATH=$PATH:/usr/bin/clang
yes, set it as above.
*Thanks & RegardsRitul Guru+91-9916513186*
On Mon, Feb 6, 2023 at 8:43 PM Guo, Gua wrote:
> Do you set clang bin path ?
>
>
>
> *From:* ritul guru
> *Sent:* Monday, February 6, 2023 11:12 PM
> *To:* Guo, Gua
> *Cc:* devel@edk2.groups.io;
"clang" -o
/home/amd/src/opensource/edk2/Build/UefiPayloadPkgX64/DEBUG_CLANGDWARF/X64/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry/DEBUG/UniversalPayloadEntry.dll
-nostdlib -Wl,-q,--gc-sections -z max-page-size=0x40
-Wl,--entry,_ModuleEntryPoint -u _ModuleEntryPoint
Great to see this and hoping to see it reviewed and integrated soon, as I've a
few other small cleanups waiting on this :-)
Reviewed-by: Andrei Warkentin
-Original Message-
From: Sunil V L
Sent: Thursday, December 15, 2022 6:56 AM
To: devel@edk2.groups.io
Cc: Abner Chang ; Daniel
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Andrew Fish ; Leif Lindholm ;
Kinney, Michael D
Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
R ; Gerd Hoffmann ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann
Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Daniel Schaefer ; Kinney, Michael D
; Gao, Liming ; Liu,
Zhiguang ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Sami Mujawar ; Gerd Hoffmann
Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
R ; Daniel Schaefer ; Abner
Chang ; Gerd Hoffmann
Subject: [edk2-devel]
getting below error:
build -p UefiPayloadPkg/UefiPayloadPkg.dsc -b DEBUG -a IA32 -a X64 -m
UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf -t CLANGDWARF -y
/home/a/src/opensource/edk2/Build/UefiPayloadPkgX64/UefiUniversalPayloadEntry.txt
-D UNIVERSAL_PAYLOAD=TRUE -D
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Ard Biesheuvel
; Abner Chang ; Daniel Schaefer
Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang ; Daniel
Schaefer ; Abner Chang
Subject: [edk2-devel]
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
R ; Daniel Schaefer ; Gerd
Hoffmann ; Abner Chang ; Heinrich
Schuchardt
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
R ; Daniel Schaefer ; Gerd
Hoffmann ; Abner Chang
Subject: [edk2-devel]
workspace needs to be set to any value?
0 $ bash UefiPayloadPkg/UniversalPayloadBuild.sh -t GCC5 -a IA32 -a X64 -D
CPU_TIMER_LIB_ENABLE=FALSE
python_exe=
Traceback (most recent call last):
File "UefiPayloadPkg/UniversalPayloadBuild.py", line 172, in
main()
File
Reviewed-by: Andrei Warkentin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Saturday, January 28, 2023 1:18 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang ; Abner Chang
Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt
thanks,
./cbfstool coreboot.rom remove -r COREBOOT -n fallback/payload
./cbfstool coreboot.rom add-payload -r COREBOOT -n fallback/payload -f
ShimLayer.elf
./cbfstool coreboot.rom remove -r COREBOOT -n img/UniversalPayload
./cbfstool coreboot.rom add-flat-binary -r COREBOOT -n
Just checking to see when this patch could be merged?
Thanks,
Swati
From: gaoliming
Sent: Saturday, January 28, 2023 10:59 PM
To: 'Name' ; devel@edk2.groups.io ;
sami.muja...@arm.com ; alexei.fedo...@arm.com
; pierre.gond...@arm.com ;
Thanks,
17:05 $ ./UefiPayloadPkg/UniversalPayloadBuild.sh -t GCC5 -a IA32 -a X64 -D
CPU_TIMER_LIB_ENABLE=FALSE
python_exe=/usr/bin/python3.8
"llvm-objcopy" --version
/bin/sh: 1: llvm-objcopy: not found
- Failed - error happened when run command: "llvm-objcopy" --version
- Failed - Please check if
Do you set clang bin path ?
From: ritul guru
Sent: Monday, February 6, 2023 11:12 PM
To: Guo, Gua
Cc: devel@edk2.groups.io; Mike Maslenkin
Subject: Re: [edk2-devel] regarding build uefipayload in debug mode in linux
getting below error:
build -p UefiPayloadPkg/UefiPayloadPkg.dsc -b DEBUG -a
Yes, I think it should be able to boot to uefi shell based on the command.
From: ritul guru
Sent: Monday, February 6, 2023 10:53 PM
To: Guo, Gua
Cc: devel@edk2.groups.io; Mike Maslenkin
Subject: Re: [edk2-devel] regarding build uefipayload in debug mode in linux
thanks,
./cbfstool
I think you can run “. edksetup.sh” in your local and WORKSPACE will be setup
automatically.
From: ritul guru
Sent: Monday, February 6, 2023 10:22 PM
To: Guo, Gua
Cc: devel@edk2.groups.io; Mike Maslenkin
Subject: Re: [edk2-devel] regarding build uefipayload in debug mode in linux
workspace
On Fri, 3 Feb 2023 at 15:53, Sami Mujawar wrote:
>
> Hi Sudeep,
>
> Thank you for the updated patch.
>
> Reviewed-by: Sami Mujawar
> Tested-by: Sami Mujawar
>
Merged as #4006
Thanks all,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Hi Igor,
It seems to me that AMI copyrights header is missing in these files. Could you
please check this?
Thanks,
Nickle
-Original Message-
From: Chang, Abner
Sent: Sunday, February 5, 2023 12:01 AM
To: devel@edk2.groups.io; ig...@ami.com
Cc: Nickle Wang
Subject: RE: [PATCH]
UniversalPayload.sh have Clang tool chain dependency.
I assume your machine is ubuntu-20.10, please download it. And set use export
PATH=$PATH: to prevent the issue.
https://github.com/llvm/llvm-project/releases/download/llvmorg-11.1.0/clang+llvm-11.1.0-x86_64-linux-gnu-ubuntu-20.10.tar.xz
Hi Swatisri,
Thank you for this patch,
I have some suggestions marked inline as [SAMI].
Regards,
Sami Mujawar
On 25/01/2023 06:40 pm, Name wrote:
From: Swatisri Kantamsetti
The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022
Hi Swatisri,
Thank you for this patch.
This patch must be 1/2 to prevent git bisect from failing. Otherwise
these changes look good to me.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/01/2023 06:40 pm, Name wrote:
From: Swatisri Kantamsetti
The IO
Hello Jeff,
Thanks for the v2. Also cf the first discussion at:
https://edk2.groups.io/g/devel/topic/96680589#99612
- I think it would be good to extract a function that does all the checks
as there are many possibilities for the flags/parent combinations.
- I think it would also be nice to
On 2/3/23 17:38, Jeff Brasen wrote:
To solve that problem I had added support for allowing the UID/Name to come
from the node
https://github.com/tianocore/edk2/commit/5fb3f5723a1ea9d9a93e317181e1c11468a9eb45
Yes right. However if the UID/Name were to be generated, the topology could be
> > > > PEI jumps up in size even though I'm using the min_pei config for
> > > > CryptoPei, seems it *still* has way too much bits compiled in
> > > > (didn't look into tweaking the config yet, hints are welcome).
> > > >
> > > > + 333950 CryptoPei
> > >
> > > Why would we use this for PEI if
66 matches
Mail list logo
