Re: [edk2-devel] [edk2-platforms][PATCH 7/7] edk2-platforms: Maintainers.txt

2023-02-07 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, February 7, 2023 8:23 AM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Leif Lindholm > ; Kinney, Michael D > ; Gao, Liming ; Oram, > Isaac W ; Desimone, Nathaniel L > > Subject:

Re: [edk2-devel] [PATCH 1/1] .pytool/Plugin/EccCheck: Add PACKAGES_PATH support

2023-02-07 Thread Michael D Kinney
I will merge tomorrow. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin Häuser > Sent: Tuesday, February 7, 2023 4:49 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Feng, Bob C ; Chen, Christine > ; Sean Brogan > ; Michael Kubacki ; > Gao, Liming ;

Re: [edk2-devel] [PATCH 4/5] UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib

2023-02-07 Thread Guo, Gua
Reviewed-by: Gua Guo -Original Message- From: Xie, Yuanhao Sent: Tuesday, February 7, 2023 9:50 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH 4/5] UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib Add

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Fix RemoteDdrSize cast

2023-02-07 Thread sahil
Hi Thomas/Sami, This issue arose while fixing comments during upstreaming the following patch - https://edk2.groups.io/g/devel/topic/83261392#76845 and was observed while we were testing the platform with upstream code. Thanks, Sahil On Thu, 26 Jan 2023 at 00:48, Thomas Abraham wrote: > > > Hi

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1sdp: Add support to parse NT_FW_CONFIG

2023-02-07 Thread sahil
On Wed, 8 Feb 2023 at 10:52, Sahil wrote: > > Hi Thomas/Sami, > > This issue arose while fixing comments during upstreaming the > following patch - https://edk2.groups.io/g/devel/topic/83261392#76845 > and was observed while we were testing the platform with upstream code. > Sorry for the

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1sdp: Add support to parse NT_FW_CONFIG

2023-02-07 Thread sahil
Hi Thomas/Sami, This issue arose while fixing comments during upstreaming the following patch - https://edk2.groups.io/g/devel/topic/83261392#76845 and was observed while we were testing the platform with upstream code. Thanks, Sahil On Thu, 26 Jan 2023 at 02:17, Thomas Abraham wrote: > > Hi

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 07/20] UefiCpuPkg/CpuDxe: Add RISC-V instance

2023-02-07 Thread Sunil V L
Thanks!, Andrei. Hi Ray, These changes are done as per your recommendation in https://edk2.groups.io/g/devel/message/97106 Could you please help reviewing UefiCpuPkg patches? RISC-V community is waiting for this support for a long time now. If we get these merged in early days after the current

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-07 Thread Tinh Nguyen via groups.io
On 2/7/2023 3:20 PM, Michael Brown wrote: > On 07/02/2023 06:21, Tinh Nguyen via groups.io wrote: >> From: Tinh Nguyen >> Date: Tue, 7 Feb 2023 12:43:17 +0700 >> Subject: [PATCH] UsbNetworkPkg: Support rate limitting >> >> Signed-off-by: Tinh Nguyen > > Thank you for extending my patch to add

[edk2-devel] [PATCH V2] RedfishPkg: RedfishRestExDxe: PCD introduced to control "Expect" header

2023-02-07 Thread Igor Kulchytskyy via groups.io
"Expect" header for POST, PATCH, PUT requests should be optional in order to work with different BMC implementation Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec | 6 +-

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, February 7, 2023 #cal-reminder

2023-02-07 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, February 7, 2023 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread ritul guru
fatal: repository 'payloads/external/edk2/workspace/tianocore' does not exist make[1]: *** [Makefile:123: /home/amd/src/phx2/coreboot_phx2/coreboot/payloads/external/edk2/workspace/edk2] Error 128 make: *** [payloads/external/Makefile.inc:158: build/UEFIPAYLOAD.fd] Error 2 *Thanks &

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread ritul guru
I do not get debug logs from edk2 payload even though debug payload is selected in menuconfig of coreboot. and also updated FD_BASE, if not then getting GCD assert while adding regions in phit table. below path should be give at L36 for custom edk2 repo?

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread Sean Rhodes
L36 is help text that says what you are trying to do, wont work On Tue, 7 Feb 2023 at 20:51, ritul guru wrote: > fatal: repository 'payloads/external/edk2/workspace/tianocore' does not > exist > make[1]: *** [Makefile:123: >

[edk2-devel] [PATCH v1 1/1] ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.c

2023-02-07 Thread Sam Kaynor
Added entries for UEFI Config Tables not present in current Dmem output. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sam Kaynor --- ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 9 ++ ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c |

[edk2-devel] [PATCH v1 0/1] Add all UEFI Config Tables to Dmem output

2023-02-07 Thread Sam Kaynor
Currently, several important UEFI defined config tables are not present in the output of Dmem. This patch implements dumping the presence of all UEFI Config Tables defined in UEFI Specification 2.10 REF: https://github.com/skaynor/edk2/tree/uefi_config_tables_dmem_v1 Cc: Ray Ni Cc: Zhichao Gao

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread Sean Rhodes
Why the edk2 changes? Just to fix this issue? Have you seen L36 of payloads/external/edk2/Kconfig On Tue, 7 Feb 2023 at 20:30, ritul guru wrote: > > > Loading driver 378D7B65-8DA9-4773-B6E4-A47826A833E1 > InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 51A3E1C0 > Loading driver

Re: [edk2-devel] Graphic Output on qemu

2023-02-07 Thread Paul, Bill
Of all the gin joints in all the towns in all the world, Alireza Banejad had to walk into mine at 02:22:32 on Tuesday, 7 February 2023 and say: > Do not click links or open attachments unless you recognize the sender and > know the content is safe. Hello everyone, > I am trying to use the GOP

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread ritul guru
building it inside coreboot only. *Thanks & RegardsRitul Guru+91-9916513186* On Wed, Feb 8, 2023 at 12:00 AM Sean Rhodes wrote: > Hi Ritul > > It might be easier to build it inside coreboot; that'll use coreboots tool > chain and Kconfig so everything will just work. > > I.e.

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread ritul guru
CONFIG_PAYLOAD_EDK2=y # CONFIG_PAYLOAD_LINUX is not set CONFIG_PAYLOAD_FILE="build/UEFIPAYLOAD.fd" CONFIG_PAYLOAD_OPTIONS="" CONFIG_EDK2_UEFIPAYLOAD=y # CONFIG_EDK2_REPO_MRCHROMEBOX is not set CONFIG_EDK2_REPO_OFFICIAL=y # CONFIG_EDK2_REPO_CUSTOM is not set

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread ritul guru
Loading driver 378D7B65-8DA9-4773-B6E4-A47826A833E1 InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 51A3E1C0 Loading driver at 0x00051DD1000 EntryPoint=0x00051DD5670 PcRtc.efi InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 51A3ED98 ProtectUefiImageCommon - 0x51A3E1C0

Re: [edk2-devel] [edk2-platforms: PATCH v3] IntelSiliconPkg/SpiFvbServiceSmm: Rewrite VariableStore header.

2023-02-07 Thread Michael Kubacki
Hi Chasel, I agree with the high-level problem. Here's some observations. 1. I'm not a big fan of implicitly associating index zero of the mPlatformFvBaseAddress array as the variable FV entry. It could be easy for that to silently get out of sync in the future. Perhaps you could check if

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread Sean Rhodes
For anyone to be able to help, you'd need to post a build log, .config, tag and what custom patches you are using. On Tue, 7 Feb 2023 at 19:02, ritul guru wrote: > CONFIG_PAYLOAD_EDK2=y > # CONFIG_PAYLOAD_LINUX is not set > CONFIG_PAYLOAD_FILE="build/UEFIPAYLOAD.fd" > CONFIG_PAYLOAD_OPTIONS=""

Re: [edk2-devel] [edk2-platforms: PATCH v2] IntelSiliconPkg/SpiFvbServiceSmm: Rewrite VariableStore header.

2023-02-07 Thread Chiu, Chasel
Hello, I have sent a V3 patch to remove Uncrustify coding style changes. We will do coding style changes separately later. Please help to review V3 patch. Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Monday, February 6, 2023

[edk2-devel] [edk2-platforms: PATCH v3] IntelSiliconPkg/SpiFvbServiceSmm: Rewrite VariableStore header.

2023-02-07 Thread Chiu, Chasel
When invalid VariableStore FV header detected, current SpiFvbService will erase both FV and VariableStore headers from flash, however, it will only rewrite FV header back and cause invalid VariableStore header. This patch adding the support for rewriting both FV header and VariableStore header

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Marvin Häuser
> On 7. Feb 2023, at 19:19, Taylor Beebe wrote: > > If I understand Marvin correctly, he means that there either needs to be a > requirement that if you change the attributes of an allocated buffer you must > change them back before freeing, or the memory management logic should handle >

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread Sean Rhodes
Hi Ritul It might be easier to build it inside coreboot; that'll use coreboots tool chain and Kconfig so everything will just work. I.e. CONFIG_PAYLOAD_EDK2=y Sean On Tue, 7 Feb 2023, 18:24 ritul guru, wrote: > UefiPayloadPkg/UefiPayloadPkg.fdf > DEFINE FD_BASE = 0x0080 > > Is the

Re: [edk2-devel] [edk2-platforms][PATCH 7/7] edk2-platforms: Maintainers.txt

2023-02-07 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Isaac, Nate and Liming, Please let me know if you would like to be the reviewer for ManageabilityPkg or not. I will add you to the maintainer list in the next patch set if you want. Thanks Abner Get Outlook for Android

Re: [edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread ritul guru
UefiPayloadPkg/UefiPayloadPkg.fdf DEFINE FD_BASE = 0x0080 Is the above address correct in uefipaylaod? As observing some regions are getting out of limit of FD limit, and when setting DEFINE FD_BASE = 0x0220, then seeing assert in

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Marvin Häuser
> On 7. Feb 2023, at 18:56, Ard Biesheuvel wrote: > > On Tue, 7 Feb 2023 at 11:13, Marvin Häuser wrote: >> >> >> On 7. Feb 2023, at 11:01, Ard Biesheuvel wrote: >> >> Actually, it seems UnprotectUefiImage () is corrent under the >> assumption that all code regions have EFI_MEMORY_XP

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Taylor Beebe
On 2/7/2023 12:56 AM, Marvin Häuser wrote: > Hi Taylor and Ard, > >> On 7. Feb 2023, at 09:29, Ard Biesheuvel wrote: >> >> On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote: >>> >>> I can't see the Bugzilla you referenced so I requested security Bugzilla >>> access. But, yes, that's the bug to

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Ard Biesheuvel
On Tue, 7 Feb 2023 at 11:13, Marvin Häuser wrote: > > > On 7. Feb 2023, at 11:01, Ard Biesheuvel wrote: > > Actually, it seems UnprotectUefiImage () is corrent under the > assumption that all code regions have EFI_MEMORY_XP cleared by > default. > > However, if you redefine the policy to set

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

2023-02-07 Thread Marvin Häuser
CC Gerd (sorry the original quote is missing, groups.io is terrible) I thought he was to be CC'd on all UefiCpuPkg patches? Best regards, Marvin > On 7. Feb 2023, at 17:40, Marvin Häuser wrote: > > Hi Yuanhao, > > 1) The code comments and copy code suggest that the

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

2023-02-07 Thread Marvin Häuser
Hi Yuanhao, 1) The code comments and copy code suggest that the stacks are located low and the function is located high (good). However, the SetMemorySpaceAttributes() call un-XP's Address, which is the low address. So, do I misunderstand the changes, or are you un-XP'ing the first stack (and

[edk2-devel] regarding uefipayload build warning for pcd

2023-02-07 Thread ritul guru
Hi, I am building edk2 payload and getting below warning for PcdRtcIndexRegister, and if try to boot to then observing that there is assert at: ASSERT_EFI_ERROR (Status = Device Error) DXE_ASSERT!:

[edk2-devel] Graphic Output on qemu

2023-02-07 Thread Alireza Banejad
Hello everyone, I am trying to use the GOP library for my uefi development. But no matter what code whenever i want to open the GOP handle RETURN_UNSUPPORTED is returned. I think this may be a qemu problem as if it doesn't support the GOP at all. This is how I run my qemu qemu-system-x86_64 -bios

[edk2-devel] [edk2-platforms][PATCH 5/7] ManageabilityPkg: Implement Ipmi Protocol/Ppi

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang Add Ipmi Protocol/Ppi implementation. The underlying implementation is provided by IpmiBaseLib. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy ---

[edk2-devel] [edk2-platforms][PATCH 4/7] ManageabilityPkg: Initial package

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang Initial commit of ManageabilityPkg Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../ManageabilityPkg/ManageabilityPkg.dec | 18 + .../Include/CommonLibs.dsc.inc

[edk2-devel] [edk2-platforms][PATCH 7/7] edk2-platforms: Maintainers.txt

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang Add maintainer and reviewer of ManageabilityPkg. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone --- Maintainers.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)

[edk2-devel] [edk2-platforms][PATCH 2/7] ManageabilityPkg: Add diagrams

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang Add diagram of ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- .../Documents/Media/ManageabilityDriverStack.svg | 1 + 1 file changed, 1

[edk2-devel] [edk2-platforms][PATCH 6/7] IpmiProtocol: Add to Manageability Package

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang Add Ipmi Protocol/Ppi module to ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- Features/ManageabilityPkg/Include/CommonLibs.dsc.inc | 12

[edk2-devel] [edk2-platforms][PATCH 3/7] ManageabilityPkg: Add Readme file

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang Add Readme file of edk2 platform ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- Features/ManageabilityPkg/Readme.md | 37 + 1 file

[edk2-devel] [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitCommand function

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang Rename IpmiSubmitCommand to IpmiSendCommand because the naming of this function is confusing with IpmiSubmitCommand defined in IPMI Protocol. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef

[edk2-devel] [edk2-platforms][PATCH 0/7] Implementation of IPMI Protocol

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang This change implementes IPMI Protocol and PPI in the new introduced ManageabilityPkg (described in below email) https://edk2.groups.io/g/devel/message/95579?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2CManageability%2C20%2C2%2C0%2C94572748 BZ #4336: The change also fixes the

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-07 Thread Rebecca Cran
On 2/4/23 01:54, RichardHo [何明忠] via groups.io wrote: diff --git a/UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h b/UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h new file mode 100644 index 00..629c83e24e --- /dev/null +++

[edk2-devel] [PATCH 5/5] UefiCpuPkg: Put APs in 64 bit mode before handoff to OS.

2023-02-07 Thread Yuanhao Xie
Only keep 4GB limitation of memory allocation for the case APs still need to be transferred to 32-bit mode before OS. Remove the unused arguments of AsmRelocateApLoopStart, updated the stack offset. Create PageTable for the allocated reserved memory. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes

[edk2-devel] [PATCH 4/5] UefiPayloadPkg: Add CpuPageTableLib required by MpInitLib

2023-02-07 Thread Yuanhao Xie
Add CpuPageTableLib required by MpInitLib in UefiPayloadPkg. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Yuanhao Xie --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc

[edk2-devel] [PATCH 3/5] OvmfPkg: Add CpuPageTableLib required by MpInitLib.

2023-02-07 Thread Yuanhao Xie
Add CpuPageTableLib required by MpInitLib in OvmfPkg. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Yuanhao Xie --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 ++- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + OvmfPkg/IntelTdx/IntelTdxX64.dsc | 4 +++-

[edk2-devel] [PATCH 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

2023-02-07 Thread Yuanhao Xie
Contiguous memory allocation and This patch includes the code refactoring to eliminate the duplication, non-descriptive variable, etc. The memory is calculated taking into account the size difference of RelocateApLoopFunc under different cases. Allocate the memory for stacks and AP loop at

[edk2-devel] [PATCH 1/5] UefiCpuPkg: Duplicate RelocateApLoop for Amd x64 processors.

2023-02-07 Thread Yuanhao Xie
The duplicated variant is to ensure 64-bit Amd processors can follow the logic of current existing design to avoid crash may caused by the untested modification. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Yuanhao Xie ---

[edk2-devel] [PATCH 0/5] Put APs in 64 bit mode before handoff to OS.

2023-02-07 Thread Yuanhao Xie
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=4234 Yuanhao Xie (5): UefiCpuPkg: Duplicate RelocateApLoop for Amd x64 processors. UefiCpuPkg: Contiguous memory allocation and code clean-up. OvmfPkg: Add CpuPageTableLib required by MpInitLib. UefiPayloadPkg: Add CpuPageTableLib

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-07 Thread Oliver Steffen
On Tue, Feb 7, 2023 at 12:57 PM Ard Biesheuvel wrote: > On Tue, 7 Feb 2023 at 11:51, Oliver Steffen wrote: > > > > On Thu, Feb 2, 2023 at 12:09 PM Oliver Steffen > wrote: > >> > >> > >> On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote: > >>> > >>> On Wed, 1 Feb 2023 at 13:59, Oliver

Re: [edk2-devel] [PATCH 1/1] .pytool/Plugin/EccCheck: Add PACKAGES_PATH support

2023-02-07 Thread Marvin Häuser
Hi Mike, This patch was reviewed by Michael Kubacki. It is required to enable edk2-platforms CI for Ext4Pkg, upstream workarounds on the edk2-platforms side would be *very* ugly. Also, the change is trivial and basically just a copy-and-paste from other pytools. Can we please merge this into

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-07 Thread Ard Biesheuvel
On Tue, 7 Feb 2023 at 11:51, Oliver Steffen wrote: > > On Thu, Feb 2, 2023 at 12:09 PM Oliver Steffen wrote: >> >> >> On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote: >>> >>> On Wed, 1 Feb 2023 at 13:59, Oliver Steffen wrote: >>> > >>> > On Wed, Feb 1, 2023 at 12:52 PM Ard Biesheuvel

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-07 Thread Oliver Steffen
On Thu, Feb 2, 2023 at 12:09 PM Oliver Steffen wrote: > > On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote: > >> On Wed, 1 Feb 2023 at 13:59, Oliver Steffen wrote: >> > >> > On Wed, Feb 1, 2023 at 12:52 PM Ard Biesheuvel wrote: >> >> >> >> On Wed, 1 Feb 2023 at 10:14, Oliver Steffen >>

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Marvin Häuser
> On 7. Feb 2023, at 11:01, Ard Biesheuvel wrote: > > Actually, it seems UnprotectUefiImage () is corrent under the > assumption that all code regions have EFI_MEMORY_XP cleared by > default. > > However, if you redefine the policy to set EFI_MEMORY_XP on code > regions by default, and only

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Ard Biesheuvel
On Tue, 7 Feb 2023 at 10:16, Ard Biesheuvel wrote: > > On Tue, 7 Feb 2023 at 09:56, Marvin Häuser wrote: > > > > Hi Taylor and Ard, > > > > > On 7. Feb 2023, at 09:29, Ard Biesheuvel wrote: > > > > > > On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote: > > >> > > >> I can't see the Bugzilla you

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Marvin Häuser
> On 7. Feb 2023, at 10:16, Ard Biesheuvel wrote: > > On Tue, 7 Feb 2023 at 09:56, Marvin Häuser wrote: >> >> Hi Taylor and Ard, >> On 7. Feb 2023, at 09:29, Ard Biesheuvel wrote: >>> >>> On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote: I can't see the Bugzilla you

[edk2-devel] [edk2-platforms] Platform/Loongson: Modify Readme of Loongarch.

2023-02-07 Thread xianglai
Fix the compilation description error in the Readme file. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Readme.md | 4 1 file changed, 4 insertions(+) diff --git

Re: [edk2-devel] [edk2-platforms: PATCH v2] IntelSiliconPkg/SpiFvbServiceSmm: Rewrite VariableStore header.

2023-02-07 Thread Ashraf Ali S
Reviewed-by: S, Ashraf Ali -Original Message- From: Chiu, Chasel Sent: Tuesday, February 7, 2023 12:20 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; S, Ashraf Ali ; Oram, Isaac W ; Chaganty, Rangasai V ; Ni, Ray ; Kubacki, Michael Subject: [edk2-platforms: PATCH v2]

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Ard Biesheuvel
On Tue, 7 Feb 2023 at 09:56, Marvin Häuser wrote: > > Hi Taylor and Ard, > > > On 7. Feb 2023, at 09:29, Ard Biesheuvel wrote: > > > > On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote: > >> > >> I can't see the Bugzilla you referenced so I requested security Bugzilla > >> access. But, yes,

[edk2-devel] [PATCH 1/1] ArmPkg/PlatformBootManagerLib: Add path to boot UEFI Shell over UiApp

2023-02-07 Thread PierreGondois
From: Pierre Gondois The UEFI Shell is a non-active boot option, at the opposite of UiApp. If no valid boot option is found, UiApp is selected. UiApp requires a human interaction. When installing a new EDKII image in CIs or when scripting is required, this is problematic. If no valid boot

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Marvin Häuser
Hi Taylor and Ard, > On 7. Feb 2023, at 09:29, Ard Biesheuvel wrote: > > On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote: >> >> I can't see the Bugzilla you referenced so I requested security Bugzilla >> access. But, yes, that's the bug to which I was referring :) >> > > I cannot see that

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/5] Platform/Sgi: Add SSDT table for IO virtualization SoC expansion block

2023-02-07 Thread PierreGondois
Hello Vivek, Thanks for the answers, On 2/7/23 07:59, Vivek Kumar Gautam wrote: Hi Pierre On 2/3/23 21:26, Pierre Gondois wrote: Hello Vivek, Thanks for review the changes, please find my responses inline below. On 1/27/23 10:23, Vivek Gautam wrote: Arm reference design platforms have

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-07 Thread Ard Biesheuvel
On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote: > > I can't see the Bugzilla you referenced so I requested security Bugzilla > access. But, yes, that's the bug to which I was referring :) > I cannot see that bugzilla entry either. > Once Ard's change to add Memory Attribute Protocol support to

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-07 Thread Michael Brown
On 07/02/2023 06:21, Tinh Nguyen via groups.io wrote: From: Tinh Nguyen Date: Tue, 7 Feb 2023 12:43:17 +0700 Subject: [PATCH] UsbNetworkPkg: Support rate limitting Signed-off-by: Tinh Nguyen Thank you for extending my patch to add the PCD support. The overall patch appears still to be